[v5.15] possible deadlock in ocfs2_fiemap
0 views
Skip to first unread message
syzbot
Oct 11, 2024, 11:39:26 AMOct 11
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=11946f07980000
kernel config: https://syzkaller.appspot.com/x/.config?x=171882977b524c53
dashboard link: https://syzkaller.appspot.com/bug?extid=48add60ba210fa322119
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/22ee27cb312d/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/90bf6a3e3d20/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/096dd2c73ac3/Image-3a592870.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+48add6...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.120/4693 is trying to acquire lock:
ffff0000d2e06e58 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa0/0x128 mm/memory.c:5326
but task is already holding lock:
ffff0000e729dbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x2a8/0xc78 fs/ocfs2/extent_map.c:755
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_read_virt_blocks+0x298/0x960 fs/ocfs2/extent_map.c:976
ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
ocfs2_find_entry+0x3ac/0x2450 fs/ocfs2/dir.c:1080
ocfs2_find_files_on_disk+0x10c/0x3d0 fs/ocfs2/dir.c:1982
ocfs2_lookup_ino_from_name+0xb8/0x1d4 fs/ocfs2/dir.c:2004
_ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
ocfs2_get_system_file_inode+0x2c8/0x6b8 fs/ocfs2/sysfile.c:112
ocfs2_init_global_system_inodes+0x2bc/0x618 fs/ocfs2/super.c:458
ocfs2_initialize_super fs/ocfs2/super.c:2276 [inline]
ocfs2_fill_super+0x394c/0x498c fs/ocfs2/super.c:995
mount_bdev+0x274/0x370 fs/super.c:1398
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #3 (&osb->system_file_mutex){+.+.}-{3:3}:
__mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743
ocfs2_get_system_file_inode+0x180/0x6b8 fs/ocfs2/sysfile.c:101
ocfs2_reserve_local_alloc_bits+0xe4/0x2474 fs/ocfs2/localalloc.c:626
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_write_begin_nolock+0x2274/0x3e1c fs/ocfs2/aops.c:1742
ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1906
generic_perform_write+0x24c/0x520 mm/filemap.c:3785
__generic_file_write_iter+0x230/0x454 mm/filemap.c:3912
ocfs2_file_write_iter+0x1478/0x1e00 fs/ocfs2/file.c:2459
call_write_iter include/linux/fs.h:2172 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x884/0xb44 fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #2 (&oi->ip_alloc_sem){++++}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_page_mkwrite+0x400/0xf0c fs/ocfs2/mmap.c:142
do_page_mkwrite+0x144/0x37c mm/memory.c:2892
do_shared_fault mm/memory.c:4298 [inline]
do_fault mm/memory.c:4366 [inline]
handle_pte_fault mm/memory.c:4620 [inline]
__handle_mm_fault mm/memory.c:4755 [inline]
handle_mm_fault+0x1a10/0x33a8 mm/memory.c:4853
__do_page_fault arch/arm64/mm/fault.c:505 [inline]
do_page_fault+0x700/0xb60 arch/arm64/mm/fault.c:605
do_translation_fault+0xe8/0x138 arch/arm64/mm/fault.c:686
do_mem_abort+0x70/0x1d8 arch/arm64/mm/fault.c:819
el0_da+0x94/0x20c arch/arm64/kernel/entry-common.c:494
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (sb_pagefaults#2){.+.+}-{0:0}:
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_pagefault include/linux/fs.h:1910 [inline]
ocfs2_page_mkwrite+0x250/0xf0c fs/ocfs2/mmap.c:122
do_page_mkwrite+0x144/0x37c mm/memory.c:2892
do_shared_fault mm/memory.c:4298 [inline]
do_fault mm/memory.c:4366 [inline]
handle_pte_fault mm/memory.c:4620 [inline]
__handle_mm_fault mm/memory.c:4755 [inline]
handle_mm_fault+0x1a10/0x33a8 mm/memory.c:4853
__do_page_fault arch/arm64/mm/fault.c:505 [inline]
do_page_fault+0x700/0xb60 arch/arm64/mm/fault.c:605
do_translation_fault+0xe8/0x138 arch/arm64/mm/fault.c:686
do_mem_abort+0x70/0x1d8 arch/arm64/mm/fault.c:819
el0_da+0x94/0x20c arch/arm64/kernel/entry-common.c:494
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
__might_fault+0xc8/0x128 mm/memory.c:5327
_copy_to_user include/linux/uaccess.h:174 [inline]
copy_to_user include/linux/uaccess.h:200 [inline]
fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144
ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline]
ocfs2_fiemap+0x994/0xc78 fs/ocfs2/extent_map.c:762
ioctl_fiemap fs/ioctl.c:219 [inline]
do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814
__do_sys_ioctl fs/ioctl.c:872 [inline]
__se_sys_ioctl fs/ioctl.c:860 [inline]
__arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
&mm->mmap_lock --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&osb->system_file_mutex);
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&mm->mmap_lock);
*** DEADLOCK ***
1 lock held by syz.0.120/4693:
#0: ffff0000e729dbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x2a8/0xc78 fs/ocfs2/extent_map.c:755
stack backtrace:
CPU: 0 PID: 4693 Comm: syz.0.120 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
__might_fault+0xc8/0x128 mm/memory.c:5327
_copy_to_user include/linux/uaccess.h:174 [inline]
copy_to_user include/linux/uaccess.h:200 [inline]
fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144
ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline]
ocfs2_fiemap+0x994/0xc78 fs/ocfs2/extent_map.c:762
ioctl_fiemap fs/ioctl.c:219 [inline]
do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814
__do_sys_ioctl fs/ioctl.c:872 [inline]
__se_sys_ioctl fs/ioctl.c:860 [inline]
__arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=11946f07980000
kernel config: https://syzkaller.appspot.com/x/.config?x=171882977b524c53
dashboard link: https://syzkaller.appspot.com/bug?extid=48add60ba210fa322119
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/22ee27cb312d/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/90bf6a3e3d20/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/096dd2c73ac3/Image-3a592870.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+48add6...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.120/4693 is trying to acquire lock:
ffff0000d2e06e58 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa0/0x128 mm/memory.c:5326
but task is already holding lock:
ffff0000e729dbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x2a8/0xc78 fs/ocfs2/extent_map.c:755
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_read_virt_blocks+0x298/0x960 fs/ocfs2/extent_map.c:976
ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
ocfs2_find_entry+0x3ac/0x2450 fs/ocfs2/dir.c:1080
ocfs2_find_files_on_disk+0x10c/0x3d0 fs/ocfs2/dir.c:1982
ocfs2_lookup_ino_from_name+0xb8/0x1d4 fs/ocfs2/dir.c:2004
_ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
ocfs2_get_system_file_inode+0x2c8/0x6b8 fs/ocfs2/sysfile.c:112
ocfs2_init_global_system_inodes+0x2bc/0x618 fs/ocfs2/super.c:458
ocfs2_initialize_super fs/ocfs2/super.c:2276 [inline]
ocfs2_fill_super+0x394c/0x498c fs/ocfs2/super.c:995
mount_bdev+0x274/0x370 fs/super.c:1398
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #3 (&osb->system_file_mutex){+.+.}-{3:3}:
__mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743
ocfs2_get_system_file_inode+0x180/0x6b8 fs/ocfs2/sysfile.c:101
ocfs2_reserve_local_alloc_bits+0xe4/0x2474 fs/ocfs2/localalloc.c:626
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_write_begin_nolock+0x2274/0x3e1c fs/ocfs2/aops.c:1742
ocfs2_write_begin+0x1ac/0x38c fs/ocfs2/aops.c:1906
generic_perform_write+0x24c/0x520 mm/filemap.c:3785
__generic_file_write_iter+0x230/0x454 mm/filemap.c:3912
ocfs2_file_write_iter+0x1478/0x1e00 fs/ocfs2/file.c:2459
call_write_iter include/linux/fs.h:2172 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x884/0xb44 fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #2 (&oi->ip_alloc_sem){++++}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_page_mkwrite+0x400/0xf0c fs/ocfs2/mmap.c:142
do_page_mkwrite+0x144/0x37c mm/memory.c:2892
do_shared_fault mm/memory.c:4298 [inline]
do_fault mm/memory.c:4366 [inline]
handle_pte_fault mm/memory.c:4620 [inline]
__handle_mm_fault mm/memory.c:4755 [inline]
handle_mm_fault+0x1a10/0x33a8 mm/memory.c:4853
__do_page_fault arch/arm64/mm/fault.c:505 [inline]
do_page_fault+0x700/0xb60 arch/arm64/mm/fault.c:605
do_translation_fault+0xe8/0x138 arch/arm64/mm/fault.c:686
do_mem_abort+0x70/0x1d8 arch/arm64/mm/fault.c:819
el0_da+0x94/0x20c arch/arm64/kernel/entry-common.c:494
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (sb_pagefaults#2){.+.+}-{0:0}:
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_pagefault include/linux/fs.h:1910 [inline]
ocfs2_page_mkwrite+0x250/0xf0c fs/ocfs2/mmap.c:122
do_page_mkwrite+0x144/0x37c mm/memory.c:2892
do_shared_fault mm/memory.c:4298 [inline]
do_fault mm/memory.c:4366 [inline]
handle_pte_fault mm/memory.c:4620 [inline]
__handle_mm_fault mm/memory.c:4755 [inline]
handle_mm_fault+0x1a10/0x33a8 mm/memory.c:4853
__do_page_fault arch/arm64/mm/fault.c:505 [inline]
do_page_fault+0x700/0xb60 arch/arm64/mm/fault.c:605
do_translation_fault+0xe8/0x138 arch/arm64/mm/fault.c:686
do_mem_abort+0x70/0x1d8 arch/arm64/mm/fault.c:819
el0_da+0x94/0x20c arch/arm64/kernel/entry-common.c:494
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
__might_fault+0xc8/0x128 mm/memory.c:5327
_copy_to_user include/linux/uaccess.h:174 [inline]
copy_to_user include/linux/uaccess.h:200 [inline]
fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144
ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline]
ocfs2_fiemap+0x994/0xc78 fs/ocfs2/extent_map.c:762
ioctl_fiemap fs/ioctl.c:219 [inline]
do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814
__do_sys_ioctl fs/ioctl.c:872 [inline]
__se_sys_ioctl fs/ioctl.c:860 [inline]
__arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
&mm->mmap_lock --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&osb->system_file_mutex);
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&mm->mmap_lock);
*** DEADLOCK ***
1 lock held by syz.0.120/4693:
#0: ffff0000e729dbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x2a8/0xc78 fs/ocfs2/extent_map.c:755
stack backtrace:
CPU: 0 PID: 4693 Comm: syz.0.120 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
__might_fault+0xc8/0x128 mm/memory.c:5327
_copy_to_user include/linux/uaccess.h:174 [inline]
copy_to_user include/linux/uaccess.h:200 [inline]
fiemap_fill_next_extent+0x1b4/0x44c fs/ioctl.c:144
ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline]
ocfs2_fiemap+0x994/0xc78 fs/ocfs2/extent_map.c:762
ioctl_fiemap fs/ioctl.c:219 [inline]
do_vfs_ioctl+0x1bcc/0x2a38 fs/ioctl.c:814
__do_sys_ioctl fs/ioctl.c:872 [inline]
__se_sys_ioctl fs/ioctl.c:860 [inline]
__arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:860
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot
Oct 11, 2024, 2:44:28 PMOct 11
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: aa4cd140bba5 Linux 6.1.112
syzbot found the following issue on:
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16de6f07980000
kernel config: https://syzkaller.appspot.com/x/.config?x=33931c04473f8585
dashboard link: https://syzkaller.appspot.com/bug?extid=d66730458cf34fe77585
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2a9778339706/disk-aa4cd140.raw.xz
Downloadable assets:
vmlinux: https://storage.googleapis.com/syzbot-assets/b568a6da8a9b/vmlinux-aa4cd140.xz
kernel image: https://storage.googleapis.com/syzbot-assets/3c56af7eb2c4/bzImage-aa4cd140.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.1.112-syzkaller #0 Not tainted
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz.0.38/4020 is trying to acquire lock:
ffff88801a730158 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa1/0x110 mm/memory.c:5851
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ocfs2_read_virt_blocks+0x2dc/0xab0 fs/ocfs2/extent_map.c:976
ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
ocfs2_find_entry+0x436/0x28c0 fs/ocfs2/dir.c:1080
ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
ocfs2_find_files_on_disk+0x10d/0x3a0 fs/ocfs2/dir.c:1982
ocfs2_lookup_ino_from_name+0xad/0x1e0 fs/ocfs2/dir.c:2004
_ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
ocfs2_get_system_file_inode+0x314/0x7b0 fs/ocfs2/sysfile.c:112
ocfs2_init_global_system_inodes+0x328/0x720 fs/ocfs2/super.c:457
ocfs2_initialize_super fs/ocfs2/super.c:2250 [inline]
ocfs2_fill_super+0x2f82/0x5730 fs/ocfs2/super.c:994
mount_bdev+0x2c9/0x3f0 fs/super.c:1443
legacy_get_tree+0xeb/0x180 fs/fs_context.c:632
vfs_get_tree+0x88/0x270 fs/super.c:1573
do_new_mount+0x2ba/0xb40 fs/namespace.c:3051
do_mount fs/namespace.c:3394 [inline]
__do_sys_mount fs/namespace.c:3602 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
-> #6 (&osb->system_file_mutex){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101
ocfs2_reserve_local_alloc_bits+0xfe/0x29d0 fs/ocfs2/localalloc.c:626
ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x4e5/0x1d00 fs/ocfs2/file.c:585
ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1027
ocfs2_acquire_dquot+0x60a/0xb60 fs/ocfs2/quota_global.c:836
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xf12/0x1f80 fs/ocfs2/file.c:1230
notify_change+0xce3/0xfc0 fs/attr.c:499
chown_common+0x5aa/0x900 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xde/0x150 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:821
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
-> #5 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_write+0x36/0x60 kernel/locking/rwsem.c:1573
ocfs2_create_local_dquot+0x1dc/0x1b50 fs/ocfs2/quota_local.c:1227
ocfs2_acquire_dquot+0x7df/0xb60 fs/ocfs2/quota_global.c:866
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xf12/0x1f80 fs/ocfs2/file.c:1230
notify_change+0xce3/0xfc0 fs/attr.c:499
chown_common+0x5aa/0x900 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xde/0x150 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:821
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
wait_on_dquot fs/quota/dquot.c:356 [inline]
dqget+0x6dc/0xe90 fs/quota/dquot.c:981
dquot_transfer+0x3a1/0x8a0 fs/quota/dquot.c:2148
ext4_setattr+0xbd3/0x1a00 fs/ext4/inode.c:5469
notify_change+0xce3/0xfc0 fs/attr.c:499
chown_common+0x5aa/0x900 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xde/0x150 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:821
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
-> #3 (&ei->xattr_sem){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ext4_readpage_inline+0x2f/0x290 fs/ext4/inline.c:519
ext4_read_folio+0x17d/0x390 fs/ext4/inode.c:3250
filemap_read_folio+0x199/0x780 mm/filemap.c:2461
filemap_create_folio mm/filemap.c:2590 [inline]
filemap_get_pages mm/filemap.c:2643 [inline]
filemap_read+0x122a/0x31d0 mm/filemap.c:2730
__kernel_read+0x421/0x890 fs/read_write.c:428
integrity_kernel_read+0xac/0xf0 security/integrity/iint.c:228
ima_calc_file_hash_tfm security/integrity/ima/ima_crypto.c:485 [inline]
ima_calc_file_shash security/integrity/ima/ima_crypto.c:516 [inline]
ima_calc_file_hash+0xa57/0x1c00 security/integrity/ima/ima_crypto.c:573
ima_collect_measurement+0x559/0xc40 security/integrity/ima/ima_api.c:293
process_measurement+0x135c/0x21b0 security/integrity/ima/ima_main.c:351
ima_file_check+0xed/0x170 security/integrity/ima/ima_main.c:534
do_open fs/namei.c:3630 [inline]
path_openat+0x2687/0x2e60 fs/namei.c:3785
do_filp_open+0x230/0x480 fs/namei.c:3812
do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
do_sys_open fs/open.c:1334 [inline]
__do_sys_openat fs/open.c:1350 [inline]
__se_sys_openat fs/open.c:1345 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1345
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
-> #2 (mapping.invalidate_lock){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
filemap_invalidate_lock_shared include/linux/fs.h:813 [inline]
ext4_page_mkwrite+0x1d7/0x10d0 fs/ext4/inode.c:6206
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:3009
wp_page_shared+0x164/0x380 mm/memory.c:3358
handle_pte_fault mm/memory.c:5047 [inline]
__handle_mm_fault mm/memory.c:5171 [inline]
handle_mm_fault+0x2525/0x5340 mm/memory.c:5292
do_user_addr_fault arch/x86/mm/fault.c:1340 [inline]
handle_page_fault arch/x86/mm/fault.c:1431 [inline]
exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
-> #1 (sb_pagefaults){.+.+}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_pagefault include/linux/fs.h:1995 [inline]
ext4_page_mkwrite+0x1ad/0x10d0 fs/ext4/inode.c:6203
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:3009
wp_page_shared+0x164/0x380 mm/memory.c:3358
handle_pte_fault mm/memory.c:5047 [inline]
__handle_mm_fault mm/memory.c:5171 [inline]
handle_mm_fault+0x2525/0x5340 mm/memory.c:5292
do_user_addr_fault arch/x86/mm/fault.c:1340 [inline]
handle_page_fault arch/x86/mm/fault.c:1431 [inline]
exc_page_fault+0x26f/0x620 arch/x86/mm/fault.c:1487
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__might_fault+0xbd/0x110 mm/memory.c:5851
_copy_to_user+0x26/0x130 lib/usercopy.c:36
copy_to_user include/linux/uaccess.h:169 [inline]
fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144
ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline]
ocfs2_fiemap+0xc1d/0xf80 fs/ocfs2/extent_map.c:762
ioctl_fiemap fs/ioctl.c:219 [inline]
do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810
__do_sys_ioctl fs/ioctl.c:868 [inline]
__se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
other info that might help us debug this:
Chain exists of:
&mm->mmap_lock --> &osb->system_file_mutex --> &ocfs2_file_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&osb->system_file_mutex);
lock(&ocfs2_file_ip_alloc_sem_key);
lock(&mm->mmap_lock);
*** DEADLOCK ***
#0: ffff888058a394a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_fiemap+0x36f/0xf80 fs/ocfs2/extent_map.c:755
stack backtrace:
CPU: 1 PID: 4020 Comm: syz.0.38 Not tainted 6.1.112-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__might_fault+0xbd/0x110 mm/memory.c:5851
_copy_to_user+0x26/0x130 lib/usercopy.c:36
copy_to_user include/linux/uaccess.h:169 [inline]
fiemap_fill_next_extent+0x231/0x410 fs/ioctl.c:144
ocfs2_fiemap_inline fs/ocfs2/extent_map.c:725 [inline]
ocfs2_fiemap+0xc1d/0xf80 fs/ocfs2/extent_map.c:762
ioctl_fiemap fs/ioctl.c:219 [inline]
do_vfs_ioctl+0x18e9/0x2a90 fs/ioctl.c:810
__do_sys_ioctl fs/ioctl.c:868 [inline]
__se_sys_ioctl+0x81/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fb8db97dff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb8dc738038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fb8dbb35f80 RCX: 00007fb8db97dff9
RDX: 0000000020000040 RSI: 00000000c020660b RDI: 0000000000000004
RBP: 00007fb8db9f0296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fb8dbb35f80 R15: 00007ffdb8b36cb8
</TASK>
Reply all
Reply to author
Forward
0 new messages