[v5.15] possible deadlock in ocfs2_reserve_local_alloc_bits
1 view
Skip to first unread message
syzbot
Sep 27, 2024, 1:46:25 PMSep 27
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10e17a80580000
kernel config: https://syzkaller.appspot.com/x/.config?x=4d3fd5cca89ae935
dashboard link: https://syzkaller.appspot.com/bug?extid=fa8da3e825fdf84780a0
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ef5025f3d708/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/776fbdad3aa8/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/79541db5bd16/bzImage-3a592870.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+fa8da3...@syzkaller.appspotmail.com
(syz.0.5709,16639,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.5709/16639 is trying to acquire lock:
ffff888065716d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff888065716d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
but task is already holding lock:
ffff888075bb22e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
dquot_commit+0x57/0x510 fs/quota/dquot.c:507
ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
__dquot_free_space+0x932/0xe40 fs/quota/dquot.c:1940
dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
dquot_free_space include/linux/quotaops.h:381 [inline]
dquot_free_block include/linux/quotaops.h:392 [inline]
ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline]
ext4_free_blocks+0x1f6e/0x2ea0 fs/ext4/mballoc.c:6288
ext4_remove_blocks fs/ext4/extents.c:2519 [inline]
ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
ext4_ext_remove_space+0x24da/0x4db0 fs/ext4/extents.c:2933
ext4_ext_truncate+0x191/0x250 fs/ext4/extents.c:4450
ext4_truncate+0x9fd/0x1130 fs/ext4/inode.c:4249
ext4_setattr+0xf96/0x1990 fs/ext4/inode.c:5550
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
vfs_truncate+0x2dd/0x3a0 fs/open.c:111
do_sys_truncate+0xda/0x190 fs/open.c:134
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #4 (&ei->i_data_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665
mpage_map_one_extent fs/ext4/inode.c:2407 [inline]
mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
ext4_writepages+0x160e/0x3d10 fs/ext4/inode.c:2828
do_writepages+0x481/0x730 mm/page-writeback.c:2386
__writeback_single_inode+0x15b/0xe30 fs/fs-writeback.c:1647
writeback_sb_inodes+0xbce/0x1a40 fs/fs-writeback.c:1930
__writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:2001
wb_writeback+0x465/0xc50 fs/fs-writeback.c:2106
wb_check_background_flush fs/fs-writeback.c:2172 [inline]
wb_do_writeback fs/fs-writeback.c:2260 [inline]
wb_workfn+0xd07/0x1130 fs/fs-writeback.c:2288
process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
kthread+0x3f6/0x4f0 kernel/kthread.c:334
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287
-> #3 (jbd2_handle){++++}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1425
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1425
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #1 (sb_internal#2){.+.+}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
ocfs2_symlink+0x147f/0x2e20 fs/ocfs2/namei.c:1913
vfs_symlink+0x247/0x3d0 fs/namei.c:4429
do_symlinkat+0x1fd/0x600 fs/namei.c:4458
__do_sys_symlink fs/namei.c:4480 [inline]
__se_sys_symlink fs/namei.c:4478 [inline]
__x64_sys_symlink+0x7a/0x90 fs/namei.c:4478
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Chain exists of:
&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
*** DEADLOCK ***
5 locks held by syz.0.5709/16639:
#0: ffff8880576e4460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
#1: ffff888065715108 (&type->i_mutex_dir_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff888065715108 (&type->i_mutex_dir_key#23){+.+.}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674
#2: ffff8880735d80a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806
#3: ffff888075bb2648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#3: ffff888075bb2648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
#4: ffff888075bb22e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
stack backtrace:
CPU: 0 PID: 16639 Comm: syz.0.5709 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f99bb6eaff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f99b9b63038 EFLAGS: 00000246 ORIG_RAX: 000000000000005d
RAX: ffffffffffffffda RBX: 00007f99bb8a2f80 RCX: 00007f99bb6eaff9
RDX: 0000000000000000 RSI: 000000000000ee00 RDI: 0000000000000003
RBP: 00007f99bb75d296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f99bb8a2f80 R15: 00007ffd717a5708
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10e17a80580000
kernel config: https://syzkaller.appspot.com/x/.config?x=4d3fd5cca89ae935
dashboard link: https://syzkaller.appspot.com/bug?extid=fa8da3e825fdf84780a0
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ef5025f3d708/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/776fbdad3aa8/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/79541db5bd16/bzImage-3a592870.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+fa8da3...@syzkaller.appspotmail.com
(syz.0.5709,16639,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xb3775c19, computed 0x2dd1c265. Applying ECC.
JBD2: Ignoring recovery information on journal
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.5709/16639 is trying to acquire lock:
ffff888065716d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff888065716d88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
but task is already holding lock:
ffff888075bb22e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
dquot_commit+0x57/0x510 fs/quota/dquot.c:507
ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6172
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
__dquot_free_space+0x932/0xe40 fs/quota/dquot.c:1940
dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
dquot_free_space include/linux/quotaops.h:381 [inline]
dquot_free_block include/linux/quotaops.h:392 [inline]
ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline]
ext4_free_blocks+0x1f6e/0x2ea0 fs/ext4/mballoc.c:6288
ext4_remove_blocks fs/ext4/extents.c:2519 [inline]
ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
ext4_ext_remove_space+0x24da/0x4db0 fs/ext4/extents.c:2933
ext4_ext_truncate+0x191/0x250 fs/ext4/extents.c:4450
ext4_truncate+0x9fd/0x1130 fs/ext4/inode.c:4249
ext4_setattr+0xf96/0x1990 fs/ext4/inode.c:5550
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
vfs_truncate+0x2dd/0x3a0 fs/open.c:111
do_sys_truncate+0xda/0x190 fs/open.c:134
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #4 (&ei->i_data_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665
mpage_map_one_extent fs/ext4/inode.c:2407 [inline]
mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
ext4_writepages+0x160e/0x3d10 fs/ext4/inode.c:2828
do_writepages+0x481/0x730 mm/page-writeback.c:2386
__writeback_single_inode+0x15b/0xe30 fs/fs-writeback.c:1647
writeback_sb_inodes+0xbce/0x1a40 fs/fs-writeback.c:1930
__writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:2001
wb_writeback+0x465/0xc50 fs/fs-writeback.c:2106
wb_check_background_flush fs/fs-writeback.c:2172 [inline]
wb_do_writeback fs/fs-writeback.c:2260 [inline]
wb_workfn+0xd07/0x1130 fs/fs-writeback.c:2288
process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
kthread+0x3f6/0x4f0 kernel/kthread.c:334
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287
-> #3 (jbd2_handle){++++}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1425
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1425
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #1 (sb_internal#2){.+.+}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
ocfs2_symlink+0x147f/0x2e20 fs/ocfs2/namei.c:1913
vfs_symlink+0x247/0x3d0 fs/namei.c:4429
do_symlinkat+0x1fd/0x600 fs/namei.c:4458
__do_sys_symlink fs/namei.c:4480 [inline]
__se_sys_symlink fs/namei.c:4478 [inline]
__x64_sys_symlink+0x7a/0x90 fs/namei.c:4478
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
other info that might help us debug this:
Chain exists of:
&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5);
*** DEADLOCK ***
5 locks held by syz.0.5709/16639:
#0: ffff8880576e4460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
#1: ffff888065715108 (&type->i_mutex_dir_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff888065715108 (&type->i_mutex_dir_key#23){+.+.}-{3:3}, at: chown_common+0x499/0x890 fs/open.c:674
#2: ffff8880735d80a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x28c/0xb40 fs/ocfs2/quota_global.c:806
#3: ffff888075bb2648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#3: ffff888075bb2648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313
#4: ffff888075bb22e0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314
stack backtrace:
CPU: 0 PID: 16639 Comm: syz.0.5709 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_local_alloc_bits+0x12e/0x27a0 fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x4e8/0x1ba0 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x631/0xb40 fs/ocfs2/quota_global.c:836
dqget+0x762/0xe90 fs/quota/dquot.c:986
ocfs2_setattr+0xcf3/0x1c70 fs/ocfs2/file.c:1233
notify_change+0xc6d/0xf50 fs/attr.c:505
chown_common+0x592/0x890 fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xde/0x150 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__x64_sys_fchown+0x76/0x80 fs/open.c:765
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f99bb6eaff9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f99b9b63038 EFLAGS: 00000246 ORIG_RAX: 000000000000005d
RAX: ffffffffffffffda RBX: 00007f99bb8a2f80 RCX: 00007f99bb6eaff9
RDX: 0000000000000000 RSI: 000000000000ee00 RDI: 0000000000000003
RBP: 00007f99bb75d296 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f99bb8a2f80 R15: 00007ffd717a5708
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot
Sep 28, 2024, 12:05:26 AMSep 28
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: e526b12bf916 Linux 6.1.111
syzbot found the following issue on:
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=123a5507980000
kernel config: https://syzkaller.appspot.com/x/.config?x=7418080a6f941760
dashboard link: https://syzkaller.appspot.com/bug?extid=315109f6cd4d9034e8ae
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
vmlinux: https://storage.googleapis.com/syzbot-assets/f358663fa696/vmlinux-e526b12b.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9b39a7b8f250/Image-e526b12b.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
======================================================
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz.1.190/5626 is trying to acquire lock:
ffff0000e15cc2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff0000e15cc2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
dqget+0x660/0xcec fs/quota/dquot.c:986
ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
notify_change+0xb58/0xe1c fs/attr.c:499
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
inode_lock include/linux/fs.h:758 [inline]
ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
dqget+0x660/0xcec fs/quota/dquot.c:986
ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
notify_change+0xb58/0xe1c fs/attr.c:499
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
dquot_commit+0x54/0x240 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6776
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6836
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
__dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1750
dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
dquot_alloc_space include/linux/quotaops.h:313 [inline]
dquot_alloc_block include/linux/quotaops.h:337 [inline]
ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5730
ext4_ext_map_blocks+0x15a8/0x6638 fs/ext4/extents.c:4318
ext4_map_blocks+0x810/0x1810 fs/ext4/inode.c:678
ext4_getblk+0x198/0x6ec fs/ext4/inode.c:889
ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:945
ext4_append+0x260/0x4cc fs/ext4/namei.c:83
ext4_init_new_dir+0x294/0x8e4 fs/ext4/namei.c:3028
ext4_mkdir+0x3d4/0xa64 fs/ext4/namei.c:3074
vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
do_mkdirat+0x220/0x510 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #4 (&ei->i_data_sem){++++}-{3:3}:
ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5598
notify_change+0xb58/0xe1c fs/attr.c:499
do_truncate+0x1c0/0x28c fs/open.c:65
do_sys_ftruncate+0x288/0x31c fs/open.c:193
__do_sys_ftruncate fs/open.c:204 [inline]
__se_sys_ftruncate fs/open.c:202 [inline]
__arm64_sys_ftruncate+0x60/0x74 fs/open.c:202
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #3 (jbd2_handle){++++}-{0:0}:
jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354
ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
do_mkdirat+0x220/0x510 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352
ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
do_mkdirat+0x220/0x510 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #1 (sb_internal#3){.+.+}-{0:0}:
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x1a8/0x560 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
do_mkdirat+0x220/0x510 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
inode_lock include/linux/fs.h:758 [inline]
ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836
dqget+0x660/0xcec fs/quota/dquot.c:986
ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
notify_change+0xb58/0xe1c fs/attr.c:499
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
other info that might help us debug this:
Chain exists of:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_quota_ip_alloc_sem_key);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
lock(&ocfs2_quota_ip_alloc_sem_key);
*** DEADLOCK ***
5 locks held by syz.1.190/5626:
#0: ffff0000f190a460 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437
#1: ffff0000f14ab488 (&type->i_mutex_dir_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#1: ffff0000f14ab488 (&type->i_mutex_dir_key#20){+.+.}-{3:3}, at: chown_common+0x358/0x7d8 fs/open.c:726
#2: ffff0000e17780a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806
#3: ffff0000f14a89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#3: ffff0000f14a89c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
#4: ffff0000f14a8660 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
stack backtrace:
CPU: 1 PID: 5626 Comm: syz.1.190 Not tainted 6.1.111-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain kernel/locking/lockdep.c:3825 [inline]
__lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
inode_lock include/linux/fs.h:758 [inline]
ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836
dqget+0x660/0xcec fs/quota/dquot.c:986
ocfs2_setattr+0xc48/0x1b3c fs/ocfs2/file.c:1230
notify_change+0xb58/0xe1c fs/attr.c:499
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
syzbot
Sep 28, 2024, 5:40:27 PMSep 28
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12604d9f980000
kernel config: https://syzkaller.appspot.com/x/.config?x=171882977b524c53
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11ad3507980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144b26a9980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/22ee27cb312d/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/90bf6a3e3d20/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/096dd2c73ac3/Image-3a592870.gz.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/f6df700efd5d/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/5b48b4e85a64/mount_1.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+fa8da3...@syzkaller.appspotmail.com
ffff0000dcc4e650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ffff0000dcc4e650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_reserve_local_alloc_bits+0x998/0x2474 fs/ocfs2/localalloc.c:668
but task is already holding lock:
ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782
ocfs2_reserve_cluster_bitmap_bits+0xcc/0x1e0 fs/ocfs2/suballoc.c:1128
ocfs2_local_alloc_reserve_for_window fs/ocfs2/localalloc.c:1112 [inline]
ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1248 [inline]
ocfs2_reserve_local_alloc_bits+0x738/0x2474 fs/ocfs2/localalloc.c:668
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #7 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_local_alloc_bits+0xfc/0x2474 fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
__mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743
dquot_commit+0x54/0x240 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6172
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6232
ext4_ext_truncate+0x188/0x250 fs/ext4/extents.c:4450
ext4_truncate+0x9c4/0x1058 fs/ext4/inode.c:4249
ext4_evict_inode+0xc30/0x124c fs/ext4/inode.c:289
evict+0x418/0x894 fs/inode.c:622
iput_final fs/inode.c:1740 [inline]
iput+0x744/0x824 fs/inode.c:1766
ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360
ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474
ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4974
mount_bdev+0x274/0x370 fs/super.c:1398
ext4_mount+0x44/0x58 fs/ext4/super.c:6602
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #3 (&ei->i_data_sem){++++}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665
do_writepages+0x39c/0x5ec mm/page-writeback.c:2386
__writeback_single_inode+0x148/0x13a4 fs/fs-writeback.c:1647
writeback_sb_inodes+0x94c/0x1654 fs/fs-writeback.c:1930
__writeback_inodes_wb+0x110/0x39c fs/fs-writeback.c:2001
wb_writeback+0x410/0xfc8 fs/fs-writeback.c:2106
process_one_work+0x790/0x11b8 kernel/workqueue.c:2310
worker_thread+0x910/0x1034 kernel/workqueue.c:2457
kthread+0x37c/0x45c kernel/kthread.c:334
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
-> #2 (jbd2_handle){.+.+}-{0:0}:
start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464
jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560
ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354
ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101
ocfs2_local_read_info+0xec8/0x1550 fs/ocfs2/quota_local.c:766
dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461
dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498
ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927
ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140
mount_bdev+0x274/0x370 fs/super.c:1398
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352
ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101
ocfs2_local_read_info+0xec8/0x1550 fs/ocfs2/quota_local.c:766
dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461
dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498
ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927
ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140
mount_bdev+0x274/0x370 fs/super.c:1398
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (sb_internal#2){.+.+}-{0:0}:
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ocfs2_reserve_local_alloc_bits+0x998/0x2474 fs/ocfs2/localalloc.c:668
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
sb_internal#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
lock(sb_internal#2);
*** DEADLOCK ***
7 locks held by syz-executor181/4042:
#0: ffff0000dcc4e460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:421
#1: ffff0000e19c89c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff0000e19c89c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: chown_common+0x3f8/0x74c fs/open.c:674
#2: ffff0000e19360a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x24c/0xa90 fs/ocfs2/quota_global.c:806
#3: ffff0000e19dd108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#3: ffff0000e19dd108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
#4: ffff0000e19dcda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
#5: ffff0000e185a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#5: ffff0000e185a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x2474 fs/ocfs2/localalloc.c:635
#6: ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#6: ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782
stack backtrace:
CPU: 1 PID: 4042 Comm: syz-executor181 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ocfs2_reserve_local_alloc_bits+0x998/0x2474 fs/ocfs2/localalloc.c:668
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
kernel config: https://syzkaller.appspot.com/x/.config?x=171882977b524c53
dashboard link: https://syzkaller.appspot.com/bug?extid=fa8da3e825fdf84780a0
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11ad3507980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=144b26a9980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/22ee27cb312d/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/90bf6a3e3d20/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/096dd2c73ac3/Image-3a592870.gz.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/f6df700efd5d/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/5b48b4e85a64/mount_1.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+fa8da3...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor181/4042 is trying to acquire lock:
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
ffff0000dcc4e650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ffff0000dcc4e650 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_reserve_local_alloc_bits+0x998/0x2474 fs/ocfs2/localalloc.c:668
but task is already holding lock:
ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782
ocfs2_reserve_cluster_bitmap_bits+0xcc/0x1e0 fs/ocfs2/suballoc.c:1128
ocfs2_local_alloc_reserve_for_window fs/ocfs2/localalloc.c:1112 [inline]
ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1248 [inline]
ocfs2_reserve_local_alloc_bits+0x738/0x2474 fs/ocfs2/localalloc.c:668
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:765
__se_sys_fchown fs/open.c:765 [inline]
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #7 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_reserve_local_alloc_bits+0xfc/0x2474 fs/ocfs2/localalloc.c:635
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:765
__se_sys_fchown fs/open.c:765 [inline]
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:765
__se_sys_fchown fs/open.c:765 [inline]
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:765
__se_sys_fchown fs/open.c:765 [inline]
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #4 (&dquot->dq_lock){+.+.}-{3:3}:
__mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743
dquot_commit+0x54/0x240 fs/quota/dquot.c:507
ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6172
ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6232
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
__dquot_free_space+0x878/0xce8 fs/quota/dquot.c:1940
mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
dquot_free_space_nodirty include/linux/quotaops.h:376 [inline]
dquot_free_space include/linux/quotaops.h:381 [inline]
dquot_free_block include/linux/quotaops.h:392 [inline]
ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline]
ext4_free_blocks+0x1c0c/0x2bf0 fs/ext4/mballoc.c:6288
dquot_free_space include/linux/quotaops.h:381 [inline]
dquot_free_block include/linux/quotaops.h:392 [inline]
ext4_mb_clear_bb fs/ext4/mballoc.c:6158 [inline]
ext4_remove_blocks fs/ext4/extents.c:2519 [inline]
ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
ext4_ext_remove_space+0x1c48/0x4254 fs/ext4/extents.c:2933
ext4_ext_rm_leaf fs/ext4/extents.c:2685 [inline]
ext4_ext_truncate+0x188/0x250 fs/ext4/extents.c:4450
ext4_truncate+0x9c4/0x1058 fs/ext4/inode.c:4249
ext4_evict_inode+0xc30/0x124c fs/ext4/inode.c:289
evict+0x418/0x894 fs/inode.c:622
iput_final fs/inode.c:1740 [inline]
iput+0x744/0x824 fs/inode.c:1766
ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360
ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474
ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4974
mount_bdev+0x274/0x370 fs/super.c:1398
ext4_mount+0x44/0x58 fs/ext4/super.c:6602
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #3 (&ei->i_data_sem){++++}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665
mpage_map_one_extent fs/ext4/inode.c:2407 [inline]
mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
ext4_writepages+0x12c0/0x36fc fs/ext4/inode.c:2828
mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline]
do_writepages+0x39c/0x5ec mm/page-writeback.c:2386
__writeback_single_inode+0x148/0x13a4 fs/fs-writeback.c:1647
writeback_sb_inodes+0x94c/0x1654 fs/fs-writeback.c:1930
__writeback_inodes_wb+0x110/0x39c fs/fs-writeback.c:2001
wb_writeback+0x410/0xfc8 fs/fs-writeback.c:2106
wb_check_background_flush fs/fs-writeback.c:2172 [inline]
wb_do_writeback fs/fs-writeback.c:2260 [inline]
wb_workfn+0xc44/0x1070 fs/fs-writeback.c:2288
wb_do_writeback fs/fs-writeback.c:2260 [inline]
process_one_work+0x790/0x11b8 kernel/workqueue.c:2310
worker_thread+0x910/0x1034 kernel/workqueue.c:2457
kthread+0x37c/0x45c kernel/kthread.c:334
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
-> #2 (jbd2_handle){.+.+}-{0:0}:
start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464
jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560
ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354
ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101
ocfs2_local_read_info+0xec8/0x1550 fs/ocfs2/quota_local.c:766
dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461
dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498
ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927
ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140
mount_bdev+0x274/0x370 fs/super.c:1398
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&journal->j_trans_barrier){.+.+}-{3:3}:
down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352
ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101
ocfs2_local_read_info+0xec8/0x1550 fs/ocfs2/quota_local.c:766
dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461
dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498
ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927
ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140
mount_bdev+0x274/0x370 fs/super.c:1398
ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
vfs_get_tree+0x90/0x274 fs/super.c:1528
do_new_mount+0x278/0x8fc fs/namespace.c:3005
path_mount+0x594/0x101c fs/namespace.c:3335
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount fs/namespace.c:3533 [inline]
__arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3533
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (sb_internal#2){.+.+}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ocfs2_reserve_local_alloc_bits+0x998/0x2474 fs/ocfs2/localalloc.c:668
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:765
__se_sys_fchown fs/open.c:765 [inline]
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);
lock(sb_internal#2);
*** DEADLOCK ***
7 locks held by syz-executor181/4042:
#0: ffff0000dcc4e460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:421
#1: ffff0000e19c89c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff0000e19c89c8 (&type->i_mutex_dir_key#6){+.+.}-{3:3}, at: chown_common+0x3f8/0x74c fs/open.c:674
#2: ffff0000e19360a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x24c/0xa90 fs/ocfs2/quota_global.c:806
#3: ffff0000e19dd108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#3: ffff0000e19dd108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
#4: ffff0000e19dcda0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
#5: ffff0000e185a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#5: ffff0000e185a648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x2474 fs/ocfs2/localalloc.c:635
#6: ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#6: ffff0000e19db488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x416c fs/ocfs2/suballoc.c:782
stack backtrace:
CPU: 1 PID: 4042 Comm: syz-executor181 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline]
ocfs2_reserve_local_alloc_bits+0x998/0x2474 fs/ocfs2/localalloc.c:668
ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
ocfs2_extend_allocation+0x474/0x18e4 fs/ocfs2/file.c:588
ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1030
ocfs2_acquire_dquot+0x5f8/0xa90 fs/ocfs2/quota_global.c:836
dqget+0x664/0xd0c fs/quota/dquot.c:986
ocfs2_setattr+0xc7c/0x191c fs/ocfs2/file.c:1243
notify_change+0xa34/0xcf8 fs/attr.c:505
chown_common+0x4ac/0x74c fs/open.c:680
vfs_fchown fs/open.c:748 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:759
__do_sys_fchown fs/open.c:767 [inline]
__se_sys_fchown fs/open.c:765 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:765
__se_sys_fchown fs/open.c:765 [inline]
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages