[v5.15] possible deadlock in ocfs2_calc_xattr_init

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17ff90a9980000
kernel config: https://syzkaller.appspot.com/x/.config?x=4d3fd5cca89ae935
dashboard link: https://syzkaller.appspot.com/bug?extid=4a9db841e5508bea2296
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ef5025f3d708/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/776fbdad3aa8/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/79541db5bd16/bzImage-3a592870.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+4a9db8...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.34/3813 is trying to acquire lock:
ffff888066c7dc78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_calc_xattr_init+0x204/0xd60 fs/ocfs2/xattr.c:631

but task is already holding lock:
ffff888060aedf48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
ffff888060aedf48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline]
ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline]
ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline]
ocfs2_evict_inode+0x2023/0x4500 fs/ocfs2/inode.c:1216
evict+0x529/0x930 fs/inode.c:622
d_delete_notify include/linux/fsnotify.h:267 [inline]
vfs_rmdir+0x33c/0x460 fs/namei.c:4162
do_rmdir+0x368/0x670 fs/namei.c:4210
__do_sys_rmdir fs/namei.c:4229 [inline]
__se_sys_rmdir fs/namei.c:4227 [inline]
__x64_sys_rmdir+0x45/0x50 fs/namei.c:4227
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
ocfs2_del_inode_from_orphan+0x155/0x7f0 fs/ocfs2/namei.c:2711
ocfs2_dio_end_io_write fs/ocfs2/aops.c:2334 [inline]
ocfs2_dio_end_io+0x556/0x1250 fs/ocfs2/aops.c:2432
dio_complete+0x25b/0x6e0 fs/direct-io.c:272
do_blockdev_direct_IO fs/direct-io.c:1336 [inline]
__blockdev_direct_IO+0x41f2/0x4f40 fs/direct-io.c:1368
ocfs2_direct_IO+0x250/0x2c0 fs/ocfs2/aops.c:2469
generic_file_direct_write+0x204/0x460 mm/filemap.c:3687
__generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3869
ocfs2_file_write_iter+0x17d5/0x1fa0 fs/ocfs2/file.c:2459
call_write_iter include/linux/fs.h:2172 [inline]
aio_write+0x566/0x780 fs/aio.c:1594
io_submit_one+0x768/0x18d0 fs/aio.c:2013
__do_sys_io_submit fs/aio.c:2072 [inline]
__se_sys_io_submit+0x17b/0x2f0 fs/aio.c:2042
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (&oi->ip_alloc_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xe3c/0x14f0 fs/ocfs2/file.c:517
ocfs2_setattr+0x165e/0x1c70 fs/ocfs2/file.c:1212
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
handle_truncate fs/namei.c:3265 [inline]
do_open fs/namei.c:3612 [inline]
path_openat+0x28a3/0x2f20 fs/namei.c:3742
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_creat fs/open.c:1343 [inline]
__se_sys_creat fs/open.c:1337 [inline]
__x64_sys_creat+0x11f/0x160 fs/open.c:1337
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&oi->ip_xattr_sem){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_calc_xattr_init+0x204/0xd60 fs/ocfs2/xattr.c:631
ocfs2_mknod+0x1303/0x2cd0 fs/ocfs2/namei.c:328
ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_creat fs/open.c:1343 [inline]
__se_sys_creat fs/open.c:1337 [inline]
__x64_sys_creat+0x11f/0x160 fs/open.c:1337
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
&oi->ip_xattr_sem --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]);
lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2);
lock(&oi->ip_xattr_sem);

*** DEADLOCK ***

3 locks held by syz.1.34/3813:
#0: ffff88807bc4a460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
#1: ffff888066c7df48 (&type->i_mutex_dir_key#8){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff888066c7df48 (&type->i_mutex_dir_key#8){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3529 [inline]
#1: ffff888066c7df48 (&type->i_mutex_dir_key#8){+.+.}-{3:3}, at: path_openat+0x824/0x2f20 fs/namei.c:3739
#2: ffff888060aedf48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#2: ffff888060aedf48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x18e/0x4c70 fs/ocfs2/suballoc.c:782

stack backtrace:
CPU: 1 PID: 3813 Comm: syz.1.34 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_calc_xattr_init+0x204/0xd60 fs/ocfs2/xattr.c:631
ocfs2_mknod+0x1303/0x2cd0 fs/ocfs2/namei.c:328
ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_creat fs/open.c:1343 [inline]
__se_sys_creat fs/open.c:1337 [inline]
__x64_sys_creat+0x11f/0x160 fs/open.c:1337
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f09df053ef9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f09dd4cc038 EFLAGS: 00000246 ORIG_RAX: 0000000000000055
RAX: ffffffffffffffda RBX: 00007f09df20bf80 RCX: 00007f09df053ef9
RDX: 0000000000000000 RSI: 000000000000000d RDI: 0000000020000240
RBP: 00007f09df0c6b76 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f09df20bf80 R15: 00007fff5851c818
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup