[v5.15] possible deadlock in ocfs2_try_remove_refcount_tree

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=11b390a9980000
kernel config: https://syzkaller.appspot.com/x/.config?x=4d3fd5cca89ae935
dashboard link: https://syzkaller.appspot.com/bug?extid=b7620f288c5e2968f14e
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ef5025f3d708/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/776fbdad3aa8/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/79541db5bd16/bzImage-3a592870.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b7620f...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------
syz.1.677/5741 is trying to acquire lock:
ffff888073a8bf60 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931

but task is already holding lock:
ffff888073a8bff8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa1/0x330 fs/ocfs2/refcounttree.c:930

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1e8f/0x2cd0 fs/ocfs2/namei.c:408
ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672
lookup_open fs/namei.c:3462 [inline]
open_last_lookups fs/namei.c:3532 [inline]
path_openat+0x130a/0x2f20 fs/namei.c:3739
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_open fs/open.c:1277 [inline]
__se_sys_open fs/open.c:1273 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1273
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #3 (jbd2_handle){++++}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521
jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560
ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1425
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1db/0x8b0 fs/ocfs2/super.c:1882
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1425
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:188
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:181
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:214
__syscall_exit_to_user_mode_work kernel/entry/common.c:296 [inline]
syscall_exit_to_user_mode+0x5d/0x240 kernel/entry/common.c:307
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #1 (sb_internal#2){.+.+}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]
ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350
ocfs2_write_begin_inline fs/ocfs2/aops.c:1483 [inline]
ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1586 [inline]
ocfs2_write_begin_nolock+0x2242/0x4d20 fs/ocfs2/aops.c:1672
ocfs2_write_begin+0x1fd/0x390 fs/ocfs2/aops.c:1906
generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3785
__generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3912
ocfs2_file_write_iter+0x17d5/0x1fa0 fs/ocfs2/file.c:2459
call_write_iter include/linux/fs.h:2172 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacd/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

-> #0 (&oi->ip_alloc_sem){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xe3c/0x14f0 fs/ocfs2/file.c:517
ocfs2_setattr+0x165e/0x1c70 fs/ocfs2/file.c:1212
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
handle_truncate fs/namei.c:3265 [inline]
do_open fs/namei.c:3612 [inline]
path_openat+0x28a3/0x2f20 fs/namei.c:3742
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_open fs/open.c:1277 [inline]
__se_sys_open fs/open.c:1273 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1273
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0

other info that might help us debug this:

Chain exists of:
&oi->ip_alloc_sem --> jbd2_handle --> &oi->ip_xattr_sem

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&oi->ip_xattr_sem);
lock(jbd2_handle);
lock(&oi->ip_xattr_sem);
lock(&oi->ip_alloc_sem);

*** DEADLOCK ***

3 locks held by syz.1.677/5741:
#0: ffff88801e24c460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
#1: ffff888073a8c2c8 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff888073a8c2c8 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: do_truncate+0x208/0x300 fs/open.c:63
#2: ffff888073a8bff8 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa1/0x330 fs/ocfs2/refcounttree.c:930

stack backtrace:
CPU: 1 PID: 5741 Comm: syz.1.677 Not tainted 5.15.167-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write+0x38/0x60 kernel/locking/rwsem.c:1551
ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xe3c/0x14f0 fs/ocfs2/file.c:517
ocfs2_setattr+0x165e/0x1c70 fs/ocfs2/file.c:1212
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
handle_truncate fs/namei.c:3265 [inline]
do_open fs/namei.c:3612 [inline]
path_openat+0x28a3/0x2f20 fs/namei.c:3742
do_filp_open+0x21c/0x460 fs/namei.c:3769
do_sys_openat2+0x13b/0x4f0 fs/open.c:1253
do_sys_open fs/open.c:1269 [inline]
__do_sys_open fs/open.c:1277 [inline]
__se_sys_open fs/open.c:1273 [inline]
__x64_sys_open+0x221/0x270 fs/open.c:1273
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x66/0xd0
RIP: 0033:0x7f59eb551ef9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f59e99ca038 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 00007f59eb709f80 RCX: 00007f59eb551ef9
RDX: 0000000000000000 RSI: 000000000014927e RDI: 0000000020000180
RBP: 00007f59eb5c4b76 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f59eb709f80 R15: 00007ffcb731e838
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 3a5928702e71 Linux 5.15.167
git tree: linux-5.15.y

console output: https://syzkaller.appspot.com/x/log.txt?x=11e19900580000
kernel config: https://syzkaller.appspot.com/x/.config?x=171882977b524c53

dashboard link: https://syzkaller.appspot.com/bug?extid=b7620f288c5e2968f14e
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

userspace arch: arm64
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12fdf49f980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=105497c7980000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/22ee27cb312d/disk-3a592870.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/90bf6a3e3d20/vmlinux-3a592870.xz
kernel image: https://storage.googleapis.com/syzbot-assets/096dd2c73ac3/Image-3a592870.gz.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/951cd61e6ece/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+b7620f...@syzkaller.appspotmail.com

el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
ENOMEM in journal_alloc_journal_head, retrying.

======================================================
WARNING: possible circular locking dependency detected
5.15.167-syzkaller #0 Not tainted
------------------------------------------------------

syz-executor283/4018 is trying to acquire lock:
ffff0000e24dcda0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:931

but task is already holding lock:

ffff0000e24dce38 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa8/0x2f0 fs/ocfs2/refcounttree.c:930

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{3:3}:

down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_init_acl+0x2d0/0x778 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1558/0x24f8 fs/ocfs2/namei.c:408
ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4065
do_mkdirat+0x20c/0x610 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #3 (jbd2_handle){.+.+}-{0:0}:
start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464
jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521
jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560
ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354
ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4065
do_mkdirat+0x20c/0x610 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:

down_read+0xc0/0x398 kernel/locking/rwsem.c:1498
ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352
ocfs2_mknod+0xe68/0x24f8 fs/ocfs2/namei.c:359
ocfs2_mkdir+0x184/0x4c8 fs/ocfs2/namei.c:655
vfs_mkdir+0x334/0x4e4 fs/namei.c:4065
do_mkdirat+0x20c/0x610 fs/namei.c:4090
__do_sys_mkdirat fs/namei.c:4105 [inline]
__se_sys_mkdirat fs/namei.c:4103 [inline]
__arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (sb_internal#2){.+.+}-{0:0}:

percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1811 [inline]
sb_start_intwrite include/linux/fs.h:1928 [inline]

ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350
ocfs2_orphan_for_truncate fs/ocfs2/file.c:392 [inline]
ocfs2_truncate_file+0x5f8/0x14dc fs/ocfs2/file.c:496
ocfs2_setattr+0x1244/0x191c fs/ocfs2/file.c:1212
notify_change+0xa34/0xcf8 fs/attr.c:505
do_truncate+0x1c0/0x28c fs/open.c:65
do_coredump+0x23b8/0x2890 fs/coredump.c:803
get_signal+0x3dc/0x1550 kernel/signal.c:2883
do_signal arch/arm64/kernel/signal.c:890 [inline]
do_notify_resume+0x320/0x32b8 arch/arm64/kernel/signal.c:943
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
el0_da+0x118/0x20c arch/arm64/kernel/entry-common.c:495
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (&oi->ip_alloc_sem){+.+.}-{3:3}:

check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]

validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xd0c/0x14dc fs/ocfs2/file.c:517
ocfs2_setattr+0x1244/0x191c fs/ocfs2/file.c:1212
notify_change+0xa34/0xcf8 fs/attr.c:505
do_truncate+0x1c0/0x28c fs/open.c:65
do_coredump+0x23b8/0x2890 fs/coredump.c:803
get_signal+0x3dc/0x1550 kernel/signal.c:2883
do_signal arch/arm64/kernel/signal.c:890 [inline]
do_notify_resume+0x320/0x32b8 arch/arm64/kernel/signal.c:943
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
el0_da+0x118/0x20c arch/arm64/kernel/entry-common.c:495
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
&oi->ip_alloc_sem --> jbd2_handle --> &oi->ip_xattr_sem

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&oi->ip_xattr_sem);
lock(jbd2_handle);
lock(&oi->ip_xattr_sem);
lock(&oi->ip_alloc_sem);

*** DEADLOCK ***

2 locks held by syz-executor283/4018:
#0: ffff0000e24dd108 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#0: ffff0000e24dd108 (&sb->s_type->i_mutex_key#20){+.+.}-{3:3}, at: do_truncate+0x1ac/0x28c fs/open.c:63
#1: ffff0000e24dce38 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa8/0x2f0 fs/ocfs2/refcounttree.c:930

stack backtrace:
CPU: 1 PID: 4018 Comm: syz-executor283 Not tainted 5.15.167-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024

Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133

check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]

validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xd0c/0x14dc fs/ocfs2/file.c:517
ocfs2_setattr+0x1244/0x191c fs/ocfs2/file.c:1212
notify_change+0xa34/0xcf8 fs/attr.c:505
do_truncate+0x1c0/0x28c fs/open.c:65
do_coredump+0x23b8/0x2890 fs/coredump.c:803
get_signal+0x3dc/0x1550 kernel/signal.c:2883
do_signal arch/arm64/kernel/signal.c:890 [inline]
do_notify_resume+0x320/0x32b8 arch/arm64/kernel/signal.c:943
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
el0_da+0x118/0x20c arch/arm64/kernel/entry-common.c:495
el0t_64_sync_handler+0xc0/0xe4 arch/arm64/kernel/entry-common.c:629
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
ocfs2: Unmounting device (7,0) on (node local)


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 5f55cad62cc9 Linux 6.1.110
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=139548a9980000
kernel config: https://syzkaller.appspot.com/x/.config?x=2b466a2c4193d8e0
dashboard link: https://syzkaller.appspot.com/bug?extid=f728bc30af05ef4bd02c

compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/8e7c40462355/disk-5f55cad6.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5a00d1171f8b/vmlinux-5f55cad6.xz
kernel image: https://storage.googleapis.com/syzbot-assets/275f8c9e4c97/bzImage-5f55cad6.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+f728bc...@syzkaller.appspotmail.com

ocfs2: Mounting device (7,3) on (node local, slot 0) with ordered data mode.

======================================================
WARNING: possible circular locking dependency detected

6.1.110-syzkaller #0 Not tainted
------------------------------------------------------
syz.3.182/4402 is trying to acquire lock:
ffff888072e3dbe0 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931

but task is already holding lock:

ffff888072e3dc78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa1/0x330 fs/ocfs2/refcounttree.c:930

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{3:3}:

lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365
ocfs2_mknod+0x1f75/0x2e20 fs/ocfs2/namei.c:408
ocfs2_mkdir+0x1c0/0x4e0 fs/ocfs2/namei.c:655
vfs_mkdir+0x3b6/0x590 fs/namei.c:4108
do_mkdirat+0x225/0x360 fs/namei.c:4133
__do_sys_mkdirat fs/namei.c:4148 [inline]
__se_sys_mkdirat fs/namei.c:4146 [inline]
__x64_sys_mkdirat+0x85/0x90 fs/namei.c:4146
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #3 (jbd2_handle){++++}-{0:0}:

lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559
ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1fb/0x960 fs/ocfs2/super.c:1879
generic_shutdown_super+0x130/0x340 fs/super.c:501
kill_block_super+0x7a/0xe0 fs/super.c:1470
deactivate_locked_super+0xa0/0x110 fs/super.c:332
cleanup_mnt+0x490/0x520 fs/namespace.c:1186
task_work_run+0x246/0x300 kernel/task_work.c:203
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210
__syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:

lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352
ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416
ocfs2_dismount_volume+0x1fb/0x960 fs/ocfs2/super.c:1879
generic_shutdown_super+0x130/0x340 fs/super.c:501
kill_block_super+0x7a/0xe0 fs/super.c:1470
deactivate_locked_super+0xa0/0x110 fs/super.c:332
cleanup_mnt+0x490/0x520 fs/namespace.c:1186
task_work_run+0x246/0x300 kernel/task_work.c:203
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210
__syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303
do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (sb_internal#2){.+.+}-{0:0}:

lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1891 [inline]
sb_start_intwrite include/linux/fs.h:2013 [inline]
ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350
ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
ocfs2_write_begin_nolock+0x2073/0x4e40 fs/ocfs2/aops.c:1671
ocfs2_write_begin+0x201/0x390 fs/ocfs2/aops.c:1905
generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3817
__generic_file_write_iter+0x176/0x400 mm/filemap.c:3945
ocfs2_file_write_iter+0x17c6/0x2020 fs/ocfs2/file.c:2456
call_write_iter include/linux/fs.h:2265 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x857/0xbc0 fs/read_write.c:584
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&oi->ip_alloc_sem){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_write+0x36/0x60 kernel/locking/rwsem.c:1573
ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xea2/0x1630 fs/ocfs2/file.c:517
ocfs2_setattr+0x18bc/0x1f80 fs/ocfs2/file.c:1209
notify_change+0xce3/0xfc0 fs/attr.c:499
do_truncate+0x21c/0x300 fs/open.c:65
handle_truncate fs/namei.c:3287 [inline]
do_open fs/namei.c:3632 [inline]
path_openat+0x27e2/0x2e60 fs/namei.c:3785
do_filp_open+0x230/0x480 fs/namei.c:3812
do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
do_sys_open fs/open.c:1334 [inline]
__do_sys_openat fs/open.c:1350 [inline]
__se_sys_openat fs/open.c:1345 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1345
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
&oi->ip_alloc_sem --> jbd2_handle --> &oi->ip_xattr_sem

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&oi->ip_xattr_sem);
lock(jbd2_handle);
lock(&oi->ip_xattr_sem);
lock(&oi->ip_alloc_sem);

*** DEADLOCK ***

3 locks held by syz.3.182/4402:
#0: ffff888076dba460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393
#1: ffff888072e3df48 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#1: ffff888072e3df48 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: do_truncate+0x208/0x300 fs/open.c:63
#2: ffff888072e3dc78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_try_remove_refcount_tree+0xa1/0x330 fs/ocfs2/refcounttree.c:930

stack backtrace:
CPU: 0 PID: 4402 Comm: syz.3.182 Not tainted 6.1.110-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024

Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]

dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_write+0x36/0x60 kernel/locking/rwsem.c:1573
ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:931
ocfs2_truncate_file+0xea2/0x1630 fs/ocfs2/file.c:517
ocfs2_setattr+0x18bc/0x1f80 fs/ocfs2/file.c:1209
notify_change+0xce3/0xfc0 fs/attr.c:499
do_truncate+0x21c/0x300 fs/open.c:65
handle_truncate fs/namei.c:3287 [inline]
do_open fs/namei.c:3632 [inline]
path_openat+0x27e2/0x2e60 fs/namei.c:3785
do_filp_open+0x230/0x480 fs/namei.c:3812
do_sys_openat2+0x13b/0x4f0 fs/open.c:1318
do_sys_open fs/open.c:1334 [inline]
__do_sys_openat fs/open.c:1350 [inline]
__se_sys_openat fs/open.c:1345 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1345
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7fc52bf7def9

Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48

RSP: 002b:00007fc52cda6038 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007fc52c135f80 RCX: 00007fc52bf7def9
RDX: 0000000000026300 RSI: 0000000020000680 RDI: ffffffffffffff9c
RBP: 00007fc52bff0b76 R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000

R13: 0000000000000000 R14: 00007fc52c135f80 R15: 00007ffc9a5d6b88