[v6.1] possible deadlock in reiserfs_dirty_inode
0 views
Skip to first unread message
syzbot
Apr 5, 2023, 9:23:52 PM4/5/23
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 3b29299e5f60 Linux 6.1.22
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1669168dc80000
kernel config: https://syzkaller.appspot.com/x/.config?x=bbb9a1f6f7f5a1d9
dashboard link: https://syzkaller.appspot.com/bug?extid=8686c078f78a397d8fcc
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2affbd06cbfd/disk-3b29299e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8b22d1baf827/vmlinux-3b29299e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d5e3891c88bf/Image-3b29299e.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8686c0...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.22-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/17723 is trying to acquire lock:
ffff0000c62fbd48 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x9c/0x124 mm/memory.c:5640
but task is already holding lock:
ffff000123645090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&sbi->lock){+.+.}-{3:3}:
__mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
reiserfs_dirty_inode+0xe4/0x204 fs/reiserfs/super.c:704
__mark_inode_dirty+0x2f8/0x1354 fs/fs-writeback.c:2408
generic_update_time fs/inode.c:1859 [inline]
inode_update_time fs/inode.c:1872 [inline]
touch_atime+0x5f0/0x8ec fs/inode.c:1944
file_accessed include/linux/fs.h:2535 [inline]
generic_file_mmap+0xb0/0x11c mm/filemap.c:3455
call_mmap include/linux/fs.h:2210 [inline]
mmap_region+0xdd0/0x1a98 mm/mmap.c:2625
do_mmap+0xa00/0x1108 mm/mmap.c:1411
vm_mmap_pgoff+0x1a4/0x2b4 mm/util.c:520
ksys_mmap_pgoff+0x3c8/0x5b0 mm/mmap.c:1457
__do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
__se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
__arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain kernel/locking/lockdep.c:3832 [inline]
__lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__might_fault+0xc4/0x124 mm/memory.c:5641
reiserfs_ioctl+0x10c/0x454 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl fs/ioctl.c:856 [inline]
__arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->lock);
lock(&mm->mmap_lock);
lock(&sbi->lock);
lock(&mm->mmap_lock);
*** DEADLOCK ***
1 lock held by syz-executor.0/17723:
#0: ffff000123645090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
stack backtrace:
CPU: 1 PID: 17723 Comm: syz-executor.0 Not tainted 6.1.22-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x5c lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain kernel/locking/lockdep.c:3832 [inline]
__lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__might_fault+0xc4/0x124 mm/memory.c:5641
reiserfs_ioctl+0x10c/0x454 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl fs/ioctl.c:856 [inline]
__arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following issue on:
HEAD commit: 3b29299e5f60 Linux 6.1.22
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1669168dc80000
kernel config: https://syzkaller.appspot.com/x/.config?x=bbb9a1f6f7f5a1d9
dashboard link: https://syzkaller.appspot.com/bug?extid=8686c078f78a397d8fcc
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2affbd06cbfd/disk-3b29299e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8b22d1baf827/vmlinux-3b29299e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d5e3891c88bf/Image-3b29299e.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8686c0...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.22-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/17723 is trying to acquire lock:
ffff0000c62fbd48 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x9c/0x124 mm/memory.c:5640
but task is already holding lock:
ffff000123645090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&sbi->lock){+.+.}-{3:3}:
__mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
reiserfs_dirty_inode+0xe4/0x204 fs/reiserfs/super.c:704
__mark_inode_dirty+0x2f8/0x1354 fs/fs-writeback.c:2408
generic_update_time fs/inode.c:1859 [inline]
inode_update_time fs/inode.c:1872 [inline]
touch_atime+0x5f0/0x8ec fs/inode.c:1944
file_accessed include/linux/fs.h:2535 [inline]
generic_file_mmap+0xb0/0x11c mm/filemap.c:3455
call_mmap include/linux/fs.h:2210 [inline]
mmap_region+0xdd0/0x1a98 mm/mmap.c:2625
do_mmap+0xa00/0x1108 mm/mmap.c:1411
vm_mmap_pgoff+0x1a4/0x2b4 mm/util.c:520
ksys_mmap_pgoff+0x3c8/0x5b0 mm/mmap.c:1457
__do_sys_mmap arch/arm64/kernel/sys.c:28 [inline]
__se_sys_mmap arch/arm64/kernel/sys.c:21 [inline]
__arm64_sys_mmap+0xf8/0x110 arch/arm64/kernel/sys.c:21
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain kernel/locking/lockdep.c:3832 [inline]
__lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__might_fault+0xc4/0x124 mm/memory.c:5641
reiserfs_ioctl+0x10c/0x454 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl fs/ioctl.c:856 [inline]
__arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->lock);
lock(&mm->mmap_lock);
lock(&sbi->lock);
lock(&mm->mmap_lock);
*** DEADLOCK ***
1 lock held by syz-executor.0/17723:
#0: ffff000123645090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x7c/0xe8 fs/reiserfs/lock.c:27
stack backtrace:
CPU: 1 PID: 17723 Comm: syz-executor.0 Not tainted 6.1.22-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x5c lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain kernel/locking/lockdep.c:3832 [inline]
__lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__might_fault+0xc4/0x124 mm/memory.c:5641
reiserfs_ioctl+0x10c/0x454 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl fs/ioctl.c:856 [inline]
__arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Aug 23, 2023, 12:14:46 PM8/23/23
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: 6c44e13dc284 Linux 6.1.46
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=13e4aa60680000
kernel config: https://syzkaller.appspot.com/x/.config?x=d53bfb03cd3f0d5d
dashboard link: https://syzkaller.appspot.com/bug?extid=8686c078f78a397d8fcc
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=120c02b7a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10050bd3a80000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/706045968752/disk-6c44e13d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2f25349b69b4/vmlinux-6c44e13d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/e6791616e516/bzImage-6c44e13d.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/458e7afaceb2/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/e53ef83a7124/mount_7.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8686c0...@syzkaller.appspotmail.com
REISERFS warning (device loop0): super-6502 reiserfs_getopt: unknown mount option "���������<<�G4��mR���� u����0� �w/�^��� �����"
------------------------------------------------------
syz-executor305/3511 is trying to acquire lock:
ffff88807e8e53d8 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x8f/0x110 mm/memory.c:5800
but task is already holding lock:
ffff888017ee5090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&sbi->lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
reiserfs_dirty_inode+0xee/0x240 fs/reiserfs/super.c:704
__mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2411
generic_update_time fs/inode.c:1901 [inline]
inode_update_time fs/inode.c:1914 [inline]
__file_update_time+0x221/0x240 fs/inode.c:2102
file_update_time+0x34c/0x3c0 fs/inode.c:2133
filemap_page_mkwrite+0x275/0x630 mm/filemap.c:3422
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2982
wp_page_shared+0x164/0x380 mm/memory.c:3331
handle_pte_fault mm/memory.c:5001 [inline]
__handle_mm_fault mm/memory.c:5125 [inline]
handle_mm_fault+0x2522/0x5330 mm/memory.c:5246
do_user_addr_fault arch/x86/mm/fault.c:1380 [inline]
handle_page_fault arch/x86/mm/fault.c:1471 [inline]
exc_page_fault+0x26f/0x660 arch/x86/mm/fault.c:1527
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
-> #1 (sb_pagefaults){.+.+}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_pagefault include/linux/fs.h:1936 [inline]
filemap_page_mkwrite+0x16a/0x630 mm/filemap.c:3421
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2982
do_shared_fault mm/memory.c:4647 [inline]
do_fault mm/memory.c:4715 [inline]
handle_pte_fault mm/memory.c:4983 [inline]
__handle_mm_fault mm/memory.c:5125 [inline]
handle_mm_fault+0x22e8/0x5330 mm/memory.c:5246
do_user_addr_fault arch/x86/mm/fault.c:1380 [inline]
handle_page_fault arch/x86/mm/fault.c:1471 [inline]
exc_page_fault+0x26f/0x660 arch/x86/mm/fault.c:1527
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__might_fault+0xb2/0x110 mm/memory.c:5801
reiserfs_ioctl+0x11d/0x340 fs/reiserfs/ioctl.c:96
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
Chain exists of:
&mm->mmap_lock --> sb_pagefaults --> &sbi->lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->lock);
lock(sb_pagefaults);
#0: ffff888017ee5090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
stack backtrace:
CPU: 0 PID: 3511 Comm: syz-executor305 Not tainted 6.1.46-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__might_fault+0xb2/0x110 mm/memory.c:5801
reiserfs_ioctl+0x11d/0x340 fs/reiserfs/ioctl.c:96
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7ff6b3b91689
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 d1 1a 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffeaaa746d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ff6b3b91689
RDX: 0000000020000000 RSI: 0000000080087601 RDI: 0000000000000006
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 00e68eb686f904ed R11: 0000000000000246 R12: 00007ffeaaa747e0
R13: 00007ffeaaa748c0 R14: 431bde82d7b634db R15: 00007ff6b3bd301d
</TASK>
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
HEAD commit: 6c44e13dc284 Linux 6.1.46
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=13e4aa60680000
kernel config: https://syzkaller.appspot.com/x/.config?x=d53bfb03cd3f0d5d
dashboard link: https://syzkaller.appspot.com/bug?extid=8686c078f78a397d8fcc
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=120c02b7a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10050bd3a80000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/706045968752/disk-6c44e13d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2f25349b69b4/vmlinux-6c44e13d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/e6791616e516/bzImage-6c44e13d.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/458e7afaceb2/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/e53ef83a7124/mount_7.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8686c0...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.46-syzkaller #0 Not tainted
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz-executor305/3511 is trying to acquire lock:
ffff88807e8e53d8 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0x8f/0x110 mm/memory.c:5800
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
reiserfs_dirty_inode+0xee/0x240 fs/reiserfs/super.c:704
__mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2411
generic_update_time fs/inode.c:1901 [inline]
inode_update_time fs/inode.c:1914 [inline]
__file_update_time+0x221/0x240 fs/inode.c:2102
file_update_time+0x34c/0x3c0 fs/inode.c:2133
filemap_page_mkwrite+0x275/0x630 mm/filemap.c:3422
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2982
wp_page_shared+0x164/0x380 mm/memory.c:3331
handle_pte_fault mm/memory.c:5001 [inline]
__handle_mm_fault mm/memory.c:5125 [inline]
handle_mm_fault+0x2522/0x5330 mm/memory.c:5246
do_user_addr_fault arch/x86/mm/fault.c:1380 [inline]
handle_page_fault arch/x86/mm/fault.c:1471 [inline]
exc_page_fault+0x26f/0x660 arch/x86/mm/fault.c:1527
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
-> #1 (sb_pagefaults){.+.+}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_pagefault include/linux/fs.h:1936 [inline]
filemap_page_mkwrite+0x16a/0x630 mm/filemap.c:3421
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2982
do_shared_fault mm/memory.c:4647 [inline]
do_fault mm/memory.c:4715 [inline]
handle_pte_fault mm/memory.c:4983 [inline]
__handle_mm_fault mm/memory.c:5125 [inline]
handle_mm_fault+0x22e8/0x5330 mm/memory.c:5246
do_user_addr_fault arch/x86/mm/fault.c:1380 [inline]
handle_page_fault arch/x86/mm/fault.c:1471 [inline]
exc_page_fault+0x26f/0x660 arch/x86/mm/fault.c:1527
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
-> #0 (&mm->mmap_lock){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__might_fault+0xb2/0x110 mm/memory.c:5801
reiserfs_ioctl+0x11d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
__do_sys_ioctl fs/ioctl.c:870 [inline]
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
&mm->mmap_lock --> sb_pagefaults --> &sbi->lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->lock);
lock(&sbi->lock);
lock(&mm->mmap_lock);
*** DEADLOCK ***
1 lock held by syz-executor305/3511:
lock(&mm->mmap_lock);
*** DEADLOCK ***
#0: ffff888017ee5090 (&sbi->lock){+.+.}-{3:3}, at: reiserfs_write_lock+0x76/0xd0 fs/reiserfs/lock.c:27
stack backtrace:
CPU: 0 PID: 3511 Comm: syz-executor305 Not tainted 6.1.46-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__might_fault+0xb2/0x110 mm/memory.c:5801
reiserfs_ioctl+0x11d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
__do_sys_ioctl fs/ioctl.c:870 [inline]
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7ff6b3b91689
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 d1 1a 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffeaaa746d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ff6b3b91689
RDX: 0000000020000000 RSI: 0000000080087601 RDI: 0000000000000006
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 00e68eb686f904ed R11: 0000000000000246 R12: 00007ffeaaa747e0
R13: 00007ffeaaa748c0 R14: 431bde82d7b634db R15: 00007ff6b3bd301d
</TASK>
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages