[v6.1] possible deadlock in input_event

1 view
Skip to first unread message

syzbot

unread,
Jun 23, 2023, 8:11:01 AM6/23/23
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: e84a4e368abe Linux 6.1.35
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=147edf4b280000
kernel config: https://syzkaller.appspot.com/x/.config?x=f77b603a569f81a7
dashboard link: https://syzkaller.appspot.com/bug?extid=0804476ed7b48fa80ca2
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/30886a06f234/disk-e84a4e36.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/84ab10f3c74b/vmlinux-e84a4e36.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ea73248cc405/Image-e84a4e36.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+080447...@syzkaller.appspotmail.com

=====================================================
WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected
6.1.35-syzkaller #0 Not tainted
-----------------------------------------------------
syz-executor.2/14672 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire:
ffff80001553a058 (tasklist_lock){.+.+}-{2:2}, at: send_sigurg+0xc8/0x38c fs/fcntl.c:833

and this task is already holding:
ffff00013c6bd030 (&f->f_owner.lock){....}-{2:2}, at: send_sigurg+0x34/0x38c fs/fcntl.c:817
which would create a new lock dependency:
(&f->f_owner.lock){....}-{2:2} -> (tasklist_lock){.+.+}-{2:2}

but this new dependency connects a SOFTIRQ-irq-safe lock:
(&dev->event_lock#2){..-.}-{2:2}

... which became SOFTIRQ-irq-safe at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0x6c/0xb4 kernel/locking/spinlock.c:162
input_event+0xa8/0xec drivers/input/input.c:430
hidinput_hid_event+0xfa0/0x1764 drivers/hid/hid-input.c:1662
hid_process_event+0x3e0/0x528 drivers/hid/hid-core.c:1537
hid_process_report drivers/hid/hid-core.c:1685 [inline]
hid_report_raw_event+0xd34/0x1448 drivers/hid/hid-core.c:2012
hid_input_report+0x3ac/0x480 drivers/hid/hid-core.c:2080
hid_irq_in+0x3ec/0x708 drivers/hid/usbhid/hid-core.c:284
__usb_hcd_giveback_urb+0x2e0/0x504 drivers/usb/core/hcd.c:1671
usb_hcd_giveback_urb+0x108/0x3f8 drivers/usb/core/hcd.c:1754
dummy_timer+0x66c/0x26cc drivers/usb/gadget/udc/dummy_hcd.c:1988
call_timer_fn+0x1c0/0xa1c kernel/time/timer.c:1474
expire_timers kernel/time/timer.c:1519 [inline]
__run_timers+0x554/0x718 kernel/time/timer.c:1790
run_timer_softirq+0x7c/0x114 kernel/time/timer.c:1803
__do_softirq+0x30c/0xea0 kernel/softirq.c:571
____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:79
call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:889
do_softirq_own_stack+0x20/0x2c arch/arm64/kernel/irq.c:84
invoke_softirq kernel/softirq.c:452 [inline]
__irq_exit_rcu+0x28c/0x534 kernel/softirq.c:650
irq_exit_rcu+0x14/0x84 kernel/softirq.c:662
__el1_irq arch/arm64/kernel/entry-common.c:472 [inline]
el1_interrupt+0x38/0x68 arch/arm64/kernel/entry-common.c:486
el1h_64_irq_handler+0x18/0x24 arch/arm64/kernel/entry-common.c:491
el1h_64_irq+0x64/0x68 arch/arm64/kernel/entry.S:577
arch_local_irq_enable+0xc/0x18 arch/arm64/include/asm/irqflags.h:35
default_idle_call+0x68/0xdc kernel/sched/idle.c:109
cpuidle_idle_call kernel/sched/idle.c:191 [inline]
do_idle+0x1e0/0x514 kernel/sched/idle.c:303
cpu_startup_entry+0x24/0x28 kernel/sched/idle.c:400
rest_init+0x2d8/0x2f0 init/main.c:729
start_kernel+0x0/0x60c init/main.c:890
start_kernel+0x44c/0x60c init/main.c:1145
__primary_switched+0xb8/0xc0 arch/arm64/kernel/head.S:468

to a SOFTIRQ-irq-unsafe lock:
(tasklist_lock){.+.+}-{2:2}

... which became SOFTIRQ-irq-unsafe at:
...
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x68/0x84 kernel/locking/spinlock.c:228
do_wait+0x2bc/0xb40 kernel/exit.c:1602
kernel_wait+0xe0/0x20c kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xd0/0x248 kernel/umh.c:167
process_one_work+0x7ac/0x1404 kernel/workqueue.c:2289
worker_thread+0x8e4/0xfec kernel/workqueue.c:2436
kthread+0x250/0x2d8 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860

other info that might help us debug this:

Chain exists of:
&dev->event_lock#2 --> &f->f_owner.lock --> tasklist_lock

Possible interrupt unsafe locking scenario:

CPU0 CPU1
---- ----
lock(tasklist_lock);
local_irq_disable();
lock(&dev->event_lock#2);
lock(&f->f_owner.lock);
<Interrupt>
lock(&dev->event_lock#2);

*** DEADLOCK ***

2 locks held by syz-executor.2/14672:
#0: ffff0000d5b2cdb0 (sk_lock-AF_INET6){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1733 [inline]
#0: ffff0000d5b2cdb0 (sk_lock-AF_INET6){+.+.}-{0:0}, at: tcp_sendmsg+0x30/0x64 net/ipv4/tcp.c:1485
#1: ffff00013c6bd030 (&f->f_owner.lock){....}-{2:2}, at: send_sigurg+0x34/0x38c fs/fcntl.c:817

the dependencies between SOFTIRQ-irq-safe lock and the holding lock:
-> (&dev->event_lock#2){..-.}-{2:2} {
IN-SOFTIRQ-W at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0x6c/0xb4 kernel/locking/spinlock.c:162
input_event+0xa8/0xec drivers/input/input.c:430
hidinput_hid_event+0xfa0/0x1764 drivers/hid/hid-input.c:1662
hid_process_event+0x3e0/0x528 drivers/hid/hid-core.c:1537
hid_process_report drivers/hid/hid-core.c:1685 [inline]
hid_report_raw_event+0xd34/0x1448 drivers/hid/hid-core.c:2012
hid_input_report+0x3ac/0x480 drivers/hid/hid-core.c:2080
hid_irq_in+0x3ec/0x708 drivers/hid/usbhid/hid-core.c:284
__usb_hcd_giveback_urb+0x2e0/0x504 drivers/usb/core/hcd.c:1671
usb_hcd_giveback_urb+0x108/0x3f8 drivers/usb/core/hcd.c:1754
dummy_timer+0x66c/0x26cc drivers/usb/gadget/udc/dummy_hcd.c:1988
call_timer_fn+0x1c0/0xa1c kernel/time/timer.c:1474
expire_timers kernel/time/timer.c:1519 [inline]
__run_timers+0x554/0x718 kernel/time/timer.c:1790
run_timer_softirq+0x7c/0x114 kernel/time/timer.c:1803
__do_softirq+0x30c/0xea0 kernel/softirq.c:571
____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:79
call_on_irq_stack+0x24/0x4c arch/arm64/kernel/entry.S:889
do_softirq_own_stack+0x20/0x2c arch/arm64/kernel/irq.c:84
invoke_softirq kernel/softirq.c:452 [inline]
__irq_exit_rcu+0x28c/0x534 kernel/softirq.c:650
irq_exit_rcu+0x14/0x84 kernel/softirq.c:662
__el1_irq arch/arm64/kernel/entry-common.c:472 [inline]
el1_interrupt+0x38/0x68 arch/arm64/kernel/entry-common.c:486
el1h_64_irq_handler+0x18/0x24 arch/arm64/kernel/entry-common.c:491
el1h_64_irq+0x64/0x68 arch/arm64/kernel/entry.S:577
arch_local_irq_enable+0xc/0x18 arch/arm64/include/asm/irqflags.h:35
default_idle_call+0x68/0xdc kernel/sched/idle.c:109
cpuidle_idle_call kernel/sched/idle.c:191 [inline]
do_idle+0x1e0/0x514 kernel/sched/idle.c:303
cpu_startup_entry+0x24/0x28 kernel/sched/idle.c:400
rest_init+0x2d8/0x2f0 init/main.c:729
start_kernel+0x0/0x60c init/main.c:890
start_kernel+0x44c/0x60c init/main.c:1145
__primary_switched+0xb8/0xc0 arch/arm64/kernel/head.S:468
INITIAL USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0x6c/0xb4 kernel/locking/spinlock.c:162
input_inject_event+0xc8/0x30c drivers/input/input.c:456
evdev_write+0x348/0x424 drivers/input/evdev.c:530
vfs_write+0x2a4/0x914 fs/read_write.c:582
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
}
... key at: [<ffff8000199d6380>] input_allocate_device.__key.6+0x0/0x20
-> (&client->buffer_lock){....}-{2:2} {
INITIAL USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x54/0x6c kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:350 [inline]
evdev_pass_values+0xe0/0x798 drivers/input/evdev.c:261
evdev_events+0x1b0/0x2f4 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x70c/0xea8 drivers/input/input.c:159
input_event_dispose+0x2a0/0x54c drivers/input/input.c:374
input_handle_event+0x710/0x9a8 drivers/input/input.c:402
input_inject_event+0x1ec/0x30c drivers/input/input.c:461
evdev_write+0x348/0x424 drivers/input/evdev.c:530
vfs_write+0x2a4/0x914 fs/read_write.c:582
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
}
... key at: [<ffff8000199d6640>] evdev_open.__key.20+0x0/0x20
... acquired at:
__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x54/0x6c kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:350 [inline]
evdev_pass_values+0xe0/0x798 drivers/input/evdev.c:261
evdev_events+0x1b0/0x2f4 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x70c/0xea8 drivers/input/input.c:159
input_event_dispose+0x2a0/0x54c drivers/input/input.c:374
input_handle_event+0x710/0x9a8 drivers/input/input.c:402
input_inject_event+0x1ec/0x30c drivers/input/input.c:461
evdev_write+0x348/0x424 drivers/input/evdev.c:530
vfs_write+0x2a4/0x914 fs/read_write.c:582
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> (&new->fa_lock){....}-{2:2} {
INITIAL USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_write_lock_irq include/linux/rwlock_api_smp.h:195 [inline]
_raw_write_lock_irq+0x70/0x9c kernel/locking/spinlock.c:326
fasync_remove_entry+0x108/0x1d8 fs/fcntl.c:873
fasync_helper+0x94/0xc4 fs/fcntl.c:976
evdev_fasync+0x58/0x6c drivers/input/evdev.c:326
__fput+0x614/0x7bc fs/file_table.c:317
____fput+0x20/0x30 fs/file_table.c:348
task_work_run+0x240/0x2f0 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
do_notify_resume+0x2144/0x3470 arch/arm64/kernel/signal.c:1132
prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline]
exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline]
el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
INITIAL READ USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0x7c/0xc4 kernel/locking/spinlock.c:236
kill_fasync_rcu fs/fcntl.c:996 [inline]
kill_fasync+0x190/0x48c fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x478/0x798 drivers/input/evdev.c:278
evdev_events+0x1b0/0x2f4 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x70c/0xea8 drivers/input/input.c:159
input_event_dispose+0x2a0/0x54c drivers/input/input.c:374
input_handle_event+0x710/0x9a8 drivers/input/input.c:402
input_inject_event+0x1ec/0x30c drivers/input/input.c:461
evdev_write+0x348/0x424 drivers/input/evdev.c:530
vfs_write+0x2a4/0x914 fs/read_write.c:582
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
}
... key at: [<ffff8000196b6f80>] fasync_insert_entry.__key+0x0/0x20
... acquired at:
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0x7c/0xc4 kernel/locking/spinlock.c:236
kill_fasync_rcu fs/fcntl.c:996 [inline]
kill_fasync+0x190/0x48c fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x478/0x798 drivers/input/evdev.c:278
evdev_events+0x1b0/0x2f4 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x70c/0xea8 drivers/input/input.c:159
input_event_dispose+0x2a0/0x54c drivers/input/input.c:374
input_handle_event+0x710/0x9a8 drivers/input/input.c:402
input_inject_event+0x1ec/0x30c drivers/input/input.c:461
evdev_write+0x348/0x424 drivers/input/evdev.c:530
vfs_write+0x2a4/0x914 fs/read_write.c:582
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> (&f->f_owner.lock){....}-{2:2} {
INITIAL USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_write_lock_irq include/linux/rwlock_api_smp.h:195 [inline]
_raw_write_lock_irq+0x70/0x9c kernel/locking/spinlock.c:326
f_modown+0x44/0x2d4 fs/fcntl.c:91
__f_setown fs/fcntl.c:110 [inline]
f_setown_ex fs/fcntl.c:200 [inline]
do_fcntl+0x13c0/0x186c fs/fcntl.c:383
__do_sys_fcntl fs/fcntl.c:454 [inline]
__se_sys_fcntl fs/fcntl.c:439 [inline]
__arm64_sys_fcntl+0x110/0x1f8 fs/fcntl.c:439
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
INITIAL READ USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock_irq include/linux/rwlock_api_smp.h:169 [inline]
_raw_read_lock_irq+0x84/0xb4 kernel/locking/spinlock.c:244
f_getown_ex fs/fcntl.c:212 [inline]
do_fcntl+0x2f0/0x186c fs/fcntl.c:380
__do_sys_fcntl fs/fcntl.c:454 [inline]
__se_sys_fcntl fs/fcntl.c:439 [inline]
__arm64_sys_fcntl+0x110/0x1f8 fs/fcntl.c:439
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
}
... key at: [<ffff8000196b6300>] __alloc_file.__key+0x0/0x10
... acquired at:
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0x7c/0xc4 kernel/locking/spinlock.c:236
send_sigio+0x40/0x33c fs/fcntl.c:778
kill_fasync_rcu fs/fcntl.c:1003 [inline]
kill_fasync+0x214/0x48c fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x478/0x798 drivers/input/evdev.c:278
evdev_events+0x1b0/0x2f4 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x70c/0xea8 drivers/input/input.c:159
input_event_dispose+0x2a0/0x54c drivers/input/input.c:374
input_handle_event+0x710/0x9a8 drivers/input/input.c:402
input_inject_event+0x1ec/0x30c drivers/input/input.c:461
evdev_write+0x348/0x424 drivers/input/evdev.c:530
vfs_write+0x2a4/0x914 fs/read_write.c:582
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581


the dependencies between the lock to be acquired
and SOFTIRQ-irq-unsafe lock:
-> (tasklist_lock){.+.+}-{2:2} {
HARDIRQ-ON-R at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x68/0x84 kernel/locking/spinlock.c:228
do_wait+0x2bc/0xb40 kernel/exit.c:1602
kernel_wait+0xe0/0x20c kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xd0/0x248 kernel/umh.c:167
process_one_work+0x7ac/0x1404 kernel/workqueue.c:2289
worker_thread+0x8e4/0xfec kernel/workqueue.c:2436
kthread+0x250/0x2d8 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860
SOFTIRQ-ON-R at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x68/0x84 kernel/locking/spinlock.c:228
do_wait+0x2bc/0xb40 kernel/exit.c:1602
kernel_wait+0xe0/0x20c kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xd0/0x248 kernel/umh.c:167
process_one_work+0x7ac/0x1404 kernel/workqueue.c:2289
worker_thread+0x8e4/0xfec kernel/workqueue.c:2436
kthread+0x250/0x2d8 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860
INITIAL USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_write_lock_irq include/linux/rwlock_api_smp.h:195 [inline]
_raw_write_lock_irq+0x70/0x9c kernel/locking/spinlock.c:326
copy_process+0x26b8/0x38d0 kernel/fork.c:2393
kernel_clone+0x1d8/0x98c kernel/fork.c:2679
user_mode_thread+0x110/0x178 kernel/fork.c:2755
rest_init+0x2c/0x2f0 init/main.c:694
start_kernel+0x0/0x60c init/main.c:890
start_kernel+0x44c/0x60c init/main.c:1145
__primary_switched+0xb8/0xc0 arch/arm64/kernel/head.S:468
INITIAL READ USE at:
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x68/0x84 kernel/locking/spinlock.c:228
do_wait+0x2bc/0xb40 kernel/exit.c:1602
kernel_wait+0xe0/0x20c kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xd0/0x248 kernel/umh.c:167
process_one_work+0x7ac/0x1404 kernel/workqueue.c:2289
worker_thread+0x8e4/0xfec kernel/workqueue.c:2436
kthread+0x250/0x2d8 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860
}
... key at: [<ffff80001553a058>] tasklist_lock+0x18/0x40
... acquired at:
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x68/0x84 kernel/locking/spinlock.c:228
send_sigurg+0xc8/0x38c fs/fcntl.c:833
sk_send_sigurg+0x6c/0xc0 net/core/sock.c:3336
tcp_check_urg+0x1a4/0x5a8 net/ipv4/tcp_input.c:5614
tcp_urg+0x130/0x374 net/ipv4/tcp_input.c:5655
tcp_rcv_established+0xa78/0x1fe0 net/ipv4/tcp_input.c:6002
tcp_v6_do_rcv+0x43c/0x11ac net/ipv6/tcp_ipv6.c:1488
sk_backlog_rcv include/net/sock.h:1111 [inline]
__release_sock+0x1a8/0x408 net/core/sock.c:2909
release_sock+0x68/0x1cc net/core/sock.c:3473
sk_stream_wait_memory+0x5e0/0xcc4 net/core/stream.c:145
tcp_sendmsg_locked+0x118c/0x34f8 net/ipv4/tcp.c:1448
tcp_sendmsg+0x40/0x64 net/ipv4/tcp.c:1486
inet6_sendmsg+0xb4/0xd8 net/ipv6/af_inet6.c:667
sock_sendmsg_nosec net/socket.c:716 [inline]
sock_sendmsg net/socket.c:736 [inline]
__sys_sendto+0x3b4/0x504 net/socket.c:2117
__do_sys_sendto net/socket.c:2129 [inline]
__se_sys_sendto net/socket.c:2125 [inline]
__arm64_sys_sendto+0xd8/0xf8 net/socket.c:2125
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581


stack backtrace:
CPU: 1 PID: 14672 Comm: syz-executor.2 Not tainted 6.1.35-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/25/2023
Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
__lock_acquire+0x6310/0x764c kernel/locking/lockdep.c:5056
lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x68/0x84 kernel/locking/spinlock.c:228
send_sigurg+0xc8/0x38c fs/fcntl.c:833
sk_send_sigurg+0x6c/0xc0 net/core/sock.c:3336
tcp_check_urg+0x1a4/0x5a8 net/ipv4/tcp_input.c:5614
tcp_urg+0x130/0x374 net/ipv4/tcp_input.c:5655
tcp_rcv_established+0xa78/0x1fe0 net/ipv4/tcp_input.c:6002
tcp_v6_do_rcv+0x43c/0x11ac net/ipv6/tcp_ipv6.c:1488
sk_backlog_rcv include/net/sock.h:1111 [inline]
__release_sock+0x1a8/0x408 net/core/sock.c:2909
release_sock+0x68/0x1cc net/core/sock.c:3473
sk_stream_wait_memory+0x5e0/0xcc4 net/core/stream.c:145
tcp_sendmsg_locked+0x118c/0x34f8 net/ipv4/tcp.c:1448
tcp_sendmsg+0x40/0x64 net/ipv4/tcp.c:1486
inet6_sendmsg+0xb4/0xd8 net/ipv6/af_inet6.c:667
sock_sendmsg_nosec net/socket.c:716 [inline]
sock_sendmsg net/socket.c:736 [inline]
__sys_sendto+0x3b4/0x504 net/socket.c:2117
__do_sys_sendto net/socket.c:2129 [inline]
__se_sys_sendto net/socket.c:2125 [inline]
__arm64_sys_sendto+0xd8/0xf8 net/socket.c:2125
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to change bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Aug 17, 2023, 9:22:49 AM8/17/23
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 6c44e13dc284 Linux 6.1.46
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=14b1a727a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=d53bfb03cd3f0d5d
dashboard link: https://syzkaller.appspot.com/bug?extid=0804476ed7b48fa80ca2
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=138fe24ba80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14428ba0680000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/706045968752/disk-6c44e13d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2f25349b69b4/vmlinux-6c44e13d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/e6791616e516/bzImage-6c44e13d.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+080447...@syzkaller.appspotmail.com

=====================================================
WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected
6.1.46-syzkaller #0 Not tainted
-----------------------------------------------------
syz-executor377/3512 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire:
ffff8880264a08b0 (&f->f_owner.lock){....}-{2:2}, at: send_sigio+0x2f/0x330 fs/fcntl.c:778

and this task is already holding:
ffff888029b31018 (&new->fa_lock){....}-{2:2}, at: kill_fasync_rcu fs/fcntl.c:996 [inline]
ffff888029b31018 (&new->fa_lock){....}-{2:2}, at: kill_fasync+0x16a/0x490 fs/fcntl.c:1017
which would create a new lock dependency:
(&new->fa_lock){....}-{2:2} -> (&f->f_owner.lock){....}-{2:2}

but this new dependency connects a HARDIRQ-irq-safe lock:
(&dev->event_lock#2){-...}-{2:2}

... which became HARDIRQ-irq-safe at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
input_event+0x8d/0xd0 drivers/input/input.c:430
input_report_key include/linux/input.h:425 [inline]
psmouse_report_standard_buttons drivers/input/mouse/psmouse-base.c:121 [inline]
psmouse_report_standard_packet+0x50/0x200 drivers/input/mouse/psmouse-base.c:139
psmouse_process_byte+0x45b/0x640 drivers/input/mouse/psmouse-base.c:230
psmouse_handle_byte+0x46/0x4b0 drivers/input/mouse/psmouse-base.c:272
psmouse_interrupt+0x697/0x10a0 drivers/input/mouse/psmouse-base.c:424
serio_interrupt+0x88/0x130 drivers/input/serio/serio.c:998
i8042_interrupt+0x357/0x750 drivers/input/serio/i8042.c:606
__handle_irq_event_percpu+0x2a8/0xb20 kernel/irq/handle.c:158
handle_irq_event_percpu kernel/irq/handle.c:193 [inline]
handle_irq_event+0x85/0x1e0 kernel/irq/handle.c:210
handle_edge_irq+0x245/0xbf0 kernel/irq/chip.c:819
generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
handle_irq arch/x86/kernel/irq.c:231 [inline]
__common_interrupt+0xd7/0x1f0 arch/x86/kernel/irq.c:250
common_interrupt+0x9f/0xc0 arch/x86/kernel/irq.c:240
asm_common_interrupt+0x22/0x40 arch/x86/include/asm/idtentry.h:640
__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline]
_raw_spin_unlock_irqrestore+0xd4/0x130 kernel/locking/spinlock.c:194
spin_unlock_irqrestore include/linux/spinlock.h:405 [inline]
i8042_command drivers/input/serio/i8042.c:356 [inline]
i8042_aux_write+0x112/0x190 drivers/input/serio/i8042.c:391
serio_write include/linux/serio.h:125 [inline]
ps2_do_sendbyte+0x20a/0x720 drivers/input/serio/libps2.c:41
ps2_sendbyte+0x5c/0x120 drivers/input/serio/libps2.c:93
cypress_ps2_sendbyte drivers/input/mouse/cypress_ps2.c:42 [inline]
cypress_ps2_read_cmd_status drivers/input/mouse/cypress_ps2.c:116 [inline]
cypress_send_ext_cmd+0x21d/0x900 drivers/input/mouse/cypress_ps2.c:189
cypress_detect+0x8f/0x220 drivers/input/mouse/cypress_ps2.c:205
psmouse_do_detect drivers/input/mouse/psmouse-base.c:1007 [inline]
psmouse_try_protocol drivers/input/mouse/psmouse-base.c:1021 [inline]
psmouse_extensions+0xc2a/0x1550 drivers/input/mouse/psmouse-base.c:1144
psmouse_switch_protocol+0x308/0x840 drivers/input/mouse/psmouse-base.c:1538
psmouse_connect+0x903/0x14c0 drivers/input/mouse/psmouse-base.c:1628
serio_connect_driver drivers/input/serio/serio.c:44 [inline]
serio_driver_probe+0x74/0x90 drivers/input/serio/serio.c:775
really_probe+0x2ab/0xcb0 drivers/base/dd.c:639
__driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:783
driver_probe_device+0x50/0x420 drivers/base/dd.c:813
__driver_attach+0x458/0x6f0 drivers/base/dd.c:1199
bus_for_each_dev+0x17c/0x1f0 drivers/base/bus.c:301
serio_attach_driver drivers/input/serio/serio.c:804 [inline]
serio_handle_event+0x56a/0x8f0 drivers/input/serio/serio.c:224
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

to a HARDIRQ-irq-unsafe lock:
(tasklist_lock){.+.+}-{2:2}

... which became HARDIRQ-irq-unsafe at:
...
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:228
do_wait+0x2c3/0xb70 kernel/exit.c:1602
kernel_wait+0xe5/0x230 kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xb5/0x220 kernel/umh.c:167
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

other info that might help us debug this:

Chain exists of:
&dev->event_lock#2 --> &new->fa_lock --> tasklist_lock

Possible interrupt unsafe locking scenario:

CPU0 CPU1
---- ----
lock(tasklist_lock);
local_irq_disable();
lock(&dev->event_lock#2);
lock(&new->fa_lock);
<Interrupt>
lock(&dev->event_lock#2);

*** DEADLOCK ***

8 locks held by syz-executor377/3512:
#0: ffff888023f4d110 (&evdev->mutex){+.+.}-{3:3}, at: evdev_write+0x26d/0x7c0 drivers/input/evdev.c:513
#1: ffff888146766230 (&dev->event_lock#2){-...}-{2:2}, at: input_inject_event+0xc1/0x300 drivers/input/input.c:456
#2: ffffffff8d129ee0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:305
#3: ffffffff8d129ee0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:305
#4: ffffffff8d129ee0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:305
#5: ffff888142f1c028 (&client->buffer_lock){....}-{2:2}, at: spin_lock include/linux/spinlock.h:350 [inline]
#5: ffff888142f1c028 (&client->buffer_lock){....}-{2:2}, at: evdev_pass_values+0xee/0xad0 drivers/input/evdev.c:261
#6: ffffffff8d129ee0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire+0x5/0x30 include/linux/rcupdate.h:305
#7: ffff888029b31018 (&new->fa_lock){....}-{2:2}, at: kill_fasync_rcu fs/fcntl.c:996 [inline]
#7: ffff888029b31018 (&new->fa_lock){....}-{2:2}, at: kill_fasync+0x16a/0x490 fs/fcntl.c:1017

the dependencies between HARDIRQ-irq-safe lock and the holding lock:
-> (&dev->event_lock#2){-...}-{2:2} {
IN-HARDIRQ-W at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
input_event+0x8d/0xd0 drivers/input/input.c:430
input_report_key include/linux/input.h:425 [inline]
psmouse_report_standard_buttons drivers/input/mouse/psmouse-base.c:121 [inline]
psmouse_report_standard_packet+0x50/0x200 drivers/input/mouse/psmouse-base.c:139
psmouse_process_byte+0x45b/0x640 drivers/input/mouse/psmouse-base.c:230
psmouse_handle_byte+0x46/0x4b0 drivers/input/mouse/psmouse-base.c:272
psmouse_interrupt+0x697/0x10a0 drivers/input/mouse/psmouse-base.c:424
serio_interrupt+0x88/0x130 drivers/input/serio/serio.c:998
i8042_interrupt+0x357/0x750 drivers/input/serio/i8042.c:606
__handle_irq_event_percpu+0x2a8/0xb20 kernel/irq/handle.c:158
handle_irq_event_percpu kernel/irq/handle.c:193 [inline]
handle_irq_event+0x85/0x1e0 kernel/irq/handle.c:210
handle_edge_irq+0x245/0xbf0 kernel/irq/chip.c:819
generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
handle_irq arch/x86/kernel/irq.c:231 [inline]
__common_interrupt+0xd7/0x1f0 arch/x86/kernel/irq.c:250
common_interrupt+0x9f/0xc0 arch/x86/kernel/irq.c:240
asm_common_interrupt+0x22/0x40 arch/x86/include/asm/idtentry.h:640
__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:152 [inline]
_raw_spin_unlock_irqrestore+0xd4/0x130 kernel/locking/spinlock.c:194
spin_unlock_irqrestore include/linux/spinlock.h:405 [inline]
i8042_command drivers/input/serio/i8042.c:356 [inline]
i8042_aux_write+0x112/0x190 drivers/input/serio/i8042.c:391
serio_write include/linux/serio.h:125 [inline]
ps2_do_sendbyte+0x20a/0x720 drivers/input/serio/libps2.c:41
ps2_sendbyte+0x5c/0x120 drivers/input/serio/libps2.c:93
cypress_ps2_sendbyte drivers/input/mouse/cypress_ps2.c:42 [inline]
cypress_ps2_read_cmd_status drivers/input/mouse/cypress_ps2.c:116 [inline]
cypress_send_ext_cmd+0x21d/0x900 drivers/input/mouse/cypress_ps2.c:189
cypress_detect+0x8f/0x220 drivers/input/mouse/cypress_ps2.c:205
psmouse_do_detect drivers/input/mouse/psmouse-base.c:1007 [inline]
psmouse_try_protocol drivers/input/mouse/psmouse-base.c:1021 [inline]
psmouse_extensions+0xc2a/0x1550 drivers/input/mouse/psmouse-base.c:1144
psmouse_switch_protocol+0x308/0x840 drivers/input/mouse/psmouse-base.c:1538
psmouse_connect+0x903/0x14c0 drivers/input/mouse/psmouse-base.c:1628
serio_connect_driver drivers/input/serio/serio.c:44 [inline]
serio_driver_probe+0x74/0x90 drivers/input/serio/serio.c:775
really_probe+0x2ab/0xcb0 drivers/base/dd.c:639
__driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:783
driver_probe_device+0x50/0x420 drivers/base/dd.c:813
__driver_attach+0x458/0x6f0 drivers/base/dd.c:1199
bus_for_each_dev+0x17c/0x1f0 drivers/base/bus.c:301
serio_attach_driver drivers/input/serio/serio.c:804 [inline]
serio_handle_event+0x56a/0x8f0 drivers/input/serio/serio.c:224
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
INITIAL USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
input_inject_event+0xc1/0x300 drivers/input/input.c:456
led_trigger_event+0xed/0x1a0 drivers/leds/led-triggers.c:390
kbd_led_trigger_activate+0xb9/0x100 drivers/tty/vt/keyboard.c:1036
led_trigger_set+0x53a/0x910 drivers/leds/led-triggers.c:197
led_trigger_set_default+0x1c2/0x200 drivers/leds/led-triggers.c:262
led_classdev_register_ext+0x600/0x7e0 drivers/leds/led-class.c:419
led_classdev_register include/linux/leds.h:196 [inline]
input_leds_connect+0x48f/0x630 drivers/input/input-leds.c:139
input_attach_handler drivers/input/input.c:1060 [inline]
input_register_device+0xcec/0x1080 drivers/input/input.c:2396
atkbd_connect+0x79d/0x9e0 drivers/input/keyboard/atkbd.c:1278
serio_connect_driver drivers/input/serio/serio.c:44 [inline]
serio_driver_probe+0x74/0x90 drivers/input/serio/serio.c:775
really_probe+0x2ab/0xcb0 drivers/base/dd.c:639
__driver_probe_device+0x1a2/0x3d0 drivers/base/dd.c:783
driver_probe_device+0x50/0x420 drivers/base/dd.c:813
__driver_attach+0x458/0x6f0 drivers/base/dd.c:1199
bus_for_each_dev+0x17c/0x1f0 drivers/base/bus.c:301
serio_attach_driver drivers/input/serio/serio.c:804 [inline]
serio_handle_event+0x56a/0x8f0 drivers/input/serio/serio.c:224
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
}
... key at: [<ffffffff9205c900>] input_allocate_device.__key.5+0x0/0x20
-> (&client->buffer_lock){....}-{2:2} {
INITIAL USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:350 [inline]
evdev_pass_values+0xee/0xad0 drivers/input/evdev.c:261
evdev_events+0x198/0x2c0 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x8dc/0x1290 drivers/input/input.c:159
input_event_dispose+0x366/0x650 drivers/input/input.c:374
input_handle_event+0x97d/0xb00 drivers/input/input.c:402
input_inject_event+0x1fd/0x300 drivers/input/input.c:461
evdev_write+0x668/0x7c0 drivers/input/evdev.c:530
vfs_write+0x2d9/0xba0 fs/read_write.c:582
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
}
... key at: [<ffffffff9205cbc0>] evdev_open.__key.25+0x0/0x20
... acquired at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:350 [inline]
evdev_pass_values+0xee/0xad0 drivers/input/evdev.c:261
evdev_events+0x198/0x2c0 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x8dc/0x1290 drivers/input/input.c:159
input_event_dispose+0x366/0x650 drivers/input/input.c:374
input_handle_event+0x97d/0xb00 drivers/input/input.c:402
input_inject_event+0x1fd/0x300 drivers/input/input.c:461
evdev_write+0x668/0x7c0 drivers/input/evdev.c:530
vfs_write+0x2d9/0xba0 fs/read_write.c:582
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> (&new->fa_lock){....}-{2:2} {
INITIAL READ USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0xd9/0x120 kernel/locking/spinlock.c:236
kill_fasync_rcu fs/fcntl.c:996 [inline]
kill_fasync+0x16a/0x490 fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x586/0xad0 drivers/input/evdev.c:278
evdev_events+0x198/0x2c0 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x8dc/0x1290 drivers/input/input.c:159
input_event_dispose+0x366/0x650 drivers/input/input.c:374
input_handle_event+0x97d/0xb00 drivers/input/input.c:402
input_inject_event+0x1fd/0x300 drivers/input/input.c:461
evdev_write+0x668/0x7c0 drivers/input/evdev.c:530
vfs_write+0x2d9/0xba0 fs/read_write.c:582
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
}
... key at: [<ffffffff91d5d060>] fasync_insert_entry.__key+0x0/0x20
... acquired at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0xd9/0x120 kernel/locking/spinlock.c:236
kill_fasync_rcu fs/fcntl.c:996 [inline]
kill_fasync+0x16a/0x490 fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x586/0xad0 drivers/input/evdev.c:278
evdev_events+0x198/0x2c0 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x8dc/0x1290 drivers/input/input.c:159
input_event_dispose+0x366/0x650 drivers/input/input.c:374
input_handle_event+0x97d/0xb00 drivers/input/input.c:402
input_inject_event+0x1fd/0x300 drivers/input/input.c:461
evdev_write+0x668/0x7c0 drivers/input/evdev.c:530
vfs_write+0x2d9/0xba0 fs/read_write.c:582
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd


the dependencies between the lock to be acquired
and HARDIRQ-irq-unsafe lock:
-> (tasklist_lock){.+.+}-{2:2} {
HARDIRQ-ON-R at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:228
do_wait+0x2c3/0xb70 kernel/exit.c:1602
kernel_wait+0xe5/0x230 kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xb5/0x220 kernel/umh.c:167
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
SOFTIRQ-ON-R at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:228
do_wait+0x2c3/0xb70 kernel/exit.c:1602
kernel_wait+0xe5/0x230 kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xb5/0x220 kernel/umh.c:167
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
INITIAL USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_write_lock_irq include/linux/rwlock_api_smp.h:195 [inline]
_raw_write_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:326
copy_process+0x2483/0x4020 kernel/fork.c:2393
kernel_clone+0x222/0x920 kernel/fork.c:2674
user_mode_thread+0x12e/0x190 kernel/fork.c:2750
rest_init+0x21/0x2b0 init/main.c:692
start_kernel+0x0/0x53f init/main.c:887
start_kernel+0x496/0x53f init/main.c:1134
secondary_startup_64_no_verify+0xcf/0xdb
INITIAL READ USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:228
do_wait+0x2c3/0xb70 kernel/exit.c:1602
kernel_wait+0xe5/0x230 kernel/exit.c:1792
call_usermodehelper_exec_sync kernel/umh.c:140 [inline]
call_usermodehelper_exec_work+0xb5/0x220 kernel/umh.c:167
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2292
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2439
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
}
... key at: [<ffffffff8ce0a058>] tasklist_lock+0x18/0x40
... acquired at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock include/linux/rwlock_api_smp.h:150 [inline]
_raw_read_lock+0x32/0x40 kernel/locking/spinlock.c:228
send_sigurg+0xc8/0x380 fs/fcntl.c:833
sk_send_sigurg+0x6a/0xb0 net/core/sock.c:3348
queue_oob+0x626/0x8e0 net/unix/af_unix.c:2151
unix_stream_sendmsg+0xe10/0x1070 net/unix/af_unix.c:2251
sock_sendmsg_nosec net/socket.c:716 [inline]
sock_sendmsg net/socket.c:736 [inline]
____sys_sendmsg+0x59e/0x8f0 net/socket.c:2482
___sys_sendmsg net/socket.c:2536 [inline]
__sys_sendmsg+0x2a9/0x390 net/socket.c:2565
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> (&f->f_owner.lock){....}-{2:2} {
INITIAL USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_write_lock_irq include/linux/rwlock_api_smp.h:195 [inline]
_raw_write_lock_irq+0xcf/0x110 kernel/locking/spinlock.c:326
f_modown+0x38/0x340 fs/fcntl.c:91
__f_setown fs/fcntl.c:110 [inline]
f_setown+0x127/0x1d0 fs/fcntl.c:138
do_fcntl+0x128/0x1480 fs/fcntl.c:377
__do_sys_fcntl fs/fcntl.c:454 [inline]
__se_sys_fcntl+0xd5/0x1b0 fs/fcntl.c:439
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
INITIAL READ USE at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0xd9/0x120 kernel/locking/spinlock.c:236
send_sigurg+0x25/0x380 fs/fcntl.c:817
sk_send_sigurg+0x6a/0xb0 net/core/sock.c:3348
queue_oob+0x626/0x8e0 net/unix/af_unix.c:2151
unix_stream_sendmsg+0xe10/0x1070 net/unix/af_unix.c:2251
sock_sendmsg_nosec net/socket.c:716 [inline]
sock_sendmsg net/socket.c:736 [inline]
____sys_sendmsg+0x59e/0x8f0 net/socket.c:2482
___sys_sendmsg net/socket.c:2536 [inline]
__sys_sendmsg+0x2a9/0x390 net/socket.c:2565
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
}
... key at: [<ffffffff91d5c3e0>] __alloc_file.__key+0x0/0x10
... acquired at:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0xd9/0x120 kernel/locking/spinlock.c:236
send_sigio+0x2f/0x330 fs/fcntl.c:778
kill_fasync_rcu fs/fcntl.c:1003 [inline]
kill_fasync+0x20c/0x490 fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x586/0xad0 drivers/input/evdev.c:278
evdev_events+0x198/0x2c0 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x8dc/0x1290 drivers/input/input.c:159
input_event_dispose+0x366/0x650 drivers/input/input.c:374
input_handle_event+0x97d/0xb00 drivers/input/input.c:402
input_inject_event+0x1fd/0x300 drivers/input/input.c:461
evdev_write+0x668/0x7c0 drivers/input/evdev.c:530
vfs_write+0x2d9/0xba0 fs/read_write.c:582
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd


stack backtrace:
CPU: 1 PID: 3512 Comm: syz-executor377 Not tainted 6.1.46-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
print_bad_irq_dependency kernel/locking/lockdep.c:2612 [inline]
check_irq_usage kernel/locking/lockdep.c:2851 [inline]
check_prev_add kernel/locking/lockdep.c:3102 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x4d2e/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline]
_raw_read_lock_irqsave+0xd9/0x120 kernel/locking/spinlock.c:236
send_sigio+0x2f/0x330 fs/fcntl.c:778
kill_fasync_rcu fs/fcntl.c:1003 [inline]
kill_fasync+0x20c/0x490 fs/fcntl.c:1017
__pass_event drivers/input/evdev.c:240 [inline]
evdev_pass_values+0x586/0xad0 drivers/input/evdev.c:278
evdev_events+0x198/0x2c0 drivers/input/evdev.c:306
input_to_handler drivers/input/input.c:127 [inline]
input_pass_values+0x8dc/0x1290 drivers/input/input.c:159
input_event_dispose+0x366/0x650 drivers/input/input.c:374
input_handle_event+0x97d/0xb00 drivers/input/input.c:402
input_inject_event+0x1fd/0x300 drivers/input/input.c:461
evdev_write+0x668/0x7c0 drivers/input/evdev.c:530
vfs_write+0x2d9/0xba0 fs/read_write.c:582
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f143be27a39
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffb7a576f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f143be27a39
RDX: 0000000000002778 RSI: 0000000020000040 RDI: 0000000000000006
RBP: 00007f143be9a5f0 R08: 0000000000000006 R09: 0000000000000006
R10: 000000000000001f R11: 0000000000000246 R12: 0000000000000001
R13: 431bde82d7b634db R14: 0000000000000001 R15: 0000000000000001
</TASK>


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages