WARNING in generic_make_request

[syzbot]

Hello,

syzbot found the following crash on:

HEAD commit: bb7b450e Linux 4.19.49
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16215a49a00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d7b3d7d5be080e97
dashboard link: https://syzkaller.appspot.com/bug?extid=74ac5ecdd84b4e305531
compiler: gcc (GCC) 9.0.0 20181231 (experimental)

Unfortunately, I don't have any reproducer for this crash yet.

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+74ac5e...@syzkaller.appspotmail.com

generic_make_request: Trying to write to read-only block-device nullb0
(partno 0)
idr_alloc_cyclic+0x132/0x270 lib/idr.c:128
__kernfs_new_node+0x171/0x680 fs/kernfs/dir.c:641
kernfs_new_node+0x99/0x130 fs/kernfs/dir.c:694
kernfs_create_dir_ns+0x52/0x160 fs/kernfs/dir.c:1020
WARNING: CPU: 1 PID: 21144 at block/blk-core.c:2175 bio_check_ro
block/blk-core.c:2175 [inline]
WARNING: CPU: 1 PID: 21144 at block/blk-core.c:2175
generic_make_request_checks+0x1fc5/0x24c0 block/blk-core.c:2280
internal_create_group+0x1cb/0xc30 fs/sysfs/group.c:135
Kernel panic - not syncing: panic_on_warn set ...

sysfs_create_group+0x20/0x30 fs/sysfs/group.c:173
loop_sysfs_init drivers/block/loop.c:840 [inline]
loop_set_fd drivers/block/loop.c:970 [inline]
lo_ioctl+0xf8f/0x20e0 drivers/block/loop.c:1543
__blkdev_driver_ioctl block/ioctl.c:303 [inline]
blkdev_ioctl+0xc38/0x1ac0 block/ioctl.c:601
block_ioctl+0xee/0x130 fs/block_dev.c:1891
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:501 [inline]
do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
__do_sys_ioctl fs/ioctl.c:712 [inline]
__se_sys_ioctl fs/ioctl.c:710 [inline]
__x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4590e7
Code: 48 83 c4 08 48 89 d8 5b 5d c3 66 0f 1f 84 00 00 00 00 00 48 89 e8 48
f7 d8 48 39 c3 0f 92 c0 eb 92 66 90 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff
ff 0f 83 5d b9 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f0af696da88 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000010 RCX: 00000000004590e7
RDX: 0000000000000005 RSI: 0000000000004c00 RDI: 0000000000000006
RBP: 0000000000000000 R08: 0000000000000000 R09: 000000000000000a
R10: 0000000000000075 R11: 0000000000000246 R12: 0000000000000005
R13: 00000000004c827a R14: 00000000004deac0 R15: 0000000000000004
CPU: 1 PID: 21144 Comm: syz-executor.3 Not tainted 4.19.49 #21
kobject: 'loop2' (000000008b60d302): kobject_uevent_env
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x172/0x1f0 lib/dump_stack.c:113
panic+0x263/0x507 kernel/panic.c:185
kobject: 'loop2' (000000008b60d302): fill_kobj_path: path
= '/devices/virtual/block/loop2'
kobject: 'loop0' (0000000001e592ab): kobject_uevent_env
__warn.cold+0x20/0x4a kernel/panic.c:540
ntfs: (device loop2): parse_options(): The disable_sparse option requires a
boolean argument.
report_bug+0x263/0x2b0 lib/bug.c:186
fixup_bug arch/x86/kernel/traps.c:178 [inline]
fixup_bug arch/x86/kernel/traps.c:173 [inline]
do_error_trap+0x204/0x360 arch/x86/kernel/traps.c:296
kobject: 'loop0' (0000000001e592ab): fill_kobj_path: path
= '/devices/virtual/block/loop0'
do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:316
invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:1013
RIP: 0010:bio_check_ro block/blk-core.c:2175 [inline]
RIP: 0010:generic_make_request_checks+0x1fc5/0x24c0 block/blk-core.c:2280
Code: 85 1f 04 00 00 45 8b b6 e4 04 00 00 48 8d 73 a0 4c 89 e7 e8 5d 58 06
00 48 c7 c7 40 0e 80 87 48 89 c6 44 89 f2 e8 09 e4 2f fe <0f> 0b 48 b8 00
00 00 00 00 fc ff df 4c 89 ea 48 c1 ea 03 80 3c 02
RSP: 0018:ffff8880559bef08 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff8880559befd8 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff8155a186 RDI: ffffed100ab37dd3
RBP: ffff8880559bf000 R08: ffff888056dce600 R09: ffffed1015d24fe9
R10: ffffed1015d24fe8 R11: ffff8880ae927f47 R12: ffff888099577a80
R13: ffff888099577a88 R14: 0000000000000000 R15: 0000000000000000
generic_make_request+0x24c/0x12d0 block/blk-core.c:2404
submit_bio+0xba/0x480 block/blk-core.c:2569
submit_bh_wbc+0x5dc/0x790 fs/buffer.c:3095
__block_write_full_page+0x76e/0x1020 fs/buffer.c:1766
block_write_full_page+0x21f/0x270 fs/buffer.c:2956
blkdev_writepage+0x25/0x30 fs/block_dev.c:581
__writepage+0x62/0xe0 mm/page-writeback.c:2308
write_cache_pages+0x971/0x1670 mm/page-writeback.c:2240
generic_writepages mm/page-writeback.c:2332 [inline]
generic_writepages+0xe6/0x160 mm/page-writeback.c:2321
blkdev_writepages+0x1e/0x30 fs/block_dev.c:1965
do_writepages+0xf3/0x2a0 mm/page-writeback.c:2347
__filemap_fdatawrite_range+0x26d/0x340 mm/filemap.c:445
__filemap_fdatawrite mm/filemap.c:453 [inline]
filemap_fdatawrite mm/filemap.c:458 [inline]
filemap_write_and_wait mm/filemap.c:617 [inline]
filemap_write_and_wait+0x47/0xd0 mm/filemap.c:612
__sync_blockdev fs/block_dev.c:463 [inline]
sync_blockdev fs/block_dev.c:472 [inline]
__blkdev_put+0x204/0x810 fs/block_dev.c:1797
blkdev_put+0x98/0x560 fs/block_dev.c:1866
blkdev_close+0x8b/0xb0 fs/block_dev.c:1873
__fput+0x2dd/0x8b0 fs/file_table.c:278
____fput+0x16/0x20 fs/file_table.c:309
task_work_run+0x145/0x1c0 kernel/task_work.c:113
exit_task_work include/linux/task_work.h:22 [inline]
do_exit+0x933/0x2fa0 kernel/exit.c:876
do_group_exit+0x135/0x370 kernel/exit.c:979
get_signal+0x3ec/0x1fc0 kernel/signal.c:2574
do_signal+0x95/0x1960 arch/x86/kernel/signal.c:821
exit_to_usermode_loop+0x244/0x2c0 arch/x86/entry/common.c:163
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x53d/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x459279
Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ff8cd76dc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: 0000000000000006 RBX: 0000000000000004 RCX: 0000000000459279
RDX: 0004000000004002 RSI: 0000000020000080 RDI: ffffffffffffff9c
RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ff8cd76e6d4
R13: 00000000004c5a3f R14: 00000000004da1b8 R15: 00000000ffffffff
Kernel Offset: disabled
Rebooting in 86400 seconds..


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

Auto-closing this bug as obsolete.
Crashes did not happen for a while, no reproducer and no activity.