[v5.15] possible deadlock in console_trylock_spinning (2)
1 view
Skip to first unread message
syzbot
Nov 28, 2023, 10:09:27 PM11/28/23
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: a78d278e01b1 Linux 5.15.140
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=136d4a64e80000
kernel config: https://syzkaller.appspot.com/x/.config?x=af8ffc64a7d6b78a
dashboard link: https://syzkaller.appspot.com/bug?extid=dc57c1cfb6ac07a3c0d2
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/725f6f29c66f/disk-a78d278e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/af4bcc4e141e/vmlinux-a78d278e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0d3f0ba6b252/Image-a78d278e.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+dc57c1...@syzkaller.appspotmail.com
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
======================================================
WARNING: possible circular locking dependency detected
5.15.140-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/17526 is trying to acquire lock:
ffff800014ae7920 (console_owner){-.-.}-{0:0}, at: console_trylock_spinning+0xe4/0x280 kernel/printk/printk.c:1879
but task is already holding lock:
ffff0000d267a958 (&port->lock){....}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x48/0x324 drivers/tty/tty_buffer.c:585
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&port->lock){....}-{2:2}:
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xc4/0x14c kernel/locking/spinlock.c:162
tty_port_tty_get+0x2c/0x124 drivers/tty/tty_port.c:289
tty_port_default_wakeup+0x20/0x54 drivers/tty/tty_port.c:48
tty_port_tty_wakeup+0x64/0x78 drivers/tty/tty_port.c:389
uart_write_wakeup+0x4c/0x64 drivers/tty/serial/serial_core.c:111
pl011_tx_chars+0xd04/0x157c drivers/tty/serial/amba-pl011.c:1505
pl011_start_tx_pio drivers/tty/serial/amba-pl011.c:1351 [inline]
pl011_start_tx+0x364/0x8b8 drivers/tty/serial/amba-pl011.c:1363
__uart_start drivers/tty/serial/serial_core.c:132 [inline]
uart_write+0x62c/0x8b8 drivers/tty/serial/serial_core.c:589
process_output_block drivers/tty/n_tty.c:592 [inline]
n_tty_write+0xae0/0xf38 drivers/tty/n_tty.c:2339
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write drivers/tty/tty_io.c:1131 [inline]
redirected_tty_write+0xc4/0x10c drivers/tty/tty_io.c:1154
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&port_lock_key){-.-.}-{2:2}:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0xb0/0x10c kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:363 [inline]
pl011_console_write+0x1a0/0x774 drivers/tty/serial/amba-pl011.c:2354
call_console_drivers kernel/printk/printk.c:1953 [inline]
console_unlock+0xbac/0x1394 kernel/printk/printk.c:2738
register_console+0x560/0x870 kernel/printk/printk.c:3068
uart_configure_port drivers/tty/serial/serial_core.c:2443 [inline]
uart_add_one_port+0xe70/0x1540 drivers/tty/serial/serial_core.c:2958
pl011_register_port+0x1a0/0x434 drivers/tty/serial/amba-pl011.c:2799
sbsa_uart_probe+0x474/0x5dc drivers/tty/serial/amba-pl011.c:2934
platform_probe+0x148/0x1c0 drivers/base/platform.c:1391
really_probe+0x26c/0xaec drivers/base/dd.c:595
__driver_probe_device+0x194/0x3b4 drivers/base/dd.c:755
driver_probe_device+0x78/0x34c drivers/base/dd.c:785
__device_attach_driver+0x28c/0x4d8 drivers/base/dd.c:907
bus_for_each_drv+0x158/0x1e0 drivers/base/bus.c:427
__device_attach+0x2f0/0x480 drivers/base/dd.c:979
device_initial_probe+0x24/0x34 drivers/base/dd.c:1028
bus_probe_device+0xbc/0x1c8 drivers/base/bus.c:487
device_add+0xae0/0xef4 drivers/base/core.c:3394
platform_device_add+0x3f8/0x708 drivers/base/platform.c:712
platform_device_register_full+0x508/0x618 drivers/base/platform.c:835
acpi_create_platform_device+0x4d8/0x650 drivers/acpi/acpi_platform.c:154
acpi_default_enumeration+0x6c/0xdc drivers/acpi/scan.c:2087
acpi_bus_attach+0x88c/0xab4 drivers/acpi/scan.c:2197
acpi_bus_attach+0x314/0xab4 drivers/acpi/scan.c:2203
acpi_bus_attach+0x314/0xab4 drivers/acpi/scan.c:2203
acpi_bus_scan+0xe4/0x20c drivers/acpi/scan.c:2375
acpi_scan_init+0x220/0x71c drivers/acpi/scan.c:2550
acpi_init+0x188/0x24c drivers/acpi/bus.c:1346
do_one_initcall+0x234/0x990 init/main.c:1295
do_initcall_level+0x154/0x214 init/main.c:1368
do_initcalls+0x58/0xac init/main.c:1384
do_basic_setup+0x8c/0xa0 init/main.c:1403
kernel_init_freeable+0x460/0x640 init/main.c:1608
kernel_init+0x24/0x294 init/main.c:1499
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
-> #0 (console_owner){-.-.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3787 [inline]
__lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
console_trylock_spinning+0x110/0x280 kernel/printk/printk.c:1896
vprintk_emit+0x124/0x21c kernel/printk/printk.c:2267
vprintk_default+0xa0/0xe4 kernel/printk/printk.c:2283
vprintk+0x200/0x2d4 kernel/printk/printk_safe.c:45
_printk+0xdc/0x128 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x398/0x514 lib/fault-inject.c:146
__should_failslab+0xbc/0x110 mm/failslab.c:33
should_failslab+0x10/0x28 mm/slab_common.c:1337
slab_pre_alloc_hook+0x64/0xe8 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0xc0/0x4c8 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1a4/0x440 drivers/tty/tty_buffer.c:276
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x74/0x324 drivers/tty/tty_buffer.c:586
pty_write+0xb8/0xe8 drivers/tty/pty.c:118
n_tty_write+0x4f4/0xf38 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write+0x48/0x58 drivers/tty/tty_io.c:1131
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
console_owner --> &port_lock_key --> &port->lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&port->lock);
lock(&port_lock_key);
lock(&port->lock);
lock(console_owner);
*** DEADLOCK ***
5 locks held by syz-executor.3/17526:
#0: ffff0000d7b79098 (&tty->ldisc_sem){++++}-{0:0}, at: ldsem_down_read+0x40/0x50 drivers/tty/tty_ldsem.c:340
#1: ffff0000d7b79130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: tty_write_lock drivers/tty/tty_io.c:961 [inline]
#1: ffff0000d7b79130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: do_tty_write drivers/tty/tty_io.c:984 [inline]
#1: ffff0000d7b79130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: file_tty_write+0x1d4/0x758 drivers/tty/tty_io.c:1110
#2: ffff0000d7b792e8 (&tty->termios_rwsem){++++}-{3:3}, at: n_tty_write+0x1ec/0xf38 drivers/tty/n_tty.c:2322
#3: ffff8000272cd378 (&ldata->output_lock){+.+.}-{3:3}, at: n_tty_write+0x4b0/0xf38 drivers/tty/n_tty.c:2361
#4: ffff0000d267a958 (&port->lock){....}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x48/0x324 drivers/tty/tty_buffer.c:585
stack backtrace:
CPU: 0 PID: 17526 Comm: syz-executor.3 Not tainted 5.15.140-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3787 [inline]
__lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
console_trylock_spinning+0x110/0x280 kernel/printk/printk.c:1896
vprintk_emit+0x124/0x21c kernel/printk/printk.c:2267
vprintk_default+0xa0/0xe4 kernel/printk/printk.c:2283
vprintk+0x200/0x2d4 kernel/printk/printk_safe.c:45
_printk+0xdc/0x128 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x398/0x514 lib/fault-inject.c:146
__should_failslab+0xbc/0x110 mm/failslab.c:33
should_failslab+0x10/0x28 mm/slab_common.c:1337
slab_pre_alloc_hook+0x64/0xe8 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0xc0/0x4c8 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1a4/0x440 drivers/tty/tty_buffer.c:276
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x74/0x324 drivers/tty/tty_buffer.c:586
pty_write+0xb8/0xe8 drivers/tty/pty.c:118
n_tty_write+0x4f4/0xf38 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write+0x48/0x58 drivers/tty/tty_io.c:1131
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
CPU: 0 PID: 17526 Comm: syz-executor.3 Not tainted 5.15.140-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
fail_dump lib/fault-inject.c:52 [inline]
should_fail+0x3b8/0x514 lib/fault-inject.c:146
__should_failslab+0xbc/0x110 mm/failslab.c:33
should_failslab+0x10/0x28 mm/slab_common.c:1337
slab_pre_alloc_hook+0x64/0xe8 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0xc0/0x4c8 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1a4/0x440 drivers/tty/tty_buffer.c:276
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x74/0x324 drivers/tty/tty_buffer.c:586
pty_write+0xb8/0xe8 drivers/tty/pty.c:118
n_tty_write+0x4f4/0xf38 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write+0x48/0x58 drivers/tty/tty_io.c:1131
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: a78d278e01b1 Linux 5.15.140
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=136d4a64e80000
kernel config: https://syzkaller.appspot.com/x/.config?x=af8ffc64a7d6b78a
dashboard link: https://syzkaller.appspot.com/bug?extid=dc57c1cfb6ac07a3c0d2
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/725f6f29c66f/disk-a78d278e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/af4bcc4e141e/vmlinux-a78d278e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0d3f0ba6b252/Image-a78d278e.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+dc57c1...@syzkaller.appspotmail.com
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 0
======================================================
WARNING: possible circular locking dependency detected
5.15.140-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.3/17526 is trying to acquire lock:
ffff800014ae7920 (console_owner){-.-.}-{0:0}, at: console_trylock_spinning+0xe4/0x280 kernel/printk/printk.c:1879
but task is already holding lock:
ffff0000d267a958 (&port->lock){....}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x48/0x324 drivers/tty/tty_buffer.c:585
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&port->lock){....}-{2:2}:
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xc4/0x14c kernel/locking/spinlock.c:162
tty_port_tty_get+0x2c/0x124 drivers/tty/tty_port.c:289
tty_port_default_wakeup+0x20/0x54 drivers/tty/tty_port.c:48
tty_port_tty_wakeup+0x64/0x78 drivers/tty/tty_port.c:389
uart_write_wakeup+0x4c/0x64 drivers/tty/serial/serial_core.c:111
pl011_tx_chars+0xd04/0x157c drivers/tty/serial/amba-pl011.c:1505
pl011_start_tx_pio drivers/tty/serial/amba-pl011.c:1351 [inline]
pl011_start_tx+0x364/0x8b8 drivers/tty/serial/amba-pl011.c:1363
__uart_start drivers/tty/serial/serial_core.c:132 [inline]
uart_write+0x62c/0x8b8 drivers/tty/serial/serial_core.c:589
process_output_block drivers/tty/n_tty.c:592 [inline]
n_tty_write+0xae0/0xf38 drivers/tty/n_tty.c:2339
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write drivers/tty/tty_io.c:1131 [inline]
redirected_tty_write+0xc4/0x10c drivers/tty/tty_io.c:1154
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&port_lock_key){-.-.}-{2:2}:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0xb0/0x10c kernel/locking/spinlock.c:154
spin_lock include/linux/spinlock.h:363 [inline]
pl011_console_write+0x1a0/0x774 drivers/tty/serial/amba-pl011.c:2354
call_console_drivers kernel/printk/printk.c:1953 [inline]
console_unlock+0xbac/0x1394 kernel/printk/printk.c:2738
register_console+0x560/0x870 kernel/printk/printk.c:3068
uart_configure_port drivers/tty/serial/serial_core.c:2443 [inline]
uart_add_one_port+0xe70/0x1540 drivers/tty/serial/serial_core.c:2958
pl011_register_port+0x1a0/0x434 drivers/tty/serial/amba-pl011.c:2799
sbsa_uart_probe+0x474/0x5dc drivers/tty/serial/amba-pl011.c:2934
platform_probe+0x148/0x1c0 drivers/base/platform.c:1391
really_probe+0x26c/0xaec drivers/base/dd.c:595
__driver_probe_device+0x194/0x3b4 drivers/base/dd.c:755
driver_probe_device+0x78/0x34c drivers/base/dd.c:785
__device_attach_driver+0x28c/0x4d8 drivers/base/dd.c:907
bus_for_each_drv+0x158/0x1e0 drivers/base/bus.c:427
__device_attach+0x2f0/0x480 drivers/base/dd.c:979
device_initial_probe+0x24/0x34 drivers/base/dd.c:1028
bus_probe_device+0xbc/0x1c8 drivers/base/bus.c:487
device_add+0xae0/0xef4 drivers/base/core.c:3394
platform_device_add+0x3f8/0x708 drivers/base/platform.c:712
platform_device_register_full+0x508/0x618 drivers/base/platform.c:835
acpi_create_platform_device+0x4d8/0x650 drivers/acpi/acpi_platform.c:154
acpi_default_enumeration+0x6c/0xdc drivers/acpi/scan.c:2087
acpi_bus_attach+0x88c/0xab4 drivers/acpi/scan.c:2197
acpi_bus_attach+0x314/0xab4 drivers/acpi/scan.c:2203
acpi_bus_attach+0x314/0xab4 drivers/acpi/scan.c:2203
acpi_bus_scan+0xe4/0x20c drivers/acpi/scan.c:2375
acpi_scan_init+0x220/0x71c drivers/acpi/scan.c:2550
acpi_init+0x188/0x24c drivers/acpi/bus.c:1346
do_one_initcall+0x234/0x990 init/main.c:1295
do_initcall_level+0x154/0x214 init/main.c:1368
do_initcalls+0x58/0xac init/main.c:1384
do_basic_setup+0x8c/0xa0 init/main.c:1403
kernel_init_freeable+0x460/0x640 init/main.c:1608
kernel_init+0x24/0x294 init/main.c:1499
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
-> #0 (console_owner){-.-.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3787 [inline]
__lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
console_trylock_spinning+0x110/0x280 kernel/printk/printk.c:1896
vprintk_emit+0x124/0x21c kernel/printk/printk.c:2267
vprintk_default+0xa0/0xe4 kernel/printk/printk.c:2283
vprintk+0x200/0x2d4 kernel/printk/printk_safe.c:45
_printk+0xdc/0x128 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x398/0x514 lib/fault-inject.c:146
__should_failslab+0xbc/0x110 mm/failslab.c:33
should_failslab+0x10/0x28 mm/slab_common.c:1337
slab_pre_alloc_hook+0x64/0xe8 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0xc0/0x4c8 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1a4/0x440 drivers/tty/tty_buffer.c:276
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x74/0x324 drivers/tty/tty_buffer.c:586
pty_write+0xb8/0xe8 drivers/tty/pty.c:118
n_tty_write+0x4f4/0xf38 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write+0x48/0x58 drivers/tty/tty_io.c:1131
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
console_owner --> &port_lock_key --> &port->lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&port->lock);
lock(&port_lock_key);
lock(&port->lock);
lock(console_owner);
*** DEADLOCK ***
5 locks held by syz-executor.3/17526:
#0: ffff0000d7b79098 (&tty->ldisc_sem){++++}-{0:0}, at: ldsem_down_read+0x40/0x50 drivers/tty/tty_ldsem.c:340
#1: ffff0000d7b79130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: tty_write_lock drivers/tty/tty_io.c:961 [inline]
#1: ffff0000d7b79130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: do_tty_write drivers/tty/tty_io.c:984 [inline]
#1: ffff0000d7b79130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: file_tty_write+0x1d4/0x758 drivers/tty/tty_io.c:1110
#2: ffff0000d7b792e8 (&tty->termios_rwsem){++++}-{3:3}, at: n_tty_write+0x1ec/0xf38 drivers/tty/n_tty.c:2322
#3: ffff8000272cd378 (&ldata->output_lock){+.+.}-{3:3}, at: n_tty_write+0x4b0/0xf38 drivers/tty/n_tty.c:2361
#4: ffff0000d267a958 (&port->lock){....}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x48/0x324 drivers/tty/tty_buffer.c:585
stack backtrace:
CPU: 0 PID: 17526 Comm: syz-executor.3 Not tainted 5.15.140-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3787 [inline]
__lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622
console_trylock_spinning+0x110/0x280 kernel/printk/printk.c:1896
vprintk_emit+0x124/0x21c kernel/printk/printk.c:2267
vprintk_default+0xa0/0xe4 kernel/printk/printk.c:2283
vprintk+0x200/0x2d4 kernel/printk/printk_safe.c:45
_printk+0xdc/0x128 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x398/0x514 lib/fault-inject.c:146
__should_failslab+0xbc/0x110 mm/failslab.c:33
should_failslab+0x10/0x28 mm/slab_common.c:1337
slab_pre_alloc_hook+0x64/0xe8 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0xc0/0x4c8 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1a4/0x440 drivers/tty/tty_buffer.c:276
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x74/0x324 drivers/tty/tty_buffer.c:586
pty_write+0xb8/0xe8 drivers/tty/pty.c:118
n_tty_write+0x4f4/0xf38 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write+0x48/0x58 drivers/tty/tty_io.c:1131
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
CPU: 0 PID: 17526 Comm: syz-executor.3 Not tainted 5.15.140-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
fail_dump lib/fault-inject.c:52 [inline]
should_fail+0x3b8/0x514 lib/fault-inject.c:146
__should_failslab+0xbc/0x110 mm/failslab.c:33
should_failslab+0x10/0x28 mm/slab_common.c:1337
slab_pre_alloc_hook+0x64/0xe8 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0xc0/0x4c8 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1a4/0x440 drivers/tty/tty_buffer.c:276
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x74/0x324 drivers/tty/tty_buffer.c:586
pty_write+0xb8/0xe8 drivers/tty/pty.c:118
n_tty_write+0x4f4/0xf38 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x44c/0x758 drivers/tty/tty_io.c:1110
tty_write+0x48/0x58 drivers/tty/tty_io.c:1131
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot
Jan 21, 2024, 4:32:17 PMJan 21
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: ddcaf4999061 Linux 5.15.147
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12029d57e80000
kernel config: https://syzkaller.appspot.com/x/.config?x=8c65db3d25098c3c
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17d270abe80000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/fe87fb57528f/disk-ddcaf499.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f64608a2759c/vmlinux-ddcaf499.xz
kernel image: https://storage.googleapis.com/syzbot-assets/84cae5bc6ed5/bzImage-ddcaf499.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+dc57c1...@syzkaller.appspotmail.com
FAULT_INJECTION: forcing a failure.
name failslab, interval 1, probability 0, space 0, times 1
------------------------------------------------------
syz-executor142/3499 is trying to acquire lock:
ffffffff8c913da0 (console_owner){-...}-{0:0}, at: console_trylock_spinning+0x185/0x3f0 kernel/printk/printk.c:1879
but task is already holding lock:
ffff88801d7ec158 (&port->lock){-...}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x3a/0x390 drivers/tty/tty_buffer.c:585
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&port->lock){-...}-{2:2}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
tty_port_tty_get drivers/tty/tty_port.c:289 [inline]
tty_port_default_wakeup+0x21/0x100 drivers/tty/tty_port.c:48
serial8250_tx_chars+0x60d/0x800 drivers/tty/serial/8250/8250_port.c:1848
serial8250_handle_irq+0x505/0x600 drivers/tty/serial/8250/8250_port.c:1944
serial8250_default_handle_irq+0xc8/0x1e0 drivers/tty/serial/8250/8250_port.c:1961
serial8250_interrupt+0xa1/0x1e0 drivers/tty/serial/8250/8250_core.c:127
__handle_irq_event_percpu+0x292/0xa70 kernel/irq/handle.c:156
handle_irq_event_percpu kernel/irq/handle.c:196 [inline]
handle_irq_event+0xff/0x2b0 kernel/irq/handle.c:213
handle_edge_irq+0x245/0xbf0 kernel/irq/chip.c:822
generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
handle_irq arch/x86/kernel/irq.c:231 [inline]
__common_interrupt+0xd7/0x1f0 arch/x86/kernel/irq.c:250
common_interrupt+0x9f/0xc0 arch/x86/kernel/irq.c:240
asm_common_interrupt+0x22/0x40 arch/x86/include/asm/idtentry.h:629
__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:161 [inline]
_raw_spin_unlock_irqrestore+0xd4/0x130 kernel/locking/spinlock.c:194
spin_unlock_irqrestore include/linux/spinlock.h:418 [inline]
uart_write+0x6af/0x930 drivers/tty/serial/serial_core.c:590
process_output_block drivers/tty/n_tty.c:592 [inline]
n_tty_write+0xd7e/0x1280 drivers/tty/n_tty.c:2339
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
call_write_iter include/linux/fs.h:2146 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacf/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
-> #1 (&port_lock_key){-...}-{2:2}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
serial8250_console_write+0x19d/0x1180 drivers/tty/serial/8250/8250_port.c:3374
console_unlock+0xced/0x12b0 kernel/printk/printk.c:2738
vprintk_emit+0xbf/0x150 kernel/printk/printk.c:2268
_printk+0xd1/0x111 kernel/printk/printk.c:2293
register_console+0x68c/0x970 kernel/printk/printk.c:3078
univ8250_console_init+0x41/0x43 drivers/tty/serial/8250/8250_core.c:690
console_init+0x18c/0x652 kernel/printk/printk.c:3178
start_kernel+0x301/0x535 init/main.c:1073
secondary_startup_64_no_verify+0xb1/0xbb
-> #0 (console_owner){-...}-{0:0}:
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
console_trylock_spinning+0x1a5/0x3f0 kernel/printk/printk.c:1896
vprintk_emit+0xa6/0x150 kernel/printk/printk.c:2267
_printk+0xd1/0x111 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x36c/0x4c0 lib/fault-inject.c:146
should_failslab+0x5/0x20 mm/slab_common.c:1337
slab_pre_alloc_hook+0x53/0xc0 mm/slab.h:494
n_tty_write+0x63c/0x1280 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
do_iter_readv_writev+0x594/0x7a0
do_iter_write+0x1ea/0x760 fs/read_write.c:855
iter_file_splice_write+0x806/0xfa0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe3/0x1c0 fs/splice.c:936
splice_direct_to_actor+0x500/0xc10 fs/splice.c:891
do_splice_direct+0x285/0x3d0 fs/splice.c:979
do_sendfile+0x625/0xff0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
other info that might help us debug this:
Chain exists of:
console_owner --> &port_lock_key --> &port->lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&port->lock);
lock(&port_lock_key);
lock(&port->lock);
lock(console_owner);
*** DEADLOCK ***
5 locks held by syz-executor142/3499:
#0: ffff8881474c6098 (&tty->ldisc_sem){++++}-{0:0}, at: tty_ldisc_ref_wait+0x21/0x70 drivers/tty/tty_ldisc.c:252
#1: ffff8881474c6130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: tty_write_lock drivers/tty/tty_io.c:961 [inline]
#1: ffff8881474c6130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: do_tty_write drivers/tty/tty_io.c:984 [inline]
#1: ffff8881474c6130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: file_tty_write+0x24f/0x920 drivers/tty/tty_io.c:1110
#2: ffff8881474c62e8 (&tty->termios_rwsem){++++}-{3:3}, at: n_tty_write+0x252/0x1280 drivers/tty/n_tty.c:2322
#3: ffffc900010e8378 (&ldata->output_lock){+.+.}-{3:3}, at: n_tty_write+0x5ee/0x1280 drivers/tty/n_tty.c:2361
#4: ffff88801d7ec158 (&port->lock){-...}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x3a/0x390 drivers/tty/tty_buffer.c:585
stack backtrace:
CPU: 1 PID: 3499 Comm: syz-executor142 Not tainted 5.15.147-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
console_trylock_spinning+0x1a5/0x3f0 kernel/printk/printk.c:1896
vprintk_emit+0xa6/0x150 kernel/printk/printk.c:2267
_printk+0xd1/0x111 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x36c/0x4c0 lib/fault-inject.c:146
should_failslab+0x5/0x20 mm/slab_common.c:1337
slab_pre_alloc_hook+0x53/0xc0 mm/slab.h:494
n_tty_write+0x63c/0x1280 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
do_iter_readv_writev+0x594/0x7a0
do_iter_write+0x1ea/0x760 fs/read_write.c:855
iter_file_splice_write+0x806/0xfa0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe3/0x1c0 fs/splice.c:936
splice_direct_to_actor+0x500/0xc10 fs/splice.c:891
do_splice_direct+0x285/0x3d0 fs/splice.c:979
do_sendfile+0x625/0xff0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fb353f84139
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc284df168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007ffc284df170 RCX: 00007fb353f84139
RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005
RBP: 0000000000000002 R08: 00007ffc284def06 R09: 00007fb353003432
R10: 0001000000201005 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc284df3d8 R14: 0000000000000001 R15: 0000000000000001
</TASK>
CPU: 1 PID: 3499 Comm: syz-executor142 Not tainted 5.15.147-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
fail_dump lib/fault-inject.c:52 [inline]
should_fail+0x38a/0x4c0 lib/fault-inject.c:146
should_failslab+0x5/0x20 mm/slab_common.c:1337
slab_pre_alloc_hook+0x53/0xc0 mm/slab.h:494
n_tty_write+0x63c/0x1280 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
do_iter_readv_writev+0x594/0x7a0
do_iter_write+0x1ea/0x760 fs/read_write.c:855
iter_file_splice_write+0x806/0xfa0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe3/0x1c0 fs/splice.c:936
splice_direct_to_actor+0x500/0xc10 fs/splice.c:891
do_splice_direct+0x285/0x3d0 fs/splice.c:979
do_sendfile+0x625/0xff0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fb353f84139
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc284df168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: fffffffffffff
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
HEAD commit: ddcaf4999061 Linux 5.15.147
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12029d57e80000
kernel config: https://syzkaller.appspot.com/x/.config?x=8c65db3d25098c3c
dashboard link: https://syzkaller.appspot.com/bug?extid=dc57c1cfb6ac07a3c0d2
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1573a7dde80000
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17d270abe80000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/fe87fb57528f/disk-ddcaf499.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f64608a2759c/vmlinux-ddcaf499.xz
kernel image: https://storage.googleapis.com/syzbot-assets/84cae5bc6ed5/bzImage-ddcaf499.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+dc57c1...@syzkaller.appspotmail.com
FAULT_INJECTION: forcing a failure.
======================================================
WARNING: possible circular locking dependency detected
5.15.147-syzkaller #0 Not tainted
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz-executor142/3499 is trying to acquire lock:
ffffffff8c913da0 (console_owner){-...}-{0:0}, at: console_trylock_spinning+0x185/0x3f0 kernel/printk/printk.c:1879
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
tty_port_tty_get drivers/tty/tty_port.c:289 [inline]
tty_port_default_wakeup+0x21/0x100 drivers/tty/tty_port.c:48
serial8250_tx_chars+0x60d/0x800 drivers/tty/serial/8250/8250_port.c:1848
serial8250_handle_irq+0x505/0x600 drivers/tty/serial/8250/8250_port.c:1944
serial8250_default_handle_irq+0xc8/0x1e0 drivers/tty/serial/8250/8250_port.c:1961
serial8250_interrupt+0xa1/0x1e0 drivers/tty/serial/8250/8250_core.c:127
__handle_irq_event_percpu+0x292/0xa70 kernel/irq/handle.c:156
handle_irq_event_percpu kernel/irq/handle.c:196 [inline]
handle_irq_event+0xff/0x2b0 kernel/irq/handle.c:213
handle_edge_irq+0x245/0xbf0 kernel/irq/chip.c:822
generic_handle_irq_desc include/linux/irqdesc.h:158 [inline]
handle_irq arch/x86/kernel/irq.c:231 [inline]
__common_interrupt+0xd7/0x1f0 arch/x86/kernel/irq.c:250
common_interrupt+0x9f/0xc0 arch/x86/kernel/irq.c:240
asm_common_interrupt+0x22/0x40 arch/x86/include/asm/idtentry.h:629
__raw_spin_unlock_irqrestore include/linux/spinlock_api_smp.h:161 [inline]
_raw_spin_unlock_irqrestore+0xd4/0x130 kernel/locking/spinlock.c:194
spin_unlock_irqrestore include/linux/spinlock.h:418 [inline]
uart_write+0x6af/0x930 drivers/tty/serial/serial_core.c:590
process_output_block drivers/tty/n_tty.c:592 [inline]
n_tty_write+0xd7e/0x1280 drivers/tty/n_tty.c:2339
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
call_write_iter include/linux/fs.h:2146 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacf/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
-> #1 (&port_lock_key){-...}-{2:2}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
serial8250_console_write+0x19d/0x1180 drivers/tty/serial/8250/8250_port.c:3374
console_unlock+0xced/0x12b0 kernel/printk/printk.c:2738
vprintk_emit+0xbf/0x150 kernel/printk/printk.c:2268
_printk+0xd1/0x111 kernel/printk/printk.c:2293
register_console+0x68c/0x970 kernel/printk/printk.c:3078
univ8250_console_init+0x41/0x43 drivers/tty/serial/8250/8250_core.c:690
console_init+0x18c/0x652 kernel/printk/printk.c:3178
start_kernel+0x301/0x535 init/main.c:1073
secondary_startup_64_no_verify+0xb1/0xbb
-> #0 (console_owner){-...}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
console_trylock_spinning+0x1a5/0x3f0 kernel/printk/printk.c:1896
vprintk_emit+0xa6/0x150 kernel/printk/printk.c:2267
_printk+0xd1/0x111 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x36c/0x4c0 lib/fault-inject.c:146
should_failslab+0x5/0x20 mm/slab_common.c:1337
slab_pre_alloc_hook+0x53/0xc0 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0x6e/0x300 mm/slub.c:4403
slab_alloc mm/slub.c:3228 [inline]
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1ef/0x500 drivers/tty/tty_buffer.c:276
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x7c/0x390 drivers/tty/tty_buffer.c:586
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
n_tty_write+0x63c/0x1280 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
do_iter_readv_writev+0x594/0x7a0
do_iter_write+0x1ea/0x760 fs/read_write.c:855
iter_file_splice_write+0x806/0xfa0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe3/0x1c0 fs/splice.c:936
splice_direct_to_actor+0x500/0xc10 fs/splice.c:891
do_splice_direct+0x285/0x3d0 fs/splice.c:979
do_sendfile+0x625/0xff0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
other info that might help us debug this:
Chain exists of:
console_owner --> &port_lock_key --> &port->lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&port->lock);
lock(&port_lock_key);
lock(&port->lock);
lock(console_owner);
*** DEADLOCK ***
#0: ffff8881474c6098 (&tty->ldisc_sem){++++}-{0:0}, at: tty_ldisc_ref_wait+0x21/0x70 drivers/tty/tty_ldisc.c:252
#1: ffff8881474c6130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: tty_write_lock drivers/tty/tty_io.c:961 [inline]
#1: ffff8881474c6130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: do_tty_write drivers/tty/tty_io.c:984 [inline]
#1: ffff8881474c6130 (&tty->atomic_write_lock){+.+.}-{3:3}, at: file_tty_write+0x24f/0x920 drivers/tty/tty_io.c:1110
#2: ffff8881474c62e8 (&tty->termios_rwsem){++++}-{3:3}, at: n_tty_write+0x252/0x1280 drivers/tty/n_tty.c:2322
#3: ffffc900010e8378 (&ldata->output_lock){+.+.}-{3:3}, at: n_tty_write+0x5ee/0x1280 drivers/tty/n_tty.c:2361
#4: ffff88801d7ec158 (&port->lock){-...}-{2:2}, at: tty_insert_flip_string_and_push_buffer+0x3a/0x390 drivers/tty/tty_buffer.c:585
stack backtrace:
CPU: 1 PID: 3499 Comm: syz-executor142 Not tainted 5.15.147-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
console_trylock_spinning+0x1a5/0x3f0 kernel/printk/printk.c:1896
vprintk_emit+0xa6/0x150 kernel/printk/printk.c:2267
_printk+0xd1/0x111 kernel/printk/printk.c:2293
fail_dump lib/fault-inject.c:45 [inline]
should_fail+0x36c/0x4c0 lib/fault-inject.c:146
should_failslab+0x5/0x20 mm/slab_common.c:1337
slab_pre_alloc_hook+0x53/0xc0 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0x6e/0x300 mm/slub.c:4403
slab_alloc mm/slub.c:3228 [inline]
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1ef/0x500 drivers/tty/tty_buffer.c:276
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x7c/0x390 drivers/tty/tty_buffer.c:586
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
n_tty_write+0x63c/0x1280 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
do_iter_readv_writev+0x594/0x7a0
do_iter_write+0x1ea/0x760 fs/read_write.c:855
iter_file_splice_write+0x806/0xfa0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe3/0x1c0 fs/splice.c:936
splice_direct_to_actor+0x500/0xc10 fs/splice.c:891
do_splice_direct+0x285/0x3d0 fs/splice.c:979
do_sendfile+0x625/0xff0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fb353f84139
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc284df168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007ffc284df170 RCX: 00007fb353f84139
RDX: 0000000000000000 RSI: 0000000000000006 RDI: 0000000000000005
RBP: 0000000000000002 R08: 00007ffc284def06 R09: 00007fb353003432
R10: 0001000000201005 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc284df3d8 R14: 0000000000000001 R15: 0000000000000001
</TASK>
CPU: 1 PID: 3499 Comm: syz-executor142 Not tainted 5.15.147-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
fail_dump lib/fault-inject.c:52 [inline]
should_fail+0x38a/0x4c0 lib/fault-inject.c:146
should_failslab+0x5/0x20 mm/slab_common.c:1337
slab_pre_alloc_hook+0x53/0xc0 mm/slab.h:494
slab_alloc_node mm/slub.c:3134 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0x6e/0x300 mm/slub.c:4403
slab_alloc mm/slub.c:3228 [inline]
kmalloc include/linux/slab.h:596 [inline]
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
__tty_buffer_request_room+0x1ef/0x500 drivers/tty/tty_buffer.c:276
tty_buffer_alloc drivers/tty/tty_buffer.c:177 [inline]
tty_insert_flip_string_fixed_flag drivers/tty/tty_buffer.c:322 [inline]
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
tty_insert_flip_string_and_push_buffer+0x7c/0x390 drivers/tty/tty_buffer.c:586
tty_insert_flip_string include/linux/tty_flip.h:41 [inline]
n_tty_write+0x63c/0x1280 drivers/tty/n_tty.c:2362
do_tty_write drivers/tty/tty_io.c:1038 [inline]
file_tty_write+0x561/0x920 drivers/tty/tty_io.c:1110
do_iter_readv_writev+0x594/0x7a0
do_iter_write+0x1ea/0x760 fs/read_write.c:855
iter_file_splice_write+0x806/0xfa0 fs/splice.c:689
do_splice_from fs/splice.c:767 [inline]
direct_splice_actor+0xe3/0x1c0 fs/splice.c:936
splice_direct_to_actor+0x500/0xc10 fs/splice.c:891
do_splice_direct+0x285/0x3d0 fs/splice.c:979
do_sendfile+0x625/0xff0 fs/read_write.c:1249
__do_sys_sendfile64 fs/read_write.c:1317 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1303
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fb353f84139
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc284df168 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: fffffffffffff
---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
syzbot
Jan 22, 2024, 10:59:06 AMJan 22
to syzkaller...@googlegroups.com
syzbot suspects this issue could be fixed by backporting the following commit:
commit 09c5ba0aa2fcfdadb17d045c3ee6f86d69270df7
git tree: upstream
Author: John Ogness <john....@linutronix.de>
Date: Thu Apr 21 21:22:48 2022 +0000
printk: add kthread console printers
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12fd8abfe80000
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
commit 09c5ba0aa2fcfdadb17d045c3ee6f86d69270df7
git tree: upstream
Author: John Ogness <john....@linutronix.de>
Date: Thu Apr 21 21:22:48 2022 +0000
printk: add kthread console printers
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12fd8abfe80000
kernel config: https://syzkaller.appspot.com/x/.config?x=8c65db3d25098c3c
dashboard link: https://syzkaller.appspot.com/bug?extid=dc57c1cfb6ac07a3c0d2
dashboard link: https://syzkaller.appspot.com/bug?extid=dc57c1cfb6ac07a3c0d2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1573a7dde80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17d270abe80000
Please keep in mind that other backports might be required as well.
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17d270abe80000
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
Reply all
Reply to author
Forward
0 new messages