[v5.15] possible deadlock in delete_one_xattr
0 views
Skip to first unread message
syzbot
Apr 29, 2024, 8:40:28 PMApr 29
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: b925f60c6ee7 Linux 5.15.157
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10062937180000
kernel config: https://syzkaller.appspot.com/x/.config?x=802c8e49b2826f05
dashboard link: https://syzkaller.appspot.com/bug?extid=bd323360d0326f7b2b54
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/add896a77889/disk-b925f60c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e24f83a46999/vmlinux-b925f60c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/de040a426c29/Image-b925f60c.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bd3233...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.157-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/6087 is trying to acquire lock:
ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
but task is already holding lock:
ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}:
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
open_xa_root fs/reiserfs/xattr.c:127 [inline]
open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152
lookup_and_delete_xattr fs/reiserfs/xattr.c:489 [inline]
reiserfs_xattr_set_handle+0x108/0xc10 fs/reiserfs/xattr.c:536
reiserfs_xattr_set+0x398/0x4b0 fs/reiserfs/xattr.c:640
trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31
__vfs_removexattr+0x370/0x38c fs/xattr.c:470
__vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505
vfs_removexattr+0xe0/0x23c fs/xattr.c:527
removexattr fs/xattr.c:857 [inline]
path_removexattr+0x1ec/0x2ec fs/xattr.c:871
__do_sys_lremovexattr fs/xattr.c:891 [inline]
__se_sys_lremovexattr fs/xattr.c:888 [inline]
__arm64_sys_lremovexattr+0x60/0x78 fs/xattr.c:888
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&type->i_mutex_dir_key#17){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
vfs_rename+0x68c/0xe04 fs/namei.c:4797
do_renameat2+0xa00/0x10c0 fs/namei.c:4985
__do_sys_renameat2 fs/namei.c:5018 [inline]
__se_sys_renameat2 fs/namei.c:5015 [inline]
__arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
dentry_unlink_inode+0x370/0x4b0 fs/dcache.c:376
__dentry_kill+0x324/0x5e4 fs/dcache.c:582
dentry_kill+0xc8/0x250
dput+0x21c/0x458 fs/dcache.c:889
path_put+0x3c/0x68 fs/namei.c:559
path_setxattr+0x1a0/0x258 fs/xattr.c:634
__do_sys_lsetxattr fs/xattr.c:653 [inline]
__se_sys_lsetxattr fs/xattr.c:649 [inline]
__arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
&type->i_mutex_dir_key#17/2 --> &type->i_mutex_dir_key#17 --> &type->i_mutex_dir_key#17/3
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#17/3);
lock(&type->i_mutex_dir_key#17);
lock(&type->i_mutex_dir_key#17/3);
lock(&type->i_mutex_dir_key#17/2);
*** DEADLOCK ***
1 lock held by syz-executor.1/6087:
#0: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#0: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
stack backtrace:
CPU: 1 PID: 6087 Comm: syz-executor.1 Not tainted 5.15.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
dentry_unlink_inode+0x370/0x4b0 fs/dcache.c:376
__dentry_kill+0x324/0x5e4 fs/dcache.c:582
dentry_kill+0xc8/0x250
dput+0x21c/0x458 fs/dcache.c:889
path_put+0x3c/0x68 fs/namei.c:559
path_setxattr+0x1a0/0x258 fs/xattr.c:634
__do_sys_lsetxattr fs/xattr.c:653 [inline]
__se_sys_lsetxattr fs/xattr.c:649 [inline]
__arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: b925f60c6ee7 Linux 5.15.157
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10062937180000
kernel config: https://syzkaller.appspot.com/x/.config?x=802c8e49b2826f05
dashboard link: https://syzkaller.appspot.com/bug?extid=bd323360d0326f7b2b54
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/add896a77889/disk-b925f60c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e24f83a46999/vmlinux-b925f60c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/de040a426c29/Image-b925f60c.gz.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bd3233...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.157-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/6087 is trying to acquire lock:
ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
ffff0000ebdc9d60 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}, at: delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
but task is already holding lock:
ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}:
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
open_xa_root fs/reiserfs/xattr.c:127 [inline]
open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152
lookup_and_delete_xattr fs/reiserfs/xattr.c:489 [inline]
reiserfs_xattr_set_handle+0x108/0xc10 fs/reiserfs/xattr.c:536
reiserfs_xattr_set+0x398/0x4b0 fs/reiserfs/xattr.c:640
trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31
__vfs_removexattr+0x370/0x38c fs/xattr.c:470
__vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:505
vfs_removexattr+0xe0/0x23c fs/xattr.c:527
removexattr fs/xattr.c:857 [inline]
path_removexattr+0x1ec/0x2ec fs/xattr.c:871
__do_sys_lremovexattr fs/xattr.c:891 [inline]
__se_sys_lremovexattr fs/xattr.c:888 [inline]
__arm64_sys_lremovexattr+0x60/0x78 fs/xattr.c:888
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&type->i_mutex_dir_key#17){+.+.}-{3:3}:
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
vfs_rename+0x68c/0xe04 fs/namei.c:4797
do_renameat2+0xa00/0x10c0 fs/namei.c:4985
__do_sys_renameat2 fs/namei.c:5018 [inline]
__se_sys_renameat2 fs/namei.c:5015 [inline]
__arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (&type->i_mutex_dir_key#17/2){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
dentry_unlink_inode+0x370/0x4b0 fs/dcache.c:376
__dentry_kill+0x324/0x5e4 fs/dcache.c:582
dentry_kill+0xc8/0x250
dput+0x21c/0x458 fs/dcache.c:889
path_put+0x3c/0x68 fs/namei.c:559
path_setxattr+0x1a0/0x258 fs/xattr.c:634
__do_sys_lsetxattr fs/xattr.c:653 [inline]
__se_sys_lsetxattr fs/xattr.c:649 [inline]
__arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
&type->i_mutex_dir_key#17/2 --> &type->i_mutex_dir_key#17 --> &type->i_mutex_dir_key#17/3
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#17/3);
lock(&type->i_mutex_dir_key#17);
lock(&type->i_mutex_dir_key#17/3);
lock(&type->i_mutex_dir_key#17/2);
*** DEADLOCK ***
1 lock held by syz-executor.1/6087:
#0: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#0: ffff0000ebdc96c0 (&type->i_mutex_dir_key#17/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
stack backtrace:
CPU: 1 PID: 6087 Comm: syz-executor.1 Not tainted 5.15.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
dentry_unlink_inode+0x370/0x4b0 fs/dcache.c:376
__dentry_kill+0x324/0x5e4 fs/dcache.c:582
dentry_kill+0xc8/0x250
dput+0x21c/0x458 fs/dcache.c:889
path_put+0x3c/0x68 fs/namei.c:559
path_setxattr+0x1a0/0x258 fs/xattr.c:634
__do_sys_lsetxattr fs/xattr.c:653 [inline]
__se_sys_lsetxattr fs/xattr.c:649 [inline]
__arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot
Apr 30, 2024, 12:23:25 AMApr 30
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: b925f60c6ee7 Linux 5.15.157
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10fda4ef180000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11604440980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/add896a77889/disk-b925f60c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e24f83a46999/vmlinux-b925f60c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/de040a426c29/Image-b925f60c.gz.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/a1f8d50bdb54/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/564e3f850ceb/mount_7.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bd3233...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.157-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor214/4052 is trying to acquire lock:
ffff0000df2b4bc0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000df2b4bc0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
ffff0000df2b4bc0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
but task is already holding lock:
ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}:
reiserfs_xattr_set_handle+0xe4/0xc10 fs/reiserfs/xattr.c:540
__vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216
__vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
vfs_setxattr+0x1a8/0x344 fs/xattr.c:303
do_setxattr fs/xattr.c:588 [inline]
setxattr+0x250/0x2b4 fs/xattr.c:611
path_setxattr+0x17c/0x258 fs/xattr.c:630
vfs_rmdir+0x2f8/0x3f0 fs/namei.c:4162
do_rmdir+0x2e8/0x84c fs/namei.c:4210
__do_sys_unlinkat fs/namei.c:4390 [inline]
__se_sys_unlinkat fs/namei.c:4384 [inline]
__arm64_sys_unlinkat+0xe0/0xfc fs/namei.c:4384
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#6/3);
lock(&type->i_mutex_dir_key#6);
lock(&type->i_mutex_dir_key#6/3);
lock(&type->i_mutex_dir_key#6/2);
*** DEADLOCK ***
3 locks held by syz-executor214/4052:
#0: ffff0000c8196460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
#1: ffff0000df301020 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#1: ffff0000df301020 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_rmdir+0x1e0/0x84c fs/namei.c:4197
#2: ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#2: ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
stack backtrace:
CPU: 1 PID: 4052 Comm: syz-executor214 Not tainted 5.15.157-syzkaller #0
vfs_rmdir+0x2f8/0x3f0 fs/namei.c:4162
do_rmdir+0x2e8/0x84c fs/namei.c:4210
__do_sys_unlinkat fs/namei.c:4390 [inline]
__se_sys_unlinkat fs/namei.c:4384 [inline]
__arm64_sys_unlinkat+0xe0/0xfc fs/namei.c:4384
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
HEAD commit: b925f60c6ee7 Linux 5.15.157
git tree: linux-5.15.y
kernel config: https://syzkaller.appspot.com/x/.config?x=802c8e49b2826f05
dashboard link: https://syzkaller.appspot.com/bug?extid=bd323360d0326f7b2b54
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=124d597f180000
dashboard link: https://syzkaller.appspot.com/bug?extid=bd323360d0326f7b2b54
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: arm64
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11604440980000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/add896a77889/disk-b925f60c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e24f83a46999/vmlinux-b925f60c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/de040a426c29/Image-b925f60c.gz.xz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/564e3f850ceb/mount_7.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bd3233...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.157-syzkaller #0 Not tainted
------------------------------------------------------
ffff0000df2b4bc0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
ffff0000df2b4bc0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
ffff0000df2b4bc0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}, at: delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
but task is already holding lock:
ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
open_xa_root fs/reiserfs/xattr.c:127 [inline]
open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152
xattr_lookup+0x3c/0x268 fs/reiserfs/xattr.c:395
inode_lock_nested include/linux/fs.h:824 [inline]
open_xa_root fs/reiserfs/xattr.c:127 [inline]
open_xa_dir+0x11c/0x578 fs/reiserfs/xattr.c:152
reiserfs_xattr_set_handle+0xe4/0xc10 fs/reiserfs/xattr.c:540
reiserfs_xattr_set+0x398/0x4b0 fs/reiserfs/xattr.c:640
trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31
__vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
trusted_set+0x98/0xec fs/reiserfs/xattr_trusted.c:31
__vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216
__vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
vfs_setxattr+0x1a8/0x344 fs/xattr.c:303
do_setxattr fs/xattr.c:588 [inline]
setxattr+0x250/0x2b4 fs/xattr.c:611
path_setxattr+0x17c/0x258 fs/xattr.c:630
__do_sys_lsetxattr fs/xattr.c:653 [inline]
__se_sys_lsetxattr fs/xattr.c:649 [inline]
__arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #1 (&type->i_mutex_dir_key#6){+.+.}-{3:3}:
__se_sys_lsetxattr fs/xattr.c:649 [inline]
__arm64_sys_lsetxattr+0xbc/0xd8 fs/xattr.c:649
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
down_write+0xbc/0x12c kernel/locking/rwsem.c:1551
inode_lock include/linux/fs.h:789 [inline]
vfs_rename+0x68c/0xe04 fs/namei.c:4797
do_renameat2+0xa00/0x10c0 fs/namei.c:4985
__do_sys_renameat2 fs/namei.c:5018 [inline]
__se_sys_renameat2 fs/namei.c:5015 [inline]
__arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
-> #0 (&type->i_mutex_dir_key#6/2){+.+.}-{3:3}:
inode_lock include/linux/fs.h:789 [inline]
vfs_rename+0x68c/0xe04 fs/namei.c:4797
do_renameat2+0xa00/0x10c0 fs/namei.c:4985
__do_sys_renameat2 fs/namei.c:5018 [inline]
__se_sys_renameat2 fs/namei.c:5015 [inline]
__arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
d_delete_notify include/linux/fsnotify.h:261 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
vfs_rmdir+0x2f8/0x3f0 fs/namei.c:4162
do_rmdir+0x2e8/0x84c fs/namei.c:4210
__do_sys_unlinkat fs/namei.c:4390 [inline]
__se_sys_unlinkat fs/namei.c:4384 [inline]
__arm64_sys_unlinkat+0xe0/0xfc fs/namei.c:4384
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
&type->i_mutex_dir_key#6/2 --> &type->i_mutex_dir_key#6 --> &type->i_mutex_dir_key#6/3
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
other info that might help us debug this:
Chain exists of:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->i_mutex_dir_key#6);
lock(&type->i_mutex_dir_key#6/3);
lock(&type->i_mutex_dir_key#6/2);
*** DEADLOCK ***
3 locks held by syz-executor214/4052:
#0: ffff0000c8196460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
#1: ffff0000df301020 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#1: ffff0000df301020 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_rmdir+0x1e0/0x84c fs/namei.c:4197
#2: ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline]
#2: ffff0000df2b37e0 (&type->i_mutex_dir_key#6/3){+.+.}-{3:3}, at: reiserfs_for_each_xattr+0x788/0x8d8 fs/reiserfs/xattr.c:309
stack backtrace:
CPU: 1 PID: 4052 Comm: syz-executor214 Not tainted 5.15.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
d_delete_notify include/linux/fsnotify.h:261 [inline]
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011
check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain kernel/locking/lockdep.c:3788 [inline]
__lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012
lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623
down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667
inode_lock_nested include/linux/fs.h:824 [inline]
xattr_rmdir fs/reiserfs/xattr.c:106 [inline]
delete_one_xattr+0xe8/0x2c8 fs/reiserfs/xattr.c:338
reiserfs_for_each_xattr+0x794/0x8d8 fs/reiserfs/xattr.c:311
reiserfs_delete_xattrs+0x2c/0xa4 fs/reiserfs/xattr.c:364
reiserfs_evict_inode+0x1dc/0x3f0 fs/reiserfs/inode.c:53
evict+0x260/0x68c fs/inode.c:587
iput_final fs/inode.c:1705 [inline]
iput+0x744/0x824 fs/inode.c:1731
vfs_rmdir+0x2f8/0x3f0 fs/namei.c:4162
do_rmdir+0x2e8/0x84c fs/namei.c:4210
__do_sys_unlinkat fs/namei.c:4390 [inline]
__se_sys_unlinkat fs/namei.c:4384 [inline]
__arm64_sys_unlinkat+0xe0/0xfc fs/namei.c:4384
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
If you want syzbot to run the reproducer, reply with:
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626
el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584
---
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.
Reply all
Reply to author
Forward
0 new messages