[v6.1] WARNING in carl9170_usb_submit_cmd_urb/usb_submit_urb

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3b29299e5f60 Linux 6.1.22
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16feabd1c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=bbb9a1f6f7f5a1d9
dashboard link: https://syzkaller.appspot.com/bug?extid=625c1e4ecd689cb90843
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17034fd1c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1329d12ec80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2affbd06cbfd/disk-3b29299e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8b22d1baf827/vmlinux-3b29299e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d5e3891c88bf/Image-3b29299e.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+625c1e...@syzkaller.appspotmail.com

------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 1 != type 3
WARNING: CPU: 1 PID: 110 at drivers/usb/core/urb.c:505 usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:504
Modules linked in:
CPU: 1 PID: 110 Comm: kworker/1:2 Not tainted 6.1.22-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: usb_hub_wq hub_event
pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:504
lr : usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:504
sp : ffff80001d726740
x29: ffff80001d726780 x28: 0000000000000001 x27: ffff8000134f8d28
x26: ffff0000cd0ddd00 x25: ffff0000cd4dc000 x24: 0000000000000040
x23: ffff8000134ff5a0 x22: dfff800000000000 x21: 0000000000000002
x20: 0000000000000a20 x19: ffff0000c08bee00 x18: ffff80001d725b40
x17: 0000000000000000 x16: ffff8000120d9934 x15: 0000000000000000
x14: 0000000000000000 x13: 0000000000000001 x12: 0000000000000001
x11: ff808000081aec18 x10: 0000000000000000 x9 : a1d2626a2462ad00
x8 : a1d2626a2462ad00 x7 : 0000000000000001 x6 : 0000000000000001
x5 : ffff80001d726038 x4 : ffff800015662680 x3 : ffff800008583464
x2 : 0000000000000001 x1 : 0000000100000000 x0 : 0000000000000000
Call trace:
usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:504
carl9170_usb_submit_cmd_urb+0x78/0x1ac drivers/net/wireless/ath/carl9170/usb.c:229
__carl9170_exec_cmd+0x2b0/0x40c drivers/net/wireless/ath/carl9170/usb.c:643
carl9170_reboot+0xa4/0xf0 drivers/net/wireless/ath/carl9170/cmd.c:141
carl9170_usb_disconnect+0x90/0x144 drivers/net/wireless/ath/carl9170/usb.c:1116
usb_unbind_interface+0x1a4/0x758 drivers/usb/core/driver.c:458
device_remove drivers/base/dd.c:550 [inline]
__device_release_driver drivers/base/dd.c:1253 [inline]
device_release_driver_internal+0x474/0x724 drivers/base/dd.c:1279
device_release_driver+0x28/0x38 drivers/base/dd.c:1302
usb_driver_release_interface drivers/usb/core/driver.c:627 [inline]
usb_forced_unbind_intf+0x128/0x1f4 drivers/usb/core/driver.c:1118
usb_reset_device+0x38c/0x9a0 drivers/usb/core/hub.c:6125
carl9170_usb_probe+0x5c/0x9d0 drivers/net/wireless/ath/carl9170/usb.c:1044
usb_probe_interface+0x500/0x984 drivers/usb/core/driver.c:396
really_probe+0x394/0xacc drivers/base/dd.c:639
__driver_probe_device+0x1bc/0x3f8 drivers/base/dd.c:778
driver_probe_device+0x78/0x330 drivers/base/dd.c:808
__device_attach_driver+0x2a8/0x4f4 drivers/base/dd.c:936
bus_for_each_drv+0x158/0x1e0 drivers/base/bus.c:427
__device_attach+0x2f0/0x480 drivers/base/dd.c:1008
device_initial_probe+0x24/0x34 drivers/base/dd.c:1057
bus_probe_device+0xbc/0x1c8 drivers/base/bus.c:487
device_add+0xae0/0xef4 drivers/base/core.c:3664
usb_set_configuration+0x15c0/0x1b40 drivers/usb/core/message.c:2170
usb_generic_driver_probe+0x8c/0x148 drivers/usb/core/generic.c:238
usb_probe_device+0x120/0x25c drivers/usb/core/driver.c:293
really_probe+0x394/0xacc drivers/base/dd.c:639
__driver_probe_device+0x1bc/0x3f8 drivers/base/dd.c:778
driver_probe_device+0x78/0x330 drivers/base/dd.c:808
__device_attach_driver+0x2a8/0x4f4 drivers/base/dd.c:936
bus_for_each_drv+0x158/0x1e0 drivers/base/bus.c:427
__device_attach+0x2f0/0x480 drivers/base/dd.c:1008
device_initial_probe+0x24/0x34 drivers/base/dd.c:1057
bus_probe_device+0xbc/0x1c8 drivers/base/bus.c:487
device_add+0xae0/0xef4 drivers/base/core.c:3664
usb_new_device+0x904/0x142c drivers/usb/core/hub.c:2575
hub_port_connect drivers/usb/core/hub.c:5355 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5499 [inline]
port_event drivers/usb/core/hub.c:5655 [inline]
hub_event+0x23dc/0x44a0 drivers/usb/core/hub.c:5737
process_one_work+0x7ac/0x1404 kernel/workqueue.c:2289
worker_thread+0x8e4/0xfec kernel/workqueue.c:2436
kthread+0x24c/0x2d4 kernel/kthread.c:376
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860
irq event stamp: 198838
hardirqs last enabled at (198837): [<ffff800008341e60>] __up_console_sem+0xb4/0x100 kernel/printk/printk.c:261
hardirqs last disabled at (198838): [<ffff8000120d55ec>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:405
softirqs last enabled at (195164): [<ffff800008020d74>] softirq_handle_end kernel/softirq.c:414 [inline]
softirqs last enabled at (195164): [<ffff800008020d74>] __do_softirq+0xc14/0xea0 kernel/softirq.c:600
softirqs last disabled at (195155): [<ffff80000802a948>] ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:79
---[ end trace 0000000000000000 ]---
usb 1-1: reset full-speed USB device number 2 using dummy_hcd
carl9170: probe of 1-1:0.24 failed with error -115
usb 1-1: Direct firmware load for carl9170-1.fw failed with error -2
usb 1-1: Falling back to sysfs fallback for: carl9170-1.fw


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: c957cbb87315 Linux 5.15.105
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1432762ec80000
kernel config: https://syzkaller.appspot.com/x/.config?x=852dc3de44ba1f3f
dashboard link: https://syzkaller.appspot.com/bug?extid=2a236bd2ff7884f06afd

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=142863cdc80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1029af15c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/91d0cf1fc5fb/disk-c957cbb8.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/346dc1169521/vmlinux-c957cbb8.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f7005bdc0e20/Image-c957cbb8.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+2a236b...@syzkaller.appspotmail.com

------------[ cut here ]------------
usb 1-1: BOGUS urb xfer, pipe 1 != type 3

WARNING: CPU: 0 PID: 1953 at drivers/usb/core/urb.c:503 usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:502
Modules linked in:
CPU: 0 PID: 1953 Comm: kworker/0:2 Not tainted 5.15.105-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: usb_hub_wq hub_event
pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)

pc : usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:502
lr : usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:502
sp : ffff8000222d6770
x29: ffff8000222d67b0 x28: 0000000000000001 x27: ffff800012b080a8
x26: ffff0000c2b91f00 x25: ffff0000c0e04000 x24: 0000000000000040
x23: ffff800012b0e8c0 x22: dfff800000000000 x21: 0000000000000002
x20: 0000000000000a20 x19: ffff0000c085d400 x18: 0000000000000001
x17: ff808000083336c4 x16: ffff80001193f6fc x15: ffff8000083336c4
x14: 00000000ffffffff x13: ffffffffffffffff x12: 0000000000000000
x11: ff8080000832b16c x10: 0000000000000000 x9 : 9d5992e197ca5500
x8 : 9d5992e197ca5500 x7 : 0000000000000001 x6 : 0000000000000001
x5 : ffff8000222d5ed8 x4 : ffff80001499f940 x3 : ffff800008549b3c
x2 : 0000000000000001 x1 : 0000000100000000 x0 : 0000000000000029
Call trace:
usb_submit_urb+0xa44/0x1588 drivers/usb/core/urb.c:502
carl9170_usb_submit_cmd_urb+0x7c/0x204 drivers/net/wireless/ath/carl9170/usb.c:229

__carl9170_exec_cmd+0x2b0/0x40c drivers/net/wireless/ath/carl9170/usb.c:643
carl9170_reboot+0xa4/0xf0 drivers/net/wireless/ath/carl9170/cmd.c:141
carl9170_usb_disconnect+0x90/0x144 drivers/net/wireless/ath/carl9170/usb.c:1116
usb_unbind_interface+0x1a4/0x758 drivers/usb/core/driver.c:458

__device_release_driver drivers/base/dd.c:1224 [inline]
device_release_driver_internal+0x464/0x6ac drivers/base/dd.c:1257
device_release_driver+0x28/0x38 drivers/base/dd.c:1280
usb_driver_release_interface drivers/usb/core/driver.c:627 [inline]
usb_forced_unbind_intf+0x128/0x1f4 drivers/usb/core/driver.c:1117
usb_reset_device+0x38c/0x9a0 drivers/usb/core/hub.c:6130

carl9170_usb_probe+0x5c/0x9d0 drivers/net/wireless/ath/carl9170/usb.c:1044
usb_probe_interface+0x500/0x984 drivers/usb/core/driver.c:396

really_probe+0x26c/0xaec drivers/base/dd.c:595
__driver_probe_device+0x1bc/0x3f8 drivers/base/dd.c:750
driver_probe_device+0x78/0x34c drivers/base/dd.c:780
__device_attach_driver+0x28c/0x4d8 drivers/base/dd.c:902
bus_for_each_drv+0x158/0x1e0 drivers/base/bus.c:427
__device_attach+0x2f0/0x480 drivers/base/dd.c:974
device_initial_probe+0x24/0x34 drivers/base/dd.c:1023
bus_probe_device+0xbc/0x1c8 drivers/base/bus.c:487
device_add+0xae0/0xef4 drivers/base/core.c:3394
usb_set_configuration+0x15e0/0x1b60 drivers/usb/core/message.c:2170

usb_generic_driver_probe+0x8c/0x148 drivers/usb/core/generic.c:238
usb_probe_device+0x120/0x25c drivers/usb/core/driver.c:293

really_probe+0x26c/0xaec drivers/base/dd.c:595
__driver_probe_device+0x1bc/0x3f8 drivers/base/dd.c:750
driver_probe_device+0x78/0x34c drivers/base/dd.c:780
__device_attach_driver+0x28c/0x4d8 drivers/base/dd.c:902
bus_for_each_drv+0x158/0x1e0 drivers/base/bus.c:427
__device_attach+0x2f0/0x480 drivers/base/dd.c:974
device_initial_probe+0x24/0x34 drivers/base/dd.c:1023
bus_probe_device+0xbc/0x1c8 drivers/base/bus.c:487
device_add+0xae0/0xef4 drivers/base/core.c:3394
usb_new_device+0x8fc/0x1448 drivers/usb/core/hub.c:2568
hub_port_connect drivers/usb/core/hub.c:5358 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5502 [inline]
port_event drivers/usb/core/hub.c:5648 [inline]
hub_event+0x22e4/0x48c4 drivers/usb/core/hub.c:5730
process_one_work+0x790/0x11b8 kernel/workqueue.c:2306
worker_thread+0x910/0x1034 kernel/workqueue.c:2453
kthread+0x37c/0x45c kernel/kthread.c:319
ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:870
irq event stamp: 80914
hardirqs last enabled at (80913): [<ffff800008329304>] __up_console_sem+0xb4/0x100 kernel/printk/printk.c:257
hardirqs last disabled at (80914): [<ffff80001193ad90>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:387
softirqs last enabled at (77952): [<ffff800008020ccc>] softirq_handle_end kernel/softirq.c:401 [inline]
softirqs last enabled at (77952): [<ffff800008020ccc>] __do_softirq+0xb5c/0xe20 kernel/softirq.c:587
softirqs last disabled at (77939): [<ffff8000081b4ee0>] do_softirq_own_stack include/asm-generic/softirq_stack.h:10 [inline]
softirqs last disabled at (77939): [<ffff8000081b4ee0>] invoke_softirq kernel/softirq.c:439 [inline]
softirqs last disabled at (77939): [<ffff8000081b4ee0>] __irq_exit_rcu+0x28c/0x534 kernel/softirq.c:636
---[ end trace bd6ef75e051de5db ]---