general protection fault in gfs2_ri_update

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 015e94d0 Linux 4.19.146
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10ccd887900000
kernel config: https://syzkaller.appspot.com/x/.config?x=243dd74ad58a8a57
dashboard link: https://syzkaller.appspot.com/bug?extid=c975a9ffb1906ee59b93
compiler: gcc (GCC) 10.1.0-syz 20200507

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c975a9...@syzkaller.appspotmail.com

gfs2: fsid=syz:syz.0: jid=0: Looking at journal...
gfs2: fsid=syz:syz.0: jid=0: Done
gfs2: fsid=syz:syz.0: first mount done, others may mount
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 1 PID: 23685 Comm: syz-executor.4 Not tainted 4.19.146-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:set_rgrp_preferences fs/gfs2/rgrp.c:984 [inline]
RIP: 0010:gfs2_ri_update+0x289/0x520 fs/gfs2/rgrp.c:1012
Code: e0 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 e8 7c 19 45 fe 49 8d 7f 74 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 68
RSP: 0018:ffff88803ee07638 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffc9000e3a0000
RDX: 000000000000000e RSI: ffffffff832ca964 RDI: 0000000000000074
RBP: ffff888055a34f00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000005 R11: 0000000000000001 R12: 0000000000000001
R13: 0000000000000000 R14: ffff888055a34efc R15: 0000000000000000
FS: 00007f884c789700(0000) GS:ffff8880ae300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b31226000 CR3: 0000000087fcb000 CR4: 00000000001426e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
gfs2_rindex_update+0x3ba/0x430 fs/gfs2/rgrp.c:1052
init_inodes+0x10cb/0x1ee0 fs/gfs2/ops_fstype.c:815
fill_super+0x190e/0x2680 fs/gfs2/ops_fstype.c:1149
gfs2_mount+0x4c0/0x598 fs/gfs2/ops_fstype.c:1312
mount_fs+0xa3/0x318 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2469 [inline]
do_mount+0x51c/0x2f10 fs/namespace.c:2799
ksys_mount+0xcf/0x130 fs/namespace.c:3015
__do_sys_mount fs/namespace.c:3029 [inline]
__se_sys_mount fs/namespace.c:3026 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3026
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x460bca
Code: b8 a6 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 dd 87 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 ba 87 fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007f884c788a88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f884c788b20 RCX: 0000000000460bca
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007f884c788ae0
RBP: 00007f884c788ae0 R08: 00007f884c788b20 R09: 0000000020000000
R10: 0000000000000000 R11: 0000000000000202 R12: 0000000020000000
R13: 0000000020000100 R14: 0000000020000200 R15: 0000000020047a20
Modules linked in:
---[ end trace f81c6f103b7fb003 ]---
RIP: 0010:set_rgrp_preferences fs/gfs2/rgrp.c:984 [inline]
RIP: 0010:gfs2_ri_update+0x289/0x520 fs/gfs2/rgrp.c:1012
Code: e0 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 e8 7c 19 45 fe 49 8d 7f 74 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 68
RSP: 0018:ffff88803ee07638 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffc9000e3a0000
RDX: 000000000000000e RSI: ffffffff832ca964 RDI: 0000000000000074
RBP: ffff888055a34f00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000005 R11: 0000000000000001 R12: 0000000000000001
R13: 0000000000000000 R14: ffff888055a34efc R15: 0000000000000000
FS: 00007f884c789700(0000) GS:ffff8880ae300000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055c7e7842970 CR3: 0000000087fcb000 CR4: 00000000001426e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: a1b977b4 Linux 4.19.150
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=138184cf900000
kernel config: https://syzkaller.appspot.com/x/.config?x=c14008c8da1ca4d4

dashboard link: https://syzkaller.appspot.com/bug?extid=c975a9ffb1906ee59b93
compiler: gcc (GCC) 10.1.0-syz 20200507

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=122bfd9f900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=146c474f900000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c975a9...@syzkaller.appspotmail.com

gfs2: fsid=syz:syz.0: jid=0: Looking at journal...
gfs2: fsid=syz:syz.0: jid=0: Done
gfs2: fsid=syz:syz.0: first mount done, others may mount
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN

CPU: 0 PID: 6499 Comm: syz-executor384 Not tainted 4.19.150-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:set_rgrp_preferences fs/gfs2/rgrp.c:984 [inline]
RIP: 0010:gfs2_ri_update+0x289/0x520 fs/gfs2/rgrp.c:1012

Code: e0 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 e8 bc f9 44 fe 49 8d 7f 74 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 68
RSP: 0018:ffff888084b67638 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff832cd73b
RDX: 000000000000000e RSI: ffffffff832cd8a4 RDI: 0000000000000074
RBP: ffff88808ccd1440 R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000005 R11: 0000000000000001 R12: 0000000000000001

R13: 0000000000000000 R14: ffff88808ccd143c R15: 0000000000000000
FS: 0000000001335880(0000) GS:ffff8880ae200000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f7d4d6b4740 CR3: 0000000096198000 CR4: 00000000001406f0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
gfs2_rindex_update+0x3ba/0x430 fs/gfs2/rgrp.c:1052
init_inodes+0x10cb/0x1ee0 fs/gfs2/ops_fstype.c:815
fill_super+0x190e/0x2680 fs/gfs2/ops_fstype.c:1149
gfs2_mount+0x4c0/0x598 fs/gfs2/ops_fstype.c:1312
mount_fs+0xa3/0x318 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2469 [inline]
do_mount+0x51c/0x2f10 fs/namespace.c:2799
ksys_mount+0xcf/0x130 fs/namespace.c:3015
__do_sys_mount fs/namespace.c:3029 [inline]
__se_sys_mount fs/namespace.c:3026 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3026
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

RIP: 0033:0x45b73a
Code: b8 08 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 fd ad fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 da ad fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007fff7ff01d28 EFLAGS: 00000293 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fff7ff01d80 RCX: 000000000045b73a
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007fff7ff01d40
RBP: 00007fff7ff01d40 R08: 00007fff7ff01d80 R09: 00007fff00000015
R10: 0000000000000000 R11: 0000000000000293 R12: 000000000000091c
R13: 0000000000000004 R14: 0000000000000003 R15: 0000000000000003
Modules linked in:
---[ end trace b661299dace97eec ]---

RIP: 0010:set_rgrp_preferences fs/gfs2/rgrp.c:984 [inline]
RIP: 0010:gfs2_ri_update+0x289/0x520 fs/gfs2/rgrp.c:1012

Code: e0 48 83 c4 18 5b 5d 41 5c 41 5d 41 5e 41 5f c3 e8 bc f9 44 fe 49 8d 7f 74 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 14 02 48 89 f8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 68
RSP: 0018:ffff888084b67638 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff832cd73b
RDX: 000000000000000e RSI: ffffffff832cd8a4 RDI: 0000000000000074
RBP: ffff88808ccd1440 R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000005 R11: 0000000000000001 R12: 0000000000000001

R13: 0000000000000000 R14: ffff88808ccd143c R15: 0000000000000000
FS: 0000000001335880(0000) GS:ffff8880ae200000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f7d4d6b4740 CR3: 0000000096198000 CR4: 00000000001406f0

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 6790f8b9370bf83c6733a537414c7ff7d989be30
Author: Bob Peterson <rpet...@redhat.com>
Date: Tue Nov 24 15:44:36 2020 +0000

gfs2: check for empty rgrp tree in gfs2_ri_update

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=158aef67500000
start commit: a1b977b4 Linux 4.19.150
git tree: linux-4.19.y

kernel config: https://syzkaller.appspot.com/x/.config?x=c14008c8da1ca4d4
dashboard link: https://syzkaller.appspot.com/bug?extid=c975a9ffb1906ee59b93

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=122bfd9f900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=146c474f900000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: gfs2: check for empty rgrp tree in gfs2_ri_update

For information about bisection process see: https://goo.gl/tpsmEJ#bisection