[v5.15] WARNING in hfsplus_cat_write_inode

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 8020ae3c051d Linux 5.15.103
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1240f17ec80000
kernel config: https://syzkaller.appspot.com/x/.config?x=d4215fb4040f8f8d
dashboard link: https://syzkaller.appspot.com/bug?extid=377f8341676334784aa6
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/857e17de0f0a/disk-8020ae3c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9efc49fcd441/vmlinux-8020ae3c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f14c38b6bfa7/bzImage-8020ae3c.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+377f83...@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 0 PID: 5753 at fs/hfsplus/inode.c:614 hfsplus_cat_write_inode+0xb2f/0x1000
Modules linked in:
CPU: 0 PID: 5753 Comm: kworker/u4:12 Not tainted 5.15.103-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: writeback wb_workfn (flush-7:1)
RIP: 0010:hfsplus_cat_write_inode+0xb2f/0x1000 fs/hfsplus/inode.c:614
Code: 00 0f 85 e8 04 00 00 44 89 f0 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 9d 8e 40 ff 0f 0b e9 d4 f7 ff ff e8 91 8e 40 ff <0f> 0b e9 85 fa ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c 0b f6 ff
RSP: 0018:ffffc90004b0f160 EFLAGS: 00010293
RAX: ffffffff823fea3f RBX: 0000000000000058 RCX: ffff88807d70d700
RDX: 0000000000000000 RSI: 0000000000000058 RDI: 00000000000000f8
RBP: ffffc90004b0f510 R08: ffffffff823fe4ba R09: ffffed100f0317c1
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff88807818be70
R13: dffffc0000000000 R14: ffffc90004b0f1c0 R15: ffffc90004b0f220
FS: 0000000000000000(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f7ad4f851b8 CR3: 000000002456b000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
write_inode fs/fs-writeback.c:1475 [inline]
__writeback_single_inode+0x808/0x1210 fs/fs-writeback.c:1680
writeback_sb_inodes+0xbd8/0x1ac0 fs/fs-writeback.c:1905
wb_writeback+0x4b8/0xeb0 fs/fs-writeback.c:2079
wb_do_writeback fs/fs-writeback.c:2222 [inline]
wb_workfn+0x49a/0x10e0 fs/fs-writeback.c:2263
process_one_work+0x90d/0x1270 kernel/workqueue.c:2306
worker_thread+0xaca/0x1280 kernel/workqueue.c:2453
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 8020ae3c051d Linux 5.15.103
git tree: linux-5.15.y

console output: https://syzkaller.appspot.com/x/log.txt?x=148ea3d6c80000

kernel config: https://syzkaller.appspot.com/x/.config?x=d4215fb4040f8f8d
dashboard link: https://syzkaller.appspot.com/bug?extid=377f8341676334784aa6
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10a3a27ec80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=118069f6c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/857e17de0f0a/disk-8020ae3c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9efc49fcd441/vmlinux-8020ae3c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f14c38b6bfa7/bzImage-8020ae3c.xz

mounted in repro: https://storage.googleapis.com/syzbot-assets/7a665b94b58e/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+377f83...@syzkaller.appspotmail.com

------------[ cut here ]------------

WARNING: CPU: 1 PID: 154 at fs/hfsplus/inode.c:614 hfsplus_cat_write_inode+0xb2f/0x1000
Modules linked in:
CPU: 0 PID: 154 Comm: kworker/u4:2 Not tainted 5.15.103-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023

Workqueue: writeback wb_workfn (flush-7:0)

RIP: 0010:hfsplus_cat_write_inode+0xb2f/0x1000 fs/hfsplus/inode.c:614
Code: 00 0f 85 e8 04 00 00 44 89 f0 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 9d 8e 40 ff 0f 0b e9 d4 f7 ff ff e8 91 8e 40 ff <0f> 0b e9 85 fa ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c 0b f6 ff

RSP: 0018:ffffc900010bf160 EFLAGS: 00010293
RAX: ffffffff823fea3f RBX: 0000000000000058 RCX: ffff88801619ba00

RDX: 0000000000000000 RSI: 0000000000000058 RDI: 00000000000000f8

RBP: ffffc900010bf510 R08: ffffffff823fe4ba R09: ffffed1003f112b1
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff88801f8895f0
R13: dffffc0000000000 R14: ffffc900010bf1c0 R15: ffffc900010bf220
FS: 0000000000000000(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00007f7e68611418 CR3: 000000001ab9d000 CR4: 00000000003506e0

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17a398f5c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=b49b0405a60858ed
dashboard link: https://syzkaller.appspot.com/bug?extid=f38e4d4c584d28d53c86

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ed3d1f3e75e6/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/6d8e44c8c75c/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cebe803ea4fa/bzImage-e3a87a10.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+f38e4d...@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 1 PID: 9 at fs/hfsplus/inode.c:616 hfsplus_cat_write_inode+0xb2f/0x1000
Modules linked in:
CPU: 1 PID: 9 Comm: kworker/u4:0 Not tainted 6.1.21-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023

Workqueue: writeback wb_workfn (flush-7:5)
RIP: 0010:hfsplus_cat_write_inode+0xb2f/0x1000 fs/hfsplus/inode.c:616
Code: 00 0f 85 e8 04 00 00 44 89 f0 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 7d 39 2e ff 0f 0b e9 d4 f7 ff ff e8 71 39 2e ff <0f> 0b e9 85 fa ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c 0b f6 ff
RSP: 0018:ffffc900000e7140 EFLAGS: 00010293
RAX: ffffffff825b4e6f RBX: 0000000000000058 RCX: ffff88813fe60000

RDX: 0000000000000000 RSI: 0000000000000058 RDI: 00000000000000f8

RBP: ffffc900000e74f0 R08: ffffffff825b48ea R09: ffffed100e9e5539
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff888074f2aa30
R13: dffffc0000000000 R14: ffffc900000e71a0 R15: ffffc900000e7200
FS: 0000000000000000(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000000020000340 CR3: 000000007eca6000 CR4: 00000000003506e0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>

write_inode fs/fs-writeback.c:1440 [inline]
__writeback_single_inode+0x67d/0x11e0 fs/fs-writeback.c:1652
writeback_sb_inodes+0xc21/0x1ac0 fs/fs-writeback.c:1878
wb_writeback+0x49d/0xe10 fs/fs-writeback.c:2052
wb_do_writeback fs/fs-writeback.c:2195 [inline]
wb_workfn+0x427/0x1020 fs/fs-writeback.c:2235
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2289
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436
kthread+0x268/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y

console output: https://syzkaller.appspot.com/x/log.txt?x=1243561ec80000

kernel config: https://syzkaller.appspot.com/x/.config?x=b49b0405a60858ed
dashboard link: https://syzkaller.appspot.com/bug?extid=f38e4d4c584d28d53c86
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=103930b6c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=103614f5c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ed3d1f3e75e6/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/6d8e44c8c75c/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cebe803ea4fa/bzImage-e3a87a10.xz

mounted in repro: https://storage.googleapis.com/syzbot-assets/0a70286d310a/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+f38e4d...@syzkaller.appspotmail.com

------------[ cut here ]------------

WARNING: CPU: 0 PID: 41 at fs/hfsplus/inode.c:616 hfsplus_cat_write_inode+0xb2f/0x1000
Modules linked in:
CPU: 0 PID: 41 Comm: kworker/u4:2 Not tainted 6.1.21-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023

Workqueue: writeback wb_workfn (flush-7:0)

RIP: 0010:hfsplus_cat_write_inode+0xb2f/0x1000 fs/hfsplus/inode.c:616
Code: 00 0f 85 e8 04 00 00 44 89 f0 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 e8 7d 39 2e ff 0f 0b e9 d4 f7 ff ff e8 71 39 2e ff <0f> 0b e9 85 fa ff ff 89 d9 80 e1 07 80 c1 03 38 c1 0f 8c 0b f6 ff

RSP: 0018:ffffc90000b27140 EFLAGS: 00010293
RAX: ffffffff825b4e6f RBX: 0000000000000058 RCX: ffff888018039d40

RDX: 0000000000000000 RSI: 0000000000000058 RDI: 00000000000000f8

RBP: ffffc90000b274f0 R08: ffffffff825b48ea R09: ffffed1004485539
R10: 0000000000000000 R11: dffffc0000000001 R12: ffff88802242aa30
R13: dffffc0000000000 R14: ffffc90000b271a0 R15: ffffc90000b27200
FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 0000563af3287e78 CR3: 000000001d347000 CR4: 00000000003506f0

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 37cab61a52d6f42b2d961c51bcf369f09e235fb5
Author: Tetsuo Handa <penguin...@I-love.SAKURA.ne.jp>
Date: Tue Apr 11 10:57:33 2023 +0000

fs: hfsplus: remove WARN_ON() from hfsplus_cat_{read,write}_inode()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1053abf3280000
start commit: 9d6bde853685 Linux 5.15.112
git tree: linux-5.15.y
kernel config: https://syzkaller.appspot.com/x/.config?x=a61e8195d8bdf36e
dashboard link: https://syzkaller.appspot.com/bug?extid=377f8341676334784aa6
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13c9f96a280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12d3ae72280000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: fs: hfsplus: remove WARN_ON() from hfsplus_cat_{read,write}_inode()

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 48960a503fcec76d3f72347b7e679dda08ca43be

Author: Tetsuo Handa <penguin...@I-love.SAKURA.ne.jp>
Date: Tue Apr 11 10:57:33 2023 +0000

fs: hfsplus: remove WARN_ON() from hfsplus_cat_{read,write}_inode()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=154615c0a80000
start commit: fa74641fb6b9 Linux 6.1.29
git tree: linux-6.1.y
kernel config: https://syzkaller.appspot.com/x/.config?x=fac5c36c2b16009f
dashboard link: https://syzkaller.appspot.com/bug?extid=f38e4d4c584d28d53c86
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17a2c039280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15d5fb41280000