KASAN: use-after-free Read in hfsplus_releasepage

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=13bdbf8d880000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=c2525802c4ad747ace2a
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=126a547b880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13e8d8d5880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/7bb411785c7d/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+c25258...@syzkaller.appspotmail.com

IPVS: ftp: loaded support on port[0] = 21
==================================================================
BUG: KASAN: use-after-free in hfsplus_releasepage+0x4bc/0x540 fs/hfsplus/inode.c:91
Read of size 4 at addr ffff8880b33f0ab8 by task syz-executor537/8098

CPU: 0 PID: 8098 Comm: syz-executor537 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_address_description.cold+0x54/0x219 mm/kasan/report.c:256
kasan_report_error.cold+0x8a/0x1b9 mm/kasan/report.c:354
kasan_report mm/kasan/report.c:412 [inline]
__asan_report_load4_noabort+0x88/0x90 mm/kasan/report.c:432
hfsplus_releasepage+0x4bc/0x540 fs/hfsplus/inode.c:91
try_to_release_page+0x242/0x390 mm/filemap.c:3358
block_invalidatepage+0x45b/0x4f0 fs/buffer.c:1511
do_invalidatepage mm/truncate.c:165 [inline]
truncate_cleanup_page+0x2b7/0x430 mm/truncate.c:184
truncate_inode_pages_range+0x528/0x1b00 mm/truncate.c:364
hfsplus_evict_inode+0x16/0xd0 fs/hfsplus/super.c:167
evict+0x2ed/0x760 fs/inode.c:559
iput_final fs/inode.c:1555 [inline]
iput+0x4f1/0x860 fs/inode.c:1581
hfsplus_put_super+0x270/0x3f0 fs/hfsplus/super.c:301
generic_shutdown_super+0x144/0x370 fs/super.c:456
kill_block_super+0x97/0xf0 fs/super.c:1185
deactivate_locked_super+0x94/0x160 fs/super.c:329
deactivate_super+0x174/0x1a0 fs/super.c:360
cleanup_mnt+0x1a8/0x290 fs/namespace.c:1098
task_work_run+0x148/0x1c0 kernel/task_work.c:113
exit_task_work include/linux/task_work.h:22 [inline]
do_exit+0xbf3/0x2be0 kernel/exit.c:870
do_group_exit+0x125/0x310 kernel/exit.c:967
__do_sys_exit_group kernel/exit.c:978 [inline]
__se_sys_exit_group kernel/exit.c:976 [inline]
__x64_sys_exit_group+0x3a/0x50 kernel/exit.c:976
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7fc0a619c9a9
Code: Bad RIP value.
RSP: 002b:00007ffe06821d78 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00007fc0a6212330 RCX: 00007fc0a619c9a9
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001
RBP: 0000000000000001 R08: ffffffffffffffc0 R09: 00000000000005f2
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fc0a6212330
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001

Allocated by task 8098:
kmem_cache_alloc_trace+0x12f/0x380 mm/slab.c:3625
kmalloc include/linux/slab.h:515 [inline]
kzalloc include/linux/slab.h:709 [inline]
hfsplus_btree_open+0x4d/0x10a0 fs/hfsplus/btree.c:142
hfsplus_fill_super+0xa2d/0x19e0 fs/hfsplus/super.c:473
mount_bdev+0x2fc/0x3b0 fs/super.c:1158
mount_fs+0xa3/0x310 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2492 [inline]
do_mount+0x115c/0x2f50 fs/namespace.c:2822
ksys_mount+0xcf/0x130 fs/namespace.c:3038
__do_sys_mount fs/namespace.c:3052 [inline]
__se_sys_mount fs/namespace.c:3049 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3049
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 8098:
__cache_free mm/slab.c:3503 [inline]
kfree+0xcc/0x210 mm/slab.c:3822
hfsplus_btree_close+0x1a6/0x300 fs/hfsplus/btree.c:279
hfsplus_put_super+0x220/0x3f0 fs/hfsplus/super.c:299
generic_shutdown_super+0x144/0x370 fs/super.c:456
kill_block_super+0x97/0xf0 fs/super.c:1185
deactivate_locked_super+0x94/0x160 fs/super.c:329
deactivate_super+0x174/0x1a0 fs/super.c:360
cleanup_mnt+0x1a8/0x290 fs/namespace.c:1098
task_work_run+0x148/0x1c0 kernel/task_work.c:113
exit_task_work include/linux/task_work.h:22 [inline]
do_exit+0xbf3/0x2be0 kernel/exit.c:870
do_group_exit+0x125/0x310 kernel/exit.c:967
__do_sys_exit_group kernel/exit.c:978 [inline]
__se_sys_exit_group kernel/exit.c:976 [inline]
__x64_sys_exit_group+0x3a/0x50 kernel/exit.c:976
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8880b33f0a80
which belongs to the cache kmalloc-4096 of size 4096
The buggy address is located 56 bytes inside of
4096-byte region [ffff8880b33f0a80, ffff8880b33f1a80)
The buggy address belongs to the page:
page:ffffea0002ccfc00 count:1 mapcount:0 mapping:ffff88813bff0dc0 index:0x0 compound_mapcount: 0
flags: 0xfff00000008100(slab|head)
raw: 00fff00000008100 ffffea0002cb9188 ffffea0002cc3c88 ffff88813bff0dc0
raw: 0000000000000000 ffff8880b33f0a80 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8880b33f0980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff8880b33f0a00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff8880b33f0a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8880b33f0b00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8880b33f0b80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 179ef7fe8677 Linux 4.14.300
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12d887f3880000
kernel config: https://syzkaller.appspot.com/x/.config?x=aa85f51ec321d5a9
dashboard link: https://syzkaller.appspot.com/bug?extid=220d2620d5b7f20282e4

compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1359f51d880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11efc77b880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d311ef57b59a/disk-179ef7fe.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/25bf5d729f69/vmlinux-179ef7fe.xz
kernel image: https://storage.googleapis.com/syzbot-assets/db9b96571e69/bzImage-179ef7fe.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/d2990d0a4913/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+220d26...@syzkaller.appspotmail.com

IPVS: ftp: loaded support on port[0] = 21
==================================================================

BUG: KASAN: use-after-free in hfsplus_releasepage+0x457/0x4e0 fs/hfsplus/inode.c:92
Read of size 4 at addr ffff8880b36f8cb8 by task syz-executor216/7979

CPU: 0 PID: 7979 Comm: syz-executor216 Not tainted 4.14.300-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:

__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x281 lib/dump_stack.c:58
print_address_description.cold+0x54/0x1d3 mm/kasan/report.c:252
kasan_report_error.cold+0x8a/0x191 mm/kasan/report.c:351
kasan_report mm/kasan/report.c:409 [inline]
__asan_report_load4_noabort+0x68/0x70 mm/kasan/report.c:429
hfsplus_releasepage+0x457/0x4e0 fs/hfsplus/inode.c:92
try_to_release_page+0x143/0x1e0 mm/filemap.c:3243
block_invalidatepage+0x258/0x2f0 fs/buffer.c:1573
do_invalidatepage mm/truncate.c:124 [inline]
truncate_complete_page mm/truncate.c:144 [inline]
truncate_inode_page+0x212/0x2f0 mm/truncate.c:192
truncate_inode_pages_range+0x1e0/0x13e0 mm/truncate.c:316
hfsplus_evict_inode+0x16/0xc0 fs/hfsplus/super.c:167
evict+0x2c8/0x700 fs/inode.c:554
iput_final fs/inode.c:1523 [inline]
iput+0x458/0x7e0 fs/inode.c:1550
hfsplus_put_super+0x258/0x3d0 fs/hfsplus/super.c:301
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
exit_task_work include/linux/task_work.h:22 [inline]
do_exit+0xa44/0x2850 kernel/exit.c:868
do_group_exit+0x100/0x2e0 kernel/exit.c:965
SYSC_exit_group kernel/exit.c:976 [inline]
SyS_exit_group+0x19/0x20 kernel/exit.c:974
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3

Allocated by task 7979:
save_stack mm/kasan/kasan.c:447 [inline]
set_track mm/kasan/kasan.c:459 [inline]
kasan_kmalloc+0xeb/0x160 mm/kasan/kasan.c:551
kmem_cache_alloc_trace+0x131/0x3d0 mm/slab.c:3618
kmalloc include/linux/slab.h:488 [inline]
kzalloc include/linux/slab.h:661 [inline]
hfsplus_btree_open+0x4d/0xff0 fs/hfsplus/btree.c:142
hfsplus_fill_super+0x9ce/0x1850 fs/hfsplus/super.c:473
mount_bdev+0x2b3/0x360 fs/super.c:1134
mount_fs+0x92/0x2a0 fs/super.c:1237
vfs_kern_mount.part.0+0x5b/0x470 fs/namespace.c:1046
vfs_kern_mount fs/namespace.c:1036 [inline]
do_new_mount fs/namespace.c:2572 [inline]
do_mount+0xe65/0x2a30 fs/namespace.c:2905
SYSC_mount fs/namespace.c:3121 [inline]
SyS_mount+0xa8/0x120 fs/namespace.c:3098
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3

Freed by task 7979:
save_stack mm/kasan/kasan.c:447 [inline]
set_track mm/kasan/kasan.c:459 [inline]
kasan_slab_free+0xc3/0x1a0 mm/kasan/kasan.c:524
__cache_free mm/slab.c:3496 [inline]
kfree+0xc9/0x250 mm/slab.c:3815
hfsplus_btree_close+0x152/0x1d0 fs/hfsplus/btree.c:279
hfsplus_put_super+0x208/0x3d0 fs/hfsplus/super.c:299
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
exit_task_work include/linux/task_work.h:22 [inline]
do_exit+0xa44/0x2850 kernel/exit.c:868
do_group_exit+0x100/0x2e0 kernel/exit.c:965
SYSC_exit_group kernel/exit.c:976 [inline]
SyS_exit_group+0x19/0x20 kernel/exit.c:974
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3

The buggy address belongs to the object at ffff8880b36f8c80

which belongs to the cache kmalloc-4096 of size 4096
The buggy address is located 56 bytes inside of

4096-byte region [ffff8880b36f8c80, ffff8880b36f9c80)

The buggy address belongs to the page:

page:ffffea0002cdbe00 count:1 mapcount:0 mapping:ffff8880b36f8c80 index:0x0 compound_mapcount: 0
flags: 0xfff00000008100(slab|head)
raw: 00fff00000008100 ffff8880b36f8c80 0000000000000000 0000000100000001
raw: ffffea0002ce88a0 ffffea00028685a0 ffff88813fe74dc0 0000000000000000

page dumped because: kasan: bad access detected

Memory state around the buggy address:

ffff8880b36f8b80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff8880b36f8c00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff8880b36f8c80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff8880b36f8d00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff8880b36f8d80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb