KASAN: use-after-free Read in ntfs_read_locked_inode

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: cbfa1702 Linux 4.14.198
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15fed23d900000
kernel config: https://syzkaller.appspot.com/x/.config?x=3990958d85b55e59
dashboard link: https://syzkaller.appspot.com/bug?extid=002e6becd6fcd67332f2
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=160f08ad900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1391f08d900000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+002e6b...@syzkaller.appspotmail.com

ntfs: (device loop0): load_and_init_upcase(): Failed to load $UpCase from the volume. Using default.
ntfs: (device loop0): map_mft_record_page(): Mft record 0x4 is corrupt. Run chkdsk.
ntfs: (device loop0): map_mft_record(): Failed with error code 5.
==================================================================
BUG: KASAN: use-after-free in ntfs_read_locked_inode+0x425a/0x5000 fs/ntfs/inode.c:677
Read of size 8 at addr ffff88808093ee46 by task syz-executor267/6358

CPU: 1 PID: 6358 Comm: syz-executor267 Not tainted 4.14.198-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x283 lib/dump_stack.c:58
print_address_description.cold+0x54/0x1d3 mm/kasan/report.c:252
kasan_report_error.cold+0x8a/0x194 mm/kasan/report.c:351
kasan_report mm/kasan/report.c:409 [inline]
__asan_report_load_n_noabort+0x6b/0x80 mm/kasan/report.c:440
ntfs_read_locked_inode+0x425a/0x5000 fs/ntfs/inode.c:677
ntfs_iget+0xfa/0x130 fs/ntfs/inode.c:190
load_and_init_mft_mirror fs/ntfs/super.c:1041 [inline]
load_system_files fs/ntfs/super.c:1786 [inline]
ntfs_fill_super+0xa5a/0x7170 fs/ntfs/super.c:2908
mount_bdev+0x2b3/0x360 fs/super.c:1134
mount_fs+0x92/0x2a0 fs/super.c:1237
vfs_kern_mount.part.0+0x5b/0x470 fs/namespace.c:1046
vfs_kern_mount fs/namespace.c:1036 [inline]
do_new_mount fs/namespace.c:2549 [inline]
do_mount+0xe53/0x2a00 fs/namespace.c:2879
SYSC_mount fs/namespace.c:3095 [inline]
SyS_mount+0xa8/0x120 fs/namespace.c:3072
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x4494fa
RSP: 002b:00007ffdddd0a7a8 EFLAGS: 00000287 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffdddd0a800 RCX: 00000000004494fa
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007ffdddd0a7c0
RBP: 00007ffdddd0a7c0 R08: 00007ffdddd0a800 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000287 R12: 00000000000000ab
R13: 0000000000000004 R14: 0000000000000003 R15: 0000000000000003

The buggy address belongs to the page:
page:ffffea0002024f80 count:0 mapcount:0 mapping: (null) index:0x1
flags: 0xfffe0000000000()
raw: 00fffe0000000000 0000000000000000 0000000000000001 00000000ffffffff
raw: ffffea0002025320 ffffea00020e4aa0 0000000000000000 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff88808093ed00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88808093ed80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff88808093ee00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88808093ee80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88808093ef00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: d09b8017 Linux 4.19.147
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1114d71d900000
kernel config: https://syzkaller.appspot.com/x/.config?x=47cc70be3c316a0a
dashboard link: https://syzkaller.appspot.com/bug?extid=9016e2b4812b0bba3879

compiler: gcc (GCC) 10.1.0-syz 20200507

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=172eadc5900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1417c927900000

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+9016e2...@syzkaller.appspotmail.com

ntfs: (device loop0): map_mft_record_page(): Mft record 0x4 is corrupt. Run chkdsk.
ntfs: (device loop0): map_mft_record(): Failed with error code 5.
==================================================================

BUG: KASAN: use-after-free in ntfs_read_locked_inode+0x4731/0x5490 fs/ntfs/inode.c:670
Read of size 8 at addr ffff88808462be46 by task syz-executor886/6521

CPU: 1 PID: 6521 Comm: syz-executor886 Not tainted 4.19.147-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:

__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
print_address_description.cold+0x56/0x25c mm/kasan/report.c:256
kasan_report_error.cold+0x66/0xb9 mm/kasan/report.c:354
kasan_report mm/kasan/report.c:412 [inline]
__asan_report_load_n_noabort+0x8b/0xa0 mm/kasan/report.c:443
ntfs_read_locked_inode+0x4731/0x5490 fs/ntfs/inode.c:670
ntfs_iget+0x12d/0x180 fs/ntfs/inode.c:190

load_and_init_mft_mirror fs/ntfs/super.c:1041 [inline]
load_system_files fs/ntfs/super.c:1786 [inline]

ntfs_fill_super+0x1853/0x89d2 fs/ntfs/super.c:2908
mount_bdev+0x2fc/0x3b0 fs/super.c:1158
mount_fs+0xa3/0x318 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2469 [inline]
do_mount+0x51c/0x2f10 fs/namespace.c:2799
ksys_mount+0xcf/0x130 fs/namespace.c:3015
__do_sys_mount fs/namespace.c:3029 [inline]
__se_sys_mount fs/namespace.c:3026 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3026
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4494fa
Code: b8 08 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 7d a3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 5a a3 fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007ffd1f9e4678 EFLAGS: 00000287 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffd1f9e46d0 RCX: 00000000004494fa
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007ffd1f9e4690
RBP: 00007ffd1f9e4690 R08: 00007ffd1f9e46d0 R09: 0000000000000000

R10: 0000000000000000 R11: 0000000000000287 R12: 00000000000000ab
R13: 0000000000000004 R14: 0000000000000003 R15: 0000000000000003

The buggy address belongs to the page:

page:ffffea0002118ac0 count:0 mapcount:0 mapping:0000000000000000 index:0x1
flags: 0xfffe0000000000()
raw: 00fffe0000000000 ffffea0002290d48 ffffea00027b4f88 0000000000000000
raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000

page dumped because: kasan: bad access detected

Memory state around the buggy address:

ffff88808462bd00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88808462bd80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff88808462be00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88808462be80: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88808462bf00: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 49ee014a2070b209fd73ad96a7a36193dcdd149c
Author: Rustam Kovhaev <rkov...@gmail.com>
Date: Wed Feb 24 20:00:30 2021 +0000

ntfs: check for valid standard information attribute

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11978826d00000
start commit: cbfa1702 Linux 4.14.198
git tree: linux-4.14.y

kernel config: https://syzkaller.appspot.com/x/.config?x=3990958d85b55e59
dashboard link: https://syzkaller.appspot.com/bug?extid=002e6becd6fcd67332f2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=111f24a3900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1434eaeb900000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: ntfs: check for valid standard information attribute

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 23e895868b518f48eab7925aeb93aeeac3ac2594

Author: Rustam Kovhaev <rkov...@gmail.com>
Date: Wed Feb 24 20:00:30 2021 +0000

ntfs: check for valid standard information attribute

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1273e4aad00000
start commit: a1b977b4 Linux 4.19.150
git tree: linux-4.19.y
kernel config: https://syzkaller.appspot.com/x/.config?x=c14008c8da1ca4d4
dashboard link: https://syzkaller.appspot.com/bug?extid=9016e2b4812b0bba3879
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13166ca0500000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11ef9a78500000