[v5.15] KASAN: use-after-free Read in udf_sync_fs

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 471e639e59d1 Linux 5.15.117
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17a3ab27280000
kernel config: https://syzkaller.appspot.com/x/.config?x=6390289bcc1381aa
dashboard link: https://syzkaller.appspot.com/bug?extid=d8d08094ff268799bae7
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=134176ef280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17647b9b280000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/145b7f137d72/disk-471e639e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b5bd2fcb945c/vmlinux-471e639e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/794584032e0f/bzImage-471e639e.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/66634ba1bfac/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/05f0c4e80fda/mount_1.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+d8d080...@syzkaller.appspotmail.com

UDF-fs: error (device loop0): udf_read_tagged: tag version 0x0000 != 0x0002 || 0x0003, block 0
UDF-fs: warning (device loop0): udf_load_vrs: No anchor found
UDF-fs: Scanning with blocksize 512 failed
UDF-fs: INFO Mounting volume 'LinuxUDF', timestamp 2022/11/22 14:59 (1000)
==================================================================
BUG: KASAN: use-after-free in crc_itu_t+0x218/0x2a0 lib/crc-itu-t.c:60
Read of size 1 at addr ffff88807c5d2000 by task syz-executor172/3503

CPU: 1 PID: 3503 Comm: syz-executor172 Not tainted 5.15.117-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
print_address_description+0x63/0x3b0 mm/kasan/report.c:248
__kasan_report mm/kasan/report.c:434 [inline]
kasan_report+0x16b/0x1c0 mm/kasan/report.c:451
crc_itu_t+0x218/0x2a0 lib/crc-itu-t.c:60
udf_finalize_lvid fs/udf/super.c:2025 [inline]
udf_sync_fs+0x1ce/0x380 fs/udf/super.c:2381
sync_filesystem+0xe8/0x220 fs/sync.c:56
generic_shutdown_super+0x6e/0x2c0 fs/super.c:448
kill_block_super+0x7a/0xe0 fs/super.c:1405
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:164
exit_task_work include/linux/task_work.h:32 [inline]
do_exit+0x6a3/0x2480 kernel/exit.c:872
do_group_exit+0x144/0x310 kernel/exit.c:994
__do_sys_exit_group kernel/exit.c:1005 [inline]
__se_sys_exit_group kernel/exit.c:1003 [inline]
__x64_sys_exit_group+0x3b/0x40 kernel/exit.c:1003
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f72a51c0c59
Code: Unable to access opcode bytes at RIP 0x7f72a51c0c2f.
RSP: 002b:00007ffdecef4878 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00007f72a525a410 RCX: 00007f72a51c0c59
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000001
RBP: 0000000000000001 R08: ffffffffffffffc0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f72a525a410
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001
</TASK>

The buggy address belongs to the page:
page:ffffea0001f17480 refcount:0 mapcount:0 mapping:0000000000000000 index:0x1 pfn:0x7c5d2
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000000 ffffea0001c5eb08 ffffea0001ca9048 0000000000000000
raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed
page last allocated via order 0, migratetype Movable, gfp_mask 0x1100dca(GFP_HIGHUSER_MOVABLE|__GFP_ZERO), pid 3356, ts 42948810914, free_ts 43082729309
prep_new_page mm/page_alloc.c:2426 [inline]
get_page_from_freelist+0x322a/0x33c0 mm/page_alloc.c:4159
__alloc_pages+0x272/0x700 mm/page_alloc.c:5421
alloc_pages_vma+0x39a/0x800 mm/mempolicy.c:2146
do_anonymous_page mm/memory.c:3795 [inline]
handle_pte_fault mm/memory.c:4606 [inline]
__handle_mm_fault mm/memory.c:4743 [inline]
handle_mm_fault+0x2f49/0x5950 mm/memory.c:4841
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1340 [inline]
free_pcp_prepare mm/page_alloc.c:1391 [inline]
free_unref_page_prepare+0xc34/0xcf0 mm/page_alloc.c:3317
free_unref_page_list+0x1f7/0x8e0 mm/page_alloc.c:3433
release_pages+0x1bb9/0x1f40 mm/swap.c:963
tlb_batch_pages_flush mm/mmu_gather.c:49 [inline]
tlb_flush_mmu_free mm/mmu_gather.c:240 [inline]
tlb_flush_mmu mm/mmu_gather.c:247 [inline]
tlb_finish_mmu+0x177/0x320 mm/mmu_gather.c:338
unmap_region+0x304/0x350 mm/mmap.c:2668
__do_munmap+0x12db/0x1740 mm/mmap.c:2899
__vm_munmap+0x134/0x230 mm/mmap.c:2922
__do_sys_munmap mm/mmap.c:2948 [inline]
__se_sys_munmap mm/mmap.c:2944 [inline]
__x64_sys_munmap+0x67/0x70 mm/mmap.c:2944
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

Memory state around the buggy address:
ffff88807c5d1f00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff88807c5d1f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff88807c5d2000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88807c5d2080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88807c5d2100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to change bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: ca87e77a2ef8 Linux 6.1.34
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17bdb2df280000
kernel config: https://syzkaller.appspot.com/x/.config?x=c188e92022a334b
dashboard link: https://syzkaller.appspot.com/bug?extid=97957ab65c3db5758ee8

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=112b956b280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13d56897280000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f48d514c343c/disk-ca87e77a.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/563336f1f216/vmlinux-ca87e77a.xz
kernel image: https://storage.googleapis.com/syzbot-assets/2254afa3642b/bzImage-ca87e77a.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/309a18e16975/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/8c5f1a36871e/mount_3.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+97957a...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: use-after-free in crc_itu_t+0x218/0x2a0 lib/crc-itu-t.c:60

Read of size 1 at addr ffff88806fdca000 by task syz-executor277/3542

CPU: 0 PID: 3542 Comm: syz-executor277 Not tainted 6.1.34-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106

print_address_description mm/kasan/report.c:284 [inline]
print_report+0x15f/0x4f0 mm/kasan/report.c:395
kasan_report+0x136/0x160 mm/kasan/report.c:495
crc_itu_t+0x218/0x2a0 lib/crc-itu-t.c:60
udf_finalize_lvid fs/udf/super.c:2022 [inline]
udf_sync_fs+0x1ce/0x380 fs/udf/super.c:2378
sync_filesystem+0xe8/0x220 fs/sync.c:56
generic_shutdown_super+0x6b/0x340 fs/super.c:474
kill_block_super+0x7a/0xe0 fs/super.c:1450
deactivate_locked_super+0xa0/0x110 fs/super.c:332
cleanup_mnt+0x490/0x520 fs/namespace.c:1186
task_work_run+0x246/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:297
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7ff83ef6d177
Code: 09 00 48 83 c4 08 5b 5d c3 66 2e 0f 1f 84 00 00 00 00 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 a6 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffe9a06ad8 EFLAGS: 00000206 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007ff83ef6d177
RDX: 00007fffe9a06b99 RSI: 000000000000000a RDI: 00007fffe9a06b90
RBP: 00007fffe9a06b90 R08: 00000000ffffffff R09: 00007fffe9a06970
R10: 0000555557067683 R11: 0000000000000206 R12: 00007fffe9a07c00
R13: 00005555570675f0 R14: 00007fffe9a06b00 R15: 0000000000000001
</TASK>

The buggy address belongs to the physical page:
page:ffffea0001bf7280 refcount:0 mapcount:0 mapping:0000000000000000 index:0x1 pfn:0x6fdca
flags: 0xfff00000000000(node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000000000 ffffea0001bf72c8 ffffea0001c1dec8 0000000000000000

raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as freed

page last allocated via order 0, migratetype Movable, gfp_mask 0x140dca(GFP_HIGHUSER_MOVABLE|__GFP_COMP|__GFP_ZERO), pid 3534, tgid 3534 (sshd), ts 53823096621, free_ts 53888333213
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook+0x18d/0x1b0 mm/page_alloc.c:2533
prep_new_page mm/page_alloc.c:2540 [inline]
get_page_from_freelist+0x32ed/0x3480 mm/page_alloc.c:4292
__alloc_pages+0x28d/0x770 mm/page_alloc.c:5559
__folio_alloc+0xf/0x30 mm/page_alloc.c:5591
vma_alloc_folio+0x486/0x990 mm/mempolicy.c:2241
alloc_page_vma include/linux/gfp.h:284 [inline]
do_anonymous_page mm/memory.c:4123 [inline]
handle_pte_fault mm/memory.c:4962 [inline]
__handle_mm_fault mm/memory.c:5106 [inline]
handle_mm_fault+0x2e85/0x5330 mm/memory.c:5227
do_user_addr_fault arch/x86/mm/fault.c:1428 [inline]
handle_page_fault arch/x86/mm/fault.c:1519 [inline]
exc_page_fault+0x58d/0x790 arch/x86/mm/fault.c:1575
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570

page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]

free_pages_prepare mm/page_alloc.c:1460 [inline]
free_pcp_prepare mm/page_alloc.c:1510 [inline]
free_unref_page_prepare+0xf63/0x1120 mm/page_alloc.c:3388
free_unref_page_list+0x107/0x810 mm/page_alloc.c:3530
release_pages+0x2836/0x2b40 mm/swap.c:1055
tlb_batch_pages_flush mm/mmu_gather.c:59 [inline]
tlb_flush_mmu_free mm/mmu_gather.c:254 [inline]
tlb_flush_mmu+0xfc/0x210 mm/mmu_gather.c:261
tlb_finish_mmu+0xce/0x1f0 mm/mmu_gather.c:361
unmap_region+0x29f/0x2f0 mm/mmap.c:2229
do_mas_align_munmap+0xe98/0x15e0 mm/mmap.c:2482
do_mas_munmap+0x246/0x2b0 mm/mmap.c:2540
__vm_munmap+0x268/0x370 mm/mmap.c:2817
__do_sys_munmap mm/mmap.c:2842 [inline]
__se_sys_munmap mm/mmap.c:2839 [inline]
__x64_sys_munmap+0x5c/0x70 mm/mmap.c:2839

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:

ffff88806fdc9f00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff88806fdc9f80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>ffff88806fdca000: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88806fdca080: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88806fdca100: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff