[v6.1] possible deadlock in ext4_evict_inode
1 view
Skip to first unread message
syzbot
Mar 23, 2023, 9:38:45 PM3/23/23
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15c7a6b1c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=b49b0405a60858ed
dashboard link: https://syzkaller.appspot.com/bug?extid=ac8ae3af0f091d178924
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ed3d1f3e75e6/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/6d8e44c8c75c/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cebe803ea4fa/bzImage-e3a87a10.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ac8ae3...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.21-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/13331 is trying to acquire lock:
ffff88807ebdc650 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1832 [inline]
ffff88807ebdc650 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:1954 [inline]
ffff88807ebdc650 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240
but task is already holding lock:
ffff88807ebdeb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x314/0x12f0 fs/ext4/migrate.c:437
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
ext4_writepages+0x1e5/0x3de0 fs/ext4/inode.c:2701
do_writepages+0x3a2/0x670 mm/page-writeback.c:2469
filemap_fdatawrite_wbc+0x121/0x180 mm/filemap.c:388
__filemap_fdatawrite_range mm/filemap.c:421 [inline]
filemap_write_and_wait_range+0x1a4/0x290 mm/filemap.c:674
__iomap_dio_rw+0xb38/0x2240 fs/iomap/direct-io.c:573
iomap_dio_rw+0x42/0xa0 fs/iomap/direct-io.c:690
ext4_dio_read_iter fs/ext4/file.c:94 [inline]
ext4_file_read_iter+0x50b/0x660 fs/ext4/file.c:145
call_read_iter include/linux/fs.h:2199 [inline]
generic_file_splice_read+0x23c/0x630 fs/splice.c:309
do_splice_to fs/splice.c:793 [inline]
splice_direct_to_actor+0x408/0xbd0 fs/splice.c:865
do_splice_direct+0x27f/0x3c0 fs/splice.c:974
do_sendfile+0x61c/0xff0 fs/read_write.c:1255
__do_sys_sendfile64 fs/read_write.c:1323 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
down_read+0x39/0x50 kernel/locking/rwsem.c:1520
inode_lock_shared include/linux/fs.h:766 [inline]
ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3171
bmap+0xa1/0xd0 fs/inode.c:1798
jbd2_journal_bmap fs/jbd2/journal.c:977 [inline]
__jbd2_journal_erase fs/jbd2/journal.c:1789 [inline]
jbd2_journal_flush+0x5b5/0xc40 fs/jbd2/journal.c:2492
ext4_ioctl_checkpoint fs/ext4/ioctl.c:1083 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1591 [inline]
ext4_ioctl+0x39e0/0x5f70 fs/ext4/ioctl.c:1611
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
mutex_lock_io_nested+0x43/0x60 kernel/locking/mutex.c:833
__jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:110
add_transaction_credits+0x94c/0xc00 fs/jbd2/transaction.c:298
start_this_handle+0x747/0x1640 fs/jbd2/transaction.c:422
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
__ext4_journal_start_sb+0x19b/0x410 fs/ext4/ext4_jbd2.c:105
__ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline]
ext4_evict_inode+0x8dc/0x1150 fs/ext4/inode.c:251
evict+0x2a4/0x620 fs/inode.c:664
__dentry_kill+0x436/0x650 fs/dcache.c:607
dentry_kill+0xbb/0x290
dput+0x1ef/0x420 fs/dcache.c:913
__fput+0x5e4/0x890 fs/file_table.c:328
task_work_run+0x246/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:296
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (sb_internal){.+.+}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_intwrite include/linux/fs.h:1954 [inline]
ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240
evict+0x2a4/0x620 fs/inode.c:664
ext4_ext_migrate+0x100b/0x12f0 fs/ext4/migrate.c:587
__ext4_ioctl fs/ext4/ioctl.c:1393 [inline]
ext4_ioctl+0x1dea/0x5f70 fs/ext4/ioctl.c:1611
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
Chain exists of:
sb_internal --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->s_writepages_rwsem);
lock(&sb->s_type->i_mutex_key#8);
lock(&sbi->s_writepages_rwsem);
lock(sb_internal);
*** DEADLOCK ***
3 locks held by syz-executor.4/13331:
#0: ffff88807ebdc460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:437
#1: ffff8880816c2c20 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline]
#1: ffff8880816c2c20 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1392 [inline]
#1: ffff8880816c2c20 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_ioctl+0x1de2/0x5f70 fs/ext4/ioctl.c:1611
#2: ffff88807ebdeb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x314/0x12f0 fs/ext4/migrate.c:437
stack backtrace:
CPU: 1 PID: 13331 Comm: syz-executor.4 Not tainted 6.1.21-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_intwrite include/linux/fs.h:1954 [inline]
ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240
evict+0x2a4/0x620 fs/inode.c:664
ext4_ext_migrate+0x100b/0x12f0 fs/ext4/migrate.c:587
__ext4_ioctl fs/ext4/ioctl.c:1393 [inline]
ext4_ioctl+0x1dea/0x5f70 fs/ext4/ioctl.c:1611
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fefd5a8c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fefd6742168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fefd5bac050 RCX: 00007fefd5a8c0f9
RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000004
RBP: 00007fefd5ae7b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc9befffaf R14: 00007fefd6742300 R15: 0000000000022000
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following issue on:
HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15c7a6b1c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=b49b0405a60858ed
dashboard link: https://syzkaller.appspot.com/bug?extid=ac8ae3af0f091d178924
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/ed3d1f3e75e6/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/6d8e44c8c75c/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/cebe803ea4fa/bzImage-e3a87a10.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ac8ae3...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.21-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/13331 is trying to acquire lock:
ffff88807ebdc650 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1832 [inline]
ffff88807ebdc650 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:1954 [inline]
ffff88807ebdc650 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240
but task is already holding lock:
ffff88807ebdeb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x314/0x12f0 fs/ext4/migrate.c:437
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
ext4_writepages+0x1e5/0x3de0 fs/ext4/inode.c:2701
do_writepages+0x3a2/0x670 mm/page-writeback.c:2469
filemap_fdatawrite_wbc+0x121/0x180 mm/filemap.c:388
__filemap_fdatawrite_range mm/filemap.c:421 [inline]
filemap_write_and_wait_range+0x1a4/0x290 mm/filemap.c:674
__iomap_dio_rw+0xb38/0x2240 fs/iomap/direct-io.c:573
iomap_dio_rw+0x42/0xa0 fs/iomap/direct-io.c:690
ext4_dio_read_iter fs/ext4/file.c:94 [inline]
ext4_file_read_iter+0x50b/0x660 fs/ext4/file.c:145
call_read_iter include/linux/fs.h:2199 [inline]
generic_file_splice_read+0x23c/0x630 fs/splice.c:309
do_splice_to fs/splice.c:793 [inline]
splice_direct_to_actor+0x408/0xbd0 fs/splice.c:865
do_splice_direct+0x27f/0x3c0 fs/splice.c:974
do_sendfile+0x61c/0xff0 fs/read_write.c:1255
__do_sys_sendfile64 fs/read_write.c:1323 [inline]
__se_sys_sendfile64+0x178/0x1e0 fs/read_write.c:1309
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
down_read+0x39/0x50 kernel/locking/rwsem.c:1520
inode_lock_shared include/linux/fs.h:766 [inline]
ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3171
bmap+0xa1/0xd0 fs/inode.c:1798
jbd2_journal_bmap fs/jbd2/journal.c:977 [inline]
__jbd2_journal_erase fs/jbd2/journal.c:1789 [inline]
jbd2_journal_flush+0x5b5/0xc40 fs/jbd2/journal.c:2492
ext4_ioctl_checkpoint fs/ext4/ioctl.c:1083 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1591 [inline]
ext4_ioctl+0x39e0/0x5f70 fs/ext4/ioctl.c:1611
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
mutex_lock_io_nested+0x43/0x60 kernel/locking/mutex.c:833
__jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:110
add_transaction_credits+0x94c/0xc00 fs/jbd2/transaction.c:298
start_this_handle+0x747/0x1640 fs/jbd2/transaction.c:422
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520
__ext4_journal_start_sb+0x19b/0x410 fs/ext4/ext4_jbd2.c:105
__ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline]
ext4_evict_inode+0x8dc/0x1150 fs/ext4/inode.c:251
evict+0x2a4/0x620 fs/inode.c:664
__dentry_kill+0x436/0x650 fs/dcache.c:607
dentry_kill+0xbb/0x290
dput+0x1ef/0x420 fs/dcache.c:913
__fput+0x5e4/0x890 fs/file_table.c:328
task_work_run+0x246/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:203
__syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:296
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (sb_internal){.+.+}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_intwrite include/linux/fs.h:1954 [inline]
ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240
evict+0x2a4/0x620 fs/inode.c:664
ext4_ext_migrate+0x100b/0x12f0 fs/ext4/migrate.c:587
__ext4_ioctl fs/ext4/ioctl.c:1393 [inline]
ext4_ioctl+0x1dea/0x5f70 fs/ext4/ioctl.c:1611
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
other info that might help us debug this:
Chain exists of:
sb_internal --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->s_writepages_rwsem);
lock(&sb->s_type->i_mutex_key#8);
lock(&sbi->s_writepages_rwsem);
lock(sb_internal);
*** DEADLOCK ***
3 locks held by syz-executor.4/13331:
#0: ffff88807ebdc460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:437
#1: ffff8880816c2c20 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline]
#1: ffff8880816c2c20 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1392 [inline]
#1: ffff8880816c2c20 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_ioctl+0x1de2/0x5f70 fs/ext4/ioctl.c:1611
#2: ffff88807ebdeb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x314/0x12f0 fs/ext4/migrate.c:437
stack backtrace:
CPU: 1 PID: 13331 Comm: syz-executor.4 Not tainted 6.1.21-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read+0x44/0x1a0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_intwrite include/linux/fs.h:1954 [inline]
ext4_evict_inode+0x46d/0x1150 fs/ext4/inode.c:240
evict+0x2a4/0x620 fs/inode.c:664
ext4_ext_migrate+0x100b/0x12f0 fs/ext4/migrate.c:587
__ext4_ioctl fs/ext4/ioctl.c:1393 [inline]
ext4_ioctl+0x1dea/0x5f70 fs/ext4/ioctl.c:1611
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fefd5a8c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fefd6742168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fefd5bac050 RCX: 00007fefd5a8c0f9
RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000004
RBP: 00007fefd5ae7b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc9befffaf R14: 00007fefd6742300 R15: 0000000000022000
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Mar 27, 2023, 9:31:47 PM3/27/23
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 115472395b0a Linux 5.15.104
syzbot found the following issue on:
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15eaa9b6c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=f5592cc4916e1c2f
dashboard link: https://syzkaller.appspot.com/bug?extid=416315211db87d24c8f8
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/6c2c0744c7e0/disk-11547239.raw.xz
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
vmlinux: https://storage.googleapis.com/syzbot-assets/7ea4c5ecca4f/vmlinux-11547239.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9a231dbcf423/bzImage-11547239.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
======================================================
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz-executor.4/24511 is trying to acquire lock:
ffff88814ac82650 (sb_internal){.+.+}-{0:0}, at: __sb_start_write include/linux/fs.h:1742 [inline]
ffff88814ac82650 (sb_internal){.+.+}-{0:0}, at: sb_start_intwrite include/linux/fs.h:1859 [inline]
ffff88814ac82650 (sb_internal){.+.+}-{0:0}, at: ext4_evict_inode+0x375/0x1100 fs/ext4/inode.c:243
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}:
percpu_down_write+0x52/0x2d0 kernel/locking/percpu-rwsem.c:217
ext4_ind_migrate+0x254/0x760 fs/ext4/migrate.c:625
ext4_ioctl_setflags fs/ext4/ioctl.c:457 [inline]
ext4_fileattr_set+0xf13/0x17d0 fs/ext4/ioctl.c:763
vfs_fileattr_set+0x8f3/0xd30 fs/ioctl.c:700
ioctl_setflags fs/ioctl.c:732 [inline]
do_vfs_ioctl+0x1d85/0x2b70 fs/ioctl.c:843
__do_sys_ioctl fs/ioctl.c:872 [inline]
__se_sys_ioctl+0x81/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
-> #2 (&sb->s_type->i_mutex_key#9){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
inode_lock_shared include/linux/fs.h:797 [inline]
ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3159
bmap+0xa1/0xd0 fs/inode.c:1714
jbd2_journal_bmap fs/jbd2/journal.c:978 [inline]
__jbd2_journal_erase fs/jbd2/journal.c:1786 [inline]
jbd2_journal_flush+0x7a2/0xc90 fs/jbd2/journal.c:2492
ext4_ioctl_checkpoint fs/ext4/ioctl.c:848 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1266 [inline]
ext4_ioctl+0x32c7/0x5b70 fs/ext4/ioctl.c:1278
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
-> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}:
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
mutex_lock_io_nested+0x45/0x60 kernel/locking/mutex.c:777
__jbd2_log_wait_for_space+0x213/0x760 fs/jbd2/checkpoint.c:110
add_transaction_credits+0x950/0xc00 fs/jbd2/transaction.c:303
start_this_handle+0x747/0x1590 fs/jbd2/transaction.c:427
jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:525
__ext4_journal_start_sb+0x175/0x370 fs/ext4/ext4_jbd2.c:105
__ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline]
ext4_evict_inode+0x7dd/0x1100 fs/ext4/inode.c:254
evict+0x2a4/0x620 fs/inode.c:587
do_unlinkat+0x502/0x940 fs/namei.c:4284
__do_sys_unlink fs/namei.c:4325 [inline]
__se_sys_unlink fs/namei.c:4323 [inline]
__x64_sys_unlink+0x45/0x50 fs/namei.c:4323
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
-> #0 (sb_internal){.+.+}-{0:0}:
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
percpu_down_read+0x46/0x1b0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1742 [inline]
sb_start_intwrite include/linux/fs.h:1859 [inline]
ext4_evict_inode+0x375/0x1100 fs/ext4/inode.c:243
evict+0x2a4/0x620 fs/inode.c:587
ext4_ext_migrate+0x100b/0x12f0 fs/ext4/migrate.c:588
__ext4_ioctl fs/ext4/ioctl.c:1027 [inline]
ext4_ioctl+0x1959/0x5b70 fs/ext4/ioctl.c:1278
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
other info that might help us debug this:
Chain exists of:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&sbi->s_writepages_rwsem);
lock(&sbi->s_writepages_rwsem);
lock(sb_internal);
*** DEADLOCK ***
3 locks held by syz-executor.4/24511:
lock(sb_internal);
*** DEADLOCK ***
#0: ffff88814ac82460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
#1: ffff88802ab267a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#1: ffff88802ab267a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1026 [inline]
#1: ffff88802ab267a0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: ext4_ioctl+0x1951/0x5b70 fs/ext4/ioctl.c:1278
#2: ffff88814ac84bd8 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x314/0x12f0 fs/ext4/migrate.c:438
stack backtrace:
CPU: 0 PID: 24511 Comm: syz-executor.4 Not tainted 5.15.104-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
percpu_down_read+0x46/0x1b0 include/linux/percpu-rwsem.h:51
__sb_start_write include/linux/fs.h:1742 [inline]
sb_start_intwrite include/linux/fs.h:1859 [inline]
ext4_evict_inode+0x375/0x1100 fs/ext4/inode.c:243
evict+0x2a4/0x620 fs/inode.c:587
ext4_ext_migrate+0x100b/0x12f0 fs/ext4/migrate.c:588
__ext4_ioctl fs/ext4/ioctl.c:1027 [inline]
ext4_ioctl+0x1959/0x5b70 fs/ext4/ioctl.c:1278
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
RIP: 0033:0x7f245d01c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f245b58e168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f245d13bf80 RCX: 00007f245d01c0f9
RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000004
RBP: 00007f245d077b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffdddc0b70f R14: 00007f245b58e300 R15: 0000000000022000
syzbot
Jul 29, 2023, 8:10:40 PM7/29/23
to syzkaller...@googlegroups.com
Auto-closing this bug as obsolete.
Crashes did not happen for a while, no reproducer and no activity.
Crashes did not happen for a while, no reproducer and no activity.
syzbot
Oct 19, 2023, 6:40:45 AM10/19/23
to syzkaller...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages