KASAN: slab-out-of-bounds Write in hfs_asc2mac

9 views
Skip to first unread message

syzbot

unread,
Nov 25, 2022, 9:11:37 PM11/25/22
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=13e178ad880000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=12da27c54cbd3890072d
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1700d0ad880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13df49bb880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/869994f2e5c8/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+12da27...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: slab-out-of-bounds in hfs_asc2mac+0x68f/0x710 fs/hfs/trans.c:133
Write of size 1 at addr ffff8880aae4a84e by task syz-executor345/8134

CPU: 0 PID: 8134 Comm: syz-executor345 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_address_description.cold+0x54/0x219 mm/kasan/report.c:256
kasan_report_error.cold+0x8a/0x1b9 mm/kasan/report.c:354
kasan_report mm/kasan/report.c:412 [inline]
__asan_report_store1_noabort+0x88/0x90 mm/kasan/report.c:435
hfs_asc2mac+0x68f/0x710 fs/hfs/trans.c:133
hfs_cat_build_key+0xbe/0x1a0 fs/hfs/catalog.c:28
hfs_lookup+0x1c2/0x300 fs/hfs/dir.c:31
lookup_open+0x698/0x1a20 fs/namei.c:3214
do_last fs/namei.c:3327 [inline]
path_openat+0x1804/0x2df0 fs/namei.c:3537
do_filp_open+0x18c/0x3f0 fs/namei.c:3567
do_sys_open+0x3b3/0x520 fs/open.c:1085
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f8e92fbf849
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd03bcbff8 EFLAGS: 00000246 ORIG_RAX: 0000000000000002
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f8e92fbf849
RDX: 0000000000000100 RSI: 0000000000002000 RDI: 0000000020000800
RBP: 00007f8e92f7f0e0 R08: 0000000000000245 R09: 0000000000000000
R10: 00007ffd03bcbec0 R11: 0000000000000246 R12: 00007f8e92f7f170
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 8134:
__do_kmalloc mm/slab.c:3727 [inline]
__kmalloc+0x15a/0x3c0 mm/slab.c:3736
kmalloc include/linux/slab.h:520 [inline]
hfs_find_init+0x91/0x230 fs/hfs/bfind.c:21
hfs_lookup+0xfe/0x300 fs/hfs/dir.c:28
lookup_open+0x698/0x1a20 fs/namei.c:3214
do_last fs/namei.c:3327 [inline]
path_openat+0x1804/0x2df0 fs/namei.c:3537
do_filp_open+0x18c/0x3f0 fs/namei.c:3567
do_sys_open+0x3b3/0x520 fs/open.c:1085
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 6314:
__cache_free mm/slab.c:3503 [inline]
kfree+0xcc/0x210 mm/slab.c:3822
aa_free_file_ctx security/apparmor/include/file.h:76 [inline]
apparmor_file_free_security+0x9a/0xd0 security/apparmor/lsm.c:448
security_file_free+0x3e/0x70 security/security.c:885
file_free fs/file_table.c:54 [inline]
__fput+0x42a/0x890 fs/file_table.c:294
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8880aae4a800
which belongs to the cache kmalloc-96 of size 96
The buggy address is located 78 bytes inside of
96-byte region [ffff8880aae4a800, ffff8880aae4a860)
The buggy address belongs to the page:
page:ffffea0002ab9280 count:1 mapcount:0 mapping:ffff88813bff04c0 index:0x0
flags: 0xfff00000000100(slab)
raw: 00fff00000000100 ffffea0002aa4308 ffffea0002aaed88 ffff88813bff04c0
raw: 0000000000000000 ffff8880aae4a000 0000000100000020 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8880aae4a700: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
ffff8880aae4a780: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
>ffff8880aae4a800: 00 00 00 00 00 00 00 00 00 06 fc fc fc fc fc fc
^
ffff8880aae4a880: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
ffff8880aae4a900: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

syzbot

unread,
Dec 2, 2022, 3:22:43 PM12/2/22
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 179ef7fe8677 Linux 4.14.300
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=11ab87ad880000
kernel config: https://syzkaller.appspot.com/x/.config?x=aa85f51ec321d5a9
dashboard link: https://syzkaller.appspot.com/bug?extid=8cb1c80b7b7e4e51fea5
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1519d7ad880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=137eb5e3880000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d311ef57b59a/disk-179ef7fe.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/25bf5d729f69/vmlinux-179ef7fe.xz
kernel image: https://storage.googleapis.com/syzbot-assets/db9b96571e69/bzImage-179ef7fe.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/a86bf9759ccb/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8cb1c8...@syzkaller.appspotmail.com

==================================================================
BUG: KASAN: slab-out-of-bounds in hfs_asc2mac+0x62a/0x680 fs/hfs/trans.c:133
Write of size 1 at addr ffff8880b3becace by task syz-executor225/7961

CPU: 0 PID: 7961 Comm: syz-executor225 Not tainted 4.14.300-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x281 lib/dump_stack.c:58
print_address_description.cold+0x54/0x1d3 mm/kasan/report.c:252
kasan_report_error.cold+0x8a/0x191 mm/kasan/report.c:351
kasan_report mm/kasan/report.c:409 [inline]
__asan_report_store1_noabort+0x68/0x70 mm/kasan/report.c:432
hfs_asc2mac+0x62a/0x680 fs/hfs/trans.c:133
hfs_cat_build_key+0xbe/0x1a0 fs/hfs/catalog.c:28
hfs_lookup+0x18c/0x2b0 fs/hfs/dir.c:31
lookup_open+0x5c4/0x1750 fs/namei.c:3220
do_last fs/namei.c:3334 [inline]
path_openat+0x14bb/0x2970 fs/namei.c:3571
do_filp_open+0x179/0x3c0 fs/namei.c:3605
do_sys_open+0x296/0x410 fs/open.c:1081
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3

Allocated by task 7961:
save_stack mm/kasan/kasan.c:447 [inline]
set_track mm/kasan/kasan.c:459 [inline]
kasan_kmalloc+0xeb/0x160 mm/kasan/kasan.c:551
__do_kmalloc mm/slab.c:3720 [inline]
__kmalloc+0x15a/0x400 mm/slab.c:3729
kmalloc include/linux/slab.h:493 [inline]
hfs_find_init+0x91/0x220 fs/hfs/bfind.c:21
hfs_lookup+0xea/0x2b0 fs/hfs/dir.c:28
lookup_open+0x5c4/0x1750 fs/namei.c:3220
do_last fs/namei.c:3334 [inline]
path_openat+0x14bb/0x2970 fs/namei.c:3571
do_filp_open+0x179/0x3c0 fs/namei.c:3605
do_sys_open+0x296/0x410 fs/open.c:1081
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3

Freed by task 6442:
save_stack mm/kasan/kasan.c:447 [inline]
set_track mm/kasan/kasan.c:459 [inline]
kasan_slab_free+0xc3/0x1a0 mm/kasan/kasan.c:524
__cache_free mm/slab.c:3496 [inline]
kfree+0xc9/0x250 mm/slab.c:3815
aa_free_file_ctx security/apparmor/include/file.h:76 [inline]
apparmor_file_free_security+0x7e/0xb0 security/apparmor/lsm.c:441
security_file_free+0x42/0x80 security/security.c:879
put_filp+0x23/0x90 fs/file_table.c:312
path_openat+0x212b/0x2970 fs/namei.c:3583
do_filp_open+0x179/0x3c0 fs/namei.c:3605
do_sys_open+0x296/0x410 fs/open.c:1081
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3

The buggy address belongs to the object at ffff8880b3beca80
which belongs to the cache kmalloc-96 of size 96
The buggy address is located 78 bytes inside of
96-byte region [ffff8880b3beca80, ffff8880b3becae0)
The buggy address belongs to the page:
page:ffffea0002cefb00 count:1 mapcount:0 mapping:ffff8880b3bec000 index:0x0
flags: 0xfff00000000100(slab)
raw: 00fff00000000100 ffff8880b3bec000 0000000000000000 0000000100000020
raw: ffffea0002cfd660 ffffea0002cd8f20 ffff88813fe744c0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff8880b3bec980: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
ffff8880b3beca00: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
>ffff8880b3beca80: 00 00 00 00 00 00 00 00 00 06 fc fc fc fc fc fc
^
ffff8880b3becb00: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
ffff8880b3becb80: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
Reply all
Reply to author
Forward
0 new messages