[v5.15] possible deadlock in lookup_slow

4 views
Skip to first unread message

syzbot

unread,
Mar 14, 2023, 11:40:54 AM3/14/23
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 2ddbd0f967b3 Linux 5.15.102
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17ea7ee2c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=fec083380faceb1e
dashboard link: https://syzkaller.appspot.com/bug?extid=3d98c42ea36505a1a0a6
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/156d2aa91f3c/disk-2ddbd0f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f0e97f5be5fb/vmlinux-2ddbd0f9.xz
kernel image: https://storage.googleapis.com/syzbot-assets/20d0a55a041d/bzImage-2ddbd0f9.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3d98c4...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
5.15.102-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/19397 is trying to acquire lock:
ffff88802547bfc0 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: inode_lock_shared include/linux/fs.h:797 [inline]
ffff88802547bfc0 (&type->i_mutex_dir_key#4){++++}-{3:3}, at: lookup_slow+0x45/0x70 fs/namei.c:1675

but task is already holding lock:
ffff88807bb3d0e0 (&fs_devs->device_list_mutex){+.+.}-{3:3}, at: btrfs_free_stale_devices+0x14b/0xb00 fs/btrfs/volumes.c:603

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (&fs_devs->device_list_mutex){+.+.}-{3:3}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
insert_dev_extents fs/btrfs/block-group.c:2344 [inline]
btrfs_create_pending_block_groups+0x5c1/0x1130 fs/btrfs/block-group.c:2394
__btrfs_end_transaction+0x296/0x780 fs/btrfs/transaction.c:1007
flush_space+0x4cf/0xe40 fs/btrfs/space-info.c:674
btrfs_async_reclaim_data_space+0x118/0x3e0 fs/btrfs/space-info.c:1169
process_one_work+0x90d/0x1270 kernel/workqueue.c:2306
worker_thread+0xaca/0x1280 kernel/workqueue.c:2453
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 <unknown>:298

-> #6 (sb_internal#4){.+.+}-{0:0}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1742 [inline]
sb_start_intwrite include/linux/fs.h:1859 [inline]
start_transaction+0x5a8/0x11a0 fs/btrfs/transaction.c:677
btrfs_dirty_inode+0xcc/0x1c0 fs/btrfs/inode.c:6322
inode_update_time fs/inode.c:1787 [inline]
file_update_time+0x3d1/0x460 fs/inode.c:2005
btrfs_page_mkwrite+0x3c0/0xd60 fs/btrfs/inode.c:8875
do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883
do_shared_fault mm/memory.c:4271 [inline]
do_fault mm/memory.c:4339 [inline]
handle_pte_fault mm/memory.c:4594 [inline]
__handle_mm_fault mm/memory.c:4729 [inline]
handle_mm_fault+0x2803/0x5950 mm/memory.c:4827
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x26e/0x800 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568

-> #5 (sb_pagefaults#4){.+.+}-{0:0}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1742 [inline]
sb_start_pagefault include/linux/fs.h:1841 [inline]
btrfs_page_mkwrite+0x1ef/0xd60 fs/btrfs/inode.c:8859
do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883
do_shared_fault mm/memory.c:4271 [inline]
do_fault mm/memory.c:4339 [inline]
handle_pte_fault mm/memory.c:4594 [inline]
__handle_mm_fault mm/memory.c:4729 [inline]
handle_mm_fault+0x2803/0x5950 mm/memory.c:4827
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x26e/0x800 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568

-> #4 (&mm->mmap_lock#2){++++}-{3:3}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
down_write+0x97/0x170 kernel/locking/rwsem.c:1541
mmap_write_lock include/linux/mmap_lock.h:71 [inline]
mpol_rebind_mm+0x34/0x2b0 mm/mempolicy.c:381
cpuset_attach+0x393/0x540 kernel/cgroup/cpuset.c:2285
cgroup_migrate_execute+0x7fb/0x10e0 kernel/cgroup/cgroup.c:2559
cgroup_attach_task+0x587/0x910 kernel/cgroup/cgroup.c:2854
__cgroup1_procs_write+0x2ec/0x460 kernel/cgroup/cgroup-v1.c:528
cgroup_file_write+0x2ac/0x670 kernel/cgroup/cgroup.c:3932
kernfs_fop_write_iter+0x3a2/0x4f0 fs/kernfs/file.c:296
call_write_iter include/linux/fs.h:2101 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacf/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #3 (&cpuset_rwsem){++++}-{0:0}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
cpuset_read_lock+0x40/0x150 kernel/cgroup/cpuset.c:356
__sched_setscheduler+0x626/0x1df0 kernel/sched/core.c:7406
_sched_setscheduler kernel/sched/core.c:7583 [inline]
sched_setscheduler_nocheck+0x187/0x2d0 kernel/sched/core.c:7630
__kthread_create_on_node+0x31b/0x3f0 kernel/kthread.c:413
kthread_create_on_node+0xda/0x120 kernel/kthread.c:453
cryptomgr_schedule_test crypto/algboss.c:219 [inline]
cryptomgr_notify+0x125/0xc70 crypto/algboss.c:240
notifier_call_chain kernel/notifier.c:83 [inline]
blocking_notifier_call_chain+0x104/0x1b0 kernel/notifier.c:318
crypto_probing_notify+0x21/0x70 crypto/api.c:251
crypto_wait_for_test+0x3e/0xd0 crypto/algapi.c:396
crypto_register_alg+0x25b/0x330 crypto/algapi.c:429
do_one_initcall+0x293/0x930 init/main.c:1306
do_initcall_level+0x157/0x207 init/main.c:1379
do_initcalls+0x49/0x86 init/main.c:1395
kernel_init_freeable+0x43c/0x5c5 init/main.c:1619
kernel_init+0x19/0x290 init/main.c:1510
ret_from_fork+0x1f/0x30 <unknown>:298

-> #2 ((crypto_chain).rwsem){++++}-{3:3}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
blocking_notifier_call_chain+0x5e/0x1b0 kernel/notifier.c:317
crypto_probing_notify crypto/api.c:251 [inline]
crypto_alg_mod_lookup+0x4e6/0x710 crypto/api.c:281
crypto_find_alg crypto/api.c:490 [inline]
crypto_alloc_tfm_node+0x12c/0x350 crypto/api.c:527
cryptd_alloc_skcipher+0xde/0x1f0 crypto/cryptd.c:916
simd_skcipher_init+0x63/0x130 crypto/simd.c:122
crypto_create_tfm_node+0x105/0x360 crypto/api.c:457
crypto_alloc_tfm_node+0x15d/0x350 crypto/api.c:533
fscrypt_allocate_skcipher fs/crypto/keysetup.c:84 [inline]
fscrypt_prepare_key+0x89/0x360 fs/crypto/keysetup.c:135
fscrypt_set_per_file_enc_key fs/crypto/keysetup.c:160 [inline]
fscrypt_setup_v2_file_key fs/crypto/keysetup.c:349 [inline]
setup_file_encryption_key fs/crypto/keysetup.c:474 [inline]
fscrypt_setup_encryption_info+0xcf4/0x13a0 fs/crypto/keysetup.c:553
fscrypt_get_encryption_info+0x334/0x420 fs/crypto/keysetup.c:638
fscrypt_prepare_readdir include/linux/fscrypt.h:908 [inline]
ext4_readdir+0x178/0x38e0 fs/ext4/dir.c:137
iterate_dir+0x224/0x570
__do_sys_getdents64 fs/readdir.c:369 [inline]
__se_sys_getdents64+0x209/0x4f0 fs/readdir.c:354
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&mk->mk_sem){++++}-{3:3}:
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
setup_file_encryption_key fs/crypto/keysetup.c:456 [inline]
fscrypt_setup_encryption_info+0x5b6/0x13a0 fs/crypto/keysetup.c:553
fscrypt_get_encryption_info+0x334/0x420 fs/crypto/keysetup.c:638
fscrypt_prepare_readdir include/linux/fscrypt.h:908 [inline]
ext4_readdir+0x178/0x38e0 fs/ext4/dir.c:137
iterate_dir+0x224/0x570
__do_sys_getdents64 fs/readdir.c:369 [inline]
__se_sys_getdents64+0x209/0x4f0 fs/readdir.c:354
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&type->i_mutex_dir_key#4){++++}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
inode_lock_shared include/linux/fs.h:797 [inline]
lookup_slow+0x45/0x70 fs/namei.c:1675
walk_component+0x48c/0x610 fs/namei.c:1972
lookup_last fs/namei.c:2427 [inline]
path_lookupat+0x16f/0x450 fs/namei.c:2451
filename_lookup+0x230/0x5c0 fs/namei.c:2480
kern_path+0x37/0x180 fs/namei.c:2570
lookup_bdev+0xc1/0x280 block/bdev.c:979
device_matched fs/btrfs/volumes.c:568 [inline]
btrfs_free_stale_devices+0x71f/0xb00 fs/btrfs/volumes.c:608
btrfs_forget_devices+0x52/0x80 fs/btrfs/volumes.c:1380
btrfs_control_ioctl+0x108/0x210 fs/btrfs/super.c:2453
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
&type->i_mutex_dir_key#4 --> sb_internal#4 --> &fs_devs->device_list_mutex

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&fs_devs->device_list_mutex);
lock(sb_internal#4);
lock(&fs_devs->device_list_mutex);
lock(&type->i_mutex_dir_key#4);

*** DEADLOCK ***

2 locks held by syz-executor.4/19397:
#0: ffffffff8cdf4b88 (uuid_mutex){+.+.}-{3:3}, at: btrfs_forget_devices+0x1a/0x80 fs/btrfs/volumes.c:1379
#1: ffff88807bb3d0e0 (&fs_devs->device_list_mutex){+.+.}-{3:3}, at: btrfs_free_stale_devices+0x14b/0xb00 fs/btrfs/volumes.c:603

stack backtrace:
CPU: 0 PID: 19397 Comm: syz-executor.4 Not tainted 5.15.102-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1ff/0x570 kernel/locking/lockdep.c:5622
down_read+0x3b/0x50 kernel/locking/rwsem.c:1488
inode_lock_shared include/linux/fs.h:797 [inline]
lookup_slow+0x45/0x70 fs/namei.c:1675
walk_component+0x48c/0x610 fs/namei.c:1972
lookup_last fs/namei.c:2427 [inline]
path_lookupat+0x16f/0x450 fs/namei.c:2451
filename_lookup+0x230/0x5c0 fs/namei.c:2480
kern_path+0x37/0x180 fs/namei.c:2570
lookup_bdev+0xc1/0x280 block/bdev.c:979
device_matched fs/btrfs/volumes.c:568 [inline]
btrfs_free_stale_devices+0x71f/0xb00 fs/btrfs/volumes.c:608
btrfs_forget_devices+0x52/0x80 fs/btrfs/volumes.c:1380
btrfs_control_ioctl+0x108/0x210 fs/btrfs/super.c:2453
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f23b42bb0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f23b282d168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f23b43daf80 RCX: 00007f23b42bb0f9
RDX: 0000000020000bc0 RSI: 0000000050009405 RDI: 0000000000000003
RBP: 00007f23b4316b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffe2f23033f R14: 00007f23b282d300 R15: 0000000000022000
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
Dec 11, 2023, 8:10:15 AM12/11/23
to syzkaller...@googlegroups.com
Auto-closing this bug as obsolete.
Crashes did not happen for a while, no reproducer and no activity.
Reply all
Reply to author
Forward
0 new messages