KASAN: slab-out-of-bounds Read in soft_cursor

19 views
Skip to first unread message

syzbot

unread,
Dec 3, 2019, 6:40:09 AM12/3/19
to syzkaller...@googlegroups.com
Hello,

syzbot found the following crash on:

HEAD commit: 174651bd Linux 4.19.87
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1425f641e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d306897dc6e131b7
dashboard link: https://syzkaller.appspot.com/bug?extid=3c1761f3a15eb7727765
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16822861e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=134e090ee00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+3c1761...@syzkaller.appspotmail.com

audit: type=1400 audit(1575368838.794:36): avc: denied { map } for
pid=7642 comm="syz-executor961" path="/root/syz-executor961368758"
dev="sda1" ino=16483 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
==================================================================
BUG: KASAN: slab-out-of-bounds in memcpy include/linux/string.h:348 [inline]
BUG: KASAN: slab-out-of-bounds in soft_cursor+0x439/0xa30
drivers/video/fbdev/core/softcursor.c:70
Read of size 9 at addr ffff88808e2fc470 by task kworker/0:2/2675

CPU: 0 PID: 2675 Comm: kworker/0:2 Not tainted 4.19.87-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Workqueue: events_power_efficient fb_flashcursor
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x197/0x210 lib/dump_stack.c:118
print_address_description.cold+0x7c/0x20d mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report mm/kasan/report.c:412 [inline]
kasan_report.cold+0x8c/0x2ba mm/kasan/report.c:396
check_memory_region_inline mm/kasan/kasan.c:260 [inline]
check_memory_region+0x123/0x190 mm/kasan/kasan.c:267
memcpy+0x24/0x50 mm/kasan/kasan.c:302
memcpy include/linux/string.h:348 [inline]
soft_cursor+0x439/0xa30 drivers/video/fbdev/core/softcursor.c:70
bit_cursor+0x12fc/0x1a60 drivers/video/fbdev/core/bitblit.c:386
fb_flashcursor+0x3a6/0x450 drivers/video/fbdev/core/fbcon.c:399
process_one_work+0x989/0x1750 kernel/workqueue.c:2153
worker_thread+0x98/0xe40 kernel/workqueue.c:2296
kthread+0x354/0x420 kernel/kthread.c:246
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415

Allocated by task 7646:
save_stack+0x45/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc mm/kasan/kasan.c:553 [inline]
kasan_kmalloc+0xce/0xf0 mm/kasan/kasan.c:531
__do_kmalloc mm/slab.c:3727 [inline]
__kmalloc+0x15d/0x750 mm/slab.c:3736
kmalloc include/linux/slab.h:520 [inline]
fbcon_set_font+0x32d/0x860 drivers/video/fbdev/core/fbcon.c:2641
con_font_set drivers/tty/vt/vt.c:4492 [inline]
con_font_op+0xe18/0x1250 drivers/tty/vt/vt.c:4557
vt_ioctl+0xd2e/0x2530 drivers/tty/vt/vt_ioctl.c:913
tty_ioctl+0x7f3/0x1510 drivers/tty/tty_io.c:2669
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:501 [inline]
do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
__do_sys_ioctl fs/ioctl.c:712 [inline]
__se_sys_ioctl fs/ioctl.c:710 [inline]
__x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 3699:
save_stack+0x45/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3503 [inline]
kfree+0xcf/0x220 mm/slab.c:3822
skb_free_head+0x99/0xc0 net/core/skbuff.c:554
skb_release_data+0x619/0x8d0 net/core/skbuff.c:574
skb_release_all+0x4d/0x60 net/core/skbuff.c:631
__kfree_skb net/core/skbuff.c:645 [inline]
kfree_skb net/core/skbuff.c:663 [inline]
kfree_skb+0xe8/0x390 net/core/skbuff.c:657
unix_stream_connect+0x106a/0x10ba net/unix/af_unix.c:1384
__sys_connect+0x264/0x330 net/socket.c:1663
__do_sys_connect net/socket.c:1674 [inline]
__se_sys_connect net/socket.c:1671 [inline]
__x64_sys_connect+0x73/0xb0 net/socket.c:1671
do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff88808e2fc340
which belongs to the cache kmalloc-512 of size 512
The buggy address is located 304 bytes inside of
512-byte region [ffff88808e2fc340, ffff88808e2fc540)
The buggy address belongs to the page:
page:ffffea000238bf00 count:1 mapcount:0 mapping:ffff88812c31c940 index:0x0
flags: 0xfffe0000000100(slab)
raw: 00fffe0000000100 ffffea00026dd188 ffffea00026cfc88 ffff88812c31c940
raw: 0000000000000000 ffff88808e2fc0c0 0000000100000006 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff88808e2fc300: fc fc fc fc fc fc fc fc 00 00 00 00 00 00 00 00
ffff88808e2fc380: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> ffff88808e2fc400: 00 00 00 00 00 00 00 00 00 00 fc fc fc fc fc fc
^
ffff88808e2fc480: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88808e2fc500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

syzbot

unread,
Dec 3, 2019, 9:54:08 AM12/3/19
to syzkaller...@googlegroups.com
Hello,

syzbot found the following crash on:

HEAD commit: fbc5fe7a Linux 4.14.157
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=132afbf2e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d49d9f4045dcfa5d
dashboard link: https://syzkaller.appspot.com/bug?extid=c9bd0b9b06a8c0ff230e
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11881edae00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1269fc32e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+c9bd0b...@syzkaller.appspotmail.com

audit: type=1400 audit(1575380937.107:39): avc: denied { read } for
pid=6920 comm="syz-executor428"
scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
tcontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
tclass=netlink_generic_socket permissive=1
==================================================================
BUG: KASAN: slab-out-of-bounds in memcpy include/linux/string.h:347 [inline]
BUG: KASAN: slab-out-of-bounds in soft_cursor+0x43d/0xa50
drivers/video/fbdev/core/softcursor.c:70
Read of size 9 at addr ffff888099af0bf0 by task kworker/1:2/2568

CPU: 1 PID: 2568 Comm: kworker/1:2 Not tainted 4.14.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Workqueue: events_power_efficient fb_flashcursor
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x142/0x197 lib/dump_stack.c:58
print_address_description.cold+0x7c/0x1dc mm/kasan/report.c:252
kasan_report_error mm/kasan/report.c:351 [inline]
kasan_report mm/kasan/report.c:409 [inline]
kasan_report.cold+0xa9/0x2af mm/kasan/report.c:393
check_memory_region_inline mm/kasan/kasan.c:260 [inline]
check_memory_region+0x123/0x190 mm/kasan/kasan.c:267
memcpy+0x24/0x50 mm/kasan/kasan.c:302
memcpy include/linux/string.h:347 [inline]
soft_cursor+0x43d/0xa50 drivers/video/fbdev/core/softcursor.c:70
bit_cursor+0x11be/0x1830 drivers/video/fbdev/core/bitblit.c:386
fb_flashcursor+0x36d/0x410 drivers/video/fbdev/core/fbcon.c:393
process_one_work+0x863/0x1600 kernel/workqueue.c:2114
worker_thread+0x5d9/0x1050 kernel/workqueue.c:2248
kthread+0x319/0x430 kernel/kthread.c:232
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404

Allocated by task 6922:
save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
save_stack+0x45/0xd0 mm/kasan/kasan.c:447
set_track mm/kasan/kasan.c:459 [inline]
kasan_kmalloc mm/kasan/kasan.c:551 [inline]
kasan_kmalloc+0xce/0xf0 mm/kasan/kasan.c:529
__do_kmalloc mm/slab.c:3720 [inline]
__kmalloc+0x15d/0x7a0 mm/slab.c:3729
kmalloc include/linux/slab.h:493 [inline]
fbcon_set_font+0x2f8/0x7b0 drivers/video/fbdev/core/fbcon.c:2618
con_font_set drivers/tty/vt/vt.c:4162 [inline]
con_font_op+0xc0f/0x1060 drivers/tty/vt/vt.c:4227
vt_ioctl+0xb80/0x2170 drivers/tty/vt/vt_ioctl.c:927
tty_ioctl+0x841/0x1320 drivers/tty/tty_io.c:2661
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x7ae/0x1060 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7

Freed by task 3606:
save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
save_stack+0x45/0xd0 mm/kasan/kasan.c:447
set_track mm/kasan/kasan.c:459 [inline]
kasan_slab_free+0x75/0xc0 mm/kasan/kasan.c:524
__cache_free mm/slab.c:3496 [inline]
kfree+0xcc/0x270 mm/slab.c:3815
kernfs_fop_release+0x112/0x180 fs/kernfs/file.c:783
__fput+0x275/0x7a0 fs/file_table.c:210
____fput+0x16/0x20 fs/file_table.c:244
task_work_run+0x114/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1da/0x220 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4bc/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x42/0xb7

The buggy address belongs to the object at ffff888099af0ac0
which belongs to the cache kmalloc-512 of size 512
The buggy address is located 304 bytes inside of
512-byte region [ffff888099af0ac0, ffff888099af0cc0)
The buggy address belongs to the page:
page:ffffea000266bc00 count:1 mapcount:0 mapping:ffff888099af00c0 index:0x0
flags: 0xfffe0000000100(slab)
raw: 00fffe0000000100 ffff888099af00c0 0000000000000000 0000000100000006
raw: ffffea0002a63be0 ffffea0002644aa0 ffff8880aa800940 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff888099af0a80: fc fc fc fc fc fc fc fc 00 00 00 00 00 00 00 00
ffff888099af0b00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> ffff888099af0b80: 00 00 00 00 00 00 00 00 00 00 fc fc fc fc fc fc
^
ffff888099af0c00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff888099af0c80: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc

syzbot

unread,
Dec 5, 2020, 2:26:04 PM12/5/20
to syzkaller...@googlegroups.com
syzbot suspects this issue was fixed by commit:

commit 3e1600cc10dffe654e2699fe9ec4d546cb7c1a30
Author: Rander Wang <rande...@intel.com>
Date: Wed Sep 2 15:42:18 2020 +0000

ALSA: hda: fix a runtime pm issue in SOF when integrated GPU is disabled

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1224a5d9500000
start commit: a083db76 Linux 4.19.107
git tree: linux-4.19.y
kernel config: https://syzkaller.appspot.com/x/.config?x=c32f76aaadd644de
dashboard link: https://syzkaller.appspot.com/bug?extid=3c1761f3a15eb7727765
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15332c55e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13dbf8f9e00000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: ALSA: hda: fix a runtime pm issue in SOF when integrated GPU is disabled

For information about bisection process see: https://goo.gl/tpsmEJ#bisection
Reply all
Reply to author
Forward
0 new messages