[v5.15] possible deadlock in hfsplus_block_allocate

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 115472395b0a Linux 5.15.104
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16a4fd19c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=f5592cc4916e1c2f
dashboard link: https://syzkaller.appspot.com/bug?extid=a8745a7f69ed81d2446b
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/6c2c0744c7e0/disk-11547239.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/7ea4c5ecca4f/vmlinux-11547239.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9a231dbcf423/bzImage-11547239.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+a8745a...@syzkaller.appspotmail.com

loop4: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
5.15.104-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/15829 is trying to acquire lock:
ffff8880346fd0f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35

but task is already holding lock:
ffff88806adb9548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260
block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290
do_read_cache_page+0x752/0x1040
read_mapping_page include/linux/pagemap.h:515 [inline]
hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37
hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_perform_write+0x2bf/0x5b0 mm/filemap.c:3776
__generic_file_write_iter+0x243/0x4f0 mm/filemap.c:3903
generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3935
call_write_iter include/linux/fs.h:2103 [inline]
aio_write+0x566/0x780 fs/aio.c:1583
io_submit_one+0x768/0x18d0 fs/aio.c:2002
__do_sys_io_submit fs/aio.c:2061 [inline]
__se_sys_io_submit+0x17b/0x2f0 fs/aio.c:2031
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35
hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
cont_expand_zero fs/buffer.c:2431 [inline]
cont_write_begin+0x654/0x840 fs/buffer.c:2461
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_cont_expand_simple+0x144/0x230 fs/buffer.c:2362
hfsplus_setattr+0x169/0x280 fs/hfsplus/inode.c:261
notify_change+0xd4d/0x1000 fs/attr.c:488
do_truncate+0x21c/0x300 fs/open.c:65
vfs_truncate+0x2dd/0x3a0 fs/open.c:111
do_sys_truncate+0xda/0x190 fs/open.c:134
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&sbi->alloc_mutex);
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&sbi->alloc_mutex);

*** DEADLOCK ***

3 locks held by syz-executor.4/15829:
#0: ffff88802e4fa460 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
#1: ffff88806adb9740 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#1: ffff88806adb9740 (&sb->s_type->i_mutex_key#21){+.+.}-{3:3}, at: do_truncate+0x208/0x300 fs/open.c:63
#2: ffff88806adb9548 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

stack backtrace:
CPU: 0 PID: 15829 Comm: syz-executor.4 Not tainted 5.15.104-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35
hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
cont_expand_zero fs/buffer.c:2431 [inline]
cont_write_begin+0x654/0x840 fs/buffer.c:2461
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_cont_expand_simple+0x144/0x230 fs/buffer.c:2362
hfsplus_setattr+0x169/0x280 fs/hfsplus/inode.c:261
notify_change+0xd4d/0x1000 fs/attr.c:488
do_truncate+0x21c/0x300 fs/open.c:65
vfs_truncate+0x2dd/0x3a0 fs/open.c:111
do_sys_truncate+0xda/0x190 fs/open.c:134
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7fe0eb6b20f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe0e9c24168 EFLAGS: 00000246 ORIG_RAX: 000000000000004c
RAX: ffffffffffffffda RBX: 00007fe0eb7d1f80 RCX: 00007fe0eb6b20f9
RDX: 0000000000000000 RSI: 0000000000000d1a RDI: 0000000020000740
RBP: 00007fe0eb70db39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffeafda7aaf R14: 00007fe0e9c24300 R15: 0000000000022000
</TASK>
attempt to access beyond end of device
loop4: rw=0, want=393222, limit=1024
buffer_io_error: 6 callbacks suppressed
Buffer I/O error on dev loop4, logical block 196610, async page read
attempt to access beyond end of device
loop4: rw=0, want=393222, limit=1024
Buffer I/O error on dev loop4, logical block 196610, async page read


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3b29299e5f60 Linux 6.1.22
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10d91a3ec80000
kernel config: https://syzkaller.appspot.com/x/.config?x=4a782518325cb082
dashboard link: https://syzkaller.appspot.com/bug?extid=7cba265d6c8566d8a3c9

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:

disk image: https://storage.googleapis.com/syzbot-assets/f6cdeb0f8946/disk-3b29299e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/cc5e0da6e9ab/vmlinux-3b29299e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9e31f151a6a5/bzImage-3b29299e.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+7cba26...@syzkaller.appspotmail.com

loop4: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected

6.1.22-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/11527 is trying to acquire lock:
ffff88807cc518f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9a/0x8b0 fs/hfsplus/bitmap.c:35

but task is already holding lock:

ffff88803c41a988 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:

lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260
block_read_full_folio+0x403/0xf60 fs/buffer.c:2271
filemap_read_folio+0x199/0x780 mm/filemap.c:2407
do_read_cache_folio+0x2ee/0x810 mm/filemap.c:3535
do_read_cache_page+0x32/0x220 mm/filemap.c:3577
read_mapping_page include/linux/pagemap.h:756 [inline]
hfsplus_block_allocate+0xea/0x8b0 fs/hfsplus/bitmap.c:37

hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245

__block_write_begin_int+0x544/0x1a30 fs/buffer.c:1991
__block_write_begin fs/buffer.c:2041 [inline]
block_write_begin+0x98/0x1f0 fs/buffer.c:2102
cont_write_begin+0x63f/0x880 fs/buffer.c:2456
hfsplus_write_begin+0x86/0xd0 fs/hfsplus/inode.c:52
generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3754
__generic_file_write_iter+0x176/0x400 mm/filemap.c:3882
generic_file_write_iter+0xab/0x310 mm/filemap.c:3914
call_write_iter include/linux/fs.h:2205 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x7ae/0xba0 fs/read_write.c:584
ksys_write+0x19c/0x2c0 fs/read_write.c:637

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&sbi->alloc_mutex){+.+.}-{3:3}:

check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
hfsplus_block_allocate+0x9a/0x8b0 fs/hfsplus/bitmap.c:35

hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245

__block_write_begin_int+0x544/0x1a30 fs/buffer.c:1991
__block_write_begin fs/buffer.c:2041 [inline]
block_write_begin+0x98/0x1f0 fs/buffer.c:2102
cont_write_begin+0x63f/0x880 fs/buffer.c:2456
hfsplus_write_begin+0x86/0xd0 fs/hfsplus/inode.c:52
generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3754
__generic_file_write_iter+0x176/0x400 mm/filemap.c:3882
generic_file_write_iter+0xab/0x310 mm/filemap.c:3914
do_iter_write+0x6e6/0xc50 fs/read_write.c:861
vfs_writev fs/read_write.c:934 [inline]
do_pwritev+0x216/0x360 fs/read_write.c:1031

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&sbi->alloc_mutex);
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&sbi->alloc_mutex);

*** DEADLOCK ***

3 locks held by syz-executor.4/11527:
#0: ffff888027b30460 (sb_writers#21){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline]
#0: ffff888027b30460 (sb_writers#21){.+.+}-{0:0}, at: do_pwritev+0x1fa/0x360 fs/read_write.c:1031
#1: ffff88803c41ab80 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline]
#1: ffff88803c41ab80 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: generic_file_write_iter+0x7f/0x310 mm/filemap.c:3911
#2: ffff88803c41a988 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

stack backtrace:
CPU: 1 PID: 11527 Comm: syz-executor.4 Not tainted 6.1.22-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106

check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
hfsplus_block_allocate+0x9a/0x8b0 fs/hfsplus/bitmap.c:35

hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245

__block_write_begin_int+0x544/0x1a30 fs/buffer.c:1991
__block_write_begin fs/buffer.c:2041 [inline]
block_write_begin+0x98/0x1f0 fs/buffer.c:2102
cont_write_begin+0x63f/0x880 fs/buffer.c:2456
hfsplus_write_begin+0x86/0xd0 fs/hfsplus/inode.c:52
generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3754
__generic_file_write_iter+0x176/0x400 mm/filemap.c:3882
generic_file_write_iter+0xab/0x310 mm/filemap.c:3914
do_iter_write+0x6e6/0xc50 fs/read_write.c:861
vfs_writev fs/read_write.c:934 [inline]
do_pwritev+0x216/0x360 fs/read_write.c:1031

do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80

entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f4c1d88c0f9

Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48

RSP: 002b:00007f4c1e5cd168 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 00007f4c1d9abf80 RCX: 00007f4c1d88c0f9
RDX: 0000000000000001 RSI: 0000000020000240 RDI: 0000000000000005
RBP: 00007f4c1d8e7b39 R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000

R13: 00007ffe424fd20f R14: 00007f4c1e5cd300 R15: 0000000000022000
</TASK>