[v6.1] WARNING in xfs_qm_dqget_cache_insert

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=161c3e01c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=390800ef8aeebc47
dashboard link: https://syzkaller.appspot.com/bug?extid=55fb1b7d909494fd520d
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9f5022ccd560/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f8524664c631/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ad699b30c2c4/Image-e3a87a10.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+55fb1b...@syzkaller.appspotmail.com

el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
------------[ cut here ]------------
WARNING: CPU: 0 PID: 10054 at fs/xfs/xfs_dquot.c:801 xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
Modules linked in:
CPU: 0 PID: 10054 Comm: syz-executor.0 Not tainted 6.1.21-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
lr : xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
sp : ffff8000219a75a0
x29: ffff8000219a75a0 x28: ffff0000cd114000 x27: dfff800000000000
x26: 1ffff00004334ec8 x25: ffff8000219a7640 x24: ffff0000d5c76800
x23: ffff0000d5c76800 x22: ffff0000d5c76800 x21: ffff0000cd114000
x20: 00000000fffffff4 x19: ffff0000d5c768f0 x18: 1fffe000368b6b76
x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000
x14: 0000000000000002 x13: 00000000ffffffef x12: 0000000000040000
x11: 0000000000015091 x10: ffff8000270d4000 x9 : ffff800009c8a188
x8 : 0000000000015092 x7 : 0000000000000001 x6 : 0000000000000001
x5 : ffff8000219a6a38 x4 : 00000000ffffffff x3 : 0000000000000c40
x2 : ffff0000c000d380 x1 : ffff800015b8b2c0 x0 : 00000000fffffff4
Call trace:
xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
xfs_qm_dqget+0x278/0x510 fs/xfs/xfs_dquot.c:874
xfs_qm_vop_dqalloc+0x484/0xdd0 fs/xfs/xfs_qm.c:1679
xfs_setattr_nonsize+0x3ec/0xdcc fs/xfs/xfs_iops.c:702
xfs_vn_setattr+0x2d8/0x398 fs/xfs/xfs_iops.c:1022
notify_change+0xc24/0xec0 fs/attr.c:482
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
irq event stamp: 165298
hardirqs last enabled at (165297): [<ffff8000120d2d80>] __exit_to_kernel_mode arch/arm64/kernel/entry-common.c:84 [inline]
hardirqs last enabled at (165297): [<ffff8000120d2d80>] exit_to_kernel_mode+0xe8/0x118 arch/arm64/kernel/entry-common.c:94
hardirqs last disabled at (165298): [<ffff8000120d096c>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:405
softirqs last enabled at (165292): [<ffff800008020d74>] softirq_handle_end kernel/softirq.c:414 [inline]
softirqs last enabled at (165292): [<ffff800008020d74>] __do_softirq+0xc14/0xea0 kernel/softirq.c:600
softirqs last disabled at (165277): [<ffff80000802a948>] ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:79
---[ end trace 0000000000000000 ]---


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y

console output: https://syzkaller.appspot.com/x/log.txt?x=17b31985c80000

kernel config: https://syzkaller.appspot.com/x/.config?x=390800ef8aeebc47
dashboard link: https://syzkaller.appspot.com/bug?extid=55fb1b7d909494fd520d
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1488bd49c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=137dd349c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9f5022ccd560/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f8524664c631/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ad699b30c2c4/Image-e3a87a10.gz.xz

mounted in repro: https://storage.googleapis.com/syzbot-assets/c92c0f1ccf23/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+55fb1b...@syzkaller.appspotmail.com

el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
------------[ cut here ]------------

WARNING: CPU: 0 PID: 4413 at fs/xfs/xfs_dquot.c:801 xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
Modules linked in:
CPU: 0 PID: 4413 Comm: syz-executor407 Not tainted 6.1.21-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
pc : xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
lr : xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801

sp : ffff80001dd675a0
x29: ffff80001dd675a0 x28: ffff0000d76930c0 x27: dfff800000000000
x26: 1ffff00003bacec8 x25: ffff80001dd67640 x24: ffff0000cfe04800
x23: ffff0000cfe04800 x22: ffff0000cfe04800 x21: ffff0000d76930c0
x20: 00000000fffffff4 x19: ffff0000cfe048f0 x18: ffff80001dd66860

x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000

x14: 0000000000000000 x13: 00000000ffffffef x12: ffff0000c2bcd1c0
x11: ff80800009c8a188 x10: 0000000000000000 x9 : ffff800009c8a188
x8 : ffff0000c2bcd1c0 x7 : 0000000000000001 x6 : 0000000000000001
x5 : ffff80001dd66a38 x4 : 00000000ffffffff x3 : 0000000000000c40

x2 : ffff0000c000d380 x1 : ffff800015b8b2c0 x0 : 00000000fffffff4
Call trace:
xfs_qm_dqget_cache_insert+0x130/0x138 fs/xfs/xfs_dquot.c:801
xfs_qm_dqget+0x278/0x510 fs/xfs/xfs_dquot.c:874
xfs_qm_vop_dqalloc+0x484/0xdd0 fs/xfs/xfs_qm.c:1679
xfs_setattr_nonsize+0x3ec/0xdcc fs/xfs/xfs_iops.c:702
xfs_vn_setattr+0x2d8/0x398 fs/xfs/xfs_iops.c:1022
notify_change+0xc24/0xec0 fs/attr.c:482
chown_common+0x4e8/0x7d8 fs/open.c:736
vfs_fchown fs/open.c:804 [inline]
ksys_fchown+0xe0/0x158 fs/open.c:815
__do_sys_fchown fs/open.c:823 [inline]
__se_sys_fchown fs/open.c:821 [inline]
__arm64_sys_fchown+0x7c/0x94 fs/open.c:821
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

irq event stamp: 144266
hardirqs last enabled at (144265): [<ffff8000120d2d80>] __exit_to_kernel_mode arch/arm64/kernel/entry-common.c:84 [inline]
hardirqs last enabled at (144265): [<ffff8000120d2d80>] exit_to_kernel_mode+0xe8/0x118 arch/arm64/kernel/entry-common.c:94
hardirqs last disabled at (144266): [<ffff8000120d096c>] el1_dbg+0x24/0x80 arch/arm64/kernel/entry-common.c:405
softirqs last enabled at (144260): [<ffff800008020d74>] softirq_handle_end kernel/softirq.c:414 [inline]
softirqs last enabled at (144260): [<ffff800008020d74>] __do_softirq+0xc14/0xea0 kernel/softirq.c:600
softirqs last disabled at (144201): [<ffff80000802a948>] ____do_softirq+0x14/0x20 arch/arm64/kernel/irq.c:79

[syzbot]

syzbot suspects this issue could be fixed by backporting the following commit:

commit 4b827b3f305d1fcf837265f1e12acc22ee84327c
git tree: upstream
Author: Dave Chinner <dchi...@redhat.com>
Date: Wed Apr 12 05:48:59 2023 +0000

xfs: remove WARN when dquot cache insertion fails

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=134446ad980000
kernel config: https://syzkaller.appspot.com/x/.config?x=fac5c36c2b16009f
dashboard link: https://syzkaller.appspot.com/bug?extid=55fb1b7d909494fd520d
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16e441c5280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15406772280000


Please keep in mind that other backports might be required as well.

For information about bisection process see: https://goo.gl/tpsmEJ#bisection