[v5.15] WARNING in isotp_tx_timer_handler

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: d86dfc4d95cd Linux 5.15.106
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17c80237c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=dca379fe384dda80
dashboard link: https://syzkaller.appspot.com/bug?extid=3a3c13a104534637475b
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2c159eb4fcae/disk-d86dfc4d.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/5f50187f87c7/vmlinux-d86dfc4d.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f787f3f09c09/bzImage-d86dfc4d.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3a3c13...@syzkaller.appspotmail.com

------------[ cut here ]------------
WARNING: CPU: 1 PID: 3517 at net/can/isotp.c:853 isotp_tx_timer_handler+0xb47/0xed0
Modules linked in:
CPU: 1 PID: 3517 Comm: modprobe Not tainted 5.15.106-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023
RIP: 0010:isotp_tx_timer_handler+0xb47/0xed0 net/can/isotp.c:853
Code: 00 00 00 00 00 00 49 81 c5 a8 40 00 00 31 db 4c 89 ef be 01 00 00 00 ba 01 00 00 00 31 c9 e8 40 9e 2b f8 eb 57 e8 89 14 4c f8 <0f> 0b eb 4c e8 80 14 4c f8 eb 45 4c 8b 74 24 30 49 81 c6 a8 05 00
RSP: 0000:ffffc90000dd0b20 EFLAGS: 00010246
RAX: ffffffff8933a627 RBX: 0000000000000000 RCX: ffff888032da5700
RDX: 0000000000000101 RSI: ffffffff8db1c360 RDI: 0000000000000000
RBP: ffffc90000dd0c70 R08: 0000000000000005 R09: ffffffff89339bbb
R10: 0000000000000003 R11: ffff888032da5700 R12: 0000000000000000
R13: ffff888078548570 R14: ffff88807854a5f4 R15: dffffc0000000000
FS: 0000000000000000(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fe7e5697440 CR3: 0000000042389000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
__run_hrtimer kernel/time/hrtimer.c:1685 [inline]
__hrtimer_run_queues+0x598/0xcf0 kernel/time/hrtimer.c:1749
hrtimer_run_softirq+0x196/0x2c0 kernel/time/hrtimer.c:1766
__do_softirq+0x3b3/0x93a kernel/softirq.c:558
invoke_softirq kernel/softirq.c:432 [inline]
__irq_exit_rcu+0x155/0x240 kernel/softirq.c:636
irq_exit_rcu+0x5/0x20 kernel/softirq.c:648
sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1097
</IRQ>
<TASK>
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:638
RIP: 0010:preempt_count_add+0xc5/0x180 kernel/sched/core.c:5493
Code: 0c 00 65 48 8b 1d fb 7f ab 7e 48 81 c3 18 14 00 00 48 89 d8 48 c1 e8 03 42 80 3c 38 00 74 08 48 89 df e8 2e 13 72 00 4c 89 33 <5b> 41 5e 41 5f c3 e8 b0 a8 ab 02 85 c0 74 9e 48 c7 c0 88 4e e3 8d
RSP: 0000:ffffc90006d1f730 EFLAGS: 00000246
RAX: 1ffff110065b4d63 RBX: ffff888032da6b18 RCX: ffffffff8a204800
RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffffffff81be1ab3
RBP: 0000000000000001 R08: dffffc0000000000 R09: ffffed100992a800
R10: 0000000000000000 R11: dffffc0000000001 R12: dffffc0000000000
R13: 0000000000000001 R14: ffffffff81be1ab3 R15: dffffc0000000000
kmap_atomic include/linux/highmem-internal.h:196 [inline]
clear_highpage include/linux/highmem.h:180 [inline]
kernel_init_free_pages+0x53/0xf0 mm/page_alloc.c:1278
post_alloc_hook+0x104/0x220 mm/page_alloc.c:2416
prep_new_page mm/page_alloc.c:2426 [inline]
get_page_from_freelist+0x322a/0x33c0 mm/page_alloc.c:4159
__alloc_pages+0x272/0x700 mm/page_alloc.c:5421
alloc_pages_vma+0x39a/0x800 mm/mempolicy.c:2146
do_anonymous_page mm/memory.c:3781 [inline]
handle_pte_fault mm/memory.c:4592 [inline]
__handle_mm_fault mm/memory.c:4729 [inline]
handle_mm_fault+0x2f49/0x5950 mm/memory.c:4827
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
RIP: 0033:0x7ff2f5efc3b7
Code: 89 5c 24 20 be 01 00 00 00 48 89 54 24 18 ff 15 67 4a 02 00 48 89 c5 48 85 c0 0f 84 40 02 00 00 48 8b 54 24 18 4c 8b 5c 24 20 <48> 89 40 28 4c 89 e6 4c 8d 8c 10 88 04 00 00 4c 89 da 4c 89 88 d0
RSP: 002b:00007ffc911aaf50 EFLAGS: 00010206
RAX: 00007ff2f5eee000 RBX: 0000000000000000 RCX: 00007ff2f5eee4bd
RDX: 0000000000000000 RSI: 0000000000002000 RDI: 0000000000000000
RBP: 00007ff2f5eee000 R08: 00000000ffffffff R09: 0000000000000000
R10: 0000000000000022 R11: 0000000000000015 R12: 0000557cbd573539
R13: 00007ff2f5f221e0 R14: 0000000000000014 R15: 0000000000000000
</TASK>
----------------
Code disassembly (best guess):
0: 0c 00 or $0x0,%al
2: 65 48 8b 1d fb 7f ab mov %gs:0x7eab7ffb(%rip),%rbx # 0x7eab8005
9: 7e
a: 48 81 c3 18 14 00 00 add $0x1418,%rbx
11: 48 89 d8 mov %rbx,%rax
14: 48 c1 e8 03 shr $0x3,%rax
18: 42 80 3c 38 00 cmpb $0x0,(%rax,%r15,1)
1d: 74 08 je 0x27
1f: 48 89 df mov %rbx,%rdi
22: e8 2e 13 72 00 callq 0x721355
27: 4c 89 33 mov %r14,(%rbx)
* 2a: 5b pop %rbx <-- trapping instruction
2b: 41 5e pop %r14
2d: 41 5f pop %r15
2f: c3 retq
30: e8 b0 a8 ab 02 callq 0x2aba8e5
35: 85 c0 test %eax,%eax
37: 74 9e je 0xffffffd7
39: 48 c7 c0 88 4e e3 8d mov $0xffffffff8de34e88,%rax


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 09996673e313 Linux 5.15.123
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16656a31a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=f9d4431ce682ac7e
dashboard link: https://syzkaller.appspot.com/bug?extid=3a3c13a104534637475b
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1087112ea80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=145202e5a80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/e665cef1f596/disk-09996673.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/c21eeab4b038/vmlinux-09996673.xz
kernel image: https://storage.googleapis.com/syzbot-assets/15e2b5a7aa32/bzImage-09996673.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/f16527f1b432/mount_9.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+3a3c13...@syzkaller.appspotmail.com

------------[ cut here ]------------

WARNING: CPU: 1 PID: 3544 at net/can/isotp.c:853 isotp_tx_timer_handler+0xb47/0xed0
Modules linked in:
CPU: 1 PID: 3544 Comm: syz-executor146 Not tainted 5.15.123-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023

RIP: 0010:isotp_tx_timer_handler+0xb47/0xed0 net/can/isotp.c:853

Code: 00 00 00 00 00 00 49 81 c5 a8 40 00 00 31 db 4c 89 ef be 01 00 00 00 ba 01 00 00 00 31 c9 e8 70 cc 26 f8 eb 57 e8 89 58 47 f8 <0f> 0b eb 4c e8 80 58 47 f8 eb 45 4c 8b 74 24 30 49 81 c6 a8 05 00
RSP: 0018:ffffc90000dd0b20 EFLAGS: 00010246
RAX: ffffffff8938a7e7 RBX: 0000000000000000 RCX: ffff8880155d9dc0
RDX: 0000000000000101 RSI: ffffffff8db298c0 RDI: 0000000000000000
RBP: ffffc90000dd0c70 R08: 0000000000000005 R09: ffffffff89389d7b
R10: 0000000000000003 R11: ffff8880155d9dc0 R12: 0000000000000000
R13: ffff88806b6a0578 R14: ffff88806b6a25fc R15: dffffc0000000000
FS: 00005555559dd480(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 00005555559e67f8 CR3: 00000000741ab000 CR4: 00000000003506e0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
__run_hrtimer kernel/time/hrtimer.c:1685 [inline]
__hrtimer_run_queues+0x598/0xcf0 kernel/time/hrtimer.c:1749
hrtimer_run_softirq+0x196/0x2c0 kernel/time/hrtimer.c:1766
__do_softirq+0x3b3/0x93a kernel/softirq.c:558
invoke_softirq kernel/softirq.c:432 [inline]
__irq_exit_rcu+0x155/0x240 kernel/softirq.c:636
irq_exit_rcu+0x5/0x20 kernel/softirq.c:648

sysvec_apic_timer_interrupt+0x91/0xb0 arch/x86/kernel/apic/apic.c:1096

</IRQ>
<TASK>
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:638

RIP: 0010:console_unlock+0xe53/0x12b0 kernel/printk/printk.c:2739
Code: 00 48 83 7c 24 18 00 75 19 e8 79 e4 19 00 eb 18 e8 72 e4 19 00 e8 8d ec b5 08 48 83 7c 24 18 00 74 e7 e8 60 e4 19 00 fb 31 ff <44> 89 f6 e8 b5 e7 19 00 31 db 45 85 f6 0f 95 c0 89 c1 0a 4c 24 17
RSP: 0018:ffffc900026bf820 EFLAGS: 00000246
RAX: ffffffff81661c10 RBX: 0000000000000000 RCX: ffff8880155d9dc0
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: ffffc900026bfab0 R08: ffffffff81661bdb R09: fffffbfff1f7aa21
R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffffffff1a4a682
R13: ffffffff8d253448 R14: 0000000000000000 R15: dffffc0000000000
vprintk_emit+0xba/0x150 kernel/printk/printk.c:2268
_printk+0xd1/0x111 kernel/printk/printk.c:2289
__xfs_printk fs/xfs/xfs_message.c:24 [inline]
xfs_notice+0x1c8/0x320 fs/xfs/xfs_message.c:56
xfs_fs_put_super+0x55/0x2b0 fs/xfs/xfs_super.c:1088
generic_shutdown_super+0x136/0x2c0 fs/super.c:475
kill_block_super+0x7a/0xe0 fs/super.c:1405
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:164
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:175
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:208
__syscall_exit_to_user_mode_work kernel/entry/common.c:290 [inline]
syscall_exit_to_user_mode+0x5d/0x250 kernel/entry/common.c:301
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7ffaa5b38477
Code: 00 00 00 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 b0 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007fff7782dce8 EFLAGS: 00000206 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00007ffaa5b38477
RDX: 0000000000000000 RSI: 000000000000000a RDI: 00007fff7782dda0
RBP: 00007fff7782dda0 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000ffffffff R11: 0000000000000206 R12: 00007fff7782ee60
R13: 00005555559de7c0 R14: 00007fff7782eea0 R15: 0000000000000022

</TASK>
----------------
Code disassembly (best guess):

0: 00 48 83 add %cl,-0x7d(%rax)
3: 7c 24 jl 0x29
5: 18 00 sbb %al,(%rax)
7: 75 19 jne 0x22
9: e8 79 e4 19 00 call 0x19e487
e: eb 18 jmp 0x28
10: e8 72 e4 19 00 call 0x19e487
15: e8 8d ec b5 08 call 0x8b5eca7
1a: 48 83 7c 24 18 00 cmpq $0x0,0x18(%rsp)
20: 74 e7 je 0x9
22: e8 60 e4 19 00 call 0x19e487
27: fb sti
28: 31 ff xor %edi,%edi
* 2a: 44 89 f6 mov %r14d,%esi <-- trapping instruction
2d: e8 b5 e7 19 00 call 0x19e7e7
32: 31 db xor %ebx,%ebx
34: 45 85 f6 test %r14d,%r14d
37: 0f 95 c0 setne %al
3a: 89 c1 mov %eax,%ecx
3c: 0a 4c 24 17 or 0x17(%rsp),%cl


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[syzbot]

syzbot suspects this issue was fixed by commit:

commit e163ad6a8639bb28f5aee683f04929cb07dd5990
Author: Oliver Hartkopp <sock...@hartkopp.net>
Date: Tue Oct 31 09:30:23 2023 +0000

can: isotp: add local echo tx processing and tx without FC

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11c27d64e80000
start commit: 09996673e313 Linux 5.15.123
git tree: linux-5.15.y

kernel config: https://syzkaller.appspot.com/x/.config?x=f9d4431ce682ac7e
dashboard link: https://syzkaller.appspot.com/bug?extid=3a3c13a104534637475b

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1087112ea80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=145202e5a80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: can: isotp: add local echo tx processing and tx without FC

For information about bisection process see: https://goo.gl/tpsmEJ#bisection