[v6.1] possible deadlock in try_to_wake_up

0 views
Skip to first unread message

syzbot

unread,
Mar 27, 2024, 1:52:22 PMMar 27
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: e5cd595e23c1 Linux 6.1.83
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=13618cce180000
kernel config: https://syzkaller.appspot.com/x/.config?x=99d0cbbc2b2c7cfd
dashboard link: https://syzkaller.appspot.com/bug?extid=f91aecb8835e72e8c465
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17e534ce180000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1435a7b6180000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/607b4730a2cc/disk-e5cd595e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/265e84c69ac5/vmlinux-e5cd595e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/af893c46019b/bzImage-e5cd595e.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+f91aec...@syzkaller.appspotmail.com

------------[ cut here ]------------
======================================================
WARNING: possible circular locking dependency detected
6.1.83-syzkaller #0 Not tainted
------------------------------------------------------
swapper/0/0 is trying to acquire lock:
ffffffff8d006ad8 ((console_sem).lock){-...}-{2:2}, at: down_trylock+0x1c/0xa0 kernel/locking/semaphore.c:139

but task is already holding lock:
ffff88802990c598 (&p->pi_lock){-.-.}-{2:2}, at: try_to_wake_up+0xad/0x12e0 kernel/sched/core.c:4112

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&p->pi_lock){-.-.}-{2:2}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
try_to_wake_up+0xad/0x12e0 kernel/sched/core.c:4112
up+0x6e/0x90 kernel/locking/semaphore.c:191
__up_console_sem+0x11a/0x1e0 kernel/printk/printk.c:260
__console_unlock kernel/printk/printk.c:2691 [inline]
console_unlock+0x591/0x7c0 kernel/printk/printk.c:2902
vprintk_emit+0x523/0x740 kernel/printk/printk.c:2297
dev_vprintk_emit+0x2aa/0x323 drivers/base/core.c:4902
dev_printk_emit+0xd9/0x118 drivers/base/core.c:4913
_dev_warn+0x11e/0x165 drivers/base/core.c:4969
firmware_fallback_sysfs+0x674/0x940 drivers/base/firmware_loader/fallback.c:229
_request_firmware+0xc13/0x1200 drivers/base/firmware_loader/main.c:856
request_firmware_work_func+0x126/0x270 drivers/base/firmware_loader/main.c:1105
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307

-> #0 ((console_sem).lock){-...}-{2:2}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
down_trylock+0x1c/0xa0 kernel/locking/semaphore.c:139
__down_trylock_console_sem+0x105/0x250 kernel/printk/printk.c:243
console_trylock kernel/printk/printk.c:2644 [inline]
console_trylock_spinning kernel/printk/printk.c:1896 [inline]
vprintk_emit+0x1ee/0x740 kernel/printk/printk.c:2296
_printk+0xd1/0x111 kernel/printk/printk.c:2322
__report_bug lib/bug.c:195 [inline]
report_bug+0x342/0x500 lib/bug.c:219
handle_bug+0x3d/0x70 arch/x86/kernel/traps.c:324
exc_invalid_op+0x16/0x40 arch/x86/kernel/traps.c:345
asm_exc_invalid_op+0x16/0x20 arch/x86/include/asm/idtentry.h:568
__local_bh_disable_ip+0x1ec/0x210 kernel/softirq.c:345
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:125 [inline]
_raw_spin_lock_bh+0x18/0x40 kernel/locking/spinlock.c:178
sock_hash_delete_elem+0xac/0x2f0 net/core/sock_map.c:932
bpf_prog_2e01b746faa822d9+0x42/0x46
bpf_dispatcher_nop_func include/linux/bpf.h:989 [inline]
__bpf_prog_run include/linux/filter.h:603 [inline]
bpf_prog_run include/linux/filter.h:610 [inline]
__bpf_trace_run kernel/trace/bpf_trace.c:2273 [inline]
bpf_trace_run2+0x1fd/0x410 kernel/trace/bpf_trace.c:2312
trace_sched_migrate_task include/trace/events/sched.h:274 [inline]
set_task_cpu+0x503/0x5a0 kernel/sched/core.c:3154
try_to_wake_up+0x544/0x12e0 kernel/sched/core.c:4222
hrtimer_wakeup+0x5e/0x70 kernel/time/hrtimer.c:1940
__run_hrtimer kernel/time/hrtimer.c:1686 [inline]
__hrtimer_run_queues+0x5e5/0xe50 kernel/time/hrtimer.c:1750
hrtimer_interrupt+0x392/0x980 kernel/time/hrtimer.c:1812
local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1095 [inline]
__sysvec_apic_timer_interrupt+0x156/0x580 arch/x86/kernel/apic/apic.c:1112
sysvec_apic_timer_interrupt+0x8c/0xb0 arch/x86/kernel/apic/apic.c:1106
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:653
native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline]
arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline]
acpi_safe_halt drivers/acpi/processor_idle.c:112 [inline]
acpi_idle_do_entry+0x10f/0x340 drivers/acpi/processor_idle.c:572
acpi_idle_enter+0x352/0x4f0 drivers/acpi/processor_idle.c:709
cpuidle_enter_state+0x516/0xf80 drivers/cpuidle/cpuidle.c:239
cpuidle_enter+0x59/0x90 drivers/cpuidle/cpuidle.c:356
call_cpuidle kernel/sched/idle.c:155 [inline]
cpuidle_idle_call kernel/sched/idle.c:236 [inline]
do_idle+0x3ce/0x680 kernel/sched/idle.c:303
cpu_startup_entry+0x3d/0x60 kernel/sched/idle.c:401
rest_init+0x2da/0x300 init/main.c:732
start_kernel+0x0/0x53f init/main.c:892
start_kernel+0x496/0x53f init/main.c:1139
secondary_startup_64_no_verify+0xcf/0xdb

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&p->pi_lock);
lock((console_sem).lock);
lock(&p->pi_lock);
lock((console_sem).lock);

*** DEADLOCK ***

2 locks held by swapper/0/0:
#0: ffff88802990c598 (&p->pi_lock){-.-.}-{2:2}, at: try_to_wake_up+0xad/0x12e0 kernel/sched/core.c:4112
#1: ffffffff8d12a940 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:350 [inline]
#1: ffffffff8d12a940 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:791 [inline]
#1: ffffffff8d12a940 (rcu_read_lock){....}-{1:2}, at: __bpf_trace_run kernel/trace/bpf_trace.c:2272 [inline]
#1: ffffffff8d12a940 (rcu_read_lock){....}-{1:2}, at: bpf_trace_run2+0x110/0x410 kernel/trace/bpf_trace.c:2312

stack backtrace:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.1.83-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
down_trylock+0x1c/0xa0 kernel/locking/semaphore.c:139
__down_trylock_console_sem+0x105/0x250 kernel/printk/printk.c:243
console_trylock kernel/printk/printk.c:2644 [inline]
console_trylock_spinning kernel/printk/printk.c:1896 [inline]
vprintk_emit+0x1ee/0x740 kernel/printk/printk.c:2296
_printk+0xd1/0x111 kernel/printk/printk.c:2322
__report_bug lib/bug.c:195 [inline]
report_bug+0x342/0x500 lib/bug.c:219
handle_bug+0x3d/0x70 arch/x86/kernel/traps.c:324
exc_invalid_op+0x16/0x40 arch/x86/kernel/traps.c:345
asm_exc_invalid_op+0x16/0x20 arch/x86/include/asm/idtentry.h:568
RIP: 0010:__local_bh_disable_ip+0x1ec/0x210 kernel/softirq.c:321
Code: 00 00 43 c6 44 2c 0b 00 65 48 8b 04 25 28 00 00 00 48 3b 84 24 80 00 00 00 75 2d 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 <0f> 0b e9 a0 fe ff ff e8 f8 de 35 09 41 f7 c6 00 02 00 00 0f 85 52
RSP: 0018:ffffc90000007980 EFLAGS: 00010006
RAX: 0000000080010004 RBX: ffffffff8897e69c RCX: ffffffff8cebd800
RDX: dffffc0000000000 RSI: 0000000000000201 RDI: ffffffff8897e69c
RBP: ffffc90000007a48 R08: 0000000000000005 R09: ffffffff8898283e
R10: 000000000000000c R11: ffffffff8cebd800 R12: dffffc0000000000
R13: 1ffff92000000f34 R14: ffffc900000079e0 R15: 0000000000000201
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:125 [inline]
_raw_spin_lock_bh+0x18/0x40 kernel/locking/spinlock.c:178
sock_hash_delete_elem+0xac/0x2f0 net/core/sock_map.c:932
bpf_prog_2e01b746faa822d9+0x42/0x46
bpf_dispatcher_nop_func include/linux/bpf.h:989 [inline]
__bpf_prog_run include/linux/filter.h:603 [inline]
bpf_prog_run include/linux/filter.h:610 [inline]
__bpf_trace_run kernel/trace/bpf_trace.c:2273 [inline]
bpf_trace_run2+0x1fd/0x410 kernel/trace/bpf_trace.c:2312
trace_sched_migrate_task include/trace/events/sched.h:274 [inline]
set_task_cpu+0x503/0x5a0 kernel/sched/core.c:3154
try_to_wake_up+0x544/0x12e0 kernel/sched/core.c:4222
hrtimer_wakeup+0x5e/0x70 kernel/time/hrtimer.c:1940
__run_hrtimer kernel/time/hrtimer.c:1686 [inline]
__hrtimer_run_queues+0x5e5/0xe50 kernel/time/hrtimer.c:1750
hrtimer_interrupt+0x392/0x980 kernel/time/hrtimer.c:1812
local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1095 [inline]
__sysvec_apic_timer_interrupt+0x156/0x580 arch/x86/kernel/apic/apic.c:1112
sysvec_apic_timer_interrupt+0x8c/0xb0 arch/x86/kernel/apic/apic.c:1106
</IRQ>
<TASK>
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:653
RIP: 0010:native_save_fl arch/x86/include/asm/irqflags.h:22 [inline]
RIP: 0010:arch_local_save_flags arch/x86/include/asm/irqflags.h:70 [inline]
RIP: 0010:arch_irqs_disabled arch/x86/include/asm/irqflags.h:130 [inline]
RIP: 0010:acpi_safe_halt drivers/acpi/processor_idle.c:113 [inline]
RIP: 0010:acpi_idle_do_entry+0x10f/0x340 drivers/acpi/processor_idle.c:572
Code: 67 f6 f6 48 83 e3 08 0f 85 0b 01 00 00 4c 8d 74 24 20 e8 f4 23 fd f6 0f 1f 44 00 00 e8 9a 63 f6 f6 0f 00 2d a3 23 b3 00 fb f4 <4c> 89 f3 48 c1 eb 03 42 80 3c 3b 00 74 08 4c 89 f7 e8 6b d9 4d f7
RSP: 0018:ffffffff8ce07b20 EFLAGS: 000002d3
RAX: ffffffff8a942156 RBX: 0000000000000000 RCX: ffffffff8cebd800
RDX: 0000000000000000 RSI: ffffffff8aebee40 RDI: ffffffff8b3d2b40
RBP: ffffffff8ce07bb0 R08: ffffffff8a942138 R09: fffffbfff19d7b01
R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffffffff19c0f64
R13: ffff888015784804 R14: ffffffff8ce07b40 R15: dffffc0000000000
acpi_idle_enter+0x352/0x4f0 drivers/acpi/processor_idle.c:709
cpuidle_enter_state+0x516/0xf80 drivers/cpuidle/cpuidle.c:239
cpuidle_enter+0x59/0x90 drivers/cpuidle/cpuidle.c:356
call_cpuidle kernel/sched/idle.c:155 [inline]
cpuidle_idle_call kernel/sched/idle.c:236 [inline]
do_idle+0x3ce/0x680 kernel/sched/idle.c:303
cpu_startup_entry+0x3d/0x60 kernel/sched/idle.c:401
rest_init+0x2da/0x300 init/main.c:732
arch_call_rest_init+0xa/0xa init/main.c:892
start_kernel+0x496/0x53f init/main.c:1139
secondary_startup_64_no_verify+0xcf/0xdb
</TASK>
WARNING: CPU: 0 PID: 0 at kernel/softirq.c:321 __local_bh_disable_ip+0x1ec/0x210 kernel/softirq.c:345
Modules linked in:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.1.83-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/29/2024
RIP: 0010:__local_bh_disable_ip+0x1ec/0x210 kernel/softirq.c:321
Code: 00 00 43 c6 44 2c 0b 00 65 48 8b 04 25 28 00 00 00 48 3b 84 24 80 00 00 00 75 2d 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 <0f> 0b e9 a0 fe ff ff e8 f8 de 35 09 41 f7 c6 00 02 00 00 0f 85 52
RSP: 0018:ffffc90000007980 EFLAGS: 00010006
RAX: 0000000080010004 RBX: ffffffff8897e69c RCX: ffffffff8cebd800
RDX: dffffc0000000000 RSI: 0000000000000201 RDI: ffffffff8897e69c
RBP: ffffc90000007a48 R08: 0000000000000005 R09: ffffffff8898283e
R10: 000000000000000c R11: ffffffff8cebd800 R12: dffffc0000000000
R13: 1ffff92000000f34 R14: ffffc900000079e0 R15: 0000000000000201
FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000555555630ca8 CR3: 0000000020de0000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:125 [inline]
_raw_spin_lock_bh+0x18/0x40 kernel/locking/spinlock.c:178
sock_hash_delete_elem+0xac/0x2f0 net/core/sock_map.c:932
bpf_prog_2e01b746faa822d9+0x42/0x46
bpf_dispatcher_nop_func include/linux/bpf.h:989 [inline]
__bpf_prog_run include/linux/filter.h:603 [inline]
bpf_prog_run include/linux/filter.h:610 [inline]
__bpf_trace_run kernel/trace/bpf_trace.c:2273 [inline]
bpf_trace_run2+0x1fd/0x410 kernel/trace/bpf_trace.c:2312
trace_sched_migrate_task include/trace/events/sched.h:274 [inline]
set_task_cpu+0x503/0x5a0 kernel/sched/core.c:3154
try_to_wake_up+0x544/0x12e0 kernel/sched/core.c:4222
hrtimer_wakeup+0x5e/0x70 kernel/time/hrtimer.c:1940
__run_hrtimer kernel/time/hrtimer.c:1686 [inline]
__hrtimer_run_queues+0x5e5/0xe50 kernel/time/hrtimer.c:1750
hrtimer_interrupt+0x392/0x980 kernel/time/hrtimer.c:1812
local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1095 [inline]
__sysvec_apic_timer_interrupt+0x156/0x580 arch/x86/kernel/apic/apic.c:1112
sysvec_apic_timer_interrupt+0x8c/0xb0 arch/x86/kernel/apic/apic.c:1106
</IRQ>
<TASK>
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:653
RIP: 0010:native_save_fl arch/x86/include/asm/irqflags.h:22 [inline]
RIP: 0010:arch_local_save_flags arch/x86/include/asm/irqflags.h:70 [inline]
RIP: 0010:arch_irqs_disabled arch/x86/include/asm/irqflags.h:130 [inline]
RIP: 0010:acpi_safe_halt drivers/acpi/processor_idle.c:113 [inline]
RIP: 0010:acpi_idle_do_entry+0x10f/0x340 drivers/acpi/processor_idle.c:572
Code: 67 f6 f6 48 83 e3 08 0f 85 0b 01 00 00 4c 8d 74 24 20 e8 f4 23 fd f6 0f 1f 44 00 00 e8 9a 63 f6 f6 0f 00 2d a3 23 b3 00 fb f4 <4c> 89 f3 48 c1 eb 03 42 80 3c 3b 00 74 08 4c 89 f7 e8 6b d9 4d f7
RSP: 0018:ffffffff8ce07b20 EFLAGS: 000002d3
RAX: ffffffff8a942156 RBX: 0000000000000000 RCX: ffffffff8cebd800
RDX: 0000000000000000 RSI: ffffffff8aebee40 RDI: ffffffff8b3d2b40
RBP: ffffffff8ce07bb0 R08: ffffffff8a942138 R09: fffffbfff19d7b01
R10: 0000000000000000 R11: dffffc0000000001 R12: 1ffffffff19c0f64
R13: ffff888015784804 R14: ffffffff8ce07b40 R15: dffffc0000000000
acpi_idle_enter+0x352/0x4f0 drivers/acpi/processor_idle.c:709
cpuidle_enter_state+0x516/0xf80 drivers/cpuidle/cpuidle.c:239
cpuidle_enter+0x59/0x90 drivers/cpuidle/cpuidle.c:356
call_cpuidle kernel/sched/idle.c:155 [inline]
cpuidle_idle_call kernel/sched/idle.c:236 [inline]
do_idle+0x3ce/0x680 kernel/sched/idle.c:303
cpu_startup_entry+0x3d/0x60 kernel/sched/idle.c:401
rest_init+0x2da/0x300 init/main.c:732
arch_call_rest_init+0xa/0xa init/main.c:892
start_kernel+0x496/0x53f init/main.c:1139
secondary_startup_64_no_verify+0xcf/0xdb
</TASK>
----------------
Code disassembly (best guess):
0: 67 f6 f6 addr32 div %dh
3: 48 83 e3 08 and $0x8,%rbx
7: 0f 85 0b 01 00 00 jne 0x118
d: 4c 8d 74 24 20 lea 0x20(%rsp),%r14
12: e8 f4 23 fd f6 call 0xf6fd240b
17: 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1)
1c: e8 9a 63 f6 f6 call 0xf6f663bb
21: 0f 00 2d a3 23 b3 00 verw 0xb323a3(%rip) # 0xb323cb
28: fb sti
29: f4 hlt
* 2a: 4c 89 f3 mov %r14,%rbx <-- trapping instruction
2d: 48 c1 eb 03 shr $0x3,%rbx
31: 42 80 3c 3b 00 cmpb $0x0,(%rbx,%r15,1)
36: 74 08 je 0x40
38: 4c 89 f7 mov %r14,%rdi
3b: e8 6b d9 4d f7 call 0xf74dd9ab


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Apr 5, 2024, 1:03:36 PMApr 5
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 9465fef4ae35 Linux 5.15.153
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=177c5d29180000
kernel config: https://syzkaller.appspot.com/x/.config?x=176c746ee3348b33
dashboard link: https://syzkaller.appspot.com/bug?extid=534c8598d72f81135bab
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2962c02652ce/disk-9465fef4.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/d0f5a1ce082d/vmlinux-9465fef4.xz
kernel image: https://storage.googleapis.com/syzbot-assets/86b5b1eea636/bzImage-9465fef4.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+534c85...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
5.15.153-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/4505 is trying to acquire lock:
ffff88801c27e368 (&p->pi_lock){-.-.}-{2:2}, at: try_to_wake_up+0xae/0x1300 kernel/sched/core.c:4030

but task is already holding lock:
ffffffff8c7fbf78 ((console_sem).lock){....}-{2:2}, at: up+0x19/0x90 kernel/locking/semaphore.c:186

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 ((console_sem).lock){....}-{2:2}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
down_trylock+0x1c/0xa0 kernel/locking/semaphore.c:138
__down_trylock_console_sem+0x105/0x250 kernel/printk/printk.c:239
console_trylock kernel/printk/printk.c:2569 [inline]
console_trylock_spinning+0x8a/0x3f0 kernel/printk/printk.c:1867
vprintk_emit+0xa6/0x150 kernel/printk/printk.c:2267
_printk+0xd1/0x111 kernel/printk/printk.c:2293
debug_objects_oom+0xb4/0x370 lib/debugobjects.c:472
debug_object_activate+0x42d/0x4e0 lib/debugobjects.c:698
debug_rcu_head_queue kernel/rcu/rcu.h:176 [inline]
kvfree_call_rcu+0xb6/0x8a0 kernel/rcu/tree.c:3587
trie_update_elem+0x808/0xc00 kernel/bpf/lpm_trie.c:384
bpf_map_update_value+0x5d7/0x6c0 kernel/bpf/syscall.c:221
generic_map_update_batch+0x54d/0x8b0 kernel/bpf/syscall.c:1421
bpf_map_do_batch+0x4d0/0x620
__sys_bpf+0x55c/0x670
__do_sys_bpf kernel/bpf/syscall.c:4755 [inline]
__se_sys_bpf kernel/bpf/syscall.c:4753 [inline]
__x64_sys_bpf+0x78/0x90 kernel/bpf/syscall.c:4753
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #2 (&trie->lock){....}-{2:2}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
trie_delete_elem+0x90/0x690 kernel/bpf/lpm_trie.c:450
0xffffffffa0028dfd
bpf_dispatcher_nop_func include/linux/bpf.h:785 [inline]
__bpf_prog_run include/linux/filter.h:628 [inline]
bpf_prog_run include/linux/filter.h:635 [inline]
__bpf_trace_run kernel/trace/bpf_trace.c:1880 [inline]
bpf_trace_run3+0x1d1/0x380 kernel/trace/bpf_trace.c:1918
__traceiter_sched_switch+0x7d/0xb0 include/trace/events/sched.h:220
trace_sched_switch include/trace/events/sched.h:220 [inline]
__schedule+0x1e8d/0x45b0 kernel/sched/core.c:6373
schedule+0x11b/0x1f0 kernel/sched/core.c:6459
freezable_schedule include/linux/freezer.h:172 [inline]
do_nanosleep+0x1bc/0x7b0 kernel/time/hrtimer.c:2045
hrtimer_nanosleep+0x24d/0x490 kernel/time/hrtimer.c:2098
__do_sys_clock_nanosleep kernel/time/posix-timers.c:1313 [inline]
__se_sys_clock_nanosleep+0x323/0x3b0 kernel/time/posix-timers.c:1290
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&rq->__lock){-.-.}-{2:2}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
_raw_spin_lock_nested+0x2d/0x40 kernel/locking/spinlock.c:368
raw_spin_rq_lock_nested+0x26/0x140 kernel/sched/core.c:475
raw_spin_rq_lock kernel/sched/sched.h:1326 [inline]
rq_lock kernel/sched/sched.h:1621 [inline]
task_fork_fair+0x5d/0x350 kernel/sched/fair.c:11480
sched_cgroup_fork+0x2d3/0x330 kernel/sched/core.c:4466
copy_process+0x224a/0x3ef0 kernel/fork.c:2320
kernel_clone+0x210/0x960 kernel/fork.c:2604
kernel_thread+0x168/0x1e0 kernel/fork.c:2656
rest_init+0x21/0x330 init/main.c:704
start_kernel+0x48c/0x535 init/main.c:1138
secondary_startup_64_no_verify+0xb1/0xbb

-> #0 (&p->pi_lock){-.-.}-{2:2}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
try_to_wake_up+0xae/0x1300 kernel/sched/core.c:4030
up+0x6e/0x90 kernel/locking/semaphore.c:190
__up_console_sem+0x11a/0x1e0 kernel/printk/printk.c:256
console_unlock+0x1145/0x12b0 kernel/printk/printk.c:2754
vprintk_emit+0xbf/0x150 kernel/printk/printk.c:2268
_printk+0xd1/0x111 kernel/printk/printk.c:2293
handle_bad_sector block/blk-core.c:655 [inline]
bio_check_eod block/blk-core.c:728 [inline]
submit_bio_checks+0x10b1/0x1940 block/blk-core.c:812
__submit_bio+0x5a1/0x850 block/blk-core.c:911
__submit_bio_noacct_mq block/blk-core.c:997 [inline]
submit_bio_noacct+0x955/0xb30 block/blk-core.c:1027
submit_bio+0x2dd/0x560 block/blk-core.c:1089
submit_bh fs/buffer.c:3062 [inline]
block_read_full_page+0x93b/0xde0 fs/buffer.c:2341
do_read_cache_page+0x752/0x1040
read_mapping_page include/linux/pagemap.h:515 [inline]
hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37
hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
cont_expand_zero fs/buffer.c:2431 [inline]
cont_write_begin+0x654/0x840 fs/buffer.c:2461
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_cont_expand_simple+0x144/0x230 fs/buffer.c:2362
hfsplus_setattr+0x169/0x280 fs/hfsplus/inode.c:261
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
do_sys_ftruncate+0x2eb/0x390 fs/open.c:193
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
&p->pi_lock --> &trie->lock --> (console_sem).lock

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock((console_sem).lock);
lock(&trie->lock);
lock((console_sem).lock);
lock(&p->pi_lock);

*** DEADLOCK ***

5 locks held by syz-executor.4/4505:
#0: ffff88806020a460 (sb_writers#17){.+.+}-{0:0}, at: do_sys_ftruncate+0x25a/0x390 fs/open.c:190
#1: ffff8880770809c0 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline]
#1: ffff8880770809c0 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: do_truncate+0x208/0x300 fs/open.c:63
#2: ffff8880770807c8 (&hip->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457
#3: ffff8880757668f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35
#4: ffffffff8c7fbf78 ((console_sem).lock){....}-{2:2}, at: up+0x19/0x90 kernel/locking/semaphore.c:186

stack backtrace:
CPU: 1 PID: 4505 Comm: syz-executor.4 Not tainted 5.15.153-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
_raw_spin_lock_irqsave+0xd1/0x120 kernel/locking/spinlock.c:162
try_to_wake_up+0xae/0x1300 kernel/sched/core.c:4030
up+0x6e/0x90 kernel/locking/semaphore.c:190
__up_console_sem+0x11a/0x1e0 kernel/printk/printk.c:256
console_unlock+0x1145/0x12b0 kernel/printk/printk.c:2754
vprintk_emit+0xbf/0x150 kernel/printk/printk.c:2268
_printk+0xd1/0x111 kernel/printk/printk.c:2293
handle_bad_sector block/blk-core.c:655 [inline]
bio_check_eod block/blk-core.c:728 [inline]
submit_bio_checks+0x10b1/0x1940 block/blk-core.c:812
__submit_bio+0x5a1/0x850 block/blk-core.c:911
__submit_bio_noacct_mq block/blk-core.c:997 [inline]
submit_bio_noacct+0x955/0xb30 block/blk-core.c:1027
submit_bio+0x2dd/0x560 block/blk-core.c:1089
submit_bh fs/buffer.c:3062 [inline]
block_read_full_page+0x93b/0xde0 fs/buffer.c:2341
do_read_cache_page+0x752/0x1040
read_mapping_page include/linux/pagemap.h:515 [inline]
hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37
hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468
hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245
__block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012
__block_write_begin fs/buffer.c:2062 [inline]
block_write_begin fs/buffer.c:2122 [inline]
cont_write_begin+0x5d6/0x840 fs/buffer.c:2471
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
cont_expand_zero fs/buffer.c:2431 [inline]
cont_write_begin+0x654/0x840 fs/buffer.c:2461
hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53
generic_cont_expand_simple+0x144/0x230 fs/buffer.c:2362
hfsplus_setattr+0x169/0x280 fs/hfsplus/inode.c:261
notify_change+0xc6d/0xf50 fs/attr.c:505
do_truncate+0x21c/0x300 fs/open.c:65
do_sys_ftruncate+0x2eb/0x390 fs/open.c:193
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f4ca0504e69
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4c9ea770c8 EFLAGS: 00000246 ORIG_RAX: 000000000000004d
RAX: ffffffffffffffda RBX: 00007f4ca0632f80 RCX: 00007f4ca0504e69
RDX: 0000000000000000 RSI: 0000000000000800 RDI: 0000000000000004
RBP: 00007f4ca055147a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007f4ca0632f80 R15: 00007ffe3378c6b8
</TASK>
Buffer I/O error on dev loop4, logical block 100663296, async page read
attempt to access beyond end of device
loop4: rw=0, want=201326594, limit=1024
Buffer I/O error on dev loop4, logical block 100663296, async page read


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

Reply all
Reply to author
Forward
0 new messages