[v6.1] possible deadlock in ext4_ioctl (3)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: ae9f2a70d69e Linux 6.1.93
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1485112e980000
kernel config: https://syzkaller.appspot.com/x/.config?x=1d7ac9fef66f54aa
dashboard link: https://syzkaller.appspot.com/bug?extid=beabd1f6d2a7dd0026a1
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/b6a79d8f90ec/disk-ae9f2a70.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f1b3e75b81f1/vmlinux-ae9f2a70.xz
kernel image: https://storage.googleapis.com/syzbot-assets/80fc2213e3e5/bzImage-ae9f2a70.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+beabd1...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
6.1.93-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/21615 is trying to acquire lock:
ffff888053850288 (&ei->i_data_sem/1){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline]
ffff888053850288 (&ei->i_data_sem/1){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1424 [inline]
ffff888053850288 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_ioctl+0x460f/0x5f60 fs/ext4/ioctl.c:1614

but task is already holding lock:
ffff888027c99698 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ei->i_data_sem/2){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574
ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866
ext4_bread+0x2a/0x170 fs/ext4/inode.c:922
ext4_quota_read+0x1a1/0x2c0 fs/ext4/super.c:7101
read_blk fs/quota/quota_tree.c:55 [inline]
find_tree_dqentry+0x190/0xc10 fs/quota/quota_tree.c:624
find_tree_dqentry+0x48a/0xc10 fs/quota/quota_tree.c:640
find_tree_dqentry+0x48a/0xc10 fs/quota/quota_tree.c:640
find_tree_dqentry+0x48a/0xc10 fs/quota/quota_tree.c:640
find_dqentry fs/quota/quota_tree.c:652 [inline]
qtree_read_dquot+0x13f/0x650 fs/quota/quota_tree.c:672
v2_read_dquot+0xbe/0x100 fs/quota/quota_v2.c:333
dquot_acquire+0x188/0x680 fs/quota/dquot.c:463
ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6773
dqget+0x74e/0xe30 fs/quota/dquot.c:986
__dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1516
ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5533 [inline]
ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664
get_tree_bdev+0x3fe/0x620 fs/super.c:1355
vfs_get_tree+0x88/0x270 fs/super.c:1562
do_new_mount+0x2ba/0xb40 fs/namespace.c:3051
do_mount fs/namespace.c:3394 [inline]
__do_sys_mount fs/namespace.c:3602 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_read+0xad/0xa30 kernel/locking/rwsem.c:1520
v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332
dquot_acquire+0x188/0x680 fs/quota/dquot.c:463
ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6773
dqget+0x74e/0xe30 fs/quota/dquot.c:986
__dquot_initialize+0x45e/0xea0 fs/quota/dquot.c:1516
ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474
__ext4_fill_super fs/ext4/super.c:5533 [inline]
ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664
get_tree_bdev+0x3fe/0x620 fs/super.c:1355
vfs_get_tree+0x88/0x270 fs/super.c:1562
do_new_mount+0x2ba/0xb40 fs/namespace.c:3051
do_mount fs/namespace.c:3394 [inline]
__do_sys_mount fs/namespace.c:3602 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
dquot_commit+0x57/0x510 fs/quota/dquot.c:507
ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6753
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412
__dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1751
dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
dquot_alloc_space include/linux/quotaops.h:313 [inline]
dquot_alloc_block include/linux/quotaops.h:337 [inline]
ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5731
ext4_new_meta_blocks+0x206/0x4f0 fs/ext4/balloc.c:739
ext4_ext_grow_indepth fs/ext4/extents.c:1329 [inline]
ext4_ext_create_new_leaf fs/ext4/extents.c:1435 [inline]
ext4_ext_insert_extent+0xf43/0x4e50 fs/ext4/extents.c:2102
ext4_split_extent_at+0x80e/0x10f0 fs/ext4/extents.c:3230
ext4_force_split_extent_at fs/ext4/extents.c:338 [inline]
ext4_swap_extents+0x12fb/0x2280 fs/ext4/extents.c:5746
move_extent_per_page+0x1e8b/0x42d0 fs/ext4/move_extent.c:368
ext4_move_extents+0x9cf/0xe30 fs/ext4/move_extent.c:679
__ext4_ioctl fs/ext4/ioctl.c:1358 [inline]
ext4_ioctl+0x3a8d/0x5f60 fs/ext4/ioctl.c:1614
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (&ei->i_data_sem/1){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_write_nested+0x39/0x60 kernel/locking/rwsem.c:1689
swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1424 [inline]
ext4_ioctl+0x460f/0x5f60 fs/ext4/ioctl.c:1614
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

Chain exists of:
&ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ei->i_data_sem/2);
lock(&s->s_dquot.dqio_sem);
lock(&ei->i_data_sem/2);
lock(&ei->i_data_sem/1);

*** DEADLOCK ***

6 locks held by syz-executor.1/21615:
#0: ffff88814c808460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:437
#1: ffff888027c99810 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
#1: ffff888027c99810 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1165
#2: ffff888053850400 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:385 [inline]
#2: ffff888053850400 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1424 [inline]
#2: ffff888053850400 (&sb->s_type->i_mutex_key#8/4){+.+.}-{3:3}, at: ext4_ioctl+0x25ff/0x5f60 fs/ext4/ioctl.c:1614
#3: ffff888027c999b0 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline]
#3: ffff888027c999b0 (mapping.invalidate_lock){++++}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:402 [inline]
#3: ffff888027c999b0 (mapping.invalidate_lock){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1424 [inline]
#3: ffff888027c999b0 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_ioctl+0x42d7/0x5f60 fs/ext4/ioctl.c:1614
#4: ffff88814c80c990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f51/0x21b0 fs/jbd2/transaction.c:463
#5: ffff888027c99698 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

stack backtrace:
CPU: 0 PID: 21615 Comm: syz-executor.1 Not tainted 6.1.93-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
down_write_nested+0x39/0x60 kernel/locking/rwsem.c:1689
swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1424 [inline]
ext4_ioctl+0x460f/0x5f60 fs/ext4/ioctl.c:1614
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7ff45ec7cea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff45f92a0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ff45edb3f80 RCX: 00007ff45ec7cea9
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000003
RBP: 00007ff45ecebff4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007ff45edb3f80 R15: 00007fff9fc4df98
</TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup