[v5.15] possible deadlock in rfkill_fop_write
3 views
Skip to first unread message
syzbot
Oct 25, 2023, 8:40:44 AM10/25/23
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 12952a23a5da Linux 5.15.137
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=123c1859680000
kernel config: https://syzkaller.appspot.com/x/.config?x=fec74236cf840914
dashboard link: https://syzkaller.appspot.com/bug?extid=586a07bb94a04b057c74
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d0102e80bd83/disk-12952a23.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ad4bb1832eb8/vmlinux-12952a23.xz
kernel image: https://storage.googleapis.com/syzbot-assets/530bbc85fac0/bzImage-12952a23.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+586a07...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.137-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/14328 is trying to acquire lock:
ffff88801dbfcc28 ((work_completion)(&hdev->bg_scan_update)){+.+.}-{0:0}, at: __flush_work+0xcf/0x1a0 kernel/workqueue.c:3090
but task is already holding lock:
ffffffff8dc66a88 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a5/0x790 net/rfkill/core.c:1266
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (rfkill_global_mutex){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
rfkill_register+0x30/0x880 net/rfkill/core.c:1045
hci_register_dev+0x4dd/0xa50 net/bluetooth/hci_core.c:3959
__vhci_create_device drivers/bluetooth/hci_vhci.c:129 [inline]
vhci_create_device+0x310/0x590 drivers/bluetooth/hci_vhci.c:153
vhci_get_user drivers/bluetooth/hci_vhci.c:210 [inline]
vhci_write+0x382/0x430 drivers/bluetooth/hci_vhci.c:290
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacf/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
-> #3 (&data->open_mutex){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
vhci_send_frame+0x8a/0xf0 drivers/bluetooth/hci_vhci.c:71
hci_send_frame+0x1af/0x2f0 net/bluetooth/hci_core.c:4251
hci_sched_acl_pkt net/bluetooth/hci_core.c:4776 [inline]
hci_sched_acl net/bluetooth/hci_core.c:4861 [inline]
hci_tx_work+0xb0b/0x19d0 net/bluetooth/hci_core.c:4932
process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
-> #2 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
hci_dev_do_close+0x20a/0x1070 net/bluetooth/hci_core.c:1756
hci_unregister_dev+0x2a7/0x550 net/bluetooth/hci_core.c:4035
vhci_release+0x73/0xc0 drivers/bluetooth/hci_vhci.c:345
__fput+0x3bf/0x890 fs/file_table.c:280
task_work_run+0x129/0x1a0 kernel/task_work.c:164
exit_task_work include/linux/task_work.h:32 [inline]
do_exit+0x6a3/0x2480 kernel/exit.c:872
do_group_exit+0x144/0x310 kernel/exit.c:994
__do_sys_exit_group kernel/exit.c:1005 [inline]
__se_sys_exit_group kernel/exit.c:1003 [inline]
__x64_sys_exit_group+0x3b/0x40 kernel/exit.c:1003
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
-> #1 (&hdev->req_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hci_req_sync net/bluetooth/hci_request.c:276 [inline]
bg_scan_update+0xa1/0x4a0 net/bluetooth/hci_request.c:2950
process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
-> #0 ((work_completion)(&hdev->bg_scan_update)){+.+.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
__cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
hci_request_cancel_all+0xcb/0x300 net/bluetooth/hci_request.c:3520
hci_dev_do_close+0x51/0x1070 net/bluetooth/hci_core.c:1736
hci_rfkill_set_block+0x114/0x1a0 net/bluetooth/hci_core.c:2235
rfkill_set_block+0x1e7/0x430 net/rfkill/core.c:345
rfkill_fop_write+0x5b7/0x790 net/rfkill/core.c:1274
vfs_write+0x30c/0xe50 fs/read_write.c:592
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
other info that might help us debug this:
Chain exists of:
(work_completion)(&hdev->bg_scan_update) --> &data->open_mutex --> rfkill_global_mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(rfkill_global_mutex);
lock(&data->open_mutex);
lock(rfkill_global_mutex);
lock((work_completion)(&hdev->bg_scan_update));
*** DEADLOCK ***
1 lock held by syz-executor.5/14328:
#0: ffffffff8dc66a88 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a5/0x790 net/rfkill/core.c:1266
stack backtrace:
CPU: 1 PID: 14328 Comm: syz-executor.5 Not tainted 5.15.137-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
__cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
hci_request_cancel_all+0xcb/0x300 net/bluetooth/hci_request.c:3520
hci_dev_do_close+0x51/0x1070 net/bluetooth/hci_core.c:1736
hci_rfkill_set_block+0x114/0x1a0 net/bluetooth/hci_core.c:2235
rfkill_set_block+0x1e7/0x430 net/rfkill/core.c:345
rfkill_fop_write+0x5b7/0x790 net/rfkill/core.c:1274
vfs_write+0x30c/0xe50 fs/read_write.c:592
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7ff60f0f1ae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff60d6730c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007ff60f210f80 RCX: 00007ff60f0f1ae9
RDX: 0000000000000008 RSI: 0000000020000080 RDI: 0000000000000003
RBP: 00007ff60f13d47a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007ff60f210f80 R15: 00007fff14261d88
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: 12952a23a5da Linux 5.15.137
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=123c1859680000
kernel config: https://syzkaller.appspot.com/x/.config?x=fec74236cf840914
dashboard link: https://syzkaller.appspot.com/bug?extid=586a07bb94a04b057c74
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d0102e80bd83/disk-12952a23.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ad4bb1832eb8/vmlinux-12952a23.xz
kernel image: https://storage.googleapis.com/syzbot-assets/530bbc85fac0/bzImage-12952a23.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+586a07...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
5.15.137-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/14328 is trying to acquire lock:
ffff88801dbfcc28 ((work_completion)(&hdev->bg_scan_update)){+.+.}-{0:0}, at: __flush_work+0xcf/0x1a0 kernel/workqueue.c:3090
but task is already holding lock:
ffffffff8dc66a88 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a5/0x790 net/rfkill/core.c:1266
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #4 (rfkill_global_mutex){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
rfkill_register+0x30/0x880 net/rfkill/core.c:1045
hci_register_dev+0x4dd/0xa50 net/bluetooth/hci_core.c:3959
__vhci_create_device drivers/bluetooth/hci_vhci.c:129 [inline]
vhci_create_device+0x310/0x590 drivers/bluetooth/hci_vhci.c:153
vhci_get_user drivers/bluetooth/hci_vhci.c:210 [inline]
vhci_write+0x382/0x430 drivers/bluetooth/hci_vhci.c:290
call_write_iter include/linux/fs.h:2103 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0xacf/0xe50 fs/read_write.c:594
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
-> #3 (&data->open_mutex){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
vhci_send_frame+0x8a/0xf0 drivers/bluetooth/hci_vhci.c:71
hci_send_frame+0x1af/0x2f0 net/bluetooth/hci_core.c:4251
hci_sched_acl_pkt net/bluetooth/hci_core.c:4776 [inline]
hci_sched_acl net/bluetooth/hci_core.c:4861 [inline]
hci_tx_work+0xb0b/0x19d0 net/bluetooth/hci_core.c:4932
process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
-> #2 ((work_completion)(&hdev->tx_work)){+.+.}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
hci_dev_do_close+0x20a/0x1070 net/bluetooth/hci_core.c:1756
hci_unregister_dev+0x2a7/0x550 net/bluetooth/hci_core.c:4035
vhci_release+0x73/0xc0 drivers/bluetooth/hci_vhci.c:345
__fput+0x3bf/0x890 fs/file_table.c:280
task_work_run+0x129/0x1a0 kernel/task_work.c:164
exit_task_work include/linux/task_work.h:32 [inline]
do_exit+0x6a3/0x2480 kernel/exit.c:872
do_group_exit+0x144/0x310 kernel/exit.c:994
__do_sys_exit_group kernel/exit.c:1005 [inline]
__se_sys_exit_group kernel/exit.c:1003 [inline]
__x64_sys_exit_group+0x3b/0x40 kernel/exit.c:1003
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
-> #1 (&hdev->req_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
hci_req_sync net/bluetooth/hci_request.c:276 [inline]
bg_scan_update+0xa1/0x4a0 net/bluetooth/hci_request.c:2950
process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310
worker_thread+0xaca/0x1280 kernel/workqueue.c:2457
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
-> #0 ((work_completion)(&hdev->bg_scan_update)){+.+.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
__cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
hci_request_cancel_all+0xcb/0x300 net/bluetooth/hci_request.c:3520
hci_dev_do_close+0x51/0x1070 net/bluetooth/hci_core.c:1736
hci_rfkill_set_block+0x114/0x1a0 net/bluetooth/hci_core.c:2235
rfkill_set_block+0x1e7/0x430 net/rfkill/core.c:345
rfkill_fop_write+0x5b7/0x790 net/rfkill/core.c:1274
vfs_write+0x30c/0xe50 fs/read_write.c:592
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
other info that might help us debug this:
Chain exists of:
(work_completion)(&hdev->bg_scan_update) --> &data->open_mutex --> rfkill_global_mutex
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(rfkill_global_mutex);
lock(&data->open_mutex);
lock(rfkill_global_mutex);
lock((work_completion)(&hdev->bg_scan_update));
*** DEADLOCK ***
1 lock held by syz-executor.5/14328:
#0: ffffffff8dc66a88 (rfkill_global_mutex){+.+.}-{3:3}, at: rfkill_fop_write+0x1a5/0x790 net/rfkill/core.c:1266
stack backtrace:
CPU: 1 PID: 14328 Comm: syz-executor.5 Not tainted 5.15.137-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__flush_work+0xeb/0x1a0 kernel/workqueue.c:3090
__cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3181
hci_request_cancel_all+0xcb/0x300 net/bluetooth/hci_request.c:3520
hci_dev_do_close+0x51/0x1070 net/bluetooth/hci_core.c:1736
hci_rfkill_set_block+0x114/0x1a0 net/bluetooth/hci_core.c:2235
rfkill_set_block+0x1e7/0x430 net/rfkill/core.c:345
rfkill_fop_write+0x5b7/0x790 net/rfkill/core.c:1274
vfs_write+0x30c/0xe50 fs/read_write.c:592
ksys_write+0x1a2/0x2c0 fs/read_write.c:647
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7ff60f0f1ae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff60d6730c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007ff60f210f80 RCX: 00007ff60f0f1ae9
RDX: 0000000000000008 RSI: 0000000020000080 RDI: 0000000000000003
RBP: 00007ff60f13d47a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007ff60f210f80 R15: 00007fff14261d88
</TASK>
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages