possible deadlock in target_revfn

6 views
Skip to first unread message

syzbot

unread,
Mar 17, 2021, 1:55:16 PM3/17/21
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: cb83ddcd Linux 4.14.226
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=100f55ecd00000
kernel config: https://syzkaller.appspot.com/x/.config?x=124f4e6b89b71fac
dashboard link: https://syzkaller.appspot.com/bug?extid=5ada7cef22db1e5045a9

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+5ada7c...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
4.14.226-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/19475 is trying to acquire lock:
(&xt[i].mutex){+.+.}, at: [<ffffffff85ef55e3>] target_revfn+0x43/0x210 net/netfilter/x_tables.c:354

but task is already holding lock:
(&table[i].mutex){+.+.}, at: [<ffffffff85e219e6>] nfnl_lock net/netfilter/nfnetlink.c:61 [inline]
(&table[i].mutex){+.+.}, at: [<ffffffff85e219e6>] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&table[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93
call_netdevice_notifiers_info net/core/dev.c:1667 [inline]
call_netdevice_notifiers net/core/dev.c:1683 [inline]
rollback_registered_many+0x765/0xba0 net/core/dev.c:7203
rollback_registered+0xca/0x170 net/core/dev.c:7245
unregister_netdevice_queue+0x1b4/0x360 net/core/dev.c:8266
br_del_bridge+0xa9/0xe0 net/bridge/br_if.c:419
br_ioctl_deviceless_stub+0x1ff/0x5f0 net/bridge/br_ioctl.c:380
sock_ioctl+0x254/0x4c0 net/socket.c:1038
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x75a/0xff0 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x7f/0xb0 fs/ioctl.c:692
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #1 (rtnl_mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
unregister_netdevice_notifier+0x5e/0x2b0 net/core/dev.c:1630
tee_tg_destroy+0x5c/0xb0 net/netfilter/xt_TEE.c:123
cleanup_entry+0x232/0x310 net/ipv6/netfilter/ip6_tables.c:684
__do_replace+0x38d/0x580 net/ipv6/netfilter/ip6_tables.c:1105
do_replace net/ipv6/netfilter/ip6_tables.c:1161 [inline]
do_ip6t_set_ctl+0x256/0x3b0 net/ipv6/netfilter/ip6_tables.c:1685
nf_sockopt net/netfilter/nf_sockopt.c:106 [inline]
nf_setsockopt+0x5f/0xb0 net/netfilter/nf_sockopt.c:115
ipv6_setsockopt+0xc0/0x120 net/ipv6/ipv6_sockglue.c:937
tcp_setsockopt+0x7b/0xc0 net/ipv4/tcp.c:2828
SYSC_setsockopt net/socket.c:1865 [inline]
SyS_setsockopt+0x110/0x1e0 net/socket.c:1844
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #0 (&xt[i].mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
target_revfn+0x43/0x210 net/netfilter/x_tables.c:354
xt_find_revision+0x15e/0x1d0 net/netfilter/x_tables.c:378
nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678
nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214
netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2433
nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515
netlink_unicast_kernel net/netlink/af_netlink.c:1287 [inline]
netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1313
netlink_sendmsg+0x62e/0xb80 net/netlink/af_netlink.c:1878
sock_sendmsg_nosec net/socket.c:646 [inline]
sock_sendmsg+0xb5/0x100 net/socket.c:656
___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb

other info that might help us debug this:

Chain exists of:
&xt[i].mutex --> rtnl_mutex --> &table[i].mutex

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&table[i].mutex);
lock(rtnl_mutex);
lock(&table[i].mutex);
lock(&xt[i].mutex);

*** DEADLOCK ***

1 lock held by syz-executor.5/19475:
#0: (&table[i].mutex){+.+.}, at: [<ffffffff85e219e6>] nfnl_lock net/netfilter/nfnetlink.c:61 [inline]
#0: (&table[i].mutex){+.+.}, at: [<ffffffff85e219e6>] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209

stack backtrace:
CPU: 0 PID: 19475 Comm: syz-executor.5 Not tainted 4.14.226-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x281 lib/dump_stack.c:58
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1905 [inline]
check_prevs_add kernel/locking/lockdep.c:2022 [inline]
validate_chain kernel/locking/lockdep.c:2464 [inline]
__lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
target_revfn+0x43/0x210 net/netfilter/x_tables.c:354
xt_find_revision+0x15e/0x1d0 net/netfilter/x_tables.c:378
nfnl_compat_get+0x1f7/0x870 net/netfilter/nft_compat.c:678
nfnetlink_rcv_msg+0x9bb/0xc00 net/netfilter/nfnetlink.c:214
netlink_rcv_skb+0x125/0x390 net/netlink/af_netlink.c:2433
nfnetlink_rcv+0x1ab/0x1da0 net/netfilter/nfnetlink.c:515
netlink_unicast_kernel net/netlink/af_netlink.c:1287 [inline]
netlink_unicast+0x437/0x610 net/netlink/af_netlink.c:1313
netlink_sendmsg+0x62e/0xb80 net/netlink/af_netlink.c:1878
sock_sendmsg_nosec net/socket.c:646 [inline]
sock_sendmsg+0xb5/0x100 net/socket.c:656
___sys_sendmsg+0x6c8/0x800 net/socket.c:2062
__sys_sendmsg+0xa3/0x120 net/socket.c:2096
SYSC_sendmsg net/socket.c:2107 [inline]
SyS_sendmsg+0x27/0x40 net/socket.c:2103
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x465f69
RSP: 002b:00007f901f4be188 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000056bf60 RCX: 0000000000465f69
RDX: 0000000000000000 RSI: 0000000020000100 RDI: 0000000000000004
RBP: 00000000004bfa8f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf60
R13: 00007ffcc56bb04f R14: 00007f901f4be300 R15: 0000000000022000
overlayfs: workdir and upperdir must be separate subtrees
overlayfs: workdir and upperdir must be separate subtrees
sctp: [Deprecated]: syz-executor.0 (pid 19530) Use of int in max_burst socket option deprecated.
Use struct sctp_assoc_value instead
overlayfs: workdir and upperdir must be separate subtrees
hfsplus: unable to find HFS+ superblock
hfsplus: unable to find HFS+ superblock
hfsplus: unable to find HFS+ superblock
hfsplus: unable to find HFS+ superblock
hfsplus: unable to find HFS+ superblock
print_req_error: I/O error, dev loop3, sector 0
print_req_error: I/O error, dev loop3, sector 0
print_req_error: I/O error, dev loop3, sector 0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
Apr 10, 2021, 12:52:14 PM4/10/21
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 958e517f Linux 4.14.230
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=171d46a6d00000
kernel config: https://syzkaller.appspot.com/x/.config?x=cdbb0f19434a286f
dashboard link: https://syzkaller.appspot.com/bug?extid=5ada7cef22db1e5045a9
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17039dd9d00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16d766d9d00000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+5ada7c...@syzkaller.appspotmail.com

syz-executor088[8010]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
traps: syz-executor088[8031] trap stack segment ip:404548 sp:7fff6a0c27e0 error:0 in syz-executor088869503[401000+83000]
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
======================================================
WARNING: possible circular locking dependency detected
4.14.230-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor088/8032 is trying to acquire lock:
(&xt[i].mutex){+.+.}, at: [<ffffffff85f08533>] target_revfn+0x43/0x210 net/netfilter/x_tables.c:354

but task is already holding lock:
(&table[i].mutex){+.+.}, at: [<ffffffff85e34936>] nfnl_lock net/netfilter/nfnetlink.c:61 [inline]
(&table[i].mutex){+.+.}, at: [<ffffffff85e34936>] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&table[i].mutex){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
nf_tables_netdev_event+0x10d/0x4d0 net/netfilter/nf_tables_netdev.c:122
notifier_call_chain+0x108/0x1a0 kernel/notifier.c:93
call_netdevice_notifiers_info net/core/dev.c:1667 [inline]
call_netdevice_notifiers net/core/dev.c:1683 [inline]
rollback_registered_many+0x765/0xba0 net/core/dev.c:7203
unregister_netdevice_many.part.0+0x18/0x2e0 net/core/dev.c:8285
unregister_netdevice_many+0x36/0x50 net/core/dev.c:8284
ip6gre_exit_net+0x41e/0x570 net/ipv6/ip6_gre.c:1212
ops_exit_list+0xa5/0x150 net/core/net_namespace.c:142
cleanup_net+0x3b3/0x840 net/core/net_namespace.c:484
process_one_work+0x793/0x14a0 kernel/workqueue.c:2116
worker_thread+0x5cc/0xff0 kernel/workqueue.c:2250
kthread+0x30d/0x420 kernel/kthread.c:232
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:404
1 lock held by syz-executor088/8032:
#0: (&table[i].mutex){+.+.}, at: [<ffffffff85e34936>] nfnl_lock net/netfilter/nfnetlink.c:61 [inline]
#0: (&table[i].mutex){+.+.}, at: [<ffffffff85e34936>] nfnetlink_rcv_msg+0x726/0xc00 net/netfilter/nfnetlink.c:209

stack backtrace:
CPU: 0 PID: 8032 Comm: syz-executor088 Not tainted 4.14.230-syzkaller #0
RIP: 0033:0x440c99
RSP: 002b:00007fff6a0c2848 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000007404 RCX: 0000000000440c99
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000004
RBP: 0000000000000000 R08: 00007fff6a0c29e8 R09: 00007fff6a0c29e8
R10: 00007fff6a0c29e8 R11: 0000000000000246 R12: 00007fff6a0c285c
R13: 431bde82d7b634db R14: 00000000004af018 R15: 0000000000400488
syz-executor088[8032]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
syz-executor088[8057]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
syz-executor088[8144]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
IPVS: ftp: loaded support on port[0] = 21
syz-executor088[8146]: segfault at 1 ip 0000000000000001 sp 00007fff6a0c27b8 error 14
syz-executor088[8167]: segfault at d ip 000000000000000d sp 00007fff6a0c2800 error 14
in syz-executor088869503[400000+1000]
in syz-executor088869503[400000+1000]
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
traps: syz-executor088[8191] trap stack segment ip:404548 sp:7fff6a0c27e0 error:0 in syz-executor088869503[401000+83000]
syz-executor088[8170]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
syz-executor088[8192]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
syz-executor088[8258]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
ip6_tables: ip6tables: counters copy to user failed while replacing table
syz-executor088[8324]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
IPVS: ftp: loaded support on port[0] = 21
syz-executor088[8326]: segfault at 7fff6a0c29e8 ip 00007fff6a0c29e8 sp 00007fff6a0c2858 error 15
ip6_tables: ip6tables: counters copy to user failed while replacing table
IPVS: ftp: loaded support on port[0] = 21
syz-executor088[8370]: segfault at 1 ip 0000000000000001 sp 00007fff6a0c27b8 error 14 in syz-executor088869503[400000+1000]
syz-executor088[8349]: segfault at d ip 000000000000000d sp 00007fff6a0c2800 error 14 in syz-executor088869503[400000+1000]
ip6_tables: ip6tables: counters copy to user failed while replacing table

Reply all
Reply to author
Forward
0 new messages