[hfsplus?] WARNING in hfsplus_bnode_create

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: c4215ee4771b Linux 4.14.302
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1677ab50480000
kernel config: https://syzkaller.appspot.com/x/.config?x=4a9988fe055c9527
dashboard link: https://syzkaller.appspot.com/bug?extid=a55a48f369871ee9f90d
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=15f02214480000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=177fa87c480000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/c93ba055d204/disk-c4215ee4.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/bfbc929a33c1/vmlinux-c4215ee4.xz
kernel image: https://storage.googleapis.com/syzbot-assets/444658051770/bzImage-c4215ee4.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/0f912dc186e5/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+a55a48...@syzkaller.appspotmail.com

hfsplus: xattr searching failed
hfsplus: xattr searching failed
audit: type=1800 audit(1672324642.219:2): pid=8012 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor272" name="file1" dev="loop0" ino=20 res=0
hfsplus: new node 0 already hashed?
------------[ cut here ]------------
WARNING: CPU: 0 PID: 8012 at fs/hfsplus/bnode.c:588 hfsplus_bnode_create.cold+0x1b/0x42 fs/hfsplus/bnode.c:587
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 8012 Comm: syz-executor272 Not tainted 4.14.302-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x281 lib/dump_stack.c:58
panic+0x1f9/0x42d kernel/panic.c:183
__warn.cold+0x20/0x44 kernel/panic.c:547
report_bug+0x208/0x250 lib/bug.c:183
fixup_bug arch/x86/kernel/traps.c:177 [inline]
fixup_bug arch/x86/kernel/traps.c:172 [inline]
do_error_trap+0x195/0x2d0 arch/x86/kernel/traps.c:295
invalid_op+0x1b/0x40 arch/x86/entry/entry_64.S:967
RIP: 0010:hfsplus_bnode_create.cold+0x1b/0x42 fs/hfsplus/bnode.c:588
RSP: 0018:ffff8880b2c071a8 EFLAGS: 00010286
RAX: 0000000000000023 RBX: dffffc0000000000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff878bd020 RDI: ffffed1016580e2b
RBP: 0000000000000000 R08: 0000000000000023 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffff8880ab8ab900
R13: ffff8880b2a8aa80 R14: ffff8880b2a8ab50 R15: 0000000000000007
hfsplus_bmap_alloc+0x5db/0x740 fs/hfsplus/btree.c:414
hfs_btree_inc_height.isra.0+0xb7/0x910 fs/hfsplus/brec.c:474
hfsplus_brec_insert+0x8f3/0xb30 fs/hfsplus/brec.c:75
__hfsplus_ext_write_extent+0x439/0x560 fs/hfsplus/extents.c:107
__hfsplus_ext_cache_extent fs/hfsplus/extents.c:186 [inline]
hfsplus_ext_read_extent+0x81a/0x9e0 fs/hfsplus/extents.c:218
hfsplus_file_extend+0x616/0xef0 fs/hfsplus/extents.c:456
hfsplus_get_block+0x15b/0x820 fs/hfsplus/extents.c:245
get_more_blocks fs/direct-io.c:718 [inline]
do_direct_IO fs/direct-io.c:1004 [inline]
do_blockdev_direct_IO fs/direct-io.c:1337 [inline]
__blockdev_direct_IO+0x3f74/0xdcb0 fs/direct-io.c:1423
blockdev_direct_IO include/linux/fs.h:2994 [inline]
hfsplus_direct_IO+0x10a/0x290 fs/hfsplus/inode.c:135
generic_file_direct_write+0x1df/0x420 mm/filemap.c:2958
__generic_file_write_iter+0x2a2/0x590 mm/filemap.c:3137
generic_file_write_iter+0x36f/0x650 mm/filemap.c:3208
call_write_iter include/linux/fs.h:1780 [inline]
do_iter_readv_writev+0x4cf/0x5f0 fs/read_write.c:675
do_iter_write+0x152/0x550 fs/read_write.c:954
vfs_writev+0x125/0x290 fs/read_write.c:999
do_pwritev fs/read_write.c:1088 [inline]
SYSC_pwritev2 fs/read_write.c:1147 [inline]
SyS_pwritev2+0x195/0x230 fs/read_write.c:1138
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x5e/0xd3
RIP: 0033:0x7f11e8f2d7d9
RSP: 002b:00007ffe20835578 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f11e8f2d7d9
RDX: 0000000000000001 RSI: 0000000020000680 RDI: 0000000000000004
RBP: 00007f11e8eed070 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000600 R11: 0000000000000246 R12: 00007f11e8eed100
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches