possible deadlock in sk_clone_lock
14 views
Skip to first unread message
syzbot
Jan 19, 2021, 10:48:17 AM1/19/21
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: c110fed0 Linux 4.19.168
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1793ed34d00000
kernel config: https://syzkaller.appspot.com/x/.config?x=ab04f4c73d0ab4a8
dashboard link: https://syzkaller.appspot.com/bug?extid=6383ce4b0b8ec575ad93
compiler: gcc (GCC) 10.1.0-syz 20200507
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6383ce...@syzkaller.appspotmail.com
=====================================================
WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected
4.19.168-syzkaller #0 Not tainted
-----------------------------------------------------
syz-executor.2/822 [HC0[0]:SC0[2]:HE1:SE0] is trying to acquire:
000000004864e4de (hugetlb_lock){+.+.}, at: spin_lock include/linux/spinlock.h:329 [inline]
000000004864e4de (hugetlb_lock){+.+.}, at: free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
and this task is already holding:
000000008644fd09 (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
000000008644fd09 (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
which would create a new lock dependency:
(slock-AF_INET){+.-.} -> (hugetlb_lock){+.+.}
but this new dependency connects a SOFTIRQ-irq-safe lock:
(slock-AF_INET){+.-.}
... which became SOFTIRQ-irq-safe at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
sk_clone_lock+0x40b/0x1430 net/core/sock.c:1671
inet_csk_clone_lock+0x1f/0x3e0 net/ipv4/inet_connection_sock.c:821
tcp_create_openreq_child+0x2c/0x19f0 net/ipv4/tcp_minisocks.c:452
tcp_v4_syn_recv_sock+0xb6/0x1030 net/ipv4/tcp_ipv4.c:1426
tcp_check_req+0x601/0x16b0 net/ipv4/tcp_minisocks.c:789
tcp_v4_rcv+0x1e3c/0x3b80 net/ipv4/tcp_ipv4.c:1770
ip_local_deliver_finish+0x495/0xc00 net/ipv4/ip_input.c:215
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_local_deliver+0x188/0x500 net/ipv4/ip_input.c:256
dst_input include/net/dst.h:461 [inline]
ip_rcv_finish+0x1ca/0x2e0 net/ipv4/ip_input.c:414
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_rcv+0xca/0x3c0 net/ipv4/ip_input.c:524
__netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:4954
__netif_receive_skb+0x27/0x1c0 net/core/dev.c:5066
netif_receive_skb_internal+0xf0/0x3f0 net/core/dev.c:5156
napi_skb_finish net/core/dev.c:5600 [inline]
napi_gro_receive+0x2e6/0x450 net/core/dev.c:5631
receive_buf+0xf1d/0x6120 drivers/net/virtio_net.c:1072
virtnet_receive drivers/net/virtio_net.c:1336 [inline]
virtnet_poll+0x568/0xd70 drivers/net/virtio_net.c:1441
napi_poll net/core/dev.c:6272 [inline]
net_rx_action+0x4ac/0xfb0 net/core/dev.c:6338
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
run_ksoftirqd+0x57/0x110 kernel/softirq.c:653
smpboot_thread_fn+0x655/0x9e0 kernel/smpboot.c:164
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
to a SOFTIRQ-irq-unsafe lock:
(hugetlb_lock){+.+.}
... which became SOFTIRQ-irq-unsafe at:
...
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
other info that might help us debug this:
Possible interrupt unsafe locking scenario:
CPU0 CPU1
---- ----
lock(hugetlb_lock);
local_irq_disable();
lock(slock-AF_INET);
lock(hugetlb_lock);
<Interrupt>
lock(slock-AF_INET);
*** DEADLOCK ***
3 locks held by syz-executor.2/822:
#0: 000000009bda2128 (&sb->s_type->i_mutex_key#13){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#0: 000000009bda2128 (&sb->s_type->i_mutex_key#13){+.+.}, at: __sock_release+0x86/0x2a0 net/socket.c:578
#1: 00000000b5a20415 (sk_lock-AF_INET){+.+.}, at: lock_sock include/net/sock.h:1510 [inline]
#1: 00000000b5a20415 (sk_lock-AF_INET){+.+.}, at: tcp_close+0x25/0xfd0 net/ipv4/tcp.c:2344
#2: 000000008644fd09 (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
#2: 000000008644fd09 (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
the dependencies between SOFTIRQ-irq-safe lock and the holding lock:
-> (slock-AF_INET){+.-.} ops: 3734666 {
HARDIRQ-ON-W at:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:168
spin_lock_bh include/linux/spinlock.h:334 [inline]
lock_sock_nested+0x3b/0x110 net/core/sock.c:2864
lock_sock include/net/sock.h:1510 [inline]
inet_autobind+0x1a/0x190 net/ipv4/af_inet.c:179
inet_dgram_connect+0x245/0x2d0 net/ipv4/af_inet.c:569
__sys_connect+0x265/0x2c0 net/socket.c:1663
__do_sys_connect net/socket.c:1674 [inline]
__se_sys_connect net/socket.c:1671 [inline]
__x64_sys_connect+0x6f/0xb0 net/socket.c:1671
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
IN-SOFTIRQ-W at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
sk_clone_lock+0x40b/0x1430 net/core/sock.c:1671
inet_csk_clone_lock+0x1f/0x3e0 net/ipv4/inet_connection_sock.c:821
tcp_create_openreq_child+0x2c/0x19f0 net/ipv4/tcp_minisocks.c:452
tcp_v4_syn_recv_sock+0xb6/0x1030 net/ipv4/tcp_ipv4.c:1426
tcp_check_req+0x601/0x16b0 net/ipv4/tcp_minisocks.c:789
tcp_v4_rcv+0x1e3c/0x3b80 net/ipv4/tcp_ipv4.c:1770
ip_local_deliver_finish+0x495/0xc00 net/ipv4/ip_input.c:215
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_local_deliver+0x188/0x500 net/ipv4/ip_input.c:256
dst_input include/net/dst.h:461 [inline]
ip_rcv_finish+0x1ca/0x2e0 net/ipv4/ip_input.c:414
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_rcv+0xca/0x3c0 net/ipv4/ip_input.c:524
__netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:4954
__netif_receive_skb+0x27/0x1c0 net/core/dev.c:5066
netif_receive_skb_internal+0xf0/0x3f0 net/core/dev.c:5156
napi_skb_finish net/core/dev.c:5600 [inline]
napi_gro_receive+0x2e6/0x450 net/core/dev.c:5631
receive_buf+0xf1d/0x6120 drivers/net/virtio_net.c:1072
virtnet_receive drivers/net/virtio_net.c:1336 [inline]
virtnet_poll+0x568/0xd70 drivers/net/virtio_net.c:1441
napi_poll net/core/dev.c:6272 [inline]
net_rx_action+0x4ac/0xfb0 net/core/dev.c:6338
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
run_ksoftirqd+0x57/0x110 kernel/softirq.c:653
smpboot_thread_fn+0x655/0x9e0 kernel/smpboot.c:164
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
INITIAL USE at:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:168
spin_lock_bh include/linux/spinlock.h:334 [inline]
lock_sock_nested+0x3b/0x110 net/core/sock.c:2864
lock_sock include/net/sock.h:1510 [inline]
inet_autobind+0x1a/0x190 net/ipv4/af_inet.c:179
inet_dgram_connect+0x245/0x2d0 net/ipv4/af_inet.c:569
__sys_connect+0x265/0x2c0 net/socket.c:1663
__do_sys_connect net/socket.c:1674 [inline]
__se_sys_connect net/socket.c:1671 [inline]
__x64_sys_connect+0x6f/0xb0 net/socket.c:1671
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
}
... key at: [<ffffffff8dd6e490>] af_family_slock_keys+0x10/0x1a0
... acquired at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
__put_page+0xe2/0x3a0 mm/swap.c:112
put_page include/linux/mm.h:963 [inline]
__skb_frag_unref include/linux/skbuff.h:2828 [inline]
skb_release_data+0x2f3/0x920 net/core/skbuff.c:568
skb_release_all net/core/skbuff.c:631 [inline]
__kfree_skb+0x46/0x60 net/core/skbuff.c:645
sk_wmem_free_skb include/net/sock.h:1466 [inline]
tcp_write_queue_purge+0x24d/0x800 net/ipv4/tcp.c:2543
tcp_v4_destroy_sock+0x101/0x770 net/ipv4/tcp_ipv4.c:1986
inet_csk_destroy_sock+0x189/0x400 net/ipv4/inet_connection_sock.c:872
tcp_close+0x95f/0xfd0 net/ipv4/tcp.c:2498
inet_release+0xd7/0x1e0 net/ipv4/af_inet.c:427
__sock_release+0xcd/0x2a0 net/socket.c:579
sock_close+0x15/0x20 net/socket.c:1140
__fput+0x2ce/0x890 fs/file_table.c:278
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
the dependencies between the lock to be acquired
and SOFTIRQ-irq-unsafe lock:
-> (hugetlb_lock){+.+.} ops: 1387 {
HARDIRQ-ON-W at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
SOFTIRQ-ON-W at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
INITIAL USE at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
}
... key at: [<ffffffff8a020978>] hugetlb_lock+0x18/0x17a0
... acquired at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
__put_page+0xe2/0x3a0 mm/swap.c:112
put_page include/linux/mm.h:963 [inline]
__skb_frag_unref include/linux/skbuff.h:2828 [inline]
skb_release_data+0x2f3/0x920 net/core/skbuff.c:568
skb_release_all net/core/skbuff.c:631 [inline]
__kfree_skb+0x46/0x60 net/core/skbuff.c:645
sk_wmem_free_skb include/net/sock.h:1466 [inline]
tcp_write_queue_purge+0x24d/0x800 net/ipv4/tcp.c:2543
tcp_v4_destroy_sock+0x101/0x770 net/ipv4/tcp_ipv4.c:1986
inet_csk_destroy_sock+0x189/0x400 net/ipv4/inet_connection_sock.c:872
tcp_close+0x95f/0xfd0 net/ipv4/tcp.c:2498
inet_release+0xd7/0x1e0 net/ipv4/af_inet.c:427
__sock_release+0xcd/0x2a0 net/socket.c:579
sock_close+0x15/0x20 net/socket.c:1140
__fput+0x2ce/0x890 fs/file_table.c:278
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
stack backtrace:
CPU: 1 PID: 822 Comm: syz-executor.2 Not tainted 4.19.168-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_bad_irq_dependency kernel/locking/lockdep.c:1572 [inline]
check_usage.cold+0x7ea/0xbad kernel/locking/lockdep.c:1604
check_irq_usage kernel/locking/lockdep.c:1660 [inline]
check_prev_add_irq kernel/locking/lockdep_states.h:8 [inline]
check_prev_add kernel/locking/lockdep.c:1870 [inline]
check_prevs_add kernel/locking/lockdep.c:1978 [inline]
validate_chain kernel/locking/lockdep.c:2419 [inline]
__lock_acquire+0x1da1/0x3ff0 kernel/locking/lockdep.c:3415
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3907
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
__put_page+0xe2/0x3a0 mm/swap.c:112
put_page include/linux/mm.h:963 [inline]
__skb_frag_unref include/linux/skbuff.h:2828 [inline]
skb_release_data+0x2f3/0x920 net/core/skbuff.c:568
skb_release_all net/core/skbuff.c:631 [inline]
__kfree_skb+0x46/0x60 net/core/skbuff.c:645
sk_wmem_free_skb include/net/sock.h:1466 [inline]
tcp_write_queue_purge+0x24d/0x800 net/ipv4/tcp.c:2543
tcp_v4_destroy_sock+0x101/0x770 net/ipv4/tcp_ipv4.c:1986
inet_csk_destroy_sock+0x189/0x400 net/ipv4/inet_connection_sock.c:872
tcp_close+0x95f/0xfd0 net/ipv4/tcp.c:2498
inet_release+0xd7/0x1e0 net/ipv4/af_inet.c:427
__sock_release+0xcd/0x2a0 net/socket.c:579
sock_close+0x15/0x20 net/socket.c:1140
__fput+0x2ce/0x890 fs/file_table.c:278
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x417b71
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 a4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffce409b1b0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000007 RCX: 0000000000417b71
RDX: 0000000000000000 RSI: 0000000000000081 RDI: 0000000000000006
RBP: 0000000000000000 R08: 00000000011a4480 R09: 0000000000000000
R10: 00007ffce409b280 R11: 0000000000000293 R12: ffffffffffffffff
R13: 0000000000000002 R14: 0000000000000003 R15: 000000000119c0dc
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
tmpfs: Bad mount option hVge
tmpfs: Bad mount option hVge
tmpfs: Bad value '' for mount option 'huge'
tmpfs: Bad value '' for mount option 'huge'
tmpfs: Bad value 'alw[ys' for mount option 'huge'
x_tables: duplicate underflow at hook 1
x_tables: duplicate underflow at hook 1
tmpfs: Bad value 'alw[ys' for mount option 'huge'
x_tables: duplicate underflow at hook 1
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
x_tables: duplicate underflow at hook 1
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option '� '
tmpfs: Bad value 'always 3�j�X�OR��I�# � �Y�c�.y � {��d�_6q )��9�o�h�|�� ' for mount option 'huge'
audit: type=1804 audit(1611071272.249:5534): pid=1192 uid=0 auid=0 ses=4 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.4" name="/root/syzkaller-testdir031991742/syzkaller.1fuMwe/497/bus/bus" dev="sda1" ino=18879 res=1
x_tables: duplicate underflow at hook 1
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
tmpfs: Bad value 'always 3�j�X�OR��I�# � �Y�c�.y � {��d�_6q )��9�o�h�|�� ' for mount option 'huge'
x_tables: duplicate underflow at hook 1
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option '00000000000000000000000'
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option '00000000000000000000000'
tmpfs: No value for mount option 'hugealways'
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option 'hugealways'
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following issue on:
HEAD commit: c110fed0 Linux 4.19.168
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1793ed34d00000
kernel config: https://syzkaller.appspot.com/x/.config?x=ab04f4c73d0ab4a8
dashboard link: https://syzkaller.appspot.com/bug?extid=6383ce4b0b8ec575ad93
compiler: gcc (GCC) 10.1.0-syz 20200507
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6383ce...@syzkaller.appspotmail.com
=====================================================
WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected
4.19.168-syzkaller #0 Not tainted
-----------------------------------------------------
syz-executor.2/822 [HC0[0]:SC0[2]:HE1:SE0] is trying to acquire:
000000004864e4de (hugetlb_lock){+.+.}, at: spin_lock include/linux/spinlock.h:329 [inline]
000000004864e4de (hugetlb_lock){+.+.}, at: free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
and this task is already holding:
000000008644fd09 (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
000000008644fd09 (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
which would create a new lock dependency:
(slock-AF_INET){+.-.} -> (hugetlb_lock){+.+.}
but this new dependency connects a SOFTIRQ-irq-safe lock:
(slock-AF_INET){+.-.}
... which became SOFTIRQ-irq-safe at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
sk_clone_lock+0x40b/0x1430 net/core/sock.c:1671
inet_csk_clone_lock+0x1f/0x3e0 net/ipv4/inet_connection_sock.c:821
tcp_create_openreq_child+0x2c/0x19f0 net/ipv4/tcp_minisocks.c:452
tcp_v4_syn_recv_sock+0xb6/0x1030 net/ipv4/tcp_ipv4.c:1426
tcp_check_req+0x601/0x16b0 net/ipv4/tcp_minisocks.c:789
tcp_v4_rcv+0x1e3c/0x3b80 net/ipv4/tcp_ipv4.c:1770
ip_local_deliver_finish+0x495/0xc00 net/ipv4/ip_input.c:215
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_local_deliver+0x188/0x500 net/ipv4/ip_input.c:256
dst_input include/net/dst.h:461 [inline]
ip_rcv_finish+0x1ca/0x2e0 net/ipv4/ip_input.c:414
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_rcv+0xca/0x3c0 net/ipv4/ip_input.c:524
__netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:4954
__netif_receive_skb+0x27/0x1c0 net/core/dev.c:5066
netif_receive_skb_internal+0xf0/0x3f0 net/core/dev.c:5156
napi_skb_finish net/core/dev.c:5600 [inline]
napi_gro_receive+0x2e6/0x450 net/core/dev.c:5631
receive_buf+0xf1d/0x6120 drivers/net/virtio_net.c:1072
virtnet_receive drivers/net/virtio_net.c:1336 [inline]
virtnet_poll+0x568/0xd70 drivers/net/virtio_net.c:1441
napi_poll net/core/dev.c:6272 [inline]
net_rx_action+0x4ac/0xfb0 net/core/dev.c:6338
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
run_ksoftirqd+0x57/0x110 kernel/softirq.c:653
smpboot_thread_fn+0x655/0x9e0 kernel/smpboot.c:164
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
to a SOFTIRQ-irq-unsafe lock:
(hugetlb_lock){+.+.}
... which became SOFTIRQ-irq-unsafe at:
...
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
other info that might help us debug this:
Possible interrupt unsafe locking scenario:
CPU0 CPU1
---- ----
lock(hugetlb_lock);
local_irq_disable();
lock(slock-AF_INET);
lock(hugetlb_lock);
<Interrupt>
lock(slock-AF_INET);
*** DEADLOCK ***
3 locks held by syz-executor.2/822:
#0: 000000009bda2128 (&sb->s_type->i_mutex_key#13){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#0: 000000009bda2128 (&sb->s_type->i_mutex_key#13){+.+.}, at: __sock_release+0x86/0x2a0 net/socket.c:578
#1: 00000000b5a20415 (sk_lock-AF_INET){+.+.}, at: lock_sock include/net/sock.h:1510 [inline]
#1: 00000000b5a20415 (sk_lock-AF_INET){+.+.}, at: tcp_close+0x25/0xfd0 net/ipv4/tcp.c:2344
#2: 000000008644fd09 (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
#2: 000000008644fd09 (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
the dependencies between SOFTIRQ-irq-safe lock and the holding lock:
-> (slock-AF_INET){+.-.} ops: 3734666 {
HARDIRQ-ON-W at:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:168
spin_lock_bh include/linux/spinlock.h:334 [inline]
lock_sock_nested+0x3b/0x110 net/core/sock.c:2864
lock_sock include/net/sock.h:1510 [inline]
inet_autobind+0x1a/0x190 net/ipv4/af_inet.c:179
inet_dgram_connect+0x245/0x2d0 net/ipv4/af_inet.c:569
__sys_connect+0x265/0x2c0 net/socket.c:1663
__do_sys_connect net/socket.c:1674 [inline]
__se_sys_connect net/socket.c:1671 [inline]
__x64_sys_connect+0x6f/0xb0 net/socket.c:1671
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
IN-SOFTIRQ-W at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
sk_clone_lock+0x40b/0x1430 net/core/sock.c:1671
inet_csk_clone_lock+0x1f/0x3e0 net/ipv4/inet_connection_sock.c:821
tcp_create_openreq_child+0x2c/0x19f0 net/ipv4/tcp_minisocks.c:452
tcp_v4_syn_recv_sock+0xb6/0x1030 net/ipv4/tcp_ipv4.c:1426
tcp_check_req+0x601/0x16b0 net/ipv4/tcp_minisocks.c:789
tcp_v4_rcv+0x1e3c/0x3b80 net/ipv4/tcp_ipv4.c:1770
ip_local_deliver_finish+0x495/0xc00 net/ipv4/ip_input.c:215
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_local_deliver+0x188/0x500 net/ipv4/ip_input.c:256
dst_input include/net/dst.h:461 [inline]
ip_rcv_finish+0x1ca/0x2e0 net/ipv4/ip_input.c:414
NF_HOOK include/linux/netfilter.h:289 [inline]
ip_rcv+0xca/0x3c0 net/ipv4/ip_input.c:524
__netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:4954
__netif_receive_skb+0x27/0x1c0 net/core/dev.c:5066
netif_receive_skb_internal+0xf0/0x3f0 net/core/dev.c:5156
napi_skb_finish net/core/dev.c:5600 [inline]
napi_gro_receive+0x2e6/0x450 net/core/dev.c:5631
receive_buf+0xf1d/0x6120 drivers/net/virtio_net.c:1072
virtnet_receive drivers/net/virtio_net.c:1336 [inline]
virtnet_poll+0x568/0xd70 drivers/net/virtio_net.c:1441
napi_poll net/core/dev.c:6272 [inline]
net_rx_action+0x4ac/0xfb0 net/core/dev.c:6338
__do_softirq+0x26c/0x9a0 kernel/softirq.c:292
run_ksoftirqd+0x57/0x110 kernel/softirq.c:653
smpboot_thread_fn+0x655/0x9e0 kernel/smpboot.c:164
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
INITIAL USE at:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:168
spin_lock_bh include/linux/spinlock.h:334 [inline]
lock_sock_nested+0x3b/0x110 net/core/sock.c:2864
lock_sock include/net/sock.h:1510 [inline]
inet_autobind+0x1a/0x190 net/ipv4/af_inet.c:179
inet_dgram_connect+0x245/0x2d0 net/ipv4/af_inet.c:569
__sys_connect+0x265/0x2c0 net/socket.c:1663
__do_sys_connect net/socket.c:1674 [inline]
__se_sys_connect net/socket.c:1671 [inline]
__x64_sys_connect+0x6f/0xb0 net/socket.c:1671
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
}
... key at: [<ffffffff8dd6e490>] af_family_slock_keys+0x10/0x1a0
... acquired at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
__put_page+0xe2/0x3a0 mm/swap.c:112
put_page include/linux/mm.h:963 [inline]
__skb_frag_unref include/linux/skbuff.h:2828 [inline]
skb_release_data+0x2f3/0x920 net/core/skbuff.c:568
skb_release_all net/core/skbuff.c:631 [inline]
__kfree_skb+0x46/0x60 net/core/skbuff.c:645
sk_wmem_free_skb include/net/sock.h:1466 [inline]
tcp_write_queue_purge+0x24d/0x800 net/ipv4/tcp.c:2543
tcp_v4_destroy_sock+0x101/0x770 net/ipv4/tcp_ipv4.c:1986
inet_csk_destroy_sock+0x189/0x400 net/ipv4/inet_connection_sock.c:872
tcp_close+0x95f/0xfd0 net/ipv4/tcp.c:2498
inet_release+0xd7/0x1e0 net/ipv4/af_inet.c:427
__sock_release+0xcd/0x2a0 net/socket.c:579
sock_close+0x15/0x20 net/socket.c:1140
__fput+0x2ce/0x890 fs/file_table.c:278
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
the dependencies between the lock to be acquired
and SOFTIRQ-irq-unsafe lock:
-> (hugetlb_lock){+.+.} ops: 1387 {
HARDIRQ-ON-W at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
SOFTIRQ-ON-W at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
INITIAL USE at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
hugetlb_overcommit_handler+0x2d4/0x460 mm/hugetlb.c:2999
proc_sys_call_handler.isra.0+0x1f3/0x3b0 fs/proc/proc_sysctl.c:597
__vfs_write+0xf7/0x770 fs/read_write.c:485
vfs_write+0x1f3/0x540 fs/read_write.c:549
ksys_write+0x12b/0x2a0 fs/read_write.c:599
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
}
... key at: [<ffffffff8a020978>] hugetlb_lock+0x18/0x17a0
... acquired at:
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
__put_page+0xe2/0x3a0 mm/swap.c:112
put_page include/linux/mm.h:963 [inline]
__skb_frag_unref include/linux/skbuff.h:2828 [inline]
skb_release_data+0x2f3/0x920 net/core/skbuff.c:568
skb_release_all net/core/skbuff.c:631 [inline]
__kfree_skb+0x46/0x60 net/core/skbuff.c:645
sk_wmem_free_skb include/net/sock.h:1466 [inline]
tcp_write_queue_purge+0x24d/0x800 net/ipv4/tcp.c:2543
tcp_v4_destroy_sock+0x101/0x770 net/ipv4/tcp_ipv4.c:1986
inet_csk_destroy_sock+0x189/0x400 net/ipv4/inet_connection_sock.c:872
tcp_close+0x95f/0xfd0 net/ipv4/tcp.c:2498
inet_release+0xd7/0x1e0 net/ipv4/af_inet.c:427
__sock_release+0xcd/0x2a0 net/socket.c:579
sock_close+0x15/0x20 net/socket.c:1140
__fput+0x2ce/0x890 fs/file_table.c:278
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
stack backtrace:
CPU: 1 PID: 822 Comm: syz-executor.2 Not tainted 4.19.168-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_bad_irq_dependency kernel/locking/lockdep.c:1572 [inline]
check_usage.cold+0x7ea/0xbad kernel/locking/lockdep.c:1604
check_irq_usage kernel/locking/lockdep.c:1660 [inline]
check_prev_add_irq kernel/locking/lockdep_states.h:8 [inline]
check_prev_add kernel/locking/lockdep.c:1870 [inline]
check_prevs_add kernel/locking/lockdep.c:1978 [inline]
validate_chain kernel/locking/lockdep.c:2419 [inline]
__lock_acquire+0x1da1/0x3ff0 kernel/locking/lockdep.c:3415
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3907
__raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline]
_raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:144
spin_lock include/linux/spinlock.h:329 [inline]
free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
__put_page+0xe2/0x3a0 mm/swap.c:112
put_page include/linux/mm.h:963 [inline]
__skb_frag_unref include/linux/skbuff.h:2828 [inline]
skb_release_data+0x2f3/0x920 net/core/skbuff.c:568
skb_release_all net/core/skbuff.c:631 [inline]
__kfree_skb+0x46/0x60 net/core/skbuff.c:645
sk_wmem_free_skb include/net/sock.h:1466 [inline]
tcp_write_queue_purge+0x24d/0x800 net/ipv4/tcp.c:2543
tcp_v4_destroy_sock+0x101/0x770 net/ipv4/tcp_ipv4.c:1986
inet_csk_destroy_sock+0x189/0x400 net/ipv4/inet_connection_sock.c:872
tcp_close+0x95f/0xfd0 net/ipv4/tcp.c:2498
inet_release+0xd7/0x1e0 net/ipv4/af_inet.c:427
__sock_release+0xcd/0x2a0 net/socket.c:579
sock_close+0x15/0x20 net/socket.c:1140
__fput+0x2ce/0x890 fs/file_table.c:278
task_work_run+0x148/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x251/0x2a0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x538/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x417b71
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 a4 1a 00 00 c3 48 83 ec 08 e8 0a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 53 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffce409b1b0 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000007 RCX: 0000000000417b71
RDX: 0000000000000000 RSI: 0000000000000081 RDI: 0000000000000006
RBP: 0000000000000000 R08: 00000000011a4480 R09: 0000000000000000
R10: 00007ffce409b280 R11: 0000000000000293 R12: ffffffffffffffff
R13: 0000000000000002 R14: 0000000000000003 R15: 000000000119c0dc
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
tmpfs: Bad mount option hVge
tmpfs: Bad mount option hVge
tmpfs: Bad value '' for mount option 'huge'
tmpfs: Bad value '' for mount option 'huge'
tmpfs: Bad value 'alw[ys' for mount option 'huge'
x_tables: duplicate underflow at hook 1
x_tables: duplicate underflow at hook 1
tmpfs: Bad value 'alw[ys' for mount option 'huge'
x_tables: duplicate underflow at hook 1
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
x_tables: duplicate underflow at hook 1
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option '� '
tmpfs: Bad value 'always 3�j�X�OR��I�# � �Y�c�.y � {��d�_6q )��9�o�h�|�� ' for mount option 'huge'
audit: type=1804 audit(1611071272.249:5534): pid=1192 uid=0 auid=0 ses=4 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.4" name="/root/syzkaller-testdir031991742/syzkaller.1fuMwe/497/bus/bus" dev="sda1" ino=18879 res=1
x_tables: duplicate underflow at hook 1
netlink: 'syz-executor.2': attribute type 5 has an invalid length.
tmpfs: Bad value 'always 3�j�X�OR��I�# � �Y�c�.y � {��d�_6q )��9�o�h�|�� ' for mount option 'huge'
x_tables: duplicate underflow at hook 1
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option '00000000000000000000000'
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option '00000000000000000000000'
tmpfs: No value for mount option 'hugealways'
x_tables: duplicate underflow at hook 1
tmpfs: No value for mount option 'hugealways'
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Jan 19, 2021, 11:16:20 AM1/19/21
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: c110fed0 Linux 4.19.168
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=14ae0c94d00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=114fe3c7500000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6383ce...@syzkaller.appspotmail.com
IPv6: ADDRCONF(NETDEV_CHANGE): macvtap0: link becomes ready
batman_adv: batadv0: Interface activated: batadv_slave_1
IPv6: ADDRCONF(NETDEV_CHANGE): veth1_to_batadv: link becomes ready
nf_conntrack: default automatic helper assignment has been turned off for security reasons and CT-based firewall rule not found. Use the iptables CT target to attach helpers instead.
0000000056494cde (hugetlb_lock){+.+.}, at: spin_lock include/linux/spinlock.h:329 [inline]
0000000056494cde (hugetlb_lock){+.+.}, at: free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
and this task is already holding:
000000000567018b (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
000000000567018b (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
3 locks held by syz-executor109/8107:
#0: 0000000036fcdfb6 (&sb->s_type->i_mutex_key#13){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#0: 0000000036fcdfb6 (&sb->s_type->i_mutex_key#13){+.+.}, at: __sock_release+0x86/0x2a0 net/socket.c:578
#1: 00000000c6da12ff (sk_lock-AF_INET){+.+.}, at: lock_sock include/net/sock.h:1510 [inline]
#1: 00000000c6da12ff (sk_lock-AF_INET){+.+.}, at: tcp_close+0x25/0xfd0 net/ipv4/tcp.c:2344
#2: 000000000567018b (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
#2: 000000000567018b (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
the dependencies between SOFTIRQ-irq-safe lock and the holding lock:
-> (slock-AF_INET){+.-.} ops: 6607 {
-> (hugetlb_lock){+.+.} ops: 26 {
CPU: 1 PID: 8107 Comm: syz-executor109 Not tainted 4.19.168-syzkaller #0
RIP: 0033:0x408111
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 24 1a 00 00 c3 48 83 ec 08 e8 6a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 b3 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffca6dbde70 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 00007ffca6dbdea0 RCX: 0000000000408111
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 0000000000000004 R08: 0000000000000140 R09: 00000000
HEAD commit: c110fed0 Linux 4.19.168
git tree: linux-4.19.y
kernel config: https://syzkaller.appspot.com/x/.config?x=ab04f4c73d0ab4a8
dashboard link: https://syzkaller.appspot.com/bug?extid=6383ce4b0b8ec575ad93
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17d03bb8d00000
dashboard link: https://syzkaller.appspot.com/bug?extid=6383ce4b0b8ec575ad93
compiler: gcc (GCC) 10.1.0-syz 20200507
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=114fe3c7500000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6383ce...@syzkaller.appspotmail.com
batman_adv: batadv0: Interface activated: batadv_slave_1
IPv6: ADDRCONF(NETDEV_CHANGE): veth1_to_batadv: link becomes ready
nf_conntrack: default automatic helper assignment has been turned off for security reasons and CT-based firewall rule not found. Use the iptables CT target to attach helpers instead.
=====================================================
WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected
4.19.168-syzkaller #0 Not tainted
-----------------------------------------------------
syz-executor109/8107 [HC0[0]:SC0[2]:HE1:SE0] is trying to acquire:
WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected
4.19.168-syzkaller #0 Not tainted
-----------------------------------------------------
0000000056494cde (hugetlb_lock){+.+.}, at: spin_lock include/linux/spinlock.h:329 [inline]
0000000056494cde (hugetlb_lock){+.+.}, at: free_huge_page+0x482/0xd20 mm/hugetlb.c:1276
and this task is already holding:
000000000567018b (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
#0: 0000000036fcdfb6 (&sb->s_type->i_mutex_key#13){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#0: 0000000036fcdfb6 (&sb->s_type->i_mutex_key#13){+.+.}, at: __sock_release+0x86/0x2a0 net/socket.c:578
#1: 00000000c6da12ff (sk_lock-AF_INET){+.+.}, at: lock_sock include/net/sock.h:1510 [inline]
#1: 00000000c6da12ff (sk_lock-AF_INET){+.+.}, at: tcp_close+0x25/0xfd0 net/ipv4/tcp.c:2344
#2: 000000000567018b (slock-AF_INET){+.-.}, at: spin_lock include/linux/spinlock.h:329 [inline]
#2: 000000000567018b (slock-AF_INET){+.-.}, at: tcp_close+0x5bd/0xfd0 net/ipv4/tcp.c:2434
the dependencies between SOFTIRQ-irq-safe lock and the holding lock:
Code: 75 14 b8 03 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 24 1a 00 00 c3 48 83 ec 08 e8 6a fc ff ff 48 89 04 24 b8 03 00 00 00 0f 05 <48> 8b 3c 24 48 89 c2 e8 b3 fc ff ff 48 89 d0 48 83 c4 08 48 3d 01
RSP: 002b:00007ffca6dbde70 EFLAGS: 00000293 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 00007ffca6dbdea0 RCX: 0000000000408111
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 0000000000000004 R08: 0000000000000140 R09: 00000000
Reply all
Reply to author
Forward
0 new messages