[v5.15] possible deadlock in ext4_ioctl

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 6139f2a02fe0 Linux 5.15.148
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12333488180000
kernel config: https://syzkaller.appspot.com/x/.config?x=c170eb20d8be8542
dashboard link: https://syzkaller.appspot.com/bug?extid=49ca58dac4fd44a8c543
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/528e8fe56997/disk-6139f2a0.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/18abf1e442f9/vmlinux-6139f2a0.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0538a5d3b1f3/bzImage-6139f2a0.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+49ca58...@syzkaller.appspotmail.com

======================================================
WARNING: possible circular locking dependency detected
5.15.148-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/20530 is trying to acquire lock:
ffff8880340db450 (&ei->i_data_sem/1){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline]
ffff8880340db450 (&ei->i_data_sem/1){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
ffff8880340db450 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276

but task is already holding lock:
ffff888034031668 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&ei->i_data_sem/2){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488
ext4_map_blocks+0x3a6/0x1e00 fs/ext4/inode.c:568
ext4_getblk+0x19f/0x710 fs/ext4/inode.c:846
ext4_bread+0x2a/0x170 fs/ext4/inode.c:899
ext4_quota_write+0x21e/0x580 fs/ext4/super.c:6546
write_blk fs/quota/quota_tree.c:64 [inline]
get_free_dqblk+0x3a9/0x800 fs/quota/quota_tree.c:125
do_insert_tree+0x2b4/0x1c20 fs/quota/quota_tree.c:335
do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
do_insert_tree+0x6d0/0x1c20 fs/quota/quota_tree.c:366
dq_insert_tree fs/quota/quota_tree.c:392 [inline]
qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:411
v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358
dquot_acquire+0x34d/0x680 fs/quota/dquot.c:470
ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180
dqget+0x74e/0xe30 fs/quota/dquot.c:984
__dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1562
ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329
ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474
ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4966
mount_bdev+0x2c9/0x3f0 fs/super.c:1387
legacy_get_tree+0xeb/0x180 fs/fs_context.c:611
vfs_get_tree+0x88/0x270 fs/super.c:1517
do_new_mount+0x2ba/0xb40 fs/namespace.c:3005
do_mount fs/namespace.c:3348 [inline]
__do_sys_mount fs/namespace.c:3556 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_read+0x45/0x2e0 kernel/locking/rwsem.c:1488
v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332
dquot_acquire+0x188/0x680 fs/quota/dquot.c:461
ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6180
dqget+0x74e/0xe30 fs/quota/dquot.c:984
__dquot_initialize+0x2d9/0xe10 fs/quota/dquot.c:1562
ext4_create+0xb1/0x550 fs/ext4/namei.c:2827
lookup_open fs/namei.c:3468 [inline]
open_last_lookups fs/namei.c:3538 [inline]
path_openat+0x12f6/0x2f20 fs/namei.c:3745
do_filp_open+0x21c/0x460 fs/namei.c:3775
do_sys_openat2+0x13b/0x500 fs/open.c:1211
do_sys_open fs/open.c:1227 [inline]
__do_sys_openat fs/open.c:1243 [inline]
__se_sys_openat fs/open.c:1238 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1238
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
dquot_commit+0x57/0x510 fs/quota/dquot.c:505
ext4_write_dquot+0x1e8/0x2b0 fs/ext4/super.c:6164
mark_dquot_dirty fs/quota/dquot.c:372 [inline]
mark_all_dquot_dirty fs/quota/dquot.c:410 [inline]
__dquot_alloc_space+0x53a/0xf30 fs/quota/dquot.c:1792
dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline]
dquot_alloc_space include/linux/quotaops.h:310 [inline]
swap_inode_boot_loader fs/ext4/ioctl.c:243 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
ext4_ioctl+0x4d2f/0x5b80 fs/ext4/ioctl.c:1276
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&ei->i_data_sem/1){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write_nested+0xa0/0x180 kernel/locking/rwsem.c:1657
swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
&ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ei->i_data_sem/2);
lock(&s->s_dquot.dqio_sem);
lock(&ei->i_data_sem/2);
lock(&ei->i_data_sem/1);

*** DEADLOCK ***

6 locks held by syz-executor.1/20530:
#0: ffff88807f07c460 (sb_writers#5){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:421
#1: ffff8880340317e0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
#1: ffff8880340317e0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xde/0x130 fs/inode.c:1083
#2: ffff8880340db5c8 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:135 [inline]
#2: ffff8880340db5c8 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
#2: ffff8880340db5c8 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: ext4_ioctl+0x1fb2/0x5b80 fs/ext4/ioctl.c:1276
#3: ffff888034031980 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:832 [inline]
#3: ffff888034031980 (mapping.invalidate_lock){++++}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:152 [inline]
#3: ffff888034031980 (mapping.invalidate_lock){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
#3: ffff888034031980 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_ioctl+0x3965/0x5b80 fs/ext4/ioctl.c:1276
#4: ffff88807f080990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x12b9/0x1570 fs/jbd2/transaction.c:462
#5: ffff888034031668 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x28/0x40

stack backtrace:
CPU: 0 PID: 20530 Comm: syz-executor.1 Not tainted 5.15.148-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
down_write_nested+0xa0/0x180 kernel/locking/rwsem.c:1657
swap_inode_boot_loader fs/ext4/ioctl.c:176 [inline]
__ext4_ioctl fs/ext4/ioctl.c:1056 [inline]
ext4_ioctl+0x3dec/0x5b80 fs/ext4/ioctl.c:1276
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7ff70d474da9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff70b9b30c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ff70d5a3120 RCX: 00007ff70d474da9
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000005
RBP: 00007ff70d4c147a R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000006e R14: 00007ff70d5a3120 R15: 00007ffe534a9a28
</TASK>
netlink: 'syz-executor.1': attribute type 4 has an invalid length.


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup