UBSAN: undefined-behaviour in choke_enqueue

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: a87f9628 Linux 4.19.145
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17129c73900000
kernel config: https://syzkaller.appspot.com/x/.config?x=9688ecb5b728ce13
dashboard link: https://syzkaller.appspot.com/bug?extid=541606d1c180a949c30a
compiler: gcc (GCC) 10.1.0-syz 20200507

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+541606...@syzkaller.appspotmail.com

================================================================================
UBSAN: Undefined behaviour in ./include/net/red.h:272:18
shift exponent 79 is too large for 64-bit type 'long unsigned int'
CPU: 1 PID: 18523 Comm: syz-executor.1 Not tainted 4.19.145-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
ubsan_epilogue+0xe/0x3a lib/ubsan.c:161
__ubsan_handle_shift_out_of_bounds.cold+0x1c4/0x250 lib/ubsan.c:422
red_calc_qavg_from_idle_time include/net/red.h:272 [inline]
red_calc_qavg include/net/red.h:313 [inline]
choke_enqueue+0x2a7e/0x2cc0 net/sched/sch_choke.c:231
__dev_xmit_skb net/core/dev.c:3494 [inline]
__dev_queue_xmit+0x14e1/0x2ec0 net/core/dev.c:3807
neigh_hh_output include/net/neighbour.h:491 [inline]
neigh_output include/net/neighbour.h:499 [inline]
ip_finish_output2+0xc04/0x1640 net/ipv4/ip_output.c:229
ip_finish_output+0x88e/0xd80 net/ipv4/ip_output.c:317
NF_HOOK_COND include/linux/netfilter.h:278 [inline]
ip_output+0x203/0x650 net/ipv4/ip_output.c:405
dst_output include/net/dst.h:455 [inline]
ip_local_out+0xaf/0x170 net/ipv4/ip_output.c:124
__ip_queue_xmit+0x8a0/0x1bd0 net/ipv4/ip_output.c:505
__tcp_transmit_skb+0x1c72/0x36c0 net/ipv4/tcp_output.c:1148
tcp_transmit_skb net/ipv4/tcp_output.c:1164 [inline]
tcp_send_syn_data net/ipv4/tcp_output.c:3486 [inline]
tcp_connect+0x121e/0x2610 net/ipv4/tcp_output.c:3525
tcp_v4_connect+0x141c/0x1aa0 net/ipv4/tcp_ipv4.c:315
__inet_stream_connect+0x836/0xe50 net/ipv4/af_inet.c:655
tcp_sendmsg_fastopen net/ipv4/tcp.c:1185 [inline]
tcp_sendmsg_locked+0x22cb/0x2fe0 net/ipv4/tcp.c:1232
tcp_sendmsg+0x2b/0x40 net/ipv4/tcp.c:1460
inet_sendmsg+0x174/0x640 net/ipv4/af_inet.c:798
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc7/0x130 net/socket.c:632
___sys_sendmsg+0x7bb/0x8f0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x45d5f9
Code: 5d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007faa90834c78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000002cc80 RCX: 000000000045d5f9
RDX: 00000000200408c4 RSI: 0000000020000180 RDI: 0000000000000004
RBP: 000000000118cf80 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118cf4c
R13: 00007fff6c22267f R14: 00007faa908359c0 R15: 000000000118cf4c
================================================================================
ptrace attach of "/root/syz-executor.3"[18528] was attempted by "/root/syz-executor.3"[18541]


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 015e94d0 Linux 4.19.146
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=11f708ad900000
kernel config: https://syzkaller.appspot.com/x/.config?x=243dd74ad58a8a57

dashboard link: https://syzkaller.appspot.com/bug?extid=541606d1c180a949c30a
compiler: gcc (GCC) 10.1.0-syz 20200507

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13fe8f8b900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1311f08d900000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+541606...@syzkaller.appspotmail.com

================================================================================
UBSAN: Undefined behaviour in ./include/net/red.h:272:18
shift exponent 79 is too large for 64-bit type 'long unsigned int'

CPU: 1 PID: 2738 Comm: kworker/1:2 Not tainted 4.19.146-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011

Workqueue: ipv6_addrconf addrconf_dad_work

Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
ubsan_epilogue+0xe/0x3a lib/ubsan.c:161
__ubsan_handle_shift_out_of_bounds.cold+0x1c4/0x250 lib/ubsan.c:422
red_calc_qavg_from_idle_time include/net/red.h:272 [inline]
red_calc_qavg include/net/red.h:313 [inline]
choke_enqueue+0x2a7e/0x2cc0 net/sched/sch_choke.c:231
__dev_xmit_skb net/core/dev.c:3494 [inline]
__dev_queue_xmit+0x14e1/0x2ec0 net/core/dev.c:3807
neigh_hh_output include/net/neighbour.h:491 [inline]
neigh_output include/net/neighbour.h:499 [inline]
ip_finish_output2+0xc04/0x1640 net/ipv4/ip_output.c:229
ip_finish_output+0x88e/0xd80 net/ipv4/ip_output.c:317
NF_HOOK_COND include/linux/netfilter.h:278 [inline]
ip_output+0x203/0x650 net/ipv4/ip_output.c:405
dst_output include/net/dst.h:455 [inline]
ip_local_out+0xaf/0x170 net/ipv4/ip_output.c:124

iptunnel_xmit+0x63e/0xa30 net/ipv4/ip_tunnel_core.c:91
geneve_xmit_skb drivers/net/geneve.c:857 [inline]
geneve_xmit+0xeb4/0x2a20 drivers/net/geneve.c:929
__netdev_start_xmit include/linux/netdevice.h:4333 [inline]
netdev_start_xmit include/linux/netdevice.h:4347 [inline]
xmit_one net/core/dev.c:3256 [inline]
dev_hard_start_xmit+0x1a8/0x960 net/core/dev.c:3272
__dev_queue_xmit+0x276a/0x2ec0 net/core/dev.c:3838
neigh_resolve_output+0x55a/0x950 net/core/neighbour.c:1374
neigh_output include/net/neighbour.h:501 [inline]
ip6_finish_output2+0x1184/0x2370 net/ipv6/ip6_output.c:120
ip6_finish_output+0x610/0xcc0 net/ipv6/ip6_output.c:154
NF_HOOK_COND include/linux/netfilter.h:278 [inline]
ip6_output+0x205/0x7c0 net/ipv6/ip6_output.c:171
dst_output include/net/dst.h:455 [inline]
NF_HOOK include/linux/netfilter.h:289 [inline]
ndisc_send_skb+0xa6b/0x1860 net/ipv6/ndisc.c:491
ndisc_send_rs+0x131/0x6a0 net/ipv6/ndisc.c:685
addrconf_dad_completed+0x31e/0xb60 net/ipv6/addrconf.c:4151
addrconf_dad_work+0x787/0x1130 net/ipv6/addrconf.c:4062
process_one_work+0x796/0x14e0 kernel/workqueue.c:2155
worker_thread+0x64c/0x1130 kernel/workqueue.c:2298
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
================================================================================
nla_parse: 1477 callbacks suppressed
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
nla_parse: 1578 callbacks suppressed
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.
netlink: 800 bytes leftover after parsing attributes in process `syz-executor591'.