[ntfs?] possible deadlock in ntfs_sync_mft_mirror

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17cd227e480000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=ba7dd6478b2ec41a19ec
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+ba7dd6...@syzkaller.appspotmail.com

syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
ntfs: volume version 3.1.
syz-executor.1 (20236): drop_caches: 1
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
kworker/u4:3/151 is trying to acquire lock:
000000001f71f4c8 (&rl->lock){++++}, at: ntfs_sync_mft_mirror+0x159d/0x1d00 fs/ntfs/mft.c:550

but task is already holding lock:
00000000a9c80564 (&ni->mrec_lock){+.+.}, at: map_mft_record+0x3c/0xc70 fs/ntfs/mft.c:168

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&ni->mrec_lock){+.+.}:
map_mft_record+0x3c/0xc70 fs/ntfs/mft.c:168
ntfs_truncate+0x202/0x2820 fs/ntfs/inode.c:2395
ntfs_truncate_vfs fs/ntfs/inode.c:2875 [inline]
ntfs_setattr+0x1b6/0x620 fs/ntfs/inode.c:2925
notify_change+0x70b/0xfc0 fs/attr.c:334
do_truncate+0x134/0x1f0 fs/open.c:63
handle_truncate fs/namei.c:3009 [inline]
do_last fs/namei.c:3427 [inline]
path_openat+0x2308/0x2df0 fs/namei.c:3537
do_filp_open+0x18c/0x3f0 fs/namei.c:3567
do_sys_open+0x3b3/0x520 fs/open.c:1085
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&rl->lock){++++}:
down_read+0x36/0x80 kernel/locking/rwsem.c:24
ntfs_sync_mft_mirror+0x159d/0x1d00 fs/ntfs/mft.c:550
write_mft_record_nolock+0x13d2/0x16c0 fs/ntfs/mft.c:801
write_mft_record fs/ntfs/mft.h:109 [inline]
__ntfs_write_inode+0x609/0xe10 fs/ntfs/inode.c:3064
write_inode fs/fs-writeback.c:1244 [inline]
__writeback_single_inode+0x733/0x11d0 fs/fs-writeback.c:1442
writeback_sb_inodes+0x537/0xef0 fs/fs-writeback.c:1647
wb_writeback+0x28d/0xcc0 fs/fs-writeback.c:1820
wb_do_writeback fs/fs-writeback.c:1965 [inline]
wb_workfn+0x29b/0x1250 fs/fs-writeback.c:2006
process_one_work+0x864/0x1570 kernel/workqueue.c:2153
worker_thread+0x64c/0x1130 kernel/workqueue.c:2296
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415

other info that might help us debug this:

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(&ni->mrec_lock);
lock(&rl->lock);
lock(&ni->mrec_lock);
lock(&rl->lock);

*** DEADLOCK ***

3 locks held by kworker/u4:3/151:
#0: 00000000d1781e4c ((wq_completion)"writeback"){+.+.}, at: process_one_work+0x767/0x1570 kernel/workqueue.c:2124
#1: 000000005299d6af ((work_completion)(&(&wb->dwork)->work)){+.+.}, at: process_one_work+0x79c/0x1570 kernel/workqueue.c:2128
#2: 00000000a9c80564 (&ni->mrec_lock){+.+.}, at: map_mft_record+0x3c/0xc70 fs/ntfs/mft.c:168

stack backtrace:
CPU: 0 PID: 151 Comm: kworker/u4:3 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Workqueue: writeback wb_workfn (flush-7:5)
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
check_prev_add kernel/locking/lockdep.c:1866 [inline]
check_prevs_add kernel/locking/lockdep.c:1979 [inline]
validate_chain kernel/locking/lockdep.c:2420 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
down_read+0x36/0x80 kernel/locking/rwsem.c:24
ntfs_sync_mft_mirror+0x159d/0x1d00 fs/ntfs/mft.c:550
write_mft_record_nolock+0x13d2/0x16c0 fs/ntfs/mft.c:801
write_mft_record fs/ntfs/mft.h:109 [inline]
__ntfs_write_inode+0x609/0xe10 fs/ntfs/inode.c:3064
write_inode fs/fs-writeback.c:1244 [inline]
__writeback_single_inode+0x733/0x11d0 fs/fs-writeback.c:1442
writeback_sb_inodes+0x537/0xef0 fs/fs-writeback.c:1647
wb_writeback+0x28d/0xcc0 fs/fs-writeback.c:1820
wb_do_writeback fs/fs-writeback.c:1965 [inline]
wb_workfn+0x29b/0x1250 fs/fs-writeback.c:2006
process_one_work+0x864/0x1570 kernel/workqueue.c:2153
worker_thread+0x64c/0x1130 kernel/workqueue.c:2296
kthread+0x33f/0x460 kernel/kthread.c:259
ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:415
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
syz-executor.1 (20236): drop_caches: 1
netlink: 168 bytes leftover after parsing attributes in process `syz-executor.4'.
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
ntfs: volume version 3.1.
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
syz-executor.1 (20282): drop_caches: 1
ntfs: volume version 3.1.
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1
syz-executor.1 (20322): drop_caches: 1


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.