UBSAN: undefined-behaviour in qdisc_get_rtab

5 views
Skip to first unread message

syzbot

unread,
Sep 16, 2020, 9:46:25 PM9/16/20
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: a87f9628 Linux 4.19.145
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16c1f473900000
kernel config: https://syzkaller.appspot.com/x/.config?x=9688ecb5b728ce13
dashboard link: https://syzkaller.appspot.com/bug?extid=410eb2a3eae45d8d0dc0
compiler: gcc (GCC) 10.1.0-syz 20200507

Unfortunately, I don't have any reproducer for this issue yet.

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+410eb2...@syzkaller.appspotmail.com

================================================================================
UBSAN: Undefined behaviour in net/sched/sch_api.c:375:22
shift exponent 43 is too large for 32-bit type 'int'
CPU: 0 PID: 28254 Comm: syz-executor.5 Not tainted 4.19.145-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
ubsan_epilogue+0xe/0x3a lib/ubsan.c:161
__ubsan_handle_shift_out_of_bounds.cold+0x1c4/0x250 lib/ubsan.c:422
__detect_linklayer net/sched/sch_api.c:375 [inline]
qdisc_get_rtab.cold+0x1d/0x8e net/sched/sch_api.c:421
tbf_change+0x978/0x1230 net/sched/sch_tbf.c:320
tbf_init+0x91/0xc4 net/sched/sch_tbf.c:433
qdisc_create+0x534/0x1080 net/sched/sch_api.c:1155
tc_modify_qdisc+0x4c0/0x195b net/sched/sch_api.c:1571
XFS (loop0): Invalid superblock magic number
rtnetlink_rcv_msg+0x498/0xc10 net/core/rtnetlink.c:4778
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x717/0xcc0 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc7/0x130 net/socket.c:632
___sys_sendmsg+0x7bb/0x8f0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x45d5f9
Code: 5d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fa635f1ac78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000002cf40 RCX: 000000000045d5f9
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000004
RBP: 000000000118cf80 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118cf4c
R13: 00007ffe8fbd608f R14: 00007fa635f1b9c0 R15: 000000000118cf4c
================================================================================
================================================================================
UBSAN: Undefined behaviour in net/sched/sch_api.c:376:24
shift exponent 43 is too large for 32-bit type 'int'
CPU: 0 PID: 28254 Comm: syz-executor.5 Not tainted 4.19.145-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
ubsan_epilogue+0xe/0x3a lib/ubsan.c:161
__ubsan_handle_shift_out_of_bounds.cold+0x1c4/0x250 lib/ubsan.c:422
__detect_linklayer net/sched/sch_api.c:376 [inline]
qdisc_get_rtab.cold+0x7f/0x8e net/sched/sch_api.c:421
tbf_change+0x978/0x1230 net/sched/sch_tbf.c:320
tbf_init+0x91/0xc4 net/sched/sch_tbf.c:433
qdisc_create+0x534/0x1080 net/sched/sch_api.c:1155
tc_modify_qdisc+0x4c0/0x195b net/sched/sch_api.c:1571
rtnetlink_rcv_msg+0x498/0xc10 net/core/rtnetlink.c:4778
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x717/0xcc0 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc7/0x130 net/socket.c:632
___sys_sendmsg+0x7bb/0x8f0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x45d5f9
Code: 5d b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 2b b4 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fa635f1ac78 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 000000000002cf40 RCX: 000000000045d5f9
RDX: 0000000000000000 RSI: 00000000200007c0 RDI: 0000000000000004
RBP: 000000000118cf80 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000118cf4c
R13: 00007ffe8fbd608f R14: 00007fa635f1b9c0 R15: 000000000118cf4c
================================================================================
XFS (loop0): Invalid superblock magic number
sch_tbf: burst 0 is lower than device lo mtu (65550) !
sch_tbf: burst 0 is lower than device lo mtu (65550) !
sch_tbf: burst 0 is lower than device lo mtu (65550) !
sch_tbf: burst 0 is lower than device lo mtu (65550) !
sch_tbf: burst 0 is lower than device lo mtu (65550) !
kauditd_printk_skb: 4 callbacks suppressed
audit: type=1400 audit(1600307105.085:167): avc: denied { dac_override } for pid=28392 comm="syz-executor.5" capability=1 scontext=system_u:system_r:kernel_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=cap_userns permissive=1
audit: type=1400 audit(1600307105.115:168): avc: denied { sys_ptrace } for pid=28389 comm="syz-executor.5" capability=19 scontext=system_u:system_r:kernel_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=cap_userns permissive=1
nf_conntrack: default automatic helper assignment has been turned off for security reasons and CT-based firewall rule not found. Use the iptables CT target to attach helpers instead.
nf_conntrack: default automatic helper assignment has been turned off for security reasons and CT-based firewall rule not found. Use the iptables CT target to attach helpers instead.
IPv6: ADDRCONF(NETDEV_CHANGE): lo: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): tunl0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gre0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gretap0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): erspan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip_vti0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip6_vti0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): lo: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): tunl0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gre0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gretap0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): erspan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip_vti0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip6_vti0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): lo: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): tunl0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gre0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gretap0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): erspan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip_vti0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip6_vti0: link becomes ready
IPVS: set_ctl: invalid protocol: 0 10.1.1.0:0
IPVS: set_ctl: invalid protocol: 0 10.1.1.0:0
IPVS: set_ctl: invalid protocol: 0 10.1.1.0:0
IPVS: set_ctl: invalid protocol: 0 10.1.1.0:0
IPv6: ADDRCONF(NETDEV_CHANGE): lo: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): tunl0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gre0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): gretap0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): erspan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip_vti0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): ip6_vti0: link becomes ready
IPVS: set_ctl: invalid protocol: 0 10.1.1.0:0
audit: type=1804 audit(1600307112.446:169): pid=28756 uid=0 auid=0 ses=4 subj=system_u:system_r:kernel_t:s0 op=invalid_pcr cause=open_writers comm="syz-executor.1" name="/root/syzkaller-testdir627078537/syzkaller.GaCE9t/382/bus" dev="sda1" ino=16571 res=1


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
Sep 20, 2020, 1:37:20 PM9/20/20
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 015e94d0 Linux 4.19.146
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=17a1184b900000
kernel config: https://syzkaller.appspot.com/x/.config?x=243dd74ad58a8a57
dashboard link: https://syzkaller.appspot.com/bug?extid=410eb2a3eae45d8d0dc0
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=138b3c3d900000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=142f15d9900000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+410eb2...@syzkaller.appspotmail.com

audit: type=1400 audit(1600623327.901:8): avc: denied { execmem } for pid=6490 comm="syz-executor263" scontext=system_u:system_r:kernel_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=process permissive=1
================================================================================
UBSAN: Undefined behaviour in net/sched/sch_api.c:375:22
shift exponent 255 is too large for 32-bit type 'int'
CPU: 0 PID: 6490 Comm: syz-executor263 Not tainted 4.19.146-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
ubsan_epilogue+0xe/0x3a lib/ubsan.c:161
__ubsan_handle_shift_out_of_bounds.cold+0x1c4/0x250 lib/ubsan.c:422
__detect_linklayer net/sched/sch_api.c:375 [inline]
qdisc_get_rtab.cold+0x1d/0x8e net/sched/sch_api.c:421
tbf_change+0x99d/0x1230 net/sched/sch_tbf.c:325
tbf_init+0x91/0xc4 net/sched/sch_tbf.c:433
qdisc_create+0x534/0x1080 net/sched/sch_api.c:1155
tc_modify_qdisc+0x4c0/0x195b net/sched/sch_api.c:1571
rtnetlink_rcv_msg+0x498/0xc10 net/core/rtnetlink.c:4778
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x717/0xcc0 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc7/0x130 net/socket.c:632
___sys_sendmsg+0x7bb/0x8f0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x440fe9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffe2ff6a018 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440fe9
RDX: 0000000000000000 RSI: 0000000020000800 RDI: 0000000000000004
RBP: 00000000006cb018 R08: 0000000000000000 R09: 00000000004002c8
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000004027f0
R13: 0000000000402880 R14: 0000000000000000 R15: 0000000000000000
================================================================================
================================================================================
UBSAN: Undefined behaviour in net/sched/sch_api.c:376:24
shift exponent 255 is too large for 32-bit type 'int'
CPU: 0 PID: 6490 Comm: syz-executor263 Not tainted 4.19.146-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x22c/0x33e lib/dump_stack.c:118
ubsan_epilogue+0xe/0x3a lib/ubsan.c:161
__ubsan_handle_shift_out_of_bounds.cold+0x1c4/0x250 lib/ubsan.c:422
__detect_linklayer net/sched/sch_api.c:376 [inline]
qdisc_get_rtab.cold+0x7f/0x8e net/sched/sch_api.c:421
tbf_change+0x99d/0x1230 net/sched/sch_tbf.c:325
tbf_init+0x91/0xc4 net/sched/sch_tbf.c:433
qdisc_create+0x534/0x1080 net/sched/sch_api.c:1155
tc_modify_qdisc+0x4c0/0x195b net/sched/sch_api.c:1571
rtnetlink_rcv_msg+0x498/0xc10 net/core/rtnetlink.c:4778
netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2455
netlink_unicast_kernel net/netlink/af_netlink.c:1318 [inline]
netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1344
netlink_sendmsg+0x717/0xcc0 net/netlink/af_netlink.c:1909
sock_sendmsg_nosec net/socket.c:622 [inline]
sock_sendmsg+0xc7/0x130 net/socket.c:632
___sys_sendmsg+0x7bb/0x8f0 net/socket.c:2115
__sys_sendmsg net/socket.c:2153 [inline]
__do_sys_sendmsg net/socket.c:2162 [inline]
__se_sys_sendmsg net/socket.c:2160 [inline]
__x64_sys_sendmsg+0x132/0x220 net/socket.c:2160
do_syscall_64+0xf9/0x670 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x440fe9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffe2ff6a018 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440fe9
RDX: 0000000000000000 RSI: 0000000020000800 RDI: 0000000000000004
RBP: 00000000006cb018 R08: 0000000000000000 R09: 00000000004002c8
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000004027f0
R13: 0000000000402880 R14: 0000000000000000 R15: 0000000000000000
================================

Reply all
Reply to author
Forward
0 new messages