KASAN: slab-out-of-bounds Read in bit_putcs

21 views
Skip to first unread message

syzbot

unread,
Dec 3, 2019, 7:47:08 AM12/3/19
to syzkaller...@googlegroups.com
Hello,

syzbot found the following crash on:

HEAD commit: 174651bd Linux 4.19.87
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=114b7446e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d306897dc6e131b7
dashboard link: https://syzkaller.appspot.com/bug?extid=07e7f57313dc988967db
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12e91c2ae00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15069aeae00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+07e7f5...@syzkaller.appspotmail.com

audit: type=1400 audit(1575373386.827:36): avc: denied { map } for
pid=7660 comm="syz-executor224" path="/root/syz-executor224548000"
dev="sda1" ino=16483 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
==================================================================
BUG: KASAN: slab-out-of-bounds in __fb_pad_aligned_buffer
include/linux/fb.h:674 [inline]
BUG: KASAN: slab-out-of-bounds in bit_putcs_aligned
drivers/video/fbdev/core/bitblit.c:96 [inline]
BUG: KASAN: slab-out-of-bounds in bit_putcs+0xd5d/0xf10
drivers/video/fbdev/core/bitblit.c:185
Read of size 1 at addr ffff888091df0734 by task syz-executor224/7660

CPU: 1 PID: 7660 Comm: syz-executor224 Not tainted 4.19.87-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x197/0x210 lib/dump_stack.c:118
print_address_description.cold+0x7c/0x20d mm/kasan/report.c:256
kasan_report_error mm/kasan/report.c:354 [inline]
kasan_report mm/kasan/report.c:412 [inline]
kasan_report.cold+0x8c/0x2ba mm/kasan/report.c:396
__asan_report_load1_noabort+0x14/0x20 mm/kasan/report.c:430
__fb_pad_aligned_buffer include/linux/fb.h:674 [inline]
bit_putcs_aligned drivers/video/fbdev/core/bitblit.c:96 [inline]
bit_putcs+0xd5d/0xf10 drivers/video/fbdev/core/bitblit.c:185
fbcon_putcs+0x42b/0x4f0 drivers/video/fbdev/core/fbcon.c:1320
do_update_region+0x42b/0x6f0 drivers/tty/vt/vt.c:677
redraw_screen+0x602/0x8e0 drivers/tty/vt/vt.c:1013
fbcon_modechanged+0x5f3/0x900 drivers/video/fbdev/core/fbcon.c:2969
fbcon_event_notify+0x1bd/0x1dba drivers/video/fbdev/core/fbcon.c:3344
notifier_call_chain+0xc2/0x230 kernel/notifier.c:93
__blocking_notifier_call_chain kernel/notifier.c:317 [inline]
__blocking_notifier_call_chain kernel/notifier.c:304 [inline]
blocking_notifier_call_chain kernel/notifier.c:328 [inline]
blocking_notifier_call_chain+0x94/0xb0 kernel/notifier.c:325
fb_notifier_call_chain+0x25/0x30 drivers/video/fbdev/core/fb_notify.c:45
fb_set_var+0xc8f/0xe80 drivers/video/fbdev/core/fbmem.c:1042
do_fb_ioctl+0x450/0xab0 drivers/video/fbdev/core/fbmem.c:1115
fb_ioctl+0xe6/0x130 drivers/video/fbdev/core/fbmem.c:1230
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:501 [inline]
do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
__do_sys_ioctl fs/ioctl.c:712 [inline]
__se_sys_ioctl fs/ioctl.c:710 [inline]
__x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x444dd9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7
48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
ff 0f 83 7b d8 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007fff053d4498 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fff053d44a0 RCX: 0000000000444dd9
RDX: 00000000200002c0 RSI: 0000000000004601 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000401690 R09: 0000000000401690
R10: 0000000000401690 R11: 0000000000000246 R12: 0000000000402ae0
R13: 0000000000402b70 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 7660:
save_stack+0x45/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
kasan_kmalloc mm/kasan/kasan.c:553 [inline]
kasan_kmalloc+0xce/0xf0 mm/kasan/kasan.c:531
__do_kmalloc mm/slab.c:3727 [inline]
__kmalloc+0x15d/0x750 mm/slab.c:3736
kmalloc include/linux/slab.h:520 [inline]
fbcon_set_font+0x32d/0x860 drivers/video/fbdev/core/fbcon.c:2641
con_font_set drivers/tty/vt/vt.c:4492 [inline]
con_font_op+0xe18/0x1250 drivers/tty/vt/vt.c:4557
vt_ioctl+0xd2e/0x2530 drivers/tty/vt/vt_ioctl.c:913
tty_ioctl+0x7f3/0x1510 drivers/tty/tty_io.c:2669
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:501 [inline]
do_vfs_ioctl+0xd5f/0x1380 fs/ioctl.c:688
ksys_ioctl+0xab/0xd0 fs/ioctl.c:705
__do_sys_ioctl fs/ioctl.c:712 [inline]
__se_sys_ioctl fs/ioctl.c:710 [inline]
__x64_sys_ioctl+0x73/0xb0 fs/ioctl.c:710
do_syscall_64+0xfd/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 5866:
save_stack+0x45/0xd0 mm/kasan/kasan.c:448
set_track mm/kasan/kasan.c:460 [inline]
__kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
__cache_free mm/slab.c:3503 [inline]
kfree+0xcf/0x220 mm/slab.c:3822
free_pipe_info+0x243/0x300 fs/pipe.c:697
put_pipe_info+0xd0/0xf0 fs/pipe.c:570
pipe_release+0x1e6/0x280 fs/pipe.c:591
__fput+0x2dd/0x8b0 fs/file_table.c:278
____fput+0x16/0x20 fs/file_table.c:309
task_work_run+0x145/0x1c0 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:193 [inline]
exit_to_usermode_loop+0x273/0x2c0 arch/x86/entry/common.c:167
prepare_exit_to_usermode arch/x86/entry/common.c:198 [inline]
syscall_return_slowpath arch/x86/entry/common.c:271 [inline]
do_syscall_64+0x53d/0x620 arch/x86/entry/common.c:296
entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff888091df04c0
which belongs to the cache kmalloc-1024 of size 1024
The buggy address is located 628 bytes inside of
1024-byte region [ffff888091df04c0, ffff888091df08c0)
The buggy address belongs to the page:
page:ffffea0002477c00 count:1 mapcount:0 mapping:ffff88812c31cac0 index:0x0
compound_mapcount: 0
flags: 0xfffe0000008100(slab|head)
raw: 00fffe0000008100 ffffea000230a908 ffffea00029f6308 ffff88812c31cac0
raw: 0000000000000000 ffff888091df0040 0000000100000007 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff888091df0600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff888091df0680: 00 00 00 00 00 00 00 00 00 00 fc fc fc fc fc fc
> ffff888091df0700: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
^
ffff888091df0780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff888091df0800: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================


---
This bug is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this bug report. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this bug, for details see:
https://goo.gl/tpsmEJ#testing-patches

syzbot

unread,
Dec 3, 2019, 11:38:09 AM12/3/19
to syzkaller...@googlegroups.com
Hello,

syzbot found the following crash on:

HEAD commit: fbc5fe7a Linux 4.14.157
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=170ecb7ae00000
kernel config: https://syzkaller.appspot.com/x/.config?x=d49d9f4045dcfa5d
dashboard link: https://syzkaller.appspot.com/bug?extid=356425c446d6a7b50838
compiler: gcc (GCC) 9.0.0 20181231 (experimental)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17cc27f2e00000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15769e41e00000

IMPORTANT: if you fix the bug, please add the following tag to the commit:
Reported-by: syzbot+356425...@syzkaller.appspotmail.com

audit: type=1400 audit(1575387220.002:36): avc: denied { map } for
pid=7060 comm="syz-executor145" path="/root/syz-executor145705848"
dev="sda1" ino=16484 scontext=unconfined_u:system_r:insmod_t:s0-s0:c0.c1023
tcontext=unconfined_u:object_r:user_home_t:s0 tclass=file permissive=1
==================================================================
BUG: KASAN: slab-out-of-bounds in __fb_pad_aligned_buffer
include/linux/fb.h:663 [inline]
BUG: KASAN: slab-out-of-bounds in bit_putcs_aligned
drivers/video/fbdev/core/bitblit.c:96 [inline]
BUG: KASAN: slab-out-of-bounds in bit_putcs+0xc09/0xdb0
drivers/video/fbdev/core/bitblit.c:185
Read of size 1 at addr ffff88808b9f4ff4 by task syz-executor145/7060

CPU: 0 PID: 7060 Comm: syz-executor145 Not tainted 4.14.157-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x142/0x197 lib/dump_stack.c:58
print_address_description.cold+0x7c/0x1dc mm/kasan/report.c:252
kasan_report_error mm/kasan/report.c:351 [inline]
kasan_report mm/kasan/report.c:409 [inline]
kasan_report.cold+0xa9/0x2af mm/kasan/report.c:393
__asan_report_load1_noabort+0x14/0x20 mm/kasan/report.c:427
__fb_pad_aligned_buffer include/linux/fb.h:663 [inline]
bit_putcs_aligned drivers/video/fbdev/core/bitblit.c:96 [inline]
bit_putcs+0xc09/0xdb0 drivers/video/fbdev/core/bitblit.c:185
fbcon_putcs+0x3c2/0x480 drivers/video/fbdev/core/fbcon.c:1298
do_update_region+0x3b3/0x650 drivers/tty/vt/vt.c:373
redraw_screen+0x589/0x7c0 drivers/tty/vt/vt.c:704
fbcon_modechanged+0x59e/0x880 drivers/video/fbdev/core/fbcon.c:2946
fbcon_event_notify+0x11f/0x17af drivers/video/fbdev/core/fbcon.c:3299
notifier_call_chain+0x111/0x1b0 kernel/notifier.c:93
__blocking_notifier_call_chain kernel/notifier.c:317 [inline]
__blocking_notifier_call_chain kernel/notifier.c:304 [inline]
blocking_notifier_call_chain kernel/notifier.c:328 [inline]
blocking_notifier_call_chain+0x80/0xa0 kernel/notifier.c:325
fb_notifier_call_chain+0x25/0x30 drivers/video/fbdev/core/fb_notify.c:45
fb_set_var+0xb09/0xcf0 drivers/video/fbdev/core/fbmem.c:1054
do_fb_ioctl+0x3cc/0x940 drivers/video/fbdev/core/fbmem.c:1127
fb_ioctl+0xe6/0x130 drivers/video/fbdev/core/fbmem.c:1242
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x7ae/0x1060 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x444dd9
RSP: 002b:00007ffd79b832c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007ffd79b832d0 RCX: 0000000000444dd9
RDX: 00000000200002c0 RSI: 0000000000004601 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000401690 R09: 0000000000401690
R10: 0000000000401690 R11: 0000000000000246 R12: 0000000000402ae0
R13: 0000000000402b70 R14: 0000000000000000 R15: 0000000000000000

Allocated by task 7060:
save_stack_trace+0x16/0x20 arch/x86/kernel/stacktrace.c:59
save_stack+0x45/0xd0 mm/kasan/kasan.c:447
set_track mm/kasan/kasan.c:459 [inline]
kasan_kmalloc mm/kasan/kasan.c:551 [inline]
kasan_kmalloc+0xce/0xf0 mm/kasan/kasan.c:529
__do_kmalloc mm/slab.c:3720 [inline]
__kmalloc+0x15d/0x7a0 mm/slab.c:3729
kmalloc include/linux/slab.h:493 [inline]
fbcon_set_font+0x2f8/0x7b0 drivers/video/fbdev/core/fbcon.c:2618
con_font_set drivers/tty/vt/vt.c:4162 [inline]
con_font_op+0xc0f/0x1060 drivers/tty/vt/vt.c:4227
vt_ioctl+0xb80/0x2170 drivers/tty/vt/vt_ioctl.c:927
tty_ioctl+0x841/0x1320 drivers/tty/tty_io.c:2661
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x7ae/0x1060 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x42/0xb7

Freed by task 0:
(stack is not available)

The buggy address belongs to the object at ffff88808b9f4d80
which belongs to the cache kmalloc-1024 of size 1024
The buggy address is located 628 bytes inside of
1024-byte region [ffff88808b9f4d80, ffff88808b9f5180)
The buggy address belongs to the page:
page:ffffea00022e7d00 count:1 mapcount:0 mapping:ffff88808b9f4000 index:0x0
compound_mapcount: 0
flags: 0xfffe0000008100(slab|head)
raw: 00fffe0000008100 ffff88808b9f4000 0000000000000000 0000000100000007
raw: ffffea0002302da0 ffff8880aa801848 ffff8880aa800ac0 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff88808b9f4e80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
ffff88808b9f4f00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> ffff88808b9f4f80: 00 00 fc fc fc fc fc fc fc fc fc fc fc fc fc fc
^
ffff88808b9f5000: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88808b9f5080: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
Reply all
Reply to author
Forward
0 new messages