[v5.15] KASAN: use-after-free Read in xfs_trans_ail_delete

3 views
Skip to first unread message

syzbot

unread,
Mar 20, 2023, 6:26:43 PM3/20/23
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 8020ae3c051d Linux 5.15.103
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=14c62ccac80000
kernel config: https://syzkaller.appspot.com/x/.config?x=d4215fb4040f8f8d
dashboard link: https://syzkaller.appspot.com/bug?extid=7e517c49fbb31941d8dd
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/857e17de0f0a/disk-8020ae3c.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9efc49fcd441/vmlinux-8020ae3c.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f14c38b6bfa7/bzImage-8020ae3c.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7e517c...@syzkaller.appspotmail.com

XFS (loop5): log I/O error -5
==================================================================
BUG: KASAN: use-after-free in xfs_trans_ail_delete+0x57/0x310 fs/xfs/xfs_trans_ail.c:865
Read of size 8 at addr ffff888034131800 by task kworker/1:1H/1239

CPU: 1 PID: 1239 Comm: kworker/1:1H Not tainted 5.15.103-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: xfs-log/loop5 xlog_ioend_work
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
print_address_description+0x63/0x3b0 mm/kasan/report.c:248
__kasan_report mm/kasan/report.c:434 [inline]
kasan_report+0x16b/0x1c0 mm/kasan/report.c:451
xfs_trans_ail_delete+0x57/0x310 fs/xfs/xfs_trans_ail.c:865
xfs_buf_item_done+0x5f/0x80 fs/xfs/xfs_buf_item.c:1041
xfs_buf_ioend+0x3dc/0x7e0 fs/xfs/xfs_buf.c:1286
xfs_trans_committed_bulk+0x300/0x7f0 fs/xfs/xfs_trans.c:780
xlog_cil_committed+0x28d/0xe50 fs/xfs/xfs_log_cil.c:631
xlog_cil_process_committed+0x155/0x1a0 fs/xfs/xfs_log_cil.c:659
xlog_state_shutdown_callbacks+0x2b6/0x3a0 fs/xfs/xfs_log.c:516
xlog_force_shutdown+0x1e7/0x200 fs/xfs/xfs_log.c:3896
xfs_do_force_shutdown+0x11d/0x520 fs/xfs/xfs_fsops.c:529
xlog_ioend_work+0xc2/0x120 fs/xfs/xfs_log.c:1364
process_one_work+0x90d/0x1270 kernel/workqueue.c:2306
worker_thread+0xaca/0x1280 kernel/workqueue.c:2453
kthread+0x3f6/0x4f0 kernel/kthread.c:319
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
</TASK>

Allocated by task 5496:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track mm/kasan/common.c:46 [inline]
set_alloc_info mm/kasan/common.c:434 [inline]
____kasan_kmalloc+0xba/0xf0 mm/kasan/common.c:513
kasan_kmalloc include/linux/kasan.h:264 [inline]
__kmalloc+0x152/0x290 mm/slub.c:4407
kmalloc include/linux/slab.h:596 [inline]
kmem_alloc+0x1c4/0x470 fs/xfs/kmem.c:21
kmem_zalloc fs/xfs/kmem.h:69 [inline]
xfs_trans_ail_init+0x20/0x240 fs/xfs/xfs_trans_ail.c:892
xfs_log_mount+0x1e4/0x720 fs/xfs/xfs_log.c:698
xfs_mountfs+0xb7a/0x1ca0 fs/xfs/xfs_mount.c:764
xfs_fs_fill_super+0x100c/0x1240 fs/xfs/xfs_super.c:1658
get_tree_bdev+0x3fe/0x620 fs/super.c:1294
vfs_get_tree+0x88/0x270 fs/super.c:1499
do_new_mount+0x28b/0xad0 fs/namespace.c:2994
do_mount fs/namespace.c:3337 [inline]
__do_sys_mount fs/namespace.c:3545 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

Freed by task 3639:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track+0x4b/0x80 mm/kasan/common.c:46
kasan_set_free_info+0x1f/0x40 mm/kasan/generic.c:360
____kasan_slab_free+0xd8/0x120 mm/kasan/common.c:366
kasan_slab_free include/linux/kasan.h:230 [inline]
slab_free_hook mm/slub.c:1705 [inline]
slab_free_freelist_hook+0xdd/0x160 mm/slub.c:1731
slab_free mm/slub.c:3499 [inline]
kfree+0x115/0x2e0 mm/slub.c:4559
xfs_log_unmount+0x51/0xc0 fs/xfs/xfs_log.c:1078
xfs_unmountfs+0x1bf/0x270 fs/xfs/xfs_mount.c:1040
xfs_fs_put_super+0x65/0x2b0 fs/xfs/xfs_super.c:1090
generic_shutdown_super+0x136/0x2c0 fs/super.c:466
kill_block_super+0x7a/0xe0 fs/super.c:1396
deactivate_locked_super+0xa0/0x110 fs/super.c:335
cleanup_mnt+0x44e/0x500 fs/namespace.c:1143
task_work_run+0x129/0x1a0 kernel/task_work.c:164
tracehook_notify_resume include/linux/tracehook.h:189 [inline]
exit_to_user_mode_loop+0x106/0x130 kernel/entry/common.c:175
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:207
__syscall_exit_to_user_mode_work kernel/entry/common.c:289 [inline]
syscall_exit_to_user_mode+0x5d/0x2b0 kernel/entry/common.c:300
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x61/0xcb

Last potentially related work creation:
kasan_save_stack+0x36/0x60 mm/kasan/common.c:38
kasan_record_aux_stack+0xba/0x100 mm/kasan/generic.c:348
__call_rcu kernel/rcu/tree.c:2993 [inline]
call_rcu+0x1c4/0xa70 kernel/rcu/tree.c:3073
free_fib_info net/ipv4/fib_semantics.c:255 [inline]
fib_info_put include/net/ip_fib.h:575 [inline]
fib_release_info+0x61c/0x6e0 net/ipv4/fib_semantics.c:280
fib_table_flush+0xb8d/0x1190 net/ipv4/fib_trie.c:2086
fib_flush net/ipv4/fib_frontend.c:194 [inline]
fib_disable_ip net/ipv4/fib_frontend.c:1412 [inline]
fib_netdev_event+0x3c5/0x760 net/ipv4/fib_frontend.c:1481
notifier_call_chain kernel/notifier.c:83 [inline]
raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:391
call_netdevice_notifiers_info net/core/dev.c:1998 [inline]
call_netdevice_notifiers_extack net/core/dev.c:2010 [inline]
call_netdevice_notifiers net/core/dev.c:2024 [inline]
dev_close_many+0x37c/0x530 net/core/dev.c:1599
dev_close+0x1b3/0x2b0 net/core/dev.c:1621
__bond_release_one+0xbdc/0x1290 drivers/net/bonding/bond_main.c:2422
do_set_master net/core/rtnetlink.c:2509 [inline]
do_setlink+0xef2/0x3af0 net/core/rtnetlink.c:2728
__rtnl_newlink net/core/rtnetlink.c:3395 [inline]
rtnl_newlink+0x177d/0x2060 net/core/rtnetlink.c:3510
rtnetlink_rcv_msg+0x993/0xee0 net/core/rtnetlink.c:5587
netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2533
netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1952
sock_sendmsg_nosec net/socket.c:704 [inline]
sock_sendmsg net/socket.c:724 [inline]
____sys_sendmsg+0x59e/0x8f0 net/socket.c:2412
___sys_sendmsg+0x252/0x2e0 net/socket.c:2466
__sys_sendmsg net/socket.c:2495 [inline]
__do_sys_sendmsg net/socket.c:2504 [inline]
__se_sys_sendmsg+0x19a/0x260 net/socket.c:2502
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

Second to last potentially related work creation:
kasan_save_stack+0x36/0x60 mm/kasan/common.c:38
kasan_record_aux_stack+0xba/0x100 mm/kasan/generic.c:348
__call_rcu kernel/rcu/tree.c:2993 [inline]
call_rcu+0x1c4/0xa70 kernel/rcu/tree.c:3073
fib_create_info+0x190d/0x2570 net/ipv4/fib_semantics.c:1602
fib_table_insert+0x213/0x1f90 net/ipv4/fib_trie.c:1231
fib_magic net/ipv4/fib_frontend.c:1090 [inline]
fib_add_ifaddr+0x47f/0x1730 net/ipv4/fib_frontend.c:1112
fib_netdev_event+0x61d/0x760 net/ipv4/fib_frontend.c:1472
notifier_call_chain kernel/notifier.c:83 [inline]
raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:391
__dev_notify_flags+0x304/0x610
dev_change_flags+0xe7/0x190 net/core/dev.c:8859
do_setlink+0xcd1/0x3af0 net/core/rtnetlink.c:2721
rtnl_group_changelink net/core/rtnetlink.c:3244 [inline]
__rtnl_newlink net/core/rtnetlink.c:3400 [inline]
rtnl_newlink+0x1109/0x2060 net/core/rtnetlink.c:3510
rtnetlink_rcv_msg+0x993/0xee0 net/core/rtnetlink.c:5587
netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2533
netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1952
sock_sendmsg_nosec net/socket.c:704 [inline]
sock_sendmsg net/socket.c:724 [inline]
____sys_sendmsg+0x59e/0x8f0 net/socket.c:2412
___sys_sendmsg+0x252/0x2e0 net/socket.c:2466
__sys_sendmsg net/socket.c:2495 [inline]
__do_sys_sendmsg net/socket.c:2504 [inline]
__se_sys_sendmsg+0x19a/0x260 net/socket.c:2502
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

The buggy address belongs to the object at ffff888034131800
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 0 bytes inside of
256-byte region [ffff888034131800, ffff888034131900)
The buggy address belongs to the page:
page:ffffea0000d04c00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x34130
head:ffffea0000d04c00 order:1 compound_mapcount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 ffffea00006d1000 0000000900000004 ffff888011c41b40
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 1, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 3625, ts 195021431115, free_ts 0
prep_new_page mm/page_alloc.c:2426 [inline]
get_page_from_freelist+0x32dd/0x3470 mm/page_alloc.c:4159
__alloc_pages+0x272/0x790 mm/page_alloc.c:5421
alloc_slab_page mm/slub.c:1775 [inline]
allocate_slab mm/slub.c:1912 [inline]
new_slab+0xbb/0x4b0 mm/slub.c:1975
___slab_alloc+0x6f6/0xe10 mm/slub.c:3008
__slab_alloc mm/slub.c:3095 [inline]
slab_alloc_node mm/slub.c:3186 [inline]
slab_alloc mm/slub.c:3228 [inline]
__kmalloc+0x1b2/0x290 mm/slub.c:4403
kmalloc include/linux/slab.h:596 [inline]
kzalloc include/linux/slab.h:721 [inline]
new_dir fs/proc/proc_sysctl.c:954 [inline]
get_subdir fs/proc/proc_sysctl.c:999 [inline]
__register_sysctl_table+0x9f1/0x1220 fs/proc/proc_sysctl.c:1348
__devinet_sysctl_register+0x1d3/0x2a0 net/ipv4/devinet.c:2577
devinet_sysctl_register+0x13a/0x1a0 net/ipv4/devinet.c:2617
inetdev_init+0x257/0x470 net/ipv4/devinet.c:276
inetdev_event+0x29b/0x1490 net/ipv4/devinet.c:1530
notifier_call_chain kernel/notifier.c:83 [inline]
raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:391
call_netdevice_notifiers_info net/core/dev.c:1998 [inline]
call_netdevice_notifiers_extack net/core/dev.c:2010 [inline]
call_netdevice_notifiers+0x145/0x1b0 net/core/dev.c:2024
register_netdevice+0x12c2/0x1700 net/core/dev.c:10358
nsim_init_netdevsim drivers/net/netdevsim/netdev.c:317 [inline]
nsim_create+0x329/0x3e0 drivers/net/netdevsim/netdev.c:365
__nsim_dev_port_add+0x6de/0xb90 drivers/net/netdevsim/dev.c:1315
nsim_dev_port_add_all+0x35/0x110 drivers/net/netdevsim/dev.c:1375
page_owner free stack trace missing

Memory state around the buggy address:
ffff888034131700: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff888034131780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff888034131800: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff888034131880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff888034131900: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

syzbot

unread,
Mar 30, 2023, 3:54:51 PM3/30/23
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 3b29299e5f60 Linux 6.1.22
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15e65725c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=4a782518325cb082
dashboard link: https://syzkaller.appspot.com/bug?extid=7f6b550d8fc0cc7f04ce
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/f6cdeb0f8946/disk-3b29299e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/cc5e0da6e9ab/vmlinux-3b29299e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/9e31f151a6a5/bzImage-3b29299e.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7f6b55...@syzkaller.appspotmail.com

XFS (loop3): log I/O error -5
XFS (loop3): Filesystem has been shut down due to log error (0x2).
XFS (loop3): Please unmount the filesystem and rectify the problem(s).
==================================================================
BUG: KASAN: use-after-free in xfs_trans_ail_delete+0x5b/0x320 fs/xfs/xfs_trans_ail.c:875
Read of size 8 at addr ffff88802754f600 by task kworker/1:1H/120

CPU: 1 PID: 120 Comm: kworker/1:1H Not tainted 6.1.22-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Workqueue: xfs-log/loop3 xlog_ioend_work
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
print_address_description mm/kasan/report.c:284 [inline]
print_report+0x15f/0x4f0 mm/kasan/report.c:395
kasan_report+0x136/0x160 mm/kasan/report.c:495
xfs_trans_ail_delete+0x5b/0x320 fs/xfs/xfs_trans_ail.c:875
xfs_buf_item_done+0x5f/0x80 fs/xfs/xfs_buf_item.c:1042
xfs_buf_ioend+0x336/0x780 fs/xfs/xfs_buf.c:1326
xfs_trans_committed_bulk+0x342/0x830 fs/xfs/xfs_trans.c:806
xlog_cil_committed+0x269/0xed0 fs/xfs/xfs_log_cil.c:795
xlog_cil_process_committed+0x155/0x1a0 fs/xfs/xfs_log_cil.c:823
xlog_state_shutdown_callbacks+0x2b6/0x3a0 fs/xfs/xfs_log.c:538
xlog_force_shutdown+0x328/0x380 fs/xfs/xfs_log.c:3821
xlog_ioend_work+0xa9/0x100 fs/xfs/xfs_log.c:1402
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2289
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436
kthread+0x268/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
</TASK>

Allocated by task 8209:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
____kasan_kmalloc mm/kasan/common.c:374 [inline]
__kasan_kmalloc+0x97/0xb0 mm/kasan/common.c:383
kasan_kmalloc include/linux/kasan.h:211 [inline]
__do_kmalloc_node mm/slab_common.c:955 [inline]
__kmalloc+0xb2/0x230 mm/slab_common.c:968
kmalloc include/linux/slab.h:558 [inline]
kmem_alloc+0x15c/0x420 fs/xfs/kmem.c:20
kmem_zalloc fs/xfs/kmem.h:69 [inline]
xfs_trans_ail_init+0x20/0x240 fs/xfs/xfs_trans_ail.c:902
xfs_log_mount+0x213/0x770 fs/xfs/xfs_log.c:721
xfs_mountfs+0xcbb/0x1f00 fs/xfs/xfs_mount.c:805
xfs_fs_fill_super+0xf90/0x11e0 fs/xfs/xfs_super.c:1666
get_tree_bdev+0x3fe/0x620 fs/super.c:1346
vfs_get_tree+0x88/0x270 fs/super.c:1553
do_new_mount+0x28b/0xad0 fs/namespace.c:3040
do_mount fs/namespace.c:3383 [inline]
__do_sys_mount fs/namespace.c:3591 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 3675:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
kasan_save_free_info+0x27/0x40 mm/kasan/generic.c:516
____kasan_slab_free+0xd6/0x120 mm/kasan/common.c:236
kasan_slab_free include/linux/kasan.h:177 [inline]
slab_free_hook mm/slub.c:1724 [inline]
slab_free_freelist_hook mm/slub.c:1750 [inline]
slab_free mm/slub.c:3661 [inline]
__kmem_cache_free+0x25c/0x3c0 mm/slub.c:3674
xfs_log_unmount+0x51/0xc0 fs/xfs/xfs_log.c:1116
xfs_unmountfs+0x12c/0x1e0 fs/xfs/xfs_mount.c:1081
xfs_fs_put_super+0x6c/0x2c0 fs/xfs/xfs_super.c:1115
generic_shutdown_super+0x130/0x340 fs/super.c:501
kill_block_super+0x7a/0xe0 fs/super.c:1450
deactivate_locked_super+0xa0/0x110 fs/super.c:332
cleanup_mnt+0x490/0x520 fs/namespace.c:1186
task_work_run+0x246/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:297
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Last potentially related work creation:
kasan_save_stack+0x3b/0x60 mm/kasan/common.c:45
__kasan_record_aux_stack+0xb0/0xc0 mm/kasan/generic.c:486
kvfree_call_rcu+0x116/0x8c0 kernel/rcu/tree.c:3343
drop_sysctl_table+0x317/0x460 fs/proc/proc_sysctl.c:1709
drop_sysctl_table+0x329/0x460 fs/proc/proc_sysctl.c:1712
unregister_sysctl_table+0x86/0x130 fs/proc/proc_sysctl.c:1747
neigh_sysctl_unregister+0x74/0x90 net/core/neighbour.c:3885
addrconf_sysctl_unregister net/ipv6/addrconf.c:7147 [inline]
addrconf_ifdown+0x18a4/0x1b90 net/ipv6/addrconf.c:3908
addrconf_notify+0x3ec/0xf60
notifier_call_chain kernel/notifier.c:87 [inline]
raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:455
call_netdevice_notifiers_info net/core/dev.c:1945 [inline]
call_netdevice_notifiers_extack net/core/dev.c:1983 [inline]
call_netdevice_notifiers net/core/dev.c:1997 [inline]
unregister_netdevice_many+0xefe/0x1870 net/core/dev.c:10841
sit_exit_batch_net+0x43c/0x480 net/ipv6/sit.c:1885
ops_exit_list net/core/net_namespace.c:174 [inline]
cleanup_net+0x763/0xb60 net/core/net_namespace.c:601
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2289
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436
kthread+0x268/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

Second to last potentially related work creation:
kasan_save_stack+0x3b/0x60 mm/kasan/common.c:45
__kasan_record_aux_stack+0xb0/0xc0 mm/kasan/generic.c:486
kvfree_call_rcu+0x116/0x8c0 kernel/rcu/tree.c:3343
drop_sysctl_table+0x317/0x460 fs/proc/proc_sysctl.c:1709
drop_sysctl_table+0x329/0x460 fs/proc/proc_sysctl.c:1712
unregister_sysctl_table+0x86/0x130 fs/proc/proc_sysctl.c:1747
neigh_sysctl_unregister+0x74/0x90 net/core/neighbour.c:3885
addrconf_sysctl_unregister net/ipv6/addrconf.c:7147 [inline]
addrconf_ifdown+0x18a4/0x1b90 net/ipv6/addrconf.c:3908
addrconf_notify+0x3ec/0xf60
notifier_call_chain kernel/notifier.c:87 [inline]
raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:455
call_netdevice_notifiers_info net/core/dev.c:1945 [inline]
call_netdevice_notifiers_extack net/core/dev.c:1983 [inline]
call_netdevice_notifiers net/core/dev.c:1997 [inline]
unregister_netdevice_many+0xefe/0x1870 net/core/dev.c:10841
ip_tunnel_delete_nets+0x2ed/0x330 net/ipv4/ip_tunnel.c:1126
ops_exit_list net/core/net_namespace.c:174 [inline]
cleanup_net+0x763/0xb60 net/core/net_namespace.c:601
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2289
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436
kthread+0x268/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

The buggy address belongs to the object at ffff88802754f600
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 0 bytes inside of
256-byte region [ffff88802754f600, ffff88802754f700)

The buggy address belongs to the physical page:
page:ffffea00009d5380 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x2754e
head:ffffea00009d5380 order:1 compound_mapcount:0 compound_pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 ffffea0000dc8e00 dead000000000002 ffff888012441b40
raw: 0000000000000000 0000000080100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 1, migratetype Unmovable, gfp_mask 0x1d20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_HARDWALL), pid 3675, tgid 3675 (syz-executor.3), ts 371467149301, free_ts 371446669554
prep_new_page mm/page_alloc.c:2540 [inline]
get_page_from_freelist+0x32ed/0x3480 mm/page_alloc.c:4292
__alloc_pages+0x28d/0x770 mm/page_alloc.c:5559
alloc_slab_page+0x6a/0x150 mm/slub.c:1794
allocate_slab mm/slub.c:1939 [inline]
new_slab+0x84/0x2d0 mm/slub.c:1992
___slab_alloc+0xa71/0x1080 mm/slub.c:3180
__slab_alloc mm/slub.c:3279 [inline]
slab_alloc_node mm/slub.c:3364 [inline]
__kmem_cache_alloc_node+0x19f/0x260 mm/slub.c:3437
__do_kmalloc_node mm/slab_common.c:954 [inline]
__kmalloc+0xa1/0x230 mm/slab_common.c:968
kmalloc include/linux/slab.h:558 [inline]
kzalloc include/linux/slab.h:689 [inline]
fib_create_info+0xa37/0x2500 net/ipv4/fib_semantics.c:1454
fib_table_insert+0x1f2/0x1f20 net/ipv4/fib_trie.c:1236
fib_magic net/ipv4/fib_frontend.c:1104 [inline]
fib_add_ifaddr+0xf4c/0x1730 net/ipv4/fib_frontend.c:1148
fib_netdev_event+0x620/0x730 net/ipv4/fib_frontend.c:1486
notifier_call_chain kernel/notifier.c:87 [inline]
raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:455
__dev_notify_flags+0x304/0x610
dev_change_flags+0xe7/0x190 net/core/dev.c:8621
do_setlink+0xf5d/0x3e60 net/core/rtnetlink.c:2788
__rtnl_newlink net/core/rtnetlink.c:3547 [inline]
rtnl_newlink+0x16f7/0x1fa0 net/core/rtnetlink.c:3594
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1460 [inline]
free_pcp_prepare mm/page_alloc.c:1510 [inline]
free_unref_page_prepare+0xf5e/0x1110 mm/page_alloc.c:3388
free_unref_page+0x98/0x570 mm/page_alloc.c:3484
free_slab mm/slub.c:2031 [inline]
discard_slab mm/slub.c:2037 [inline]
__unfreeze_partials+0x1b7/0x210 mm/slub.c:2586
put_cpu_partial+0x116/0x180 mm/slub.c:2662
qlist_free_all+0x22/0x60 mm/kasan/quarantine.c:187
kasan_quarantine_reduce+0x162/0x180 mm/kasan/quarantine.c:294
__kasan_slab_alloc+0x1f/0x70 mm/kasan/common.c:305
kasan_slab_alloc include/linux/kasan.h:201 [inline]
slab_post_alloc_hook+0x50/0x370 mm/slab.h:737
slab_alloc_node mm/slub.c:3398 [inline]
slab_alloc mm/slub.c:3406 [inline]
__kmem_cache_alloc_lru mm/slub.c:3413 [inline]
kmem_cache_alloc+0x10c/0x2d0 mm/slub.c:3422
getname_flags+0xb8/0x4e0 fs/namei.c:139
do_sys_openat2+0xd2/0x500 fs/open.c:1304
do_sys_open fs/open.c:1326 [inline]
__do_sys_openat fs/open.c:1342 [inline]
__se_sys_openat fs/open.c:1337 [inline]
__x64_sys_openat+0x243/0x290 fs/open.c:1337
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
ffff88802754f500: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff88802754f580: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff88802754f600: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff88802754f680: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88802754f700: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc

syzbot

unread,
May 24, 2023, 4:33:05 AM5/24/23
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: fa74641fb6b9 Linux 6.1.29
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15ef3f2e280000
kernel config: https://syzkaller.appspot.com/x/.config?x=fac5c36c2b16009f
dashboard link: https://syzkaller.appspot.com/bug?extid=7f6b550d8fc0cc7f04ce
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1306341e280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1028c5f9280000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/3e78f005d7f8/disk-fa74641f.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/6527fcf66401/vmlinux-fa74641f.xz
kernel image: https://storage.googleapis.com/syzbot-assets/c5e0d5f8b434/bzImage-fa74641f.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/5fb1a9dcee0a/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7f6b55...@syzkaller.appspotmail.com

XFS (loop3): Please unmount the filesystem and rectify the problem(s).
XFS (loop2): log I/O error -5
XFS (loop2): Filesystem has been shut down due to log error (0x2).
XFS (loop2): Please unmount the filesystem and rectify the problem(s).
==================================================================
BUG: KASAN: use-after-free in xfs_trans_ail_delete+0x5b/0x320 fs/xfs/xfs_trans_ail.c:875
Read of size 8 at addr ffff888022910a00 by task kworker/1:1H/52

CPU: 1 PID: 52 Comm: kworker/1:1H Not tainted 6.1.29-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/28/2023
Workqueue: xfs-log/loop2 xlog_ioend_work
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
print_address_description mm/kasan/report.c:284 [inline]
print_report+0x15f/0x4f0 mm/kasan/report.c:395
kasan_report+0x136/0x160 mm/kasan/report.c:495
xfs_trans_ail_delete+0x5b/0x320 fs/xfs/xfs_trans_ail.c:875
xfs_buf_item_done+0x5f/0x80 fs/xfs/xfs_buf_item.c:1042
xfs_buf_ioend+0x336/0x780 fs/xfs/xfs_buf.c:1326
xfs_trans_committed_bulk+0x342/0x830 fs/xfs/xfs_trans.c:806
xlog_cil_committed+0x269/0xed0 fs/xfs/xfs_log_cil.c:795
xlog_cil_process_committed+0x155/0x1a0 fs/xfs/xfs_log_cil.c:823
xlog_state_shutdown_callbacks+0x2b6/0x3a0 fs/xfs/xfs_log.c:538
xlog_force_shutdown+0x328/0x380 fs/xfs/xfs_log.c:3821
xlog_ioend_work+0xa9/0x100 fs/xfs/xfs_log.c:1402
process_one_work+0x8aa/0x11f0 kernel/workqueue.c:2289
worker_thread+0xa5f/0x1210 kernel/workqueue.c:2436
kthread+0x26e/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
</TASK>

Allocated by task 4496:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
____kasan_kmalloc mm/kasan/common.c:374 [inline]
__kasan_kmalloc+0x97/0xb0 mm/kasan/common.c:383
kasan_kmalloc include/linux/kasan.h:211 [inline]
__do_kmalloc_node mm/slab_common.c:955 [inline]
__kmalloc+0xb2/0x230 mm/slab_common.c:968
kmalloc include/linux/slab.h:558 [inline]
kmem_alloc+0x15c/0x420 fs/xfs/kmem.c:20
kmem_zalloc fs/xfs/kmem.h:69 [inline]
xfs_trans_ail_init+0x20/0x240 fs/xfs/xfs_trans_ail.c:902
xfs_log_mount+0x213/0x770 fs/xfs/xfs_log.c:721
xfs_mountfs+0xcbb/0x1f00 fs/xfs/xfs_mount.c:805
xfs_fs_fill_super+0xf90/0x11e0 fs/xfs/xfs_super.c:1666
get_tree_bdev+0x3fe/0x620 fs/super.c:1346
vfs_get_tree+0x88/0x270 fs/super.c:1553
do_new_mount+0x28b/0xad0 fs/namespace.c:3040
do_mount fs/namespace.c:3383 [inline]
__do_sys_mount fs/namespace.c:3591 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Freed by task 3580:
kasan_save_stack mm/kasan/common.c:45 [inline]
kasan_set_track+0x4b/0x70 mm/kasan/common.c:52
kasan_save_free_info+0x27/0x40 mm/kasan/generic.c:516
____kasan_slab_free+0xd6/0x120 mm/kasan/common.c:236
kasan_slab_free include/linux/kasan.h:177 [inline]
slab_free_hook mm/slub.c:1724 [inline]
slab_free_freelist_hook mm/slub.c:1750 [inline]
slab_free mm/slub.c:3661 [inline]
__kmem_cache_free+0x25c/0x3c0 mm/slub.c:3674
xfs_log_unmount+0x51/0xc0 fs/xfs/xfs_log.c:1116
xfs_unmountfs+0x12c/0x1e0 fs/xfs/xfs_mount.c:1081
xfs_fs_put_super+0x6c/0x2c0 fs/xfs/xfs_super.c:1115
generic_shutdown_super+0x130/0x340 fs/super.c:501
kill_block_super+0x7a/0xe0 fs/super.c:1450
deactivate_locked_super+0xa0/0x110 fs/super.c:332
cleanup_mnt+0x490/0x520 fs/namespace.c:1186
task_work_run+0x246/0x300 kernel/task_work.c:179
resume_user_mode_work include/linux/resume_user_mode.h:49 [inline]
exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171
exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:204
__syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline]
syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:297
do_syscall_64+0x49/0xb0 arch/x86/entry/common.c:86
entry_SYSCALL_64_after_hwframe+0x63/0xcd

The buggy address belongs to the object at ffff888022910a00
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 0 bytes inside of
256-byte region [ffff888022910a00, ffff888022910b00)

The buggy address belongs to the physical page:
page:ffffea00008a4400 refcount:1 mapcount:0 mapping:0000000000000000 index:0xffff888022911e00 pfn:0x22910
head:ffffea00008a4400 order:1 compound_mapcount:0 compound_pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 ffffea00007b7f80 dead000000000003 ffff888012441b40
raw: ffff888022911e00 0000000080100006 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 1, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 4040, tgid 4039 (syz-executor191), ts 613421102172, free_ts 612431443091
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook+0x18d/0x1b0 mm/page_alloc.c:2533
prep_new_page mm/page_alloc.c:2540 [inline]
get_page_from_freelist+0x32ed/0x3480 mm/page_alloc.c:4292
__alloc_pages+0x28d/0x770 mm/page_alloc.c:5559
alloc_slab_page+0x6a/0x150 mm/slub.c:1794
allocate_slab mm/slub.c:1939 [inline]
new_slab+0x84/0x2d0 mm/slub.c:1992
___slab_alloc+0xa71/0x1080 mm/slub.c:3180
__slab_alloc mm/slub.c:3279 [inline]
slab_alloc_node mm/slub.c:3364 [inline]
__kmem_cache_alloc_node+0x19f/0x260 mm/slub.c:3437
__do_kmalloc_node mm/slab_common.c:954 [inline]
__kmalloc+0xa1/0x230 mm/slab_common.c:968
kmalloc_array include/linux/slab.h:605 [inline]
kcalloc include/linux/slab.h:636 [inline]
__list_lru_init+0xa6/0x5d0 mm/list_lru.c:571
xfs_qm_init_quotainfo+0xef/0x12f0 fs/xfs/xfs_qm.c:627
xfs_qm_mount_quotas+0x97/0x620 fs/xfs/xfs_qm.c:1424
xfs_mountfs+0x185d/0x1f00 fs/xfs/xfs_mount.c:945
xfs_fs_fill_super+0xf90/0x11e0 fs/xfs/xfs_super.c:1666
get_tree_bdev+0x3fe/0x620 fs/super.c:1346
vfs_get_tree+0x88/0x270 fs/super.c:1553
do_new_mount+0x28b/0xad0 fs/namespace.c:3040
page last free stack trace:
reset_page_owner include/linux/page_owner.h:24 [inline]
free_pages_prepare mm/page_alloc.c:1460 [inline]
free_pcp_prepare mm/page_alloc.c:1510 [inline]
free_unref_page_prepare+0xf63/0x1120 mm/page_alloc.c:3388
free_unref_page+0x98/0x570 mm/page_alloc.c:3484
qlist_free_all+0x22/0x60 mm/kasan/quarantine.c:187
kasan_quarantine_reduce+0x162/0x180 mm/kasan/quarantine.c:294
__kasan_slab_alloc+0x1f/0x70 mm/kasan/common.c:305
kasan_slab_alloc include/linux/kasan.h:201 [inline]
slab_post_alloc_hook+0x50/0x370 mm/slab.h:737
slab_alloc_node mm/slub.c:3398 [inline]
slab_alloc mm/slub.c:3406 [inline]
__kmem_cache_alloc_lru mm/slub.c:3413 [inline]
kmem_cache_alloc+0x10c/0x2d0 mm/slub.c:3422
getname_flags+0xb8/0x4e0 fs/namei.c:139
user_path_at_empty+0x2a/0x180 fs/namei.c:2875
do_readlinkat+0x114/0x3a0 fs/stat.c:468
__do_sys_readlink fs/stat.c:501 [inline]
__se_sys_readlink fs/stat.c:498 [inline]
__x64_sys_readlink+0x7b/0x90 fs/stat.c:498
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
ffff888022910900: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
ffff888022910980: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
>ffff888022910a00: fa fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff888022910a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff888022910b00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

syzbot

unread,
Oct 3, 2023, 11:08:46 AM10/3/23
to syzkaller...@googlegroups.com
Auto-closing this bug as obsolete.
Crashes did not happen for a while, no reproducer and no activity.

syzbot

unread,
Nov 23, 2023, 6:10:09 AM11/23/23
to syzkaller...@googlegroups.com
syzbot suspects this issue could be fixed by backporting the following commit:

commit 1eb52a6a71981b80f9acbd915acd6a05a5037196
git tree: upstream
Author: Guo Xuenan <guox...@huawei.com>
Date: Wed Nov 30 17:25:46 2022 +0000

xfs: wait iclog complete before tearing down AIL

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=116705af680000
Please keep in mind that other backports might be required as well.

For information about bisection process see: https://goo.gl/tpsmEJ#bisection
Reply all
Reply to author
Forward
0 new messages