[v5.15] possible deadlock in do_journal_begin_r

0 views
Skip to first unread message

syzbot

unread,
Jun 19, 2023, 3:49:58 AM6/19/23
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 471e639e59d1 Linux 5.15.117
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=142917ef280000
kernel config: https://syzkaller.appspot.com/x/.config?x=6390289bcc1381aa
dashboard link: https://syzkaller.appspot.com/bug?extid=f6ec13710cba2de48467
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14c9d897280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1235d24b280000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/145b7f137d72/disk-471e639e.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/b5bd2fcb945c/vmlinux-471e639e.xz
kernel image: https://storage.googleapis.com/syzbot-assets/794584032e0f/bzImage-471e639e.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/0690fa98c32b/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+f6ec13...@syzkaller.appspotmail.com

REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop0): using 3.5.x disk format
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
5.15.117-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor302/3585 is trying to acquire lock:
ffffc900036e10f0 (&journal->j_mutex){+.+.}-{3:3}, at: reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
ffffc900036e10f0 (&journal->j_mutex){+.+.}-{3:3}, at: lock_journal fs/reiserfs/journal.c:534 [inline]
ffffc900036e10f0 (&journal->j_mutex){+.+.}-{3:3}, at: do_journal_begin_r+0x34e/0x1000 fs/reiserfs/journal.c:3043

but task is already holding lock:
ffff8880790da558 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (sb_pagefaults){.+.+}-{0:0}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1742 [inline]
sb_start_pagefault include/linux/fs.h:1841 [inline]
filemap_page_mkwrite+0x11b/0x650 mm/filemap.c:3358
do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883
do_shared_fault mm/memory.c:4285 [inline]
do_fault mm/memory.c:4353 [inline]
handle_pte_fault mm/memory.c:4608 [inline]
__handle_mm_fault mm/memory.c:4743 [inline]
handle_mm_fault+0x2803/0x5950 mm/memory.c:4841
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
__put_user_nocheck_4+0x3/0x11
reiserfs_ioctl+0x14d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #2 (&mm->mmap_lock#2){++++}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__might_fault+0xb4/0x110 mm/memory.c:5311
reiserfs_ioctl+0x11d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&sbi->lock){+.+.}-{3:3}:
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
reiserfs_write_lock_nested+0x5b/0xd0 fs/reiserfs/lock.c:78
reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:815 [inline]
lock_journal fs/reiserfs/journal.c:534 [inline]
do_journal_begin_r+0x359/0x1000 fs/reiserfs/journal.c:3043
journal_begin+0x148/0x350 fs/reiserfs/journal.c:3251
reiserfs_fill_super+0x1812/0x2690 fs/reiserfs/super.c:2108
mount_bdev+0x2c9/0x3f0 fs/super.c:1378
legacy_get_tree+0xeb/0x180 fs/fs_context.c:610
vfs_get_tree+0x88/0x270 fs/super.c:1508
do_new_mount+0x28b/0xae0 fs/namespace.c:2994
do_mount fs/namespace.c:3337 [inline]
__do_sys_mount fs/namespace.c:3545 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3522
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&journal->j_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
lock_journal fs/reiserfs/journal.c:534 [inline]
do_journal_begin_r+0x34e/0x1000 fs/reiserfs/journal.c:3043
journal_begin+0x148/0x350 fs/reiserfs/journal.c:3251
reiserfs_dirty_inode+0x11c/0x240 fs/reiserfs/super.c:710
__mark_inode_dirty+0x2fd/0xd60 fs/fs-writeback.c:2442
generic_update_time+0x1cb/0x1e0 fs/inode.c:1775
inode_update_time fs/inode.c:1788 [inline]
file_update_time+0x3eb/0x460 fs/inode.c:1977
filemap_page_mkwrite+0x222/0x650 mm/filemap.c:3359
do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883
do_shared_fault mm/memory.c:4285 [inline]
do_fault mm/memory.c:4353 [inline]
handle_pte_fault mm/memory.c:4608 [inline]
__handle_mm_fault mm/memory.c:4743 [inline]
handle_mm_fault+0x2803/0x5950 mm/memory.c:4841
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
__put_user_nocheck_4+0x3/0x11
reiserfs_ioctl+0x14d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
&journal->j_mutex --> &mm->mmap_lock#2 --> sb_pagefaults

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(sb_pagefaults);
lock(&mm->mmap_lock#2);
lock(sb_pagefaults);
lock(&journal->j_mutex);

*** DEADLOCK ***

2 locks held by syz-executor302/3585:
#0: ffff888018da3228 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_lock+0x1c/0x50 include/linux/mmap_lock.h:117
#1: ffff8880790da558 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883

stack backtrace:
CPU: 0 PID: 3585 Comm: syz-executor302 Not tainted 5.15.117-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
check_prev_add kernel/locking/lockdep.c:3053 [inline]
check_prevs_add kernel/locking/lockdep.c:3172 [inline]
validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
__lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
__mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
__mutex_lock kernel/locking/mutex.c:729 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
lock_journal fs/reiserfs/journal.c:534 [inline]
do_journal_begin_r+0x34e/0x1000 fs/reiserfs/journal.c:3043
journal_begin+0x148/0x350 fs/reiserfs/journal.c:3251
reiserfs_dirty_inode+0x11c/0x240 fs/reiserfs/super.c:710
__mark_inode_dirty+0x2fd/0xd60 fs/fs-writeback.c:2442
generic_update_time+0x1cb/0x1e0 fs/inode.c:1775
inode_update_time fs/inode.c:1788 [inline]
file_update_time+0x3eb/0x460 fs/inode.c:1977
filemap_page_mkwrite+0x222/0x650 mm/filemap.c:3359
do_page_mkwrite+0x1a9/0x440 mm/memory.c:2883
do_shared_fault mm/memory.c:4285 [inline]
do_fault mm/memory.c:4353 [inline]
handle_pte_fault mm/memory.c:4608 [inline]
__handle_mm_fault mm/memory.c:4743 [inline]
handle_mm_fault+0x2803/0x5950 mm/memory.c:4841
do_user_addr_fault arch/x86/mm/fault.c:1397 [inline]
handle_page_fault arch/x86/mm/fault.c:1485 [inline]
exc_page_fault+0x271/0x740 arch/x86/mm/fault.c:1541
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:568
RIP: 0010:__put_user_nocheck_4+0x3/0x11
Code: 00 00 48 39 d9 73 54 0f 01 cb 66 89 01 31 c9 0f 01 ca c3 0f 1f 44 00 00 48 bb fd ef ff ff ff 7f 00 00 48 39 d9 73 34 0f 01 cb <89> 01 31 c9 0f 01 ca c3 66 0f 1f 44 00 00 48 bb f9 ef ff ff ff 7f
RSP: 0018:ffffc9000346feb0 EFLAGS: 00050297
RAX: 0000000000000002 RBX: 00007fffffffeffd RCX: 0000000020000000
RDX: 0000000000000001 RSI: ffffffff8a8b0f00 RDI: ffffffff8ad86000
RBP: 1ffff1100df9852f R08: dffffc0000000000 R09: fffffbfff1bc788e
R10: 0000000000000000 R11: dffffc0000000001 R12: 0000000020000000
R13: ffff88806fcc2db8 R14: ffff88806fcc2978 R15: ffff8880785c6f00
reiserfs_ioctl+0x14d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:874 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f3271faac89
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 31 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff8fc74238 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 000000000000fd76 RCX: 00007f3271faac89
RDX: 0000000020000000 RSI: 0000000080087601 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fff8fc7426c
R13: 00007fff8fc742a0 R14: 00007fff8fc74280 R15: 0000000000000029
</TASK>
----------------
Code disassembly (best guess):
0: 00 00 add %al,(%rax)
2: 48 39 d9 cmp %rbx,%rcx
5: 73 54 jae 0x5b
7: 0f 01 cb stac
a: 66 89 01 mov %ax,(%rcx)
d: 31 c9 xor %ecx,%ecx
f: 0f 01 ca clac
12: c3 retq
13: 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1)
18: 48 bb fd ef ff ff ff movabs $0x7fffffffeffd,%rbx
1f: 7f 00 00
22: 48 39 d9 cmp %rbx,%rcx
25: 73 34 jae 0x5b
27: 0f 01 cb stac
* 2a: 89 01 mov %eax,(%rcx) <-- trapping instruction
2c: 31 c9 xor %ecx,%ecx
2e: 0f 01 ca clac
31: c3 retq
32: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1)
38: 48 rex.W
39: bb f9 ef ff ff mov $0xffffeff9,%ebx
3e: ff (bad)
3f: 7f .byte 0x7f


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to change bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

syzbot

unread,
Jun 25, 2023, 6:36:07 AM6/25/23
to syzkaller...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: e84a4e368abe Linux 6.1.35
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=150db8cb280000
kernel config: https://syzkaller.appspot.com/x/.config?x=a69b5c9de715622a
dashboard link: https://syzkaller.appspot.com/bug?extid=072acd93ef3214032377
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13054c0b280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10b20f1f280000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/3c7fedd1a86d/disk-e84a4e36.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8b34c6296ed7/vmlinux-e84a4e36.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a88164798cc2/bzImage-e84a4e36.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/52cfe0eed8e0/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+072acd...@syzkaller.appspotmail.com

REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using r5 hash to sort names
REISERFS (device loop0): using 3.5.x disk format
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
======================================================
WARNING: possible circular locking dependency detected
6.1.35-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor141/3852 is trying to acquire lock:
ffffc900063de0f0 (&journal->j_mutex){+.+.}-{3:3}, at: reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
ffffc900063de0f0 (&journal->j_mutex){+.+.}-{3:3}, at: lock_journal fs/reiserfs/journal.c:534 [inline]
ffffc900063de0f0 (&journal->j_mutex){+.+.}-{3:3}, at: do_journal_begin_r+0x34e/0x1020 fs/reiserfs/journal.c:3047

but task is already holding lock:
ffff888019676558 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2973

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (sb_pagefaults){.+.+}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
__sb_start_write include/linux/fs.h:1832 [inline]
sb_start_pagefault include/linux/fs.h:1936 [inline]
filemap_page_mkwrite+0x16a/0x630 mm/filemap.c:3421
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2973
do_shared_fault mm/memory.c:4628 [inline]
do_fault mm/memory.c:4696 [inline]
handle_pte_fault mm/memory.c:4964 [inline]
__handle_mm_fault mm/memory.c:5106 [inline]
handle_mm_fault+0x22e8/0x5330 mm/memory.c:5227
do_user_addr_fault arch/x86/mm/fault.c:1428 [inline]
handle_page_fault arch/x86/mm/fault.c:1519 [inline]
exc_page_fault+0x58d/0x790 arch/x86/mm/fault.c:1575
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
__put_user_nocheck_4+0x3/0x11
reiserfs_ioctl+0x14d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #2 (&mm->mmap_lock#2){++++}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__might_fault+0xb2/0x110 mm/memory.c:5655
reiserfs_ioctl+0x11d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&sbi->lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
reiserfs_write_lock_nested+0x5b/0xd0 fs/reiserfs/lock.c:78
reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:815 [inline]
lock_journal fs/reiserfs/journal.c:534 [inline]
do_journal_begin_r+0x359/0x1020 fs/reiserfs/journal.c:3047
journal_begin+0x148/0x350 fs/reiserfs/journal.c:3255
reiserfs_fill_super+0x184f/0x2620 fs/reiserfs/super.c:2104
mount_bdev+0x2c9/0x3f0 fs/super.c:1423
legacy_get_tree+0xeb/0x180 fs/fs_context.c:610
vfs_get_tree+0x88/0x270 fs/super.c:1553
do_new_mount+0x28b/0xae0 fs/namespace.c:3040
do_mount fs/namespace.c:3383 [inline]
__do_sys_mount fs/namespace.c:3591 [inline]
__se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3568
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&journal->j_mutex){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
lock_journal fs/reiserfs/journal.c:534 [inline]
do_journal_begin_r+0x34e/0x1020 fs/reiserfs/journal.c:3047
journal_begin+0x148/0x350 fs/reiserfs/journal.c:3255
reiserfs_dirty_inode+0x11c/0x240 fs/reiserfs/super.c:710
__mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2411
generic_update_time fs/inode.c:1859 [inline]
inode_update_time fs/inode.c:1872 [inline]
__file_update_time+0x221/0x240 fs/inode.c:2060
file_update_time+0x34c/0x3c0 fs/inode.c:2091
filemap_page_mkwrite+0x275/0x630 mm/filemap.c:3422
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2973
do_shared_fault mm/memory.c:4628 [inline]
do_fault mm/memory.c:4696 [inline]
handle_pte_fault mm/memory.c:4964 [inline]
__handle_mm_fault mm/memory.c:5106 [inline]
handle_mm_fault+0x22e8/0x5330 mm/memory.c:5227
do_user_addr_fault arch/x86/mm/fault.c:1428 [inline]
handle_page_fault arch/x86/mm/fault.c:1519 [inline]
exc_page_fault+0x58d/0x790 arch/x86/mm/fault.c:1575
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
__put_user_nocheck_4+0x3/0x11
reiserfs_ioctl+0x14d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
&journal->j_mutex --> &mm->mmap_lock#2 --> sb_pagefaults

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(sb_pagefaults);
lock(&mm->mmap_lock#2);
lock(sb_pagefaults);
lock(&journal->j_mutex);

*** DEADLOCK ***

2 locks held by syz-executor141/3852:
#0: ffff8880759435d8 (&mm->mmap_lock#2){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:117 [inline]
#0: ffff8880759435d8 (&mm->mmap_lock#2){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1379 [inline]
#0: ffff8880759435d8 (&mm->mmap_lock#2){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1519 [inline]
#0: ffff8880759435d8 (&mm->mmap_lock#2){++++}-{3:3}, at: exc_page_fault+0x46a/0x790 arch/x86/mm/fault.c:1575
#1: ffff888019676558 (sb_pagefaults){.+.+}-{0:0}, at: do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2973

stack backtrace:
CPU: 1 PID: 3852 Comm: syz-executor141 Not tainted 6.1.35-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2178
check_prev_add kernel/locking/lockdep.c:3098 [inline]
check_prevs_add kernel/locking/lockdep.c:3217 [inline]
validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3832
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5669
__mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603
__mutex_lock kernel/locking/mutex.c:747 [inline]
mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799
reiserfs_mutex_lock_safe fs/reiserfs/reiserfs.h:814 [inline]
lock_journal fs/reiserfs/journal.c:534 [inline]
do_journal_begin_r+0x34e/0x1020 fs/reiserfs/journal.c:3047
journal_begin+0x148/0x350 fs/reiserfs/journal.c:3255
reiserfs_dirty_inode+0x11c/0x240 fs/reiserfs/super.c:710
__mark_inode_dirty+0x331/0xf80 fs/fs-writeback.c:2411
generic_update_time fs/inode.c:1859 [inline]
inode_update_time fs/inode.c:1872 [inline]
__file_update_time+0x221/0x240 fs/inode.c:2060
file_update_time+0x34c/0x3c0 fs/inode.c:2091
filemap_page_mkwrite+0x275/0x630 mm/filemap.c:3422
do_page_mkwrite+0x1a1/0x5f0 mm/memory.c:2973
do_shared_fault mm/memory.c:4628 [inline]
do_fault mm/memory.c:4696 [inline]
handle_pte_fault mm/memory.c:4964 [inline]
__handle_mm_fault mm/memory.c:5106 [inline]
handle_mm_fault+0x22e8/0x5330 mm/memory.c:5227
do_user_addr_fault arch/x86/mm/fault.c:1428 [inline]
handle_page_fault arch/x86/mm/fault.c:1519 [inline]
exc_page_fault+0x58d/0x790 arch/x86/mm/fault.c:1575
asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:570
RIP: 0010:__put_user_nocheck_4+0x3/0x11
Code: 00 00 48 39 d9 73 54 0f 01 cb 66 89 01 31 c9 0f 01 ca c3 0f 1f 44 00 00 48 bb fd ef ff ff ff 7f 00 00 48 39 d9 73 34 0f 01 cb <89> 01 31 c9 0f 01 ca c3 66 0f 1f 44 00 00 48 bb f9 ef ff ff ff 7f
RSP: 0018:ffffc9000632feb0 EFLAGS: 00050297
RAX: 0000000000000002 RBX: 00007fffffffeffd RCX: 0000000020000000
RDX: 0000000000000001 RSI: ffffffff8aebe320 RDI: ffffffff8b3ccb60
RBP: 1ffff1100de1de4b R08: dffffc0000000000 R09: fffffbfff1ca654e
R10: 0000000000000000 R11: dffffc0000000001 R12: 0000000020000000
R13: ffff88806f0ef698 R14: ffff88806f0ef258 R15: ffff888027298f00
reiserfs_ioctl+0x14d/0x340 fs/reiserfs/ioctl.c:96
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:870 [inline]
__se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fb8f29869d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 11 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffea26a4658 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 000000000008d44b RCX: 00007fb8f29869d9
RDX: 0000000020000000 RSI: 0000000080087601 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffea26a468c
R13: 00007ffea26a46c0 R14: 00007ffea26a46a0 R15: 0000000000000088
Reply all
Reply to author
Forward
0 new messages