possible deadlock in blkdev_put
7 views
Skip to first unread message
syzbot
Oct 1, 2020, 5:27:16 AM10/1/20
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: cbfa1702 Linux 4.14.198
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=132930cb900000
kernel config: https://syzkaller.appspot.com/x/.config?x=3990958d85b55e59
dashboard link: https://syzkaller.appspot.com/bug?extid=6348c095f6a5ccbb6500
compiler: gcc (GCC) 10.1.0-syz 20200507
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6348c0...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
4.14.198-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/23249 is trying to acquire lock:
(&bdev->bd_mutex){+.+.}, at: [<ffffffff819a48e7>] blkdev_put+0x27/0x4c0 fs/block_dev.c:1816
but task is already holding lock:
(&type->s_umount_key#84){++++}, at: [<ffffffff818db247>] deactivate_super+0x77/0xa0 fs/super.c:349
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&type->s_umount_key#84){++++}:
down_read+0x36/0x80 kernel/locking/rwsem.c:24
__get_super.part.0+0x271/0x390 fs/super.c:678
__get_super include/linux/spinlock.h:317 [inline]
get_super+0x2b/0x50 fs/super.c:707
fsync_bdev+0x14/0xc0 fs/block_dev.c:495
invalidate_partition+0x74/0xb0 block/genhd.c:1506
drop_partitions.isra.0+0x83/0x150 block/partition-generic.c:442
rescan_partitions+0xa9/0x800 block/partition-generic.c:515
__blkdev_reread_part+0x140/0x1d0 block/ioctl.c:173
blkdev_reread_part+0x23/0x40 block/ioctl.c:193
loop_reread_partitions drivers/block/loop.c:624 [inline]
loop_set_status+0xeeb/0x12b0 drivers/block/loop.c:1193
loop_set_status_old+0x18a/0x200 drivers/block/loop.c:1301
lo_ioctl+0x5ae/0x1cd0 drivers/block/loop.c:1431
__blkdev_driver_ioctl block/ioctl.c:297 [inline]
blkdev_ioctl+0x540/0x1830 block/ioctl.c:594
block_ioctl+0xd9/0x120 fs/block_dev.c:1883
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x75a/0xff0 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x7f/0xb0 fs/ioctl.c:692
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
-> #0 (&bdev->bd_mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
blkdev_put+0x27/0x4c0 fs/block_dev.c:1816
release_journal_dev fs/reiserfs/journal.c:2598 [inline]
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->s_umount_key#84);
lock(&bdev->bd_mutex);
lock(&type->s_umount_key#84);
lock(&bdev->bd_mutex);
*** DEADLOCK ***
1 lock held by syz-executor.0/23249:
#0: (&type->s_umount_key#84){++++}, at: [<ffffffff818db247>] deactivate_super+0x77/0xa0 fs/super.c:349
stack backtrace:
CPU: 1 PID: 23249 Comm: syz-executor.0 Not tainted 4.14.198-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x283 lib/dump_stack.c:58
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1905 [inline]
check_prevs_add kernel/locking/lockdep.c:2022 [inline]
validate_chain kernel/locking/lockdep.c:2464 [inline]
__lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
blkdev_put+0x27/0x4c0 fs/block_dev.c:1816
release_journal_dev fs/reiserfs/journal.c:2598 [inline]
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x4607c7
RSP: 002b:00007ffdec485188 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000004607c7
RDX: 0000000000403158 RSI: 0000000000000002 RDI: 00007ffdec485230
RBP: 0000000000000129 R08: 0000000000000000 R09: 000000000000000b
R10: 0000000000000005 R11: 0000000000000246 R12: 00007ffdec4862c0
R13: 0000000001b4ba60 R14: 0000000000000000 R15: 00007ffdec4862c0
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following issue on:
HEAD commit: cbfa1702 Linux 4.14.198
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=132930cb900000
kernel config: https://syzkaller.appspot.com/x/.config?x=3990958d85b55e59
dashboard link: https://syzkaller.appspot.com/bug?extid=6348c095f6a5ccbb6500
compiler: gcc (GCC) 10.1.0-syz 20200507
Unfortunately, I don't have any reproducer for this issue yet.
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6348c0...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
4.14.198-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.0/23249 is trying to acquire lock:
(&bdev->bd_mutex){+.+.}, at: [<ffffffff819a48e7>] blkdev_put+0x27/0x4c0 fs/block_dev.c:1816
but task is already holding lock:
(&type->s_umount_key#84){++++}, at: [<ffffffff818db247>] deactivate_super+0x77/0xa0 fs/super.c:349
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&type->s_umount_key#84){++++}:
down_read+0x36/0x80 kernel/locking/rwsem.c:24
__get_super.part.0+0x271/0x390 fs/super.c:678
__get_super include/linux/spinlock.h:317 [inline]
get_super+0x2b/0x50 fs/super.c:707
fsync_bdev+0x14/0xc0 fs/block_dev.c:495
invalidate_partition+0x74/0xb0 block/genhd.c:1506
drop_partitions.isra.0+0x83/0x150 block/partition-generic.c:442
rescan_partitions+0xa9/0x800 block/partition-generic.c:515
__blkdev_reread_part+0x140/0x1d0 block/ioctl.c:173
blkdev_reread_part+0x23/0x40 block/ioctl.c:193
loop_reread_partitions drivers/block/loop.c:624 [inline]
loop_set_status+0xeeb/0x12b0 drivers/block/loop.c:1193
loop_set_status_old+0x18a/0x200 drivers/block/loop.c:1301
lo_ioctl+0x5ae/0x1cd0 drivers/block/loop.c:1431
__blkdev_driver_ioctl block/ioctl.c:297 [inline]
blkdev_ioctl+0x540/0x1830 block/ioctl.c:594
block_ioctl+0xd9/0x120 fs/block_dev.c:1883
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x75a/0xff0 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x7f/0xb0 fs/ioctl.c:692
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
-> #0 (&bdev->bd_mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
blkdev_put+0x27/0x4c0 fs/block_dev.c:1816
release_journal_dev fs/reiserfs/journal.c:2598 [inline]
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->s_umount_key#84);
lock(&bdev->bd_mutex);
lock(&type->s_umount_key#84);
lock(&bdev->bd_mutex);
*** DEADLOCK ***
1 lock held by syz-executor.0/23249:
#0: (&type->s_umount_key#84){++++}, at: [<ffffffff818db247>] deactivate_super+0x77/0xa0 fs/super.c:349
stack backtrace:
CPU: 1 PID: 23249 Comm: syz-executor.0 Not tainted 4.14.198-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x283 lib/dump_stack.c:58
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1905 [inline]
check_prevs_add kernel/locking/lockdep.c:2022 [inline]
validate_chain kernel/locking/lockdep.c:2464 [inline]
__lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
blkdev_put+0x27/0x4c0 fs/block_dev.c:1816
release_journal_dev fs/reiserfs/journal.c:2598 [inline]
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x4607c7
RSP: 002b:00007ffdec485188 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000004607c7
RDX: 0000000000403158 RSI: 0000000000000002 RDI: 00007ffdec485230
RBP: 0000000000000129 R08: 0000000000000000 R09: 000000000000000b
R10: 0000000000000005 R11: 0000000000000246 R12: 00007ffdec4862c0
R13: 0000000001b4ba60 R14: 0000000000000000 R15: 00007ffdec4862c0
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Oct 27, 2020, 8:42:24 AM10/27/20
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: 5b7a52cd Linux 4.14.202
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=152fdf3c500000
kernel config: https://syzkaller.appspot.com/x/.config?x=fa386e02ca459165
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de4128500000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6348c0...@syzkaller.appspotmail.com
loop0: partition table beyond EOD, truncated
REISERFS (device loop4): using 3.5.x disk format
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop1): Using r5 hash to sort names
------------------------------------------------------
syz-executor942/7993 is trying to acquire lock:
(&bdev->bd_mutex){+.+.}, at: [<ffffffff819615f7>] blkdev_put+0x27/0x4c0 fs/block_dev.c:1826
but task is already holding lock:
(&type->s_umount_key#46){++++}, at: [<ffffffff81897ea7>] deactivate_super+0x77/0xa0 fs/super.c:349
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&type->s_umount_key#46){++++}:
lock(&bdev->bd_mutex);
lock(&type->s_umount_key#46);
#0: (&type->s_umount_key#46){++++}, at: [<ffffffff81897ea7>] deactivate_super+0x77/0xa0 fs/super.c:349
stack backtrace:
CPU: 0 PID: 7993 Comm: syz-executor942 Not tainted 4.14.202-syzkaller #0
RSP: 002b:00007ffe5f4ce478 EFLAGS: 00000202 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 000000000000b05d RCX: 000000000044dfd7
RDX: 0000000000400d57 RSI: 0000000000000002 RDI: 00007ffe5f4ce520
RBP: 0000000000001f3b R08: 0000000000000000 R09: 0000000000000009
R10: 0000000000000005 R11: 0000000000000202 R12: 00007ffe5f4cf5c0
R13: 00000000018aa880 R14: 0000000000000000 R15: 0000000000000000
REISERFS (device loop1): using 3.5.x disk format
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS (device loop5): Using r5 hash to sort names
REISERFS (device loop5): using 3.5.x disk format
REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): using 3.5.x disk format
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): using 3.5.x disk format
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS warning (device loop0): sh-2021 reiserfs_fill_super: can not find reiserfs on loop0
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
loop_reread_partitions: partition scan of loop0 (�J�pf��QT�)�[q�Z�;(�q� ��-My� ) failed (rc=-5)
REISERFS (device loop1): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop1): using ordered data mode
reiserfs: using flush barriers
REISERFS warning (device loop4): reiserfs_fill_super: Cannot allocate commit workqueue
REISERFS (device loop1): journal params: device loop1, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop1): checking transaction log (loop1)
REISERFS (device loop3): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop5): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop3): using ordered data mode
REISERFS (device loop5): using ordered data mode
REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal
reiserfs: using flush barriers
REISERFS (device loop2): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop5): journal params: device loop5, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
reiserfs: using flush barriers
REISERFS (device loop3): journal params: device loop3, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop5): checking transaction log (loop5)
REISERFS (device loop2): journal params: device loop2, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
REISERFS (device loop4): checking transaction log (loop4)
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
REISERFS (device loop1): Using r5 hash to sort names
loop0: partition table beyond EOD, truncated
REISERFS (device loop1): using 3.5.x disk format
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): using 3.5.x disk format
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): using 3.5.x disk format
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop5): Using r5 hash to sort names
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop5): using 3.5.x disk format
REISERFS (device loop4): using 3.5.x disk format
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS (device loop0): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS warning (device loop0): sh-460 journal_init: journal header magic 49a51c6e (device loop0) does not match to magic found in super block 49ad1c61
REISERFS (device loop1): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop1): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop1): journal params: device loop1, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop1): checking transaction log (loop1)
REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop2): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop5): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop2): journal params: device loop2, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop3): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop5): using ordered data mode
REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal
reiserfs: using flush barriers
REISERFS (device loop4): using ordered data mode
REISERFS (device loop5): journal params: device loop5, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
reiserfs: using flush barriers
REISERFS (device loop3): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop3): journal params: device loop3, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop5): checking transaction log (loop5)
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop5): Using r5 hash to sort names
REISERFS (device loop5): using 3.5.x disk format
REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop1): Using r5 hash to sort names
REISERFS (device loop1): using 3.5.x disk format
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): using 3.5.x disk format
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): using 3.5.x disk format
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): using 3.5.x disk format
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
HEAD commit: 5b7a52cd Linux 4.14.202
git tree: linux-4.14.y
console output: https://syzkaller.appspot.com/x/log.txt?x=152fdf3c500000
kernel config: https://syzkaller.appspot.com/x/.config?x=fa386e02ca459165
dashboard link: https://syzkaller.appspot.com/bug?extid=6348c095f6a5ccbb6500
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1038eff7900000
compiler: gcc (GCC) 10.1.0-syz 20200507
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14de4128500000
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6348c0...@syzkaller.appspotmail.com
REISERFS (device loop4): using 3.5.x disk format
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop1): Using r5 hash to sort names
======================================================
WARNING: possible circular locking dependency detected
4.14.202-syzkaller #0 Not tainted
WARNING: possible circular locking dependency detected
------------------------------------------------------
syz-executor942/7993 is trying to acquire lock:
(&bdev->bd_mutex){+.+.}, at: [<ffffffff819615f7>] blkdev_put+0x27/0x4c0 fs/block_dev.c:1826
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
down_read+0x36/0x80 kernel/locking/rwsem.c:24
__get_super.part.0+0x271/0x390 fs/super.c:678
__get_super include/linux/spinlock.h:317 [inline]
get_super+0x2b/0x50 fs/super.c:707
fsync_bdev+0x14/0xc0 fs/block_dev.c:495
invalidate_partition+0x74/0xb0 block/genhd.c:1506
drop_partitions.isra.0+0x83/0x150 block/partition-generic.c:442
rescan_partitions+0xa9/0x800 block/partition-generic.c:515
__blkdev_reread_part+0x140/0x1d0 block/ioctl.c:173
blkdev_reread_part+0x23/0x40 block/ioctl.c:193
loop_reread_partitions drivers/block/loop.c:624 [inline]
loop_set_status+0xeeb/0x12b0 drivers/block/loop.c:1193
loop_set_status_old+0x18a/0x200 drivers/block/loop.c:1301
lo_ioctl+0x5ae/0x1cd0 drivers/block/loop.c:1431
__blkdev_driver_ioctl block/ioctl.c:297 [inline]
blkdev_ioctl+0x540/0x1830 block/ioctl.c:594
block_ioctl+0xd9/0x120 fs/block_dev.c:1893
__get_super.part.0+0x271/0x390 fs/super.c:678
__get_super include/linux/spinlock.h:317 [inline]
get_super+0x2b/0x50 fs/super.c:707
fsync_bdev+0x14/0xc0 fs/block_dev.c:495
invalidate_partition+0x74/0xb0 block/genhd.c:1506
drop_partitions.isra.0+0x83/0x150 block/partition-generic.c:442
rescan_partitions+0xa9/0x800 block/partition-generic.c:515
__blkdev_reread_part+0x140/0x1d0 block/ioctl.c:173
blkdev_reread_part+0x23/0x40 block/ioctl.c:193
loop_reread_partitions drivers/block/loop.c:624 [inline]
loop_set_status+0xeeb/0x12b0 drivers/block/loop.c:1193
loop_set_status_old+0x18a/0x200 drivers/block/loop.c:1301
lo_ioctl+0x5ae/0x1cd0 drivers/block/loop.c:1431
__blkdev_driver_ioctl block/ioctl.c:297 [inline]
blkdev_ioctl+0x540/0x1830 block/ioctl.c:594
vfs_ioctl fs/ioctl.c:46 [inline]
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x75a/0xff0 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x7f/0xb0 fs/ioctl.c:692
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
-> #0 (&bdev->bd_mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
blkdev_put+0x27/0x4c0 fs/block_dev.c:1826
file_ioctl fs/ioctl.c:500 [inline]
do_vfs_ioctl+0x75a/0xff0 fs/ioctl.c:684
SYSC_ioctl fs/ioctl.c:701 [inline]
SyS_ioctl+0x7f/0xb0 fs/ioctl.c:692
do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
entry_SYSCALL_64_after_hwframe+0x46/0xbb
-> #0 (&bdev->bd_mutex){+.+.}:
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
release_journal_dev fs/reiserfs/journal.c:2598 [inline]
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&type->s_umount_key#46);
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&bdev->bd_mutex);
lock(&type->s_umount_key#46);
lock(&bdev->bd_mutex);
*** DEADLOCK ***
1 lock held by syz-executor942/7993:
*** DEADLOCK ***
#0: (&type->s_umount_key#46){++++}, at: [<ffffffff81897ea7>] deactivate_super+0x77/0xa0 fs/super.c:349
stack backtrace:
CPU: 0 PID: 7993 Comm: syz-executor942 Not tainted 4.14.202-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x283 lib/dump_stack.c:58
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1905 [inline]
check_prevs_add kernel/locking/lockdep.c:2022 [inline]
validate_chain kernel/locking/lockdep.c:2464 [inline]
__lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
blkdev_put+0x27/0x4c0 fs/block_dev.c:1826
Call Trace:
__dump_stack lib/dump_stack.c:17 [inline]
dump_stack+0x1b2/0x283 lib/dump_stack.c:58
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
check_prev_add kernel/locking/lockdep.c:1905 [inline]
check_prevs_add kernel/locking/lockdep.c:2022 [inline]
validate_chain kernel/locking/lockdep.c:2464 [inline]
__lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
__mutex_lock_common kernel/locking/mutex.c:756 [inline]
__mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
release_journal_dev fs/reiserfs/journal.c:2598 [inline]
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x44dfd7
free_journal_ram+0x41a/0x5c0 fs/reiserfs/journal.c:1903
do_journal_release fs/reiserfs/journal.c:1969 [inline]
journal_release+0x1cf/0x450 fs/reiserfs/journal.c:1980
reiserfs_put_super+0xbb/0x560 fs/reiserfs/super.c:616
generic_shutdown_super+0x144/0x370 fs/super.c:446
kill_block_super+0x95/0xe0 fs/super.c:1161
deactivate_locked_super+0x6c/0xd0 fs/super.c:319
deactivate_super+0x7f/0xa0 fs/super.c:350
cleanup_mnt+0x186/0x2c0 fs/namespace.c:1183
task_work_run+0x11f/0x190 kernel/task_work.c:113
tracehook_notify_resume include/linux/tracehook.h:191 [inline]
exit_to_usermode_loop+0x1ad/0x200 arch/x86/entry/common.c:164
prepare_exit_to_usermode arch/x86/entry/common.c:199 [inline]
syscall_return_slowpath arch/x86/entry/common.c:270 [inline]
do_syscall_64+0x4a3/0x640 arch/x86/entry/common.c:297
entry_SYSCALL_64_after_hwframe+0x46/0xbb
RSP: 002b:00007ffe5f4ce478 EFLAGS: 00000202 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 000000000000b05d RCX: 000000000044dfd7
RDX: 0000000000400d57 RSI: 0000000000000002 RDI: 00007ffe5f4ce520
RBP: 0000000000001f3b R08: 0000000000000000 R09: 0000000000000009
R10: 0000000000000005 R11: 0000000000000202 R12: 00007ffe5f4cf5c0
R13: 00000000018aa880 R14: 0000000000000000 R15: 0000000000000000
REISERFS (device loop1): using 3.5.x disk format
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS (device loop5): Using r5 hash to sort names
REISERFS (device loop5): using 3.5.x disk format
REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): using 3.5.x disk format
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): using 3.5.x disk format
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS warning (device loop0): sh-2021 reiserfs_fill_super: can not find reiserfs on loop0
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
loop_reread_partitions: partition scan of loop0 (�J�pf��QT�)�[q�Z�;(�q� ��-My� ) failed (rc=-5)
REISERFS (device loop1): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop1): using ordered data mode
reiserfs: using flush barriers
REISERFS warning (device loop4): reiserfs_fill_super: Cannot allocate commit workqueue
REISERFS (device loop1): journal params: device loop1, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop1): checking transaction log (loop1)
REISERFS (device loop3): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop5): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop3): using ordered data mode
REISERFS (device loop5): using ordered data mode
REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal
reiserfs: using flush barriers
REISERFS (device loop2): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop5): journal params: device loop5, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
reiserfs: using flush barriers
REISERFS (device loop3): journal params: device loop3, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop5): checking transaction log (loop5)
REISERFS (device loop2): journal params: device loop2, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
REISERFS (device loop4): checking transaction log (loop4)
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
REISERFS (device loop1): Using r5 hash to sort names
loop0: partition table beyond EOD, truncated
REISERFS (device loop1): using 3.5.x disk format
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop3): using 3.5.x disk format
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): using 3.5.x disk format
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop5): Using r5 hash to sort names
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop5): using 3.5.x disk format
REISERFS (device loop4): using 3.5.x disk format
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage.
Dev loop0: unable to read partition block 735977472
loop0: RDSK (-336099328) unable to read partition table
loop0: partition table beyond EOD, truncated
REISERFS (device loop0): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS warning (device loop0): sh-460 journal_init: journal header magic 49a51c6e (device loop0) does not match to magic found in super block 49ad1c61
REISERFS (device loop1): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop1): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop1): journal params: device loop1, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop1): checking transaction log (loop1)
REISERFS (device loop2): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop2): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop5): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop2): journal params: device loop2, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop3): found reiserfs format "3.5" with non-standard journal
REISERFS (device loop2): checking transaction log (loop2)
REISERFS (device loop5): using ordered data mode
REISERFS (device loop4): found reiserfs format "3.5" with non-standard journal
reiserfs: using flush barriers
REISERFS (device loop4): using ordered data mode
REISERFS (device loop5): journal params: device loop5, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
reiserfs: using flush barriers
REISERFS (device loop3): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop3): journal params: device loop3, size 8192, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop5): checking transaction log (loop5)
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop3): checking transaction log (loop3)
REISERFS (device loop5): Using r5 hash to sort names
REISERFS (device loop5): using 3.5.x disk format
REISERFS (device loop5): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop1): Using r5 hash to sort names
REISERFS (device loop1): using 3.5.x disk format
REISERFS (device loop1): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop2): Using r5 hash to sort names
REISERFS (device loop2): using 3.5.x disk format
REISERFS (device loop3): Using r5 hash to sort names
REISERFS (device loop2): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop3): using 3.5.x disk format
REISERFS (device loop3): Created .reiserfs_priv - reserved for xattr storage.
REISERFS (device loop4): Using r5 hash to sort names
REISERFS (device loop4): using 3.5.x disk format
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
Reply all
Reply to author
Forward
0 new messages