possible deadlock in hfsplus_file_truncate
6 views
Skip to first unread message
syzbot
Nov 27, 2022, 4:20:46 AM11/27/22
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=14fad173880000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=6d9b7e8f97ee638f0d63
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6d9b7e...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/13375 is trying to acquire lock:
00000000a2f77ae7 (&tree->tree_lock#2){+.+.}, at: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
but task is already holding lock:
0000000023825ae9 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357
hfsplus_create_cat+0x1e3/0x1210 fs/hfsplus/catalog.c:272
hfsplus_fill_super+0x14a8/0x19e0 fs/hfsplus/super.c:560
mount_bdev+0x2fc/0x3b0 fs/super.c:1158
mount_fs+0xa3/0x310 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2492 [inline]
do_mount+0x115c/0x2f50 fs/namespace.c:2822
ksys_mount+0xcf/0x130 fs/namespace.c:3038
__do_sys_mount fs/namespace.c:3052 [inline]
__se_sys_mount fs/namespace.c:3049 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3049
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
-> #0 (&tree->tree_lock#2){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__do_sys_renameat2 fs/namei.c:4664 [inline]
__se_sys_renameat2 fs/namei.c:4661 [inline]
__x64_sys_renameat2+0xba/0x150 fs/namei.c:4661
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock#2);
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock#2);
*** DEADLOCK ***
8 locks held by syz-executor.5/13375:
#0: 00000000c2e6ac46 (sb_writers#30){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
#0: 00000000c2e6ac46 (sb_writers#30){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360
#1: 00000000636379a8 (&type->s_vfs_rename_key#3){+.+.}, at: lock_rename+0x54/0x280 fs/namei.c:2867
#2: 000000003887a542 (&type->i_mutex_dir_key#17/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#2: 000000003887a542 (&type->i_mutex_dir_key#17/1){+.+.}, at: lock_rename+0x132/0x280 fs/namei.c:2878
#3: 00000000987d4983 (&type->i_mutex_dir_key#17/2){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#3: 00000000987d4983 (&type->i_mutex_dir_key#17/2){+.+.}, at: lock_rename+0x166/0x280 fs/namei.c:2879
#4: 00000000c3b80c1f (&sb->s_type->i_mutex_key#35){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#4: 00000000c3b80c1f (&sb->s_type->i_mutex_key#35){+.+.}, at: lock_two_nondirectories+0xec/0x110 fs/inode.c:1015
#5: 0000000036e10ca4 (&sb->s_type->i_mutex_key#35/4){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#5: 0000000036e10ca4 (&sb->s_type->i_mutex_key#35/4){+.+.}, at: lock_two_nondirectories+0xd1/0x110 fs/inode.c:1017
#6: 00000000d4ef0119 (&sbi->vh_mutex){+.+.}, at: hfsplus_unlink+0x140/0x820 fs/hfsplus/dir.c:370
#7: 0000000023825ae9 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
stack backtrace:
CPU: 1 PID: 13375 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
check_prev_add kernel/locking/lockdep.c:1866 [inline]
check_prevs_add kernel/locking/lockdep.c:1979 [inline]
validate_chain kernel/locking/lockdep.c:2420 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__do_sys_renameat2 fs/namei.c:4664 [inline]
__se_sys_renameat2 fs/namei.c:4661 [inline]
__x64_sys_renameat2+0xba/0x150 fs/namei.c:4661
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f76e43510d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f76e28c3168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007f76e4470f80 RCX: 00007f76e43510d9
RDX: 0000000000000006 RSI: 0000000020000000 RDI: 0000000000000007
RBP: 00007f76e43acae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020000080 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd085e037f R14: 00007f76e28c3300 R15: 0000000000022000
netlink: 104 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 104 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 104 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 304 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 96 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 324 bytes leftover after parsing attributes in process `syz-executor.3'.
hfsplus: unable to parse mount options
netlink: 280 bytes leftover after parsing attributes in process `syz-executor.3'.
hfsplus: unable to parse mount options
nla_parse: 1 callbacks suppressed
netlink: 304 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 96 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 324 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 280 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 328 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 304 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 96 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 324 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 280 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 328 bytes leftover after parsing attributes in process `syz-executor.0'.
wlan1: No active IBSS STAs - trying to scan for other IBSS networks with same SSID (merge)
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot found the following issue on:
HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=14fad173880000
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=6d9b7e8f97ee638f0d63
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6d9b7e...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.5/13375 is trying to acquire lock:
00000000a2f77ae7 (&tree->tree_lock#2){+.+.}, at: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
but task is already holding lock:
0000000023825ae9 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357
hfsplus_create_cat+0x1e3/0x1210 fs/hfsplus/catalog.c:272
hfsplus_fill_super+0x14a8/0x19e0 fs/hfsplus/super.c:560
mount_bdev+0x2fc/0x3b0 fs/super.c:1158
mount_fs+0xa3/0x310 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2492 [inline]
do_mount+0x115c/0x2f50 fs/namespace.c:2822
ksys_mount+0xcf/0x130 fs/namespace.c:3038
__do_sys_mount fs/namespace.c:3052 [inline]
__se_sys_mount fs/namespace.c:3049 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3049
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
-> #0 (&tree->tree_lock#2){+.+.}:
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__do_sys_renameat2 fs/namei.c:4664 [inline]
__se_sys_renameat2 fs/namei.c:4661 [inline]
__x64_sys_renameat2+0xba/0x150 fs/namei.c:4661
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock#2);
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock#2);
*** DEADLOCK ***
8 locks held by syz-executor.5/13375:
#0: 00000000c2e6ac46 (sb_writers#30){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
#0: 00000000c2e6ac46 (sb_writers#30){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360
#1: 00000000636379a8 (&type->s_vfs_rename_key#3){+.+.}, at: lock_rename+0x54/0x280 fs/namei.c:2867
#2: 000000003887a542 (&type->i_mutex_dir_key#17/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#2: 000000003887a542 (&type->i_mutex_dir_key#17/1){+.+.}, at: lock_rename+0x132/0x280 fs/namei.c:2878
#3: 00000000987d4983 (&type->i_mutex_dir_key#17/2){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#3: 00000000987d4983 (&type->i_mutex_dir_key#17/2){+.+.}, at: lock_rename+0x166/0x280 fs/namei.c:2879
#4: 00000000c3b80c1f (&sb->s_type->i_mutex_key#35){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#4: 00000000c3b80c1f (&sb->s_type->i_mutex_key#35){+.+.}, at: lock_two_nondirectories+0xec/0x110 fs/inode.c:1015
#5: 0000000036e10ca4 (&sb->s_type->i_mutex_key#35/4){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#5: 0000000036e10ca4 (&sb->s_type->i_mutex_key#35/4){+.+.}, at: lock_two_nondirectories+0xd1/0x110 fs/inode.c:1017
#6: 00000000d4ef0119 (&sbi->vh_mutex){+.+.}, at: hfsplus_unlink+0x140/0x820 fs/hfsplus/dir.c:370
#7: 0000000023825ae9 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
stack backtrace:
CPU: 1 PID: 13375 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
check_prev_add kernel/locking/lockdep.c:1866 [inline]
check_prevs_add kernel/locking/lockdep.c:1979 [inline]
validate_chain kernel/locking/lockdep.c:2420 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__do_sys_renameat2 fs/namei.c:4664 [inline]
__se_sys_renameat2 fs/namei.c:4661 [inline]
__x64_sys_renameat2+0xba/0x150 fs/namei.c:4661
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f76e43510d9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f76e28c3168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 00007f76e4470f80 RCX: 00007f76e43510d9
RDX: 0000000000000006 RSI: 0000000020000000 RDI: 0000000000000007
RBP: 00007f76e43acae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000020000080 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd085e037f R14: 00007f76e28c3300 R15: 0000000000022000
netlink: 104 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 104 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 104 bytes leftover after parsing attributes in process `syz-executor.1'.
netlink: 304 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 96 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 324 bytes leftover after parsing attributes in process `syz-executor.3'.
hfsplus: unable to parse mount options
netlink: 280 bytes leftover after parsing attributes in process `syz-executor.3'.
hfsplus: unable to parse mount options
nla_parse: 1 callbacks suppressed
netlink: 304 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 96 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 324 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 280 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 328 bytes leftover after parsing attributes in process `syz-executor.2'.
netlink: 304 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 96 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 324 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 280 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 328 bytes leftover after parsing attributes in process `syz-executor.0'.
wlan1: No active IBSS STAs - trying to scan for other IBSS networks with same SSID (merge)
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot
Dec 8, 2022, 7:51:35 AM12/8/22
to syzkaller...@googlegroups.com
syzbot has found a reproducer for the following issue on:
HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=12855fc3880000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11aa627d880000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/113bac9a39ba/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/556288a133b7/mount_2.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6d9b7e...@syzkaller.appspotmail.com
hfsplus: failed to load root directory
000000003bd561fa (&tree->tree_lock){+.+.}, at: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
but task is already holding lock:
00000000f2354500 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260
block_read_full_page+0x288/0xd10 fs/buffer.c:2259
do_read_cache_page+0x533/0x1170 mm/filemap.c:2828
read_mapping_page include/linux/pagemap.h:402 [inline]
__hfs_bnode_create+0x5b7/0xb60 fs/hfsplus/bnode.c:447
hfsplus_bnode_find+0x2aa/0xb80 fs/hfsplus/bnode.c:497
hfsplus_brec_find+0x2af/0x500 fs/hfsplus/bfind.c:183
hfsplus_brec_read+0x28/0x120 fs/hfsplus/bfind.c:222
hfsplus_find_cat+0x1d0/0x480 fs/hfsplus/catalog.c:202
hfsplus_iget+0x400/0x790 fs/hfsplus/super.c:81
hfsplus_fill_super+0xc5f/0x19e0 fs/hfsplus/super.c:503
__se_sys_rename fs/namei.c:4673 [inline]
__x64_sys_rename+0x5d/0x80 fs/namei.c:4673
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock);
*** DEADLOCK ***
6 locks held by syz-executor374/8127:
#0: 00000000414d9562 (sb_writers#11){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
#0: 00000000414d9562 (sb_writers#11){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360
#1: 000000002107836a (&type->i_mutex_dir_key#7/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#1: 000000002107836a (&type->i_mutex_dir_key#7/1){+.+.}, at: lock_rename+0x225/0x280 fs/namei.c:2863
#2: 000000008137c92f (&sb->s_type->i_mutex_key#17){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#2: 000000008137c92f (&sb->s_type->i_mutex_key#17){+.+.}, at: lock_two_nondirectories+0xec/0x110 fs/inode.c:1015
#3: 000000006fc6dafd (&sb->s_type->i_mutex_key#17/4){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#3: 000000006fc6dafd (&sb->s_type->i_mutex_key#17/4){+.+.}, at: lock_two_nondirectories+0xd1/0x110 fs/inode.c:1017
#4: 00000000d1f5b90d (&sbi->vh_mutex){+.+.}, at: hfsplus_unlink+0x140/0x820 fs/hfsplus/dir.c:370
#5: 00000000f2354500 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
stack backtrace:
CPU: 1 PID: 8127 Comm: syz-executor374 Not tainted 4.19.211-syzkaller #0
__se_sys_rename fs/namei.c:4673 [inline]
__x64_sys_rename+0x5d/0x80 fs/namei.c:4673
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f852dc37e19
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f852dbc21f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f852dcbc798 RCX: 00007f852dc37e19
RDX: 00007f852dc37e19 RSI: 00000000200001c0 RDI: 0000000020000180
RBP: 00007f852dcbc790 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000000005fb R11: 0000000000000246 R12: 00007f852dcbc79c
R13: 00007ffebd99a3cf R14: 00007f852dbc2300 R15: 0000000000022000
HEAD commit: 3f8a27f9e27b Linux 4.19.211
git tree: linux-4.19.y
kernel config: https://syzkaller.appspot.com/x/.config?x=9b9277b418617afe
dashboard link: https://syzkaller.appspot.com/bug?extid=6d9b7e8f97ee638f0d63
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1496f2fb880000
dashboard link: https://syzkaller.appspot.com/bug?extid=6d9b7e8f97ee638f0d63
compiler: gcc version 10.2.1 20210110 (Debian 10.2.1-6)
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11aa627d880000
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/98c0bdb4abb3/disk-3f8a27f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ea228ff02669/vmlinux-3f8a27f9.xz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/556288a133b7/mount_2.gz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6d9b7e...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor374/8127 is trying to acquire lock:
WARNING: possible circular locking dependency detected
4.19.211-syzkaller #0 Not tainted
------------------------------------------------------
000000003bd561fa (&tree->tree_lock){+.+.}, at: hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
but task is already holding lock:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}:
block_read_full_page+0x288/0xd10 fs/buffer.c:2259
do_read_cache_page+0x533/0x1170 mm/filemap.c:2828
read_mapping_page include/linux/pagemap.h:402 [inline]
__hfs_bnode_create+0x5b7/0xb60 fs/hfsplus/bnode.c:447
hfsplus_bnode_find+0x2aa/0xb80 fs/hfsplus/bnode.c:497
hfsplus_brec_find+0x2af/0x500 fs/hfsplus/bfind.c:183
hfsplus_brec_read+0x28/0x120 fs/hfsplus/bfind.c:222
hfsplus_find_cat+0x1d0/0x480 fs/hfsplus/catalog.c:202
hfsplus_iget+0x400/0x790 fs/hfsplus/super.c:81
hfsplus_fill_super+0xc5f/0x19e0 fs/hfsplus/super.c:503
mount_bdev+0x2fc/0x3b0 fs/super.c:1158
mount_fs+0xa3/0x310 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2492 [inline]
do_mount+0x115c/0x2f50 fs/namespace.c:2822
ksys_mount+0xcf/0x130 fs/namespace.c:3038
__do_sys_mount fs/namespace.c:3052 [inline]
__se_sys_mount fs/namespace.c:3049 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3049
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
-> #0 (&tree->tree_lock){+.+.}:
mount_fs+0xa3/0x310 fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2492 [inline]
do_mount+0x115c/0x2f50 fs/namespace.c:2822
ksys_mount+0xcf/0x130 fs/namespace.c:3038
__do_sys_mount fs/namespace.c:3052 [inline]
__se_sys_mount fs/namespace.c:3049 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3049
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__do_sys_rename fs/namei.c:4675 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__se_sys_rename fs/namei.c:4673 [inline]
__x64_sys_rename+0x5d/0x80 fs/namei.c:4673
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock);
entry_SYSCALL_64_after_hwframe+0x49/0xbe
other info that might help us debug this:
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&HFSPLUS_I(inode)->extents_lock);
lock(&tree->tree_lock);
*** DEADLOCK ***
6 locks held by syz-executor374/8127:
#0: 00000000414d9562 (sb_writers#11){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
#0: 00000000414d9562 (sb_writers#11){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360
#1: 000000002107836a (&type->i_mutex_dir_key#7/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#1: 000000002107836a (&type->i_mutex_dir_key#7/1){+.+.}, at: lock_rename+0x225/0x280 fs/namei.c:2863
#2: 000000008137c92f (&sb->s_type->i_mutex_key#17){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
#2: 000000008137c92f (&sb->s_type->i_mutex_key#17){+.+.}, at: lock_two_nondirectories+0xec/0x110 fs/inode.c:1015
#3: 000000006fc6dafd (&sb->s_type->i_mutex_key#17/4){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline]
#3: 000000006fc6dafd (&sb->s_type->i_mutex_key#17/4){+.+.}, at: lock_two_nondirectories+0xd1/0x110 fs/inode.c:1017
#4: 00000000d1f5b90d (&sbi->vh_mutex){+.+.}, at: hfsplus_unlink+0x140/0x820 fs/hfsplus/dir.c:370
#5: 00000000f2354500 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576
stack backtrace:
CPU: 1 PID: 8127 Comm: syz-executor374 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
check_prev_add kernel/locking/lockdep.c:1866 [inline]
check_prevs_add kernel/locking/lockdep.c:1979 [inline]
validate_chain kernel/locking/lockdep.c:2420 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__do_sys_rename fs/namei.c:4675 [inline]
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
check_prev_add kernel/locking/lockdep.c:1866 [inline]
check_prevs_add kernel/locking/lockdep.c:1979 [inline]
validate_chain kernel/locking/lockdep.c:2420 [inline]
__lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
__mutex_lock_common kernel/locking/mutex.c:937 [inline]
__mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
hfsplus_file_truncate+0xde7/0x1040 fs/hfsplus/extents.c:595
hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419
hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405
hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545
vfs_rename+0x67e/0x1bc0 fs/namei.c:4479
do_renameat2+0xb59/0xc70 fs/namei.c:4629
__se_sys_rename fs/namei.c:4673 [inline]
__x64_sys_rename+0x5d/0x80 fs/namei.c:4673
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f852dc37e19
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f852dbc21f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f852dcbc798 RCX: 00007f852dc37e19
RDX: 00007f852dc37e19 RSI: 00000000200001c0 RDI: 0000000020000180
RBP: 00007f852dcbc790 R08: 0000000000000000 R09: 0000000000000000
R10: 00000000000005fb R11: 0000000000000246 R12: 00007f852dcbc79c
R13: 00007ffebd99a3cf R14: 00007f852dbc2300 R15: 0000000000022000
Reply all
Reply to author
Forward
0 new messages