[v6.1] possible deadlock in sco_sock_timeout (2)
0 views
Skip to first unread message
syzbot
Apr 6, 2024, 10:01:27 PMApr 6
to syzkaller...@googlegroups.com
Hello,
syzbot found the following issue on:
HEAD commit: 347385861c50 Linux 6.1.84
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16efc39d180000
kernel config: https://syzkaller.appspot.com/x/.config?x=40dfd13b04bfc094
dashboard link: https://syzkaller.appspot.com/bug?extid=43013a84c1d2e6b30c48
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/73d2a8622b6e/disk-34738586.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e7bc2e0101a7/vmlinux-34738586.xz
kernel image: https://storage.googleapis.com/syzbot-assets/7b96d1168608/bzImage-34738586.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+43013a...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.84-syzkaller #0 Not tainted
------------------------------------------------------
kworker/0:11/3795 is trying to acquire lock:
ffff8880567ed130 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1745 [inline]
ffff8880567ed130 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:97
but task is already holding lock:
ffffc900057cfd20 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}, at: process_one_work+0x7a9/0x11d0 kernel/workqueue.c:2267
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__flush_work+0xfe/0xad0 kernel/workqueue.c:3072
__cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3163
sco_conn_del+0x205/0x300 net/bluetooth/sco.c:205
hci_disconn_cfm include/net/bluetooth/hci_core.h:1808 [inline]
hci_conn_hash_flush+0x10e/0x2a0 net/bluetooth/hci_conn.c:2441
hci_dev_close_sync+0x9a9/0x1020 net/bluetooth/hci_sync.c:5015
hci_dev_do_close net/bluetooth/hci_core.c:554 [inline]
hci_error_reset+0x12c/0x3c0 net/bluetooth/hci_core.c:1060
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
-> #2 (hci_cb_list_lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
hci_connect_cfm include/net/bluetooth/hci_core.h:1790 [inline]
hci_remote_features_evt+0x664/0xab0 net/bluetooth/hci_event.c:3778
hci_event_func net/bluetooth/hci_event.c:7514 [inline]
hci_event_packet+0xa9d/0x1510 net/bluetooth/hci_event.c:7566
hci_rx_work+0x3cd/0xce0 net/bluetooth/hci_core.c:4130
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
-> #1 (&hdev->lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
sco_sock_connect+0x181/0x8f0 net/bluetooth/sco.c:593
__sys_connect_file net/socket.c:2006 [inline]
__sys_connect+0x2c9/0x300 net/socket.c:2023
__do_sys_connect net/socket.c:2033 [inline]
__se_sys_connect net/socket.c:2030 [inline]
__x64_sys_connect+0x76/0x80 net/socket.c:2030
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
lock_sock_nested+0x44/0x100 net/core/sock.c:3484
lock_sock include/net/sock.h:1745 [inline]
sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:97
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
other info that might help us debug this:
Chain exists of:
sk_lock-AF_BLUETOOTH-BTPROTO_SCO --> hci_cb_list_lock --> (work_completion)(&(&conn->timeout_work)->work)
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock((work_completion)(&(&conn->timeout_work)->work));
lock(hci_cb_list_lock);
lock((work_completion)(&(&conn->timeout_work)->work));
lock(sk_lock-AF_BLUETOOTH-BTPROTO_SCO);
*** DEADLOCK ***
2 locks held by kworker/0:11/3795:
#0: ffff888012470938 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x7a9/0x11d0 kernel/workqueue.c:2267
#1: ffffc900057cfd20 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}, at: process_one_work+0x7a9/0x11d0 kernel/workqueue.c:2267
stack backtrace:
CPU: 0 PID: 3795 Comm: kworker/0:11 Not tainted 6.1.84-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Workqueue: events sco_sock_timeout
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
lock_sock_nested+0x44/0x100 net/core/sock.c:3484
lock_sock include/net/sock.h:1745 [inline]
sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:97
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
</TASK>
IPv6: ADDRCONF(NETDEV_CHANGE): vxcan1: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): vxcan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth1_vlan: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth0_vlan: link becomes ready
usb 2-1: new high-speed USB device number 11 using dummy_hcd
usb 2-1: Using ep0 maxpacket: 16
usb 2-1: config 0 has an invalid descriptor of length 0, skipping remainder of the config
usb 2-1: config 0 interface 0 altsetting 0 endpoint 0x82 has an invalid bInterval 0, changing to 7
usb 2-1: config 0 interface 0 altsetting 0 endpoint 0x2 has invalid wMaxPacketSize 0
usb 2-1: config 0 interface 0 altsetting 0 bulk endpoint 0x2 has invalid maxpacket 0
usb 2-1: config 0 interface 0 altsetting 0 has 2 endpoint descriptors, different from the interface descriptor's value: 3
usb 2-1: New USB device found, idVendor=2040, idProduct=b138, bcdDevice= 1.42
usb 2-1: New USB device strings: Mfr=4, Product=0, SerialNumber=0
usb 2-1: Manufacturer: syz
usb 2-1: config 0 descriptor??
rc_core: IR keymap rc-hauppauge not found
Registered IR keymap rc-empty
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
rc rc0: Conexant Hybrid TV (cx231xx) MCE IR no TX (2040:b138) as /devices/platform/dummy_hcd.1/usb2/2-1/2-1:0.0/rc/rc0
input: Conexant Hybrid TV (cx231xx) MCE IR no TX (2040:b138) as /devices/platform/dummy_hcd.1/usb2/2-1/2-1:0.0/rc/rc0/input24
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Registered with mce emulator interface version 1
mceusb 2-1:0.0: 2 tx ports (0x0 cabled) and 2 rx sensors (0x0 active)
usb 2-1: USB disconnect, device number 11
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
syzbot found the following issue on:
HEAD commit: 347385861c50 Linux 6.1.84
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16efc39d180000
kernel config: https://syzkaller.appspot.com/x/.config?x=40dfd13b04bfc094
dashboard link: https://syzkaller.appspot.com/bug?extid=43013a84c1d2e6b30c48
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Unfortunately, I don't have any reproducer for this issue yet.
Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/73d2a8622b6e/disk-34738586.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e7bc2e0101a7/vmlinux-34738586.xz
kernel image: https://storage.googleapis.com/syzbot-assets/7b96d1168608/bzImage-34738586.xz
IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+43013a...@syzkaller.appspotmail.com
======================================================
WARNING: possible circular locking dependency detected
6.1.84-syzkaller #0 Not tainted
------------------------------------------------------
kworker/0:11/3795 is trying to acquire lock:
ffff8880567ed130 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1745 [inline]
ffff8880567ed130 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}, at: sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:97
but task is already holding lock:
ffffc900057cfd20 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}, at: process_one_work+0x7a9/0x11d0 kernel/workqueue.c:2267
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #3 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__flush_work+0xfe/0xad0 kernel/workqueue.c:3072
__cancel_work_timer+0x519/0x6a0 kernel/workqueue.c:3163
sco_conn_del+0x205/0x300 net/bluetooth/sco.c:205
hci_disconn_cfm include/net/bluetooth/hci_core.h:1808 [inline]
hci_conn_hash_flush+0x10e/0x2a0 net/bluetooth/hci_conn.c:2441
hci_dev_close_sync+0x9a9/0x1020 net/bluetooth/hci_sync.c:5015
hci_dev_do_close net/bluetooth/hci_core.c:554 [inline]
hci_error_reset+0x12c/0x3c0 net/bluetooth/hci_core.c:1060
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
-> #2 (hci_cb_list_lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
hci_connect_cfm include/net/bluetooth/hci_core.h:1790 [inline]
hci_remote_features_evt+0x664/0xab0 net/bluetooth/hci_event.c:3778
hci_event_func net/bluetooth/hci_event.c:7514 [inline]
hci_event_packet+0xa9d/0x1510 net/bluetooth/hci_event.c:7566
hci_rx_work+0x3cd/0xce0 net/bluetooth/hci_core.c:4130
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
-> #1 (&hdev->lock){+.+.}-{3:3}:
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
__mutex_lock_common kernel/locking/mutex.c:603 [inline]
__mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
sco_sock_connect+0x181/0x8f0 net/bluetooth/sco.c:593
__sys_connect_file net/socket.c:2006 [inline]
__sys_connect+0x2c9/0x300 net/socket.c:2023
__do_sys_connect net/socket.c:2033 [inline]
__se_sys_connect net/socket.c:2030 [inline]
__x64_sys_connect+0x76/0x80 net/socket.c:2030
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:81
entry_SYSCALL_64_after_hwframe+0x63/0xcd
-> #0 (sk_lock-AF_BLUETOOTH-BTPROTO_SCO){+.+.}-{0:0}:
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
lock_sock_nested+0x44/0x100 net/core/sock.c:3484
lock_sock include/net/sock.h:1745 [inline]
sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:97
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
other info that might help us debug this:
Chain exists of:
sk_lock-AF_BLUETOOTH-BTPROTO_SCO --> hci_cb_list_lock --> (work_completion)(&(&conn->timeout_work)->work)
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock((work_completion)(&(&conn->timeout_work)->work));
lock(hci_cb_list_lock);
lock((work_completion)(&(&conn->timeout_work)->work));
lock(sk_lock-AF_BLUETOOTH-BTPROTO_SCO);
*** DEADLOCK ***
2 locks held by kworker/0:11/3795:
#0: ffff888012470938 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x7a9/0x11d0 kernel/workqueue.c:2267
#1: ffffc900057cfd20 ((work_completion)(&(&conn->timeout_work)->work)){+.+.}-{0:0}, at: process_one_work+0x7a9/0x11d0 kernel/workqueue.c:2267
stack backtrace:
CPU: 0 PID: 3795 Comm: kworker/0:11 Not tainted 6.1.84-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Workqueue: events sco_sock_timeout
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
check_prev_add kernel/locking/lockdep.c:3090 [inline]
check_prevs_add kernel/locking/lockdep.c:3209 [inline]
validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
__lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
lock_sock_nested+0x44/0x100 net/core/sock.c:3484
lock_sock include/net/sock.h:1745 [inline]
sco_sock_timeout+0xbd/0x230 net/bluetooth/sco.c:97
process_one_work+0x8a9/0x11d0 kernel/workqueue.c:2292
worker_thread+0xa47/0x1200 kernel/workqueue.c:2439
kthread+0x28d/0x320 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:307
</TASK>
IPv6: ADDRCONF(NETDEV_CHANGE): vxcan1: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): vxcan0: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth1_vlan: link becomes ready
IPv6: ADDRCONF(NETDEV_CHANGE): veth0_vlan: link becomes ready
usb 2-1: new high-speed USB device number 11 using dummy_hcd
usb 2-1: Using ep0 maxpacket: 16
usb 2-1: config 0 has an invalid descriptor of length 0, skipping remainder of the config
usb 2-1: config 0 interface 0 altsetting 0 endpoint 0x82 has an invalid bInterval 0, changing to 7
usb 2-1: config 0 interface 0 altsetting 0 endpoint 0x2 has invalid wMaxPacketSize 0
usb 2-1: config 0 interface 0 altsetting 0 bulk endpoint 0x2 has invalid maxpacket 0
usb 2-1: config 0 interface 0 altsetting 0 has 2 endpoint descriptors, different from the interface descriptor's value: 3
usb 2-1: New USB device found, idVendor=2040, idProduct=b138, bcdDevice= 1.42
usb 2-1: New USB device strings: Mfr=4, Product=0, SerialNumber=0
usb 2-1: Manufacturer: syz
usb 2-1: config 0 descriptor??
rc_core: IR keymap rc-hauppauge not found
Registered IR keymap rc-empty
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
rc rc0: Conexant Hybrid TV (cx231xx) MCE IR no TX (2040:b138) as /devices/platform/dummy_hcd.1/usb2/2-1/2-1:0.0/rc/rc0
input: Conexant Hybrid TV (cx231xx) MCE IR no TX (2040:b138) as /devices/platform/dummy_hcd.1/usb2/2-1/2-1:0.0/rc/rc0/input24
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Error: mce write submit urb error = -90
mceusb 2-1:0.0: Registered with mce emulator interface version 1
mceusb 2-1:0.0: 2 tx ports (0x0 cabled) and 2 rx sensors (0x0 active)
usb 2-1: USB disconnect, device number 11
---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.
syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title
If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)
If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report
If you want to undo deduplication, reply with:
#syz undup
Reply all
Reply to author
Forward
0 new messages