KASAN: use-after-free Read in ntfs_iget

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 13d2ce42 Linux 4.19.163
git tree: linux-4.19.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1708cfb7500000
kernel config: https://syzkaller.appspot.com/x/.config?x=fac7c3360835a4e0
dashboard link: https://syzkaller.appspot.com/bug?extid=f8f6a05924ba9a810722
compiler: gcc (GCC) 10.1.0-syz 20200507
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=134a8383500000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11ceffbd500000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+f8f6a0...@syzkaller.appspotmail.com

ntfs: (device loop0): map_mft_record_page(): Mft record 0x4 is corrupt. Run chkdsk.
==================================================================
BUG: KASAN: use-after-free in ntfs_read_locked_inode+0x47c6/0x5580 fs/ntfs/inode.c:670
Read of size 8 at addr ffff88808ad693d5 by task syz-executor122/8129

CPU: 1 PID: 8129 Comm: syz-executor122 Not tainted 4.19.163-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x1fc/0x2fe lib/dump_stack.c:118
print_address_description.cold+0x54/0x219 mm/kasan/report.c:256
kasan_report_error.cold+0x8a/0x1c7 mm/kasan/report.c:354
kasan_report mm/kasan/report.c:412 [inline]
__asan_report_load_n_noabort+0x8b/0xa0 mm/kasan/report.c:443
ntfs_read_locked_inode+0x47c6/0x5580 fs/ntfs/inode.c:670
ntfs_iget+0x12d/0x180 fs/ntfs/inode.c:190
load_and_init_mft_mirror+0x34/0x350 fs/ntfs/super.c:1041
load_system_files fs/ntfs/super.c:1786 [inline]
ntfs_fill_super+0xade/0x7e10 fs/ntfs/super.c:2908
mount_bdev+0x2fc/0x3b0 fs/super.c:1158
mount_fs+0xa3/0x30c fs/super.c:1261
vfs_kern_mount.part.0+0x68/0x470 fs/namespace.c:961
vfs_kern_mount fs/namespace.c:951 [inline]
do_new_mount fs/namespace.c:2469 [inline]
do_mount+0x113c/0x2f10 fs/namespace.c:2799
ksys_mount+0xcf/0x130 fs/namespace.c:3015
__do_sys_mount fs/namespace.c:3029 [inline]
__se_sys_mount fs/namespace.c:3026 [inline]
__x64_sys_mount+0xba/0x150 fs/namespace.c:3026
do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4494fa
Code: b8 08 00 00 00 0f 05 48 3d 01 f0 ff ff 0f 83 7d a3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 0f 83 5a a3 fb ff c3 66 0f 1f 84 00 00 00 00 00
RSP: 002b:00007ffd9369a9c8 EFLAGS: 00000287 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffd9369aa20 RCX: 00000000004494fa
RDX: 0000000020000000 RSI: 0000000020000100 RDI: 00007ffd9369a9e0
RBP: 00007ffd9369a9e0 R08: 00007ffd9369aa20 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000287 R12: 00000000000000ab
R13: 0000000000000004 R14: 0000000000000003 R15: 0000000000000003

The buggy address belongs to the page:
page:ffffea00022b5a40 count:0 mapcount:0 mapping:0000000000000000 index:0x1
flags: 0xfff00000000000()
raw: 00fff00000000000 ffffea00022b5a88 ffffea00022b5a08 0000000000000000
raw: 0000000000000001 0000000000000000 00000000ffffffff 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
ffff88808ad69280: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88808ad69300: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
>ffff88808ad69380: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
^
ffff88808ad69400: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
ffff88808ad69480: ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff
==================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 23e895868b518f48eab7925aeb93aeeac3ac2594
Author: Rustam Kovhaev <rkov...@gmail.com>
Date: Wed Feb 24 20:00:30 2021 +0000

ntfs: check for valid standard information attribute

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16c96301d00000
start commit: 13d2ce42 Linux 4.19.163
git tree: linux-4.19.y

kernel config: https://syzkaller.appspot.com/x/.config?x=fac7c3360835a4e0
dashboard link: https://syzkaller.appspot.com/bug?extid=f8f6a05924ba9a810722

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=134a8383500000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=11ceffbd500000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: ntfs: check for valid standard information attribute

For information about bisection process see: https://goo.gl/tpsmEJ#bisection