[v5.15] UBSAN: shift-out-of-bounds in extAlloc

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: d9b4a0c83a2d Linux 5.15.98
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=1306c30ac80000
kernel config: https://syzkaller.appspot.com/x/.config?x=b57cfa804330c3b7
dashboard link: https://syzkaller.appspot.com/bug?extid=101992cd74f73e92da5d
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/8088989394e3/disk-d9b4a0c8.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2651d6753959/vmlinux-d9b4a0c8.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f3fa3f994f9a/Image-d9b4a0c8.gz.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+101992...@syzkaller.appspotmail.com

loop5: detected capacity change from 0 to 32768
================================================================================
UBSAN: shift-out-of-bounds in fs/jfs/jfs_extent.c:511:16
shift exponent -1 is negative
CPU: 1 PID: 17122 Comm: syz-executor.5 Not tainted 5.15.98-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call trace:
dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
dump_stack+0x1c/0x58 lib/dump_stack.c:113
ubsan_epilogue lib/ubsan.c:151 [inline]
__ubsan_handle_shift_out_of_bounds+0x2f8/0x378 lib/ubsan.c:321
extBalloc fs/jfs/jfs_extent.c:511 [inline]
extAlloc+0xbd4/0xe38 fs/jfs/jfs_extent.c:125
jfs_get_block+0x34c/0xbfc fs/jfs/inode.c:258
nobh_write_begin+0x2d8/0xa28 fs/buffer.c:2650
jfs_write_begin+0x58/0xa0 fs/jfs/inode.c:322
generic_perform_write+0x24c/0x520 mm/filemap.c:3776
__generic_file_write_iter+0x230/0x454 mm/filemap.c:3903
generic_file_write_iter+0xb4/0x1b8 mm/filemap.c:3935
call_write_iter include/linux/fs.h:2101 [inline]
new_sync_write fs/read_write.c:507 [inline]
vfs_write+0x87c/0xb3c fs/read_write.c:594
ksys_write+0x15c/0x26c fs/read_write.c:647
__do_sys_write fs/read_write.c:659 [inline]
__se_sys_write fs/read_write.c:656 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:656
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596
el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614
el0t_64_sync+0x1a0/0x1a4 <unknown>:584
================================================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 1cc3fcf63192 Linux 6.1.18
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=10185a34c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=ac04a15f4a80e9d0
dashboard link: https://syzkaller.appspot.com/bug?extid=67f714a53ce18d5b542e

compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:

disk image: https://storage.googleapis.com/syzbot-assets/9dee98921f5a/disk-1cc3fcf6.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/713a648558bd/vmlinux-1cc3fcf6.xz
kernel image: https://storage.googleapis.com/syzbot-assets/6b9e84fcf1df/bzImage-1cc3fcf6.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:

Reported-by: syzbot+67f714...@syzkaller.appspotmail.com

loop5: detected capacity change from 0 to 32768
================================================================================

UBSAN: shift-out-of-bounds in fs/jfs/jfs_extent.c:314:16

shift exponent -1 is negative

CPU: 0 PID: 21536 Comm: syz-executor.5 Not tainted 6.1.18-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023

Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
ubsan_epilogue lib/ubsan.c:151 [inline]
__ubsan_handle_shift_out_of_bounds+0x3bf/0x420 lib/ubsan.c:321
extBalloc fs/jfs/jfs_extent.c:314 [inline]
extAlloc+0xe4f/0x1010 fs/jfs/jfs_extent.c:122
jfs_get_block+0x417/0xe50 fs/jfs/inode.c:248
__block_write_begin_int+0x544/0x1a30 fs/buffer.c:1991
__block_write_begin fs/buffer.c:2041 [inline]
block_write_begin+0x98/0x1f0 fs/buffer.c:2102
jfs_write_begin+0x2d/0x60 fs/jfs/inode.c:304
generic_perform_write+0x2fc/0x5e0 mm/filemap.c:3754
__generic_file_write_iter+0x176/0x400 mm/filemap.c:3882
generic_file_write_iter+0xab/0x310 mm/filemap.c:3914
call_write_iter include/linux/fs.h:2205 [inline]
new_sync_write fs/read_write.c:491 [inline]
vfs_write+0x7ae/0xba0 fs/read_write.c:584
ksys_write+0x19c/0x2c0 fs/read_write.c:637
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fd7c728c0f9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd7c7f25168 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007fd7c73abf80 RCX: 00007fd7c728c0f9
RDX: 000000000208e24b RSI: 0000000020000140 RDI: 0000000000000004
RBP: 00007fd7c72e7ae9 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fff1775d5ff R14: 00007fd7c7f25300 R15: 0000000000022000
</TASK>

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 2ddbd0f967b3 Linux 5.15.102
git tree: linux-5.15.y
console output: https://syzkaller.appspot.com/x/log.txt?x=16d3c626c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=d6af46e4bd7d6a2f

dashboard link: https://syzkaller.appspot.com/bug?extid=101992cd74f73e92da5d
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2
userspace arch: arm64

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1530789ac80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12e4f572c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/d46a989959b6/disk-2ddbd0f9.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/4d06a9b2ddaf/vmlinux-2ddbd0f9.xz
kernel image: https://storage.googleapis.com/syzbot-assets/0921009430c0/Image-2ddbd0f9.gz.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/31318c69a97b/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+101992...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 32768

================================================================================
UBSAN: shift-out-of-bounds in fs/jfs/jfs_extent.c:511:16
shift exponent -1 is negative

CPU: 1 PID: 4053 Comm: syz-executor304 Not tainted 5.15.102-syzkaller #0

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: e3a87a10f259 Linux 6.1.21
git tree: linux-6.1.y
console output: https://syzkaller.appspot.com/x/log.txt?x=15ab0cd5c80000
kernel config: https://syzkaller.appspot.com/x/.config?x=390800ef8aeebc47

dashboard link: https://syzkaller.appspot.com/bug?extid=67f714a53ce18d5b542e
compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2

userspace arch: arm64
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16f9a0c1c80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1198dbb1c80000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/9f5022ccd560/disk-e3a87a10.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/f8524664c631/vmlinux-e3a87a10.xz
kernel image: https://storage.googleapis.com/syzbot-assets/ad699b30c2c4/Image-e3a87a10.gz.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/d8995d479701/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+67f714...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 32768

================================================================================
UBSAN: shift-out-of-bounds in fs/jfs/jfs_extent.c:314:16
shift exponent -1 is negative

CPU: 0 PID: 4314 Comm: syz-executor368 Not tainted 6.1.21-syzkaller #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023

Call trace:
dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165

__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106

dump_stack+0x1c/0x5c lib/dump_stack.c:113
ubsan_epilogue lib/ubsan.c:151 [inline]
__ubsan_handle_shift_out_of_bounds+0x2f4/0x36c lib/ubsan.c:321
extBalloc fs/jfs/jfs_extent.c:314 [inline]
extAlloc+0xbb8/0xdd0 fs/jfs/jfs_extent.c:122
jfs_get_block+0x340/0xb98 fs/jfs/inode.c:248
__block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991
__block_write_begin fs/buffer.c:2041 [inline]
block_write_begin+0x98/0x11c fs/buffer.c:2102
jfs_write_begin+0x44/0x88 fs/jfs/inode.c:304
generic_perform_write+0x278/0x55c mm/filemap.c:3754
__generic_file_write_iter+0x168/0x388 mm/filemap.c:3882
generic_file_write_iter+0xb8/0x2b4 mm/filemap.c:3914

call_write_iter include/linux/fs.h:2205 [inline]
new_sync_write fs/read_write.c:491 [inline]

vfs_write+0x610/0x914 fs/read_write.c:584
ksys_write+0x15c/0x26c fs/read_write.c:637
__do_sys_write fs/read_write.c:649 [inline]
__se_sys_write fs/read_write.c:646 [inline]
__arm64_sys_write+0x7c/0x90 fs/read_write.c:646
__invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581
================================================================================

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 8f994b830dd0cf1239c85d900ce5df2030d95e0c
Author: Alexei Filippov <hali...@gmail.com>
Date: Sat Aug 19 17:32:16 2023 +0000

jfs: validate max amount of blocks before allocation.

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=16a170f5680000
start commit: f48aeeaaa64c Linux 5.15.109
git tree: linux-5.15.y
kernel config: https://syzkaller.appspot.com/x/.config?x=f0ea19992afd55ad
dashboard link: https://syzkaller.appspot.com/bug?extid=101992cd74f73e92da5d
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17e048dfc80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=178b1b58280000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: jfs: validate max amount of blocks before allocation.

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[syzbot]

syzbot suspects this issue could be fixed by backporting the following commit:

commit a779ed754e52d582b8c0e17959df063108bd0656
git tree: upstream
Author: Dave Kleikamp <dave.k...@oracle.com>
Date: Thu Oct 5 14:16:14 2023 +0000

jfs: define xtree root and page independently

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12a6d7eee80000
kernel config: https://syzkaller.appspot.com/x/.config?x=47d3bbfdb3b1ddd2
dashboard link: https://syzkaller.appspot.com/bug?extid=67f714a53ce18d5b542e
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1371e070280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17765c32280000


Please keep in mind that other backports might be required as well.