syzkaller: testing failed: failed to run ["go" "test" "-short" "./..."]: exit status 1 (6)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:
git tree: https://github.com/google/syzkaller.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=152c3881900000
dashboard link: https://syzkaller.appspot.com/bug?extid=7535aaead02df7aae1b0
compiler: go version go1.14.4 freebsd/amd64

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+7535aa...@syzkaller.appspotmail.com



---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

[Dmitry Vyukov]

On Tue, Sep 22, 2020 at 10:23 AM syzbot
<syzbot+7535aa...@syzkaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:
> git tree: https://github.com/google/syzkaller.git master
> console output: https://syzkaller.appspot.com/x/log.txt?x=152c3881900000
> dashboard link: https://syzkaller.appspot.com/bug?extid=7535aaead02df7aae1b0
> compiler: go version go1.14.4 freebsd/amd64
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+7535aa...@syzkaller.appspotmail.com

Hi,

This is broken with a new error:

<stdin>:698:11: error: use of undeclared identifier
'SYS_freebsd12_shm_open'
syscall(SYS_freebsd12_shm_open,
0x10000840, 0x800, 0x100);

(since the previous bug wasn't marked as fixed/closed, syzbot did not
create another one and just piles all new similar errors into the same
bug).

If this is because the new syscalls are not present in the old host
image, we have this NeedSyscallDefine thing that can be used to inject
some syscall numbers into C reproducers:
https://github.com/google/syzkaller/blob/f12ba0c59fb470378fd054bba8ce424156c4f164/sys/targets/targets.go#L36-L37

[Mark Johnston]

I think that is the reason. The POSIX shm system calls are new and I
don't see such test failures on my own systems. I submitted
https://github.com/google/syzkaller/pull/2331 . This looks like an
abuse of NeedSyscallDefine but it seems reasonable to do this until the
syzbot hosts are updated.

[Dmitry Vyukov]

Maybe it's an abuse for FreeBSD, but at least that's exactly how/why
we use it for Linux :)