Re: KMSAN: uninit-value in ax88172a_bind

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer still triggered
crash:
KMSAN: uninit-value in asix_mdio_read

asix 4-1:0.78 (unnamed net_device) (uninitialized): Failed to enable
software MII access
asix 4-1:0.78 (unnamed net_device) (uninitialized): Failed to read reg
index 0x0000: -71
=====================================================
BUG: KMSAN: uninit-value in asix_mdio_read+0x3e9/0x8f0
drivers/net/usb/asix_common.c:460
CPU: 0 PID: 3385 Comm: kworker/0:2 Not tainted 5.4.0-rc5+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x191/0x1f0 lib/dump_stack.c:113
kmsan_report+0x128/0x220 mm/kmsan/kmsan_report.c:108
__msan_warning+0x73/0xe0 mm/kmsan/kmsan_instr.c:245
asix_mdio_read+0x3e9/0x8f0 drivers/net/usb/asix_common.c:460
asix_mdio_bus_read+0xbc/0xe0 drivers/net/usb/ax88172a.c:31
__mdiobus_read+0x103/0x3b0 drivers/net/phy/mdio_bus.c:552
mdiobus_read+0xbd/0x110 drivers/net/phy/mdio_bus.c:629
get_phy_id drivers/net/phy/phy_device.c:785 [inline]
get_phy_device+0x331/0x8a0 drivers/net/phy/phy_device.c:819
mdiobus_scan+0x91/0x760 drivers/net/phy/mdio_bus.c:516
__mdiobus_register+0x86d/0xca0 drivers/net/phy/mdio_bus.c:415
ax88172a_init_mdio drivers/net/usb/ax88172a.c:105 [inline]
ax88172a_bind+0xcd4/0xfa0 drivers/net/usb/ax88172a.c:243
usbnet_probe+0x10d3/0x39d0 drivers/net/usb/usbnet.c:1730
usb_probe_interface+0xd19/0x1310 drivers/usb/core/driver.c:361
really_probe+0xd91/0x1f90 drivers/base/dd.c:552
driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
__device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
__device_attach+0x489/0x750 drivers/base/dd.c:894
device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
bus_probe_device+0x131/0x390 drivers/base/bus.c:490
device_add+0x25b5/0x2df0 drivers/base/core.c:2202
usb_set_configuration+0x309f/0x3710 drivers/usb/core/message.c:2027
generic_probe+0xe7/0x280 drivers/usb/core/generic.c:210
usb_probe_device+0x146/0x200 drivers/usb/core/driver.c:266
really_probe+0xd91/0x1f90 drivers/base/dd.c:552
driver_probe_device+0x1ba/0x510 drivers/base/dd.c:721
__device_attach_driver+0x5b8/0x790 drivers/base/dd.c:828
bus_for_each_drv+0x28e/0x3b0 drivers/base/bus.c:430
__device_attach+0x489/0x750 drivers/base/dd.c:894
device_initial_probe+0x4a/0x60 drivers/base/dd.c:941
bus_probe_device+0x131/0x390 drivers/base/bus.c:490
device_add+0x25b5/0x2df0 drivers/base/core.c:2202
usb_new_device+0x23e5/0x2fb0 drivers/usb/core/hub.c:2536
hub_port_connect drivers/usb/core/hub.c:5098 [inline]
hub_port_connect_change drivers/usb/core/hub.c:5213 [inline]
port_event drivers/usb/core/hub.c:5359 [inline]
hub_event+0x581d/0x72f0 drivers/usb/core/hub.c:5441
process_one_work+0x1572/0x1ef0 kernel/workqueue.c:2269
worker_thread+0x111b/0x2460 kernel/workqueue.c:2415
kthread+0x4b5/0x4f0 kernel/kthread.c:256
ret_from_fork+0x35/0x40 arch/x86/entry/entry_64.S:355

Local variable description: ----smsr@asix_mdio_read
Variable was created at:
asix_mdio_read+0xa0/0x8f0 include/linux/netdevice.h:2193
asix_mdio_read+0xa0/0x8f0 include/linux/netdevice.h:2193
=====================================================


Tested on:

commit: 6f88939b kmsan: don't unpoison memory in do_read_cache_pag..
git tree: https://github.com/google/kmsan.git master
console output: https://syzkaller.appspot.com/x/log.txt?x=10505268e00000
kernel config: https://syzkaller.appspot.com/x/.config?x=9e324dfe9c7b0360
dashboard link: https://syzkaller.appspot.com/bug?extid=a8d4acdad35e6bbca308
compiler: clang version 9.0.0 (/home/glider/llvm/clang
80fee25776c2fb61e74c1ecb1a523375c2500b69)
patch: https://syzkaller.appspot.com/x/patch.diff?x=11d1f242e00000

[Phong Tran]

#syz test: https://github.com/google/kmsan.git master

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer still triggered
crash:

KMSAN: uninit-value in get_phy_device

asix 6-1:0.78 (unnamed net_device) (uninitialized): Failed to read reg
index 0x0003: -71
asix 6-1:0.78 (unnamed net_device) (uninitialized): Failed to write reg
index 0x0000: -71
asix 6-1:0.78 (unnamed net_device) (uninitialized): Failed to enable
hardware MII access
=====================================================
BUG: KMSAN: uninit-value in get_phy_device+0x7d5/0x8a0
drivers/net/phy/phy_device.c:824
CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 5.4.0-rc5+ #0

Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS
Google 01/01/2011
Workqueue: usb_hub_wq hub_event
Call Trace:
__dump_stack lib/dump_stack.c:77 [inline]
dump_stack+0x191/0x1f0 lib/dump_stack.c:113
kmsan_report+0x128/0x220 mm/kmsan/kmsan_report.c:108
__msan_warning+0x73/0xe0 mm/kmsan/kmsan_instr.c:245

get_phy_device+0x7d5/0x8a0 drivers/net/phy/phy_device.c:824

asix_mdio_read+0xa3/0x900 include/linux/netdevice.h:2193
asix_mdio_read+0xa3/0x900 include/linux/netdevice.h:2193

=====================================================


Tested on:

commit: 6f88939b kmsan: don't unpoison memory in do_read_cache_pag..
git tree: https://github.com/google/kmsan.git master

console output: https://syzkaller.appspot.com/x/log.txt?x=115def5ce00000

kernel config: https://syzkaller.appspot.com/x/.config?x=9e324dfe9c7b0360
dashboard link: https://syzkaller.appspot.com/bug?extid=a8d4acdad35e6bbca308
compiler: clang version 9.0.0 (/home/glider/llvm/clang
80fee25776c2fb61e74c1ecb1a523375c2500b69)

patch: https://syzkaller.appspot.com/x/patch.diff?x=166069a4e00000

[Phong Tran]

#syz test: https://github.com/google/kmsan.git master

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer still triggered
crash:
KMSAN: uninit-value in get_phy_device

asix 5-1:0.78 (unnamed net_device) (uninitialized): Failed to enable

hardware MII access
=====================================================
BUG: KMSAN: uninit-value in get_phy_device+0x7d5/0x8a0
drivers/net/phy/phy_device.c:824

CPU: 1 PID: 3906 Comm: kworker/1:2 Not tainted 5.4.0-rc5+ #0

console output: https://syzkaller.appspot.com/x/log.txt?x=16d7ca68e00000

kernel config: https://syzkaller.appspot.com/x/.config?x=9e324dfe9c7b0360
dashboard link: https://syzkaller.appspot.com/bug?extid=a8d4acdad35e6bbca308
compiler: clang version 9.0.0 (/home/glider/llvm/clang
80fee25776c2fb61e74c1ecb1a523375c2500b69)

patch: https://syzkaller.appspot.com/x/patch.diff?x=110a1d34e00000

[Phong Tran]

#syz test: https://github.com/google/kmsan.git master

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer still triggered
crash:
KMSAN: uninit-value in get_phy_device

asix 5-1:0.78 (unnamed net_device) (uninitialized): Failed to write reg
index 0x0000: -71

asix 5-1:0.78 (unnamed net_device) (uninitialized): Failed to enable
hardware MII access
=====================================================
BUG: KMSAN: uninit-value in get_phy_device+0x7d5/0x8a0
drivers/net/phy/phy_device.c:824

CPU: 0 PID: 2988 Comm: kworker/0:2 Not tainted 5.4.0-rc5+ #0

console output: https://syzkaller.appspot.com/x/log.txt?x=1155438ae00000

kernel config: https://syzkaller.appspot.com/x/.config?x=9e324dfe9c7b0360
dashboard link: https://syzkaller.appspot.com/bug?extid=a8d4acdad35e6bbca308
compiler: clang version 9.0.0 (/home/glider/llvm/clang
80fee25776c2fb61e74c1ecb1a523375c2500b69)

patch: https://syzkaller.appspot.com/x/patch.diff?x=1228f9b2e00000

[Phong Tran]

#syz test: https://github.com/google/kmsan.git master

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer still triggered
crash:
KMSAN: uninit-value in get_phy_device

asix 6-1:0.78 (unnamed net_device) (uninitialized): Failed to write reg
index 0x0000: -71
asix 6-1:0.78 (unnamed net_device) (uninitialized): Failed to enable

hardware MII access
=====================================================
BUG: KMSAN: uninit-value in get_phy_device+0x7d5/0x8a0
drivers/net/phy/phy_device.c:824

CPU: 0 PID: 3378 Comm: kworker/0:2 Not tainted 5.4.0-rc5+ #0

commit: c235b34b kmsan: mm: fixup "call KMSAN hooks from SLUB code"

git tree: https://github.com/google/kmsan.git master

console output: https://syzkaller.appspot.com/x/log.txt?x=176e50aae00000

kernel config: https://syzkaller.appspot.com/x/.config?x=9e324dfe9c7b0360
dashboard link: https://syzkaller.appspot.com/bug?extid=a8d4acdad35e6bbca308
compiler: clang version 9.0.0 (/home/glider/llvm/clang
80fee25776c2fb61e74c1ecb1a523375c2500b69)

patch: https://syzkaller.appspot.com/x/patch.diff?x=16d0db8ae00000