[syzbot] [modules?] KASAN: invalid-access Read in init_module_from_file

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 533925cb7604 Merge tag 'riscv-for-linus-6.5-mw1' of git://..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=151dba0ca80000
kernel config: https://syzkaller.appspot.com/x/.config?x=998aa1e85d118b55
dashboard link: https://syzkaller.appspot.com/bug?extid=e3705186451a87fd93b8
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=16a4eb98a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=14ec1a6f280000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/03caccccf2c4/disk-533925cb.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/2fc5ec527ecb/vmlinux-533925cb.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1c17e9d79ab7/bzImage-533925cb.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+e37051...@syzkaller.appspotmail.com

general protection fault, probably for non-canonical address 0xdffffc0000000007: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000038-0x000000000000003f]
CPU: 1 PID: 5014 Comm: syz-executor823 Not tainted 6.4.0-syzkaller-08881-g533925cb7604 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023
RIP: 0010:idempotent kernel/module/main.c:3078 [inline]
RIP: 0010:init_module_from_file+0x1c1/0x6a0 kernel/module/main.c:3124
Code: 0f 84 c0 01 00 00 e8 7e ee 12 00 4d 89 e7 49 83 ef 08 74 61 e8 70 ee 12 00 4c 89 fa 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 59 04 00 00 4d 3b 2f 0f 84 ae 00 00 00 e8 47 ee
RSP: 0018:ffffc900033ffd28 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 000000000000002e RCX: 0000000000000000
RDX: 0000000000000007 RSI: ffffffff8170eaa0 RDI: ffffc9000336fe28
RBP: ffff88807adaa280 R08: 0000000000000001 R09: fffff5200067ff97
R10: 0000000000000003 R11: 0000000000000001 R12: ffffc9000336fe28
R13: ffff8880752b54c0 R14: ffffffff91f19290 R15: 000000000000003e
FS: 0000555556cec3c0(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000073bff000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__do_sys_finit_module kernel/module/main.c:3171 [inline]
__se_sys_finit_module kernel/module/main.c:3154 [inline]
__x64_sys_finit_module+0xfd/0x190 kernel/module/main.c:3154
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f4b273fcfa9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 11 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd7aa7c1f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000139
RAX: ffffffffffffffda RBX: 0000000000018ef9 RCX: 00007f4b273fcfa9
RDX: 0000000000000002 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffd7aa7c2ac
R13: 00007ffd7aa7c2e0 R14: 00007ffd7aa7c2c0 R15: 000000000000000a
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:idempotent kernel/module/main.c:3078 [inline]
RIP: 0010:init_module_from_file+0x1c1/0x6a0 kernel/module/main.c:3124
Code: 0f 84 c0 01 00 00 e8 7e ee 12 00 4d 89 e7 49 83 ef 08 74 61 e8 70 ee 12 00 4c 89 fa 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 59 04 00 00 4d 3b 2f 0f 84 ae 00 00 00 e8 47 ee
RSP: 0018:ffffc900033ffd28 EFLAGS: 00010203
RAX: dffffc0000000000 RBX: 000000000000002e RCX: 0000000000000000
RDX: 0000000000000007 RSI: ffffffff8170eaa0 RDI: ffffc9000336fe28
RBP: ffff88807adaa280 R08: 0000000000000001 R09: fffff5200067ff97
R10: 0000000000000003 R11: 0000000000000001 R12: ffffc9000336fe28
R13: ffff8880752b54c0 R14: ffffffff91f19290 R15: 000000000000003e
FS: 0000555556cec3c0(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000073bff000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
0: 0f 84 c0 01 00 00 je 0x1c6
6: e8 7e ee 12 00 callq 0x12ee89
b: 4d 89 e7 mov %r12,%r15
e: 49 83 ef 08 sub $0x8,%r15
12: 74 61 je 0x75
14: e8 70 ee 12 00 callq 0x12ee89
19: 4c 89 fa mov %r15,%rdx
1c: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax
23: fc ff df
26: 48 c1 ea 03 shr $0x3,%rdx
* 2a: 80 3c 02 00 cmpb $0x0,(%rdx,%rax,1) <-- trapping instruction
2e: 0f 85 59 04 00 00 jne 0x48d
34: 4d 3b 2f cmp (%r15),%r13
37: 0f 84 ae 00 00 00 je 0xeb
3d: e8 .byte 0xe8
3e: 47 ee rex.RXB out %al,(%dx)


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the bug is already fixed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

If you want to change bug's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the bug is a duplicate of another bug, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[Luis Chamberlain]

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 910e230d5f1bb72c54532e94fbb1705095c7bab6

[syzbot]

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

failed to checkout kernel repo git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git on commit 910e230d5f1bb72c54532e94fbb1705095c7bab6: failed to run ["git" "checkout" "910e230d5f1bb72c54532e94fbb1705095c7bab6"]: exit status 128
fatal: reference is not a tree: 910e230d5f1bb72c54532e94fbb1705095c7bab6



Tested on:

commit: [unknown
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 910e230d5f1bb72c54532e94fbb1705095c7bab6

dashboard link: https://syzkaller.appspot.com/bug?extid=e3705186451a87fd93b8
compiler:

Note: no patches were applied.

[Luis Chamberlain]

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git 910e230d5f1bb72c54532e94fbb1705095c7bab6

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+e37051...@syzkaller.appspotmail.com

Tested on:

commit: 910e230d samples/hw_breakpoint: Fix kernel BUG 'invali..
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=11e83081a80000
kernel config: https://syzkaller.appspot.com/x/.config?x=34364e75687fa9c3
dashboard link: https://syzkaller.appspot.com/bug?extid=e3705186451a87fd93b8
compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.

Note: testing is done by a robot and is best-effort only.

[syzbot]

syzbot suspects this issue was fixed by commit:

commit 125bfc7cd750e68c99f1d446e2c22abea08c237f
Author: Li Nan <lina...@huawei.com>
Date: Fri Jun 9 09:43:20 2023 +0000

md/raid10: fix the condition to call bio_end_io_acct()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=15c26ba9a80000
start commit: a901a3568fd2 Merge tag 'iomap-6.5-merge-1' of git://git.ke..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=f5e1158c5b2f83bb
dashboard link: https://syzkaller.appspot.com/bug?extid=e3705186451a87fd93b8
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12518548a80000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=124ccf70a80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: md/raid10: fix the condition to call bio_end_io_acct()

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Aleksandr Nogikh]

No, that's unrelated.

Most likely it's due to https://github.com/google/syzkaller/issues/4117
TL;DR: for bugs that only existed for a very short time syzbot is
having problems differentiating between revisions where the bug is not
yet introduced and where it's already fixed.

[syzbot]

syzbot suspects this issue was fixed by commit:

commit f1962207150c8b602e980616f04b37ea4e64bb9f
Author: Linus Torvalds <torv...@linux-foundation.org>
Date: Tue Jul 4 13:37:32 2023 +0000

module: fix init_module_from_file() error handling

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17c80763a80000
start commit: 995b406c7e97 Merge tag 'csky-for-linus-6.5' of https://git..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=3f27fb02fc20d955
dashboard link: https://syzkaller.appspot.com/bug?extid=e3705186451a87fd93b8
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=12219fbf280000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1278c8a4a80000

If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: module: fix init_module_from_file() error handling

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.