test debug prints

2 views
Skip to first unread message

Michal Koutný

unread,
May 26, 2022, 5:54:52 AM5/26/22
to syzbot+e42ae4...@syzkaller.appspotmail.com, syzkall...@googlegroups.com
#syz test: https://github.com/Werkov/linux.git cgroup-ml/css-lifecycle-syzbot

syzbot

unread,
May 26, 2022, 6:09:19 AM5/26/22
to mko...@suse.com, syzkaller-a...@googlegroups.com, syzkall...@googlegroups.com
Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
KASAN: use-after-free Write in put_task_stack

</TASK>
==================================================================
BUG: KASAN: use-after-free in instrument_atomic_read_write include/linux/instrumented.h:101 [inline]
BUG: KASAN: use-after-free in atomic_fetch_sub_release include/linux/atomic/atomic-instrumented.h:176 [inline]
BUG: KASAN: use-after-free in __refcount_sub_and_test include/linux/refcount.h:272 [inline]
BUG: KASAN: use-after-free in __refcount_dec_and_test include/linux/refcount.h:315 [inline]
BUG: KASAN: use-after-free in refcount_dec_and_test include/linux/refcount.h:333 [inline]
BUG: KASAN: use-after-free in put_task_stack+0x2a/0x220 kernel/fork.c:533
Write of size 4 at addr ffff88810cea1bc0 by task kworker/0:2/53

CPU: 0 PID: 53 Comm: kworker/0:2 Tainted: G W 5.18.0-syzkaller-01161-gcb93b3201ead #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: rcu_gp wait_rcu_exp_gp

Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x151/0x1b7 lib/dump_stack.c:106
print_address_description mm/kasan/report.c:313 [inline]
print_report+0x15f/0x620 mm/kasan/report.c:429
kasan_report+0xe6/0x110 mm/kasan/report.c:491
kasan_check_range+0x2aa/0x2e0 mm/kasan/generic.c:189
__kasan_check_write+0x14/0x20 mm/kasan/shadow.c:37
instrument_atomic_read_write include/linux/instrumented.h:101 [inline]
atomic_fetch_sub_release include/linux/atomic/atomic-instrumented.h:176 [inline]
__refcount_sub_and_test include/linux/refcount.h:272 [inline]
__refcount_dec_and_test include/linux/refcount.h:315 [inline]
refcount_dec_and_test include/linux/refcount.h:333 [inline]
put_task_stack+0x2a/0x220 kernel/fork.c:533
sched_show_task+0x380/0x520 kernel/sched/core.c:8732
dump_cpu_task+0x73/0x90 kernel/sched/core.c:11046
synchronize_rcu_expedited_wait+0xc17/0x1310 kernel/rcu/tree_exp.h:668
rcu_exp_wait_wake kernel/rcu/tree_exp.h:685 [inline]
rcu_exp_sel_wait_wake+0x4c9/0x8a0 kernel/rcu/tree_exp.h:719
wait_rcu_exp_gp+0x33/0x40 kernel/rcu/tree_exp.h:510
process_one_work+0x6cb/0xbf0 kernel/workqueue.c:2289
worker_thread+0xb3c/0x1390 kernel/workqueue.c:2436
kthread+0x26b/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30
</TASK>

Allocated by task 453:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track mm/kasan/common.c:45 [inline]
set_alloc_info mm/kasan/common.c:436 [inline]
__kasan_slab_alloc+0xb2/0xe0 mm/kasan/common.c:469
kasan_slab_alloc include/linux/kasan.h:224 [inline]
slab_post_alloc_hook mm/slab.h:749 [inline]
slab_alloc_node mm/slub.c:3217 [inline]
slab_alloc mm/slub.c:3225 [inline]
__kmem_cache_alloc_lru mm/slub.c:3232 [inline]
kmem_cache_alloc+0x192/0x300 mm/slub.c:3242
kmem_cache_alloc_node include/linux/slab.h:453 [inline]
alloc_task_struct_node kernel/fork.c:172 [inline]
dup_task_struct+0x54/0x4a0 kernel/fork.c:971
copy_process+0x582/0x34c0 kernel/fork.c:2073
kernel_clone+0x224/0x8d0 kernel/fork.c:2644
__do_sys_clone kernel/fork.c:2761 [inline]
__se_sys_clone kernel/fork.c:2745 [inline]
__x64_sys_clone+0x289/0x310 kernel/fork.c:2745
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x2f/0x50 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x46/0xb0

Freed by task 20:
kasan_save_stack mm/kasan/common.c:38 [inline]
kasan_set_track+0x4c/0x70 mm/kasan/common.c:45
kasan_set_free_info+0x23/0x40 mm/kasan/generic.c:370
____kasan_slab_free+0x133/0x170 mm/kasan/common.c:366
__kasan_slab_free+0x11/0x20 mm/kasan/common.c:374
kasan_slab_free include/linux/kasan.h:200 [inline]
slab_free_hook mm/slub.c:1728 [inline]
slab_free_freelist_hook+0xc9/0x1a0 mm/slub.c:1754
slab_free mm/slub.c:3510 [inline]
kmem_cache_free+0x110/0x2d0 mm/slub.c:3527
free_task_struct kernel/fork.c:177 [inline]
free_task kernel/fork.c:561 [inline]
__put_task_struct+0x32b/0x4d0 kernel/fork.c:850
put_task_struct include/linux/sched/task.h:115 [inline]
delayed_put_task_struct+0x5c/0x180 kernel/exit.c:177
rcu_do_batch+0x507/0xbc0 kernel/rcu/tree.c:2578
rcu_core+0x4dc/0xef0 kernel/rcu/tree.c:2838
rcu_core_si+0x9/0x10 kernel/rcu/tree.c:2855
__do_softirq+0x24e/0x586 kernel/softirq.c:558

Last potentially related work creation:
kasan_save_stack+0x3b/0x60 mm/kasan/common.c:38
__kasan_record_aux_stack+0xb3/0xc0 mm/kasan/generic.c:348
kasan_record_aux_stack_noalloc+0xb/0x10 mm/kasan/generic.c:358
call_rcu+0xf9/0x1390 kernel/rcu/tree.c:3126
put_task_struct_rcu_user+0x58/0xa0 kernel/exit.c:183
finish_task_switch+0x34a/0x700 kernel/sched/core.c:4987
context_switch kernel/sched/core.c:5076 [inline]
__schedule+0xb2a/0x1020 kernel/sched/core.c:6388
preempt_schedule_common+0xa7/0x100 kernel/sched/core.c:6553
preempt_schedule+0xd9/0xe0 kernel/sched/core.c:6577
preempt_schedule_thunk+0x16/0x18
on_each_cpu_cond_mask+0x78/0x80 kernel/smp.c:1139
on_each_cpu include/linux/smp.h:71 [inline]
text_poke_sync arch/x86/kernel/alternative.c:1184 [inline]
text_poke_bp_batch+0x504/0x740 arch/x86/kernel/alternative.c:1425
text_poke_flush arch/x86/kernel/alternative.c:1542 [inline]
text_poke_finish+0x1a/0x30 arch/x86/kernel/alternative.c:1549
arch_jump_label_transform_apply+0x15/0x30 arch/x86/kernel/jump_label.c:146
__jump_label_update+0x37e/0x3a0 kernel/jump_label.c:459
jump_label_update+0x3bc/0x450 kernel/jump_label.c:830
static_key_enable_cpuslocked+0x12a/0x250 kernel/jump_label.c:177
static_key_enable+0x1a/0x30 kernel/jump_label.c:190
toggle_allocation_gate+0xbf/0x450 mm/kfence/core.c:774
process_one_work+0x6cb/0xbf0 kernel/workqueue.c:2289
worker_thread+0xb3c/0x1390 kernel/workqueue.c:2436
kthread+0x26b/0x300 kernel/kthread.c:376
ret_from_fork+0x1f/0x30

Second to last potentially related work creation:
kasan_save_stack+0x3b/0x60 mm/kasan/common.c:38
__kasan_record_aux_stack+0xb3/0xc0 mm/kasan/generic.c:348
kasan_record_aux_stack_noalloc+0xb/0x10 mm/kasan/generic.c:358
call_rcu+0xf9/0x1390 kernel/rcu/tree.c:3126
put_task_struct_rcu_user+0x58/0xa0 kernel/exit.c:183
finish_task_switch+0x34a/0x700 kernel/sched/core.c:4987
context_switch kernel/sched/core.c:5076 [inline]
__schedule+0xb2a/0x1020 kernel/sched/core.c:6388
schedule_idle+0x50/0x90 kernel/sched/core.c:6488
do_idle+0x583/0x5e0 kernel/sched/idle.c:331
cpu_startup_entry+0x25/0x30 kernel/sched/idle.c:400
start_secondary+0xe3/0xf0 arch/x86/kernel/smpboot.c:266
secondary_startup_64_no_verify+0xce/0xdb

The buggy address belongs to the object at ffff88810cea10c0
which belongs to the cache task_struct of size 4032
The buggy address is located 2816 bytes inside of
4032-byte region [ffff88810cea10c0, ffff88810cea2080)

The buggy address belongs to the physical page:
page:ffffea000433a800 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x10cea0
head:ffffea000433a800 order:3 compound_mapcount:0 compound_pincount:0
flags: 0x8000000000010200(slab|head|zone=2)
raw: 8000000000010200 ffffea00042a5000 dead000000000002 ffff888100132280
raw: 0000000000000000 0000000080070007 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 2, tgid 2 (kthreadd), ts 2422520428, free_ts 0
set_page_owner include/linux/page_owner.h:31 [inline]
post_alloc_hook+0x15b/0x160 mm/page_alloc.c:2434
prep_new_page mm/page_alloc.c:2441 [inline]
get_page_from_freelist+0x3f6/0x8b0 mm/page_alloc.c:4182
__alloc_pages+0x3bd/0x850 mm/page_alloc.c:5408
allocate_slab+0x69/0x4d0 mm/slub.c:1944
new_slab mm/slub.c:2004 [inline]
___slab_alloc+0x2c2/0x6a0 mm/slub.c:3005
__slab_alloc+0x4a/0x90 mm/slub.c:3092
slab_alloc_node mm/slub.c:3183 [inline]
slab_alloc mm/slub.c:3225 [inline]
__kmem_cache_alloc_lru mm/slub.c:3232 [inline]
kmem_cache_alloc+0x20e/0x300 mm/slub.c:3242
kmem_cache_alloc_node include/linux/slab.h:453 [inline]
alloc_task_struct_node kernel/fork.c:172 [inline]
dup_task_struct+0x54/0x4a0 kernel/fork.c:971
copy_process+0x582/0x34c0 kernel/fork.c:2073
kernel_clone+0x224/0x8d0 kernel/fork.c:2644
kernel_thread+0x167/0x1e0 kernel/fork.c:2696
create_kthread kernel/kthread.c:399 [inline]
kthreadd+0x38d/0x4e0 kernel/kthread.c:745
ret_from_fork+0x1f/0x30
page_owner free stack trace missing

Memory state around the buggy address:
ffff88810cea1a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88810cea1b00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88810cea1b80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
^
ffff88810cea1c00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
ffff88810cea1c80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================


Tested on:

commit: cb93b320 DEBUG percpu-recount: Crude printk dumps
git tree: https://github.com/Werkov/linux.git cgroup-ml/css-lifecycle-syzbot
console output: https://syzkaller.appspot.com/x/log.txt?x=102151d3f00000
kernel config: https://syzkaller.appspot.com/x/.config?x=b58c85ce5be4e90e
dashboard link: https://syzkaller.appspot.com/bug?extid=e42ae441c3b10acf9e9d
compiler: Debian clang version 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU Binutils for Debian) 2.35.2

Note: no patches were applied.
Reply all
Reply to author
Forward
0 new messages