Hello,
syzbot has tested the proposed patch but the reproducer is still triggering an issue:
WARNING in firmware_fallback_sysfs
sysfs group 'power' not found for kobject 'ueagle-atm!eagleIII.fw'
WARNING: CPU: 1 PID: 3608 at fs/sysfs/group.c:278 sysfs_remove_group+0x126/0x170 fs/sysfs/group.c:278
Modules linked in:
CPU: 1 PID: 3608 Comm: kworker/1:3 Not tainted 5.18.0-rc1-syzkaller-00184-g1831fed55973 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events request_firmware_work_func
RIP: 0010:sysfs_remove_group+0x126/0x170 fs/sysfs/group.c:278
Code: 48 89 d9 49 8b 14 24 48 b8 00 00 00 00 00 fc ff df 48 c1 e9 03 80 3c 01 00 75 37 48 8b 33 48 c7 c7 c0 82 de 89 e8 0a e7 1a 07 <0f> 0b eb 98 e8 51 22 c5 ff e9 01 ff ff ff 48 89 df e8 44 22 c5 ff
RSP: 0018:ffffc90003ecfaa0 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffffff8a3edf20 RCX: 0000000000000000
RDX: ffff8880232f3a00 RSI: ffffffff815fccf8 RDI: fffff520007d9f46
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815f76ce R11: 0000000000000000 R12: ffff88807cfaa008
R13: ffffffff8a3ee4c0 R14: ffff88807cfaa008 R15: ffff8880223d0c00
FS: 0000000000000000(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f97ab6b1900 CR3: 000000001e296000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
dpm_sysfs_remove+0x97/0xb0 drivers/base/power/sysfs.c:837
device_del+0x20b/0xc80 drivers/base/core.c:3569
fw_load_sysfs_fallback drivers/base/firmware_loader/fallback.c:550 [inline]
fw_load_from_user_helper drivers/base/firmware_loader/fallback.c:588 [inline]
firmware_fallback_sysfs+0xa39/0xe70 drivers/base/firmware_loader/fallback.c:664
_request_firmware+0xb97/0xfe0 drivers/base/firmware_loader/main.c:774
request_firmware_work_func+0xdd/0x230 drivers/base/firmware_loader/main.c:1020
process_one_work+0x996/0x1610 kernel/workqueue.c:2289
worker_thread+0x665/0x1080 kernel/workqueue.c:2436
kthread+0x2e9/0x3a0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:298
</TASK>
Tested on:
commit: 1831fed5 Merge tag 'drm-fixes-2022-04-08' of git://ano..
console output:
https://syzkaller.appspot.com/x/log.txt?x=13d897f7700000
kernel config:
https://syzkaller.appspot.com/x/.config?x=29c1bcfee780952a
dashboard link:
https://syzkaller.appspot.com/bug?extid=95f2e2439b97575ec3c0
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
Note: no patches were applied.