Re: memory leak in get_device_parent

[syzbot]

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

ivers/infiniband/core/ib_core_uverbs.o
CC drivers/media/test-drivers/vivid/vivid-vid-common.o
CC drivers/infiniband/hw/mlx4/mcg.o
CC drivers/firmware/dmi_scan.o
AR drivers/firmware/xilinx/built-in.a
CC drivers/infiniband/core/trace.o
CC drivers/hid/usbhid/hiddev.o
CC drivers/firmware/dmi-id.o
CC fs/xfs/xfs_log.o
CC drivers/infiniband/sw/rdmavt/mr.o
CC drivers/infiniband/sw/rdmavt/pd.o
CC drivers/infiniband/ulp/ipoib/ipoib_ethtool.o
CC drivers/media/test-drivers/vivid/vivid-vbi-gen.o
CC drivers/media/test-drivers/vivid/vivid-vid-cap.o
CC drivers/media/rc/keymaps/rc-msi-tvanywhere.o
CC drivers/gpu/drm/i915/display/intel_dsi_vbt.o
CC drivers/infiniband/core/lag.o
CC drivers/infiniband/ulp/opa_vnic/opa_vnic_vema_iface.o
CC drivers/media/rc/keymaps/rc-msi-tvanywhere-plus.o
CC drivers/infiniband/hw/mlx4/cm.o
AR drivers/firmware/efi/built-in.a
CC drivers/infiniband/hw/mlx4/alias_GUID.o
CC drivers/infiniband/hw/mlx4/sysfs.o
AR drivers/infiniband/ulp/srp/built-in.a
CC drivers/media/test-drivers/vimc/vimc-scaler.o
CC drivers/media/test-drivers/vimc/vimc-sensor.o
AR drivers/dca/built-in.a
CC drivers/infiniband/sw/rdmavt/qp.o
CC drivers/media/test-drivers/vivid/vivid-vid-out.o
AR drivers/media/test-drivers/vicodec/built-in.a
CC drivers/gpu/drm/i915/display/intel_dvo.o
CC drivers/hid/hid-core.o
CC drivers/infiniband/core/security.o
CC drivers/media/rc/keymaps/rc-nebula.o
AR net/ncsi/built-in.a
CC drivers/hid/hid-input.o
CC drivers/vhost/net.o
CC drivers/infiniband/sw/rdmavt/rc.o
CC drivers/media/rc/keymaps/rc-nec-terratec-cinergy-xs.o
CC drivers/gpu/drm/i915/display/intel_gmbus.o
CC drivers/gpu/drm/i915/display/intel_hdmi.o
CC drivers/hid/usbhid/hid-pidff.o
CC drivers/hid/hid-quirks.o
CC drivers/infiniband/sw/rxe/rxe_req.o
AR drivers/staging/media/built-in.a
CC drivers/infiniband/sw/rxe/rxe_resp.o
CC drivers/infiniband/sw/rxe/rxe_recv.o
CC drivers/staging/android/ion/ion.o
CC drivers/media/test-drivers/vivid/vivid-kthread-cap.o
AR drivers/crypto/qat/qat_common/built-in.a
CC drivers/infiniband/core/cgroup.o
CC drivers/firmware/memmap.o
AR drivers/crypto/qat/built-in.a
AR drivers/infiniband/ulp/iser/built-in.a
CC drivers/infiniband/ulp/ipoib/ipoib_netlink.o
AR drivers/crypto/built-in.a
CC drivers/infiniband/core/cm.o
CC drivers/infiniband/sw/rdmavt/srq.o
CC drivers/gpu/drm/i915/display/intel_lspcon.o
CC drivers/infiniband/ulp/ipoib/ipoib_cm.o
CC drivers/infiniband/ulp/ipoib/ipoib_fs.o
CC drivers/gpu/drm/i915/display/intel_lvds.o
CC drivers/media/rc/keymaps/rc-norwood.o
CC fs/xfs/xfs_log_cil.o
CC drivers/hid/hid-debug.o
CC drivers/media/rc/keymaps/rc-npgtech.o
CC drivers/hid/hidraw.o
CC drivers/hid/uhid.o
CC drivers/infiniband/core/iwcm.o
CC drivers/infiniband/core/iwpm_util.o
AR drivers/media/test-drivers/vimc/built-in.a
CC drivers/gpu/drm/i915/display/intel_panel.o
CC drivers/infiniband/sw/rdmavt/trace.o
CC drivers/hid/hid-generic.o
CC drivers/media/rc/keymaps/rc-odroid.o
CC drivers/staging/android/ashmem.o
CC drivers/infiniband/core/iwpm_msg.o
CC drivers/gpu/drm/i915/display/intel_sdvo.o
CC drivers/vhost/vsock.o
CC drivers/hid/hid-a4tech.o
CC drivers/vhost/vhost.o
AR drivers/firmware/built-in.a
CC drivers/vhost/iotlb.o
AR drivers/infiniband/ulp/opa_vnic/built-in.a
CC drivers/infiniband/core/cma.o
CC drivers/media/rc/keymaps/rc-pctv-sedna.o
CC drivers/infiniband/sw/rxe/rxe_pool.o
CC net/devres.o
CC net/xdp/xsk.o
CC drivers/infiniband/core/cma_trace.o
CC net/xdp/xdp_umem.o
CC net/xdp/xskmap.o
CC net/xdp/xsk_queue.o
CC drivers/platform/x86/eeepc-laptop.o
CC fs/xfs/xfs_bmap_item.o
CC drivers/hid/hid-axff.o
CC net/socket.o
CC net/compat.o
CC drivers/hid/hid-apple.o
CC drivers/hid/hid-belkin.o
AR net/batman-adv/built-in.a
CC drivers/media/test-drivers/vivid/vivid-kthread-out.o
CC drivers/staging/android/ion/ion_heap.o
CC drivers/media/test-drivers/vivid/vivid-radio-rx.o
CC fs/xfs/xfs_buf_item.o
CC drivers/staging/android/ion/ion_system_heap.o
CC drivers/media/test-drivers/vivid/vivid-radio-tx.o
CC drivers/gpu/drm/i915/display/intel_tv.o
CC drivers/infiniband/core/cma_configfs.o
CC drivers/hid/hid-cherry.o
AR drivers/hid/usbhid/built-in.a
CC drivers/media/rc/keymaps/rc-pinnacle-color.o
CC drivers/infiniband/sw/rxe/rxe_queue.o
CC drivers/hid/hid-chicony.o
CC drivers/infiniband/core/user_mad.o
CC drivers/platform/x86/intel_menlow.o
CC drivers/platform/x86/i2c-multi-instantiate.o
CC drivers/hid/hid-cypress.o
CC drivers/platform/x86/pmc_atom.o
CC drivers/hid/hid-dr.o
CC drivers/platform/chrome/chromeos_pstore.o
CC drivers/platform/chrome/chromeos_laptop.o
CC drivers/media/rc/keymaps/rc-pinnacle-grey.o
CC drivers/platform/chrome/chromeos_tbmc.o
CC net/sysctl_net.o
CC drivers/media/rc/keymaps/rc-pinnacle-pctv-hd.o
CC drivers/infiniband/sw/rxe/rxe_verbs.o
CC fs/xfs/xfs_buf_item_recover.o
CC drivers/infiniband/sw/rxe/rxe_av.o
CC drivers/infiniband/sw/rxe/rxe_srq.o
CC drivers/infiniband/sw/rxe/rxe_qp.o
CC drivers/hid/hid-emsff.o
CC drivers/mailbox/mailbox.o
CC drivers/media/rc/keymaps/rc-pixelview.o
CC drivers/media/rc/keymaps/rc-pixelview-mk12.o
CC drivers/hid/hid-elecom.o
CC drivers/infiniband/sw/rxe/rxe_cq.o
CC drivers/staging/android/ion/ion_page_pool.o
CC net/xdp/xsk_buff_pool.o
CC drivers/infiniband/core/uverbs_main.o
CC drivers/mailbox/pcc.o
CC fs/xfs/xfs_dquot_item_recover.o
CC net/xdp/xsk_diag.o
CC fs/xfs/xfs_extfree_item.o
CC drivers/media/test-drivers/vivid/vivid-radio-common.o
CC drivers/hid/hid-ezkey.o
CC drivers/hid/hid-gyration.o
CC drivers/staging/android/ion/ion_cma_heap.o
CC drivers/media/rc/keymaps/rc-pixelview-002t.o
CC drivers/platform/chrome/cros_kbd_led_backlight.o
CC drivers/media/rc/keymaps/rc-pixelview-new.o
CC drivers/media/test-drivers/vivid/vivid-rds-gen.o
CC drivers/infiniband/sw/rxe/rxe_mr.o
CC drivers/hid/hid-holtek-kbd.o
CC drivers/media/rc/keymaps/rc-powercolor-real-angel.o
CC drivers/media/rc/keymaps/rc-proteus-2309.o
CC drivers/infiniband/core/uverbs_cmd.o
CC drivers/infiniband/sw/rxe/rxe_opcode.o
CC drivers/extcon/extcon.o
CC drivers/extcon/devres.o
CC drivers/media/rc/keymaps/rc-purpletv.o
CC drivers/media/test-drivers/vivid/vivid-sdr-cap.o
CC fs/xfs/xfs_icreate_item.o
CC drivers/infiniband/sw/rxe/rxe_mmap.o
CC drivers/gpu/drm/i915/display/intel_vdsc.o
AR drivers/infiniband/ulp/ipoib/built-in.a
AR drivers/infiniband/ulp/built-in.a
CC drivers/media/test-drivers/vivid/vivid-vbi-cap.o
CC drivers/infiniband/core/uverbs_marshall.o
CC drivers/infiniband/sw/rxe/rxe_icrc.o
CC drivers/infiniband/sw/rxe/rxe_mcast.o
CC drivers/media/rc/keymaps/rc-pv951.o
CC drivers/infiniband/sw/rxe/rxe_task.o
CC drivers/infiniband/sw/rxe/rxe_net.o
CC drivers/infiniband/sw/rxe/rxe_sysfs.o
CC fs/xfs/xfs_inode_item.o
AR drivers/platform/x86/built-in.a
CC drivers/infiniband/core/rdma_core.o
CC drivers/media/rc/keymaps/rc-hauppauge.o
CC drivers/media/rc/keymaps/rc-rc6-mce.o
CC drivers/hid/hid-holtek-mouse.o
CC drivers/media/rc/keymaps/rc-real-audio-220-32-keys.o
CC drivers/infiniband/sw/rxe/rxe_hw_counters.o
AR drivers/platform/chrome/built-in.a
AR drivers/perf/built-in.a
CC drivers/ras/ras.o
CC drivers/hid/hid-holtekff.o
AR drivers/platform/built-in.a
CC drivers/media/rc/keymaps/rc-reddo.o
CC fs/xfs/xfs_inode_item_recover.o
CC drivers/media/rc/keymaps/rc-snapstream-firefly.o
CC drivers/hid/hid-ite.o
CC fs/xfs/xfs_refcount_item.o
CC fs/xfs/xfs_rmap_item.o
CC drivers/infiniband/core/uverbs_std_types.o
AR drivers/staging/android/ion/built-in.a
CC drivers/media/test-drivers/vivid/vivid-vbi-out.o
CC drivers/media/test-drivers/vivid/vivid-meta-cap.o
CC drivers/media/test-drivers/vivid/vivid-osd.o
AR drivers/staging/android/built-in.a
CC drivers/media/rc/keymaps/rc-streamzap.o
CC drivers/media/test-drivers/vivid/vivid-meta-out.o
AR drivers/staging/built-in.a
CC drivers/gpu/drm/i915/display/vlv_dsi.o
CC drivers/infiniband/core/uverbs_ioctl.o
CC drivers/gpu/drm/i915/display/vlv_dsi_pll.o
AR drivers/mailbox/built-in.a
CC drivers/media/test-drivers/vivid/vivid-kthread-touch.o
CC drivers/ras/debugfs.o
AR drivers/vhost/built-in.a
CC drivers/gpu/drm/i915/i915_perf.o
CC drivers/media/rc/keymaps/rc-tango.o
CC drivers/media/rc/keymaps/rc-tanix-tx3mini.o
AR drivers/hwtracing/intel_th/built-in.a
AR drivers/infiniband/sw/rdmavt/built-in.a
CC drivers/hid/hid-kensington.o
CC drivers/media/test-drivers/vivid/vivid-touch-cap.o
AR drivers/infiniband/hw/mlx4/built-in.a
CC drivers/hid/hid-keytouch.o
AR drivers/infiniband/hw/built-in.a
CC drivers/media/rc/keymaps/rc-tanix-tx5max.o
CC drivers/media/rc/keymaps/rc-tbs-nec.o
CC drivers/hid/hid-kye.o
CC drivers/android/binder.o
CC drivers/counter/counter.o
CC drivers/android/binder_alloc.o
CC drivers/media/test-drivers/vivid/vivid-cec.o
CC fs/xfs/xfs_log_recover.o
CC fs/xfs/xfs_trans_ail.o
CC drivers/infiniband/core/uverbs_std_types_cq.o
CC drivers/gpu/drm/i915/i915_gpu_error.o
CC drivers/hid/hid-lcpower.o
CC drivers/hid/hid-lg.o
CC drivers/hid/hid-lgff.o
CC fs/xfs/xfs_trans_buf.o
CC drivers/media/rc/keymaps/rc-technisat-ts35.o
CC drivers/infiniband/core/uverbs_std_types_flow_action.o
CC drivers/infiniband/core/uverbs_std_types_dm.o
CC drivers/infiniband/core/uverbs_std_types_mr.o
CC drivers/hid/hid-lg2ff.o
CC drivers/infiniband/core/uverbs_std_types_counters.o
CC drivers/hid/hid-lg3ff.o
CC drivers/media/rc/keymaps/rc-technisat-usb2.o
AR net/xdp/built-in.a
CC drivers/media/rc/keymaps/rc-terratec-cinergy-c-pci.o
CC drivers/hid/hid-lg4ff.o
CC drivers/hid/hid-lg-g15.o
CC drivers/media/rc/keymaps/rc-terratec-cinergy-s2-hd.o
CC drivers/gpu/drm/i915/i915_vgpu.o
AR drivers/extcon/built-in.a
CC drivers/media/rc/keymaps/rc-terratec-cinergy-xs.o
CC drivers/infiniband/core/uverbs_uapi.o
CC drivers/hid/hid-logitech-dj.o
CC drivers/hid/hid-logitech-hidpp.o
CC drivers/media/rc/keymaps/rc-terratec-slim.o
CC drivers/hid/hid-magicmouse.o
CC drivers/media/rc/keymaps/rc-tevii-nec.o
CC drivers/media/rc/keymaps/rc-terratec-slim-2.o
CC drivers/infiniband/core/uverbs_std_types_device.o
CC drivers/infiniband/core/uverbs_std_types_async_fd.o
CC drivers/hid/hid-microsoft.o
CC drivers/media/rc/keymaps/rc-tivo.o
CC drivers/hid/hid-monterey.o
CC fs/xfs/xfs_dquot.o
CC fs/xfs/xfs_dquot_item.o
CC drivers/hid/hid-multitouch.o
CC drivers/infiniband/core/uverbs_std_types_srq.o
CC drivers/hid/hid-ntrig.o
CC drivers/infiniband/core/uverbs_std_types_qp.o
CC fs/xfs/xfs_trans_dquot.o
CC drivers/infiniband/core/uverbs_std_types_wq.o
CC drivers/hid/hid-ortek.o
CC drivers/hid/hid-prodikeys.o
CC drivers/infiniband/core/umem.o
CC fs/xfs/xfs_qm_syscalls.o
AR drivers/ras/built-in.a
AR drivers/infiniband/sw/rxe/built-in.a
CC fs/xfs/xfs_qm_bhv.o
CC drivers/hid/hid-pl.o
AR drivers/infiniband/sw/built-in.a
CC drivers/infiniband/core/umem_odp.o
CC drivers/media/rc/keymaps/rc-total-media-in-hand.o
CC drivers/infiniband/core/ucma.o
CC drivers/hid/hid-petalynx.o
AR drivers/media/test-drivers/vivid/built-in.a
CC drivers/media/rc/keymaps/rc-total-media-in-hand-02.o
AR drivers/media/test-drivers/built-in.a
CC fs/xfs/xfs_qm.o
CC drivers/hid/hid-picolcd_core.o
CC drivers/hid/hid-picolcd_debugfs.o
CC fs/xfs/xfs_quotaops.o
CC drivers/media/rc/keymaps/rc-trekstor.o
CC drivers/media/rc/keymaps/rc-tt-1500.o
CC drivers/hid/hid-plantronics.o
CC fs/xfs/xfs_rtalloc.o
CC fs/xfs/xfs_acl.o
AR net/built-in.a
AR drivers/counter/built-in.a
CC fs/xfs/xfs_sysctl.o
CC drivers/hid/hid-primax.o
CC drivers/hid/hid-roccat.o
CC drivers/media/rc/keymaps/rc-twinhan-dtv-cab-ci.o
CC drivers/media/rc/keymaps/rc-vega-s9x.o
CC drivers/media/rc/keymaps/rc-twinhan1027.o
CC fs/xfs/xfs_ioctl32.o
CC drivers/hid/hid-roccat-common.o
CC drivers/media/rc/keymaps/rc-videomate-m1f.o
CC fs/xfs/xfs_pnfs.o
CC drivers/hid/hid-roccat-arvo.o
CC drivers/hid/hid-roccat-isku.o
CC drivers/hid/hid-roccat-kone.o
CC drivers/hid/hid-roccat-koneplus.o
CC drivers/media/rc/keymaps/rc-videomate-tv-pvr.o
CC drivers/media/rc/keymaps/rc-videomate-s350.o
CC drivers/hid/hid-roccat-konepure.o
CC drivers/media/rc/keymaps/rc-videostrong-kii-pro.o
CC drivers/hid/hid-roccat-kovaplus.o
CC drivers/media/rc/keymaps/rc-wetek-hub.o
CC drivers/media/rc/keymaps/rc-wetek-play2.o
CC drivers/media/rc/keymaps/rc-winfast.o
CC drivers/hid/hid-roccat-lua.o
CC drivers/media/rc/keymaps/rc-winfast-usbii-deluxe.o
CC drivers/media/rc/keymaps/rc-su3000.o
CC drivers/media/rc/keymaps/rc-xbox-dvd.o
CC drivers/hid/hid-roccat-pyra.o
CC drivers/hid/hid-roccat-ryos.o
CC drivers/hid/hid-roccat-savu.o
CC drivers/hid/hid-rmi.o
CC drivers/hid/hid-saitek.o
CC drivers/hid/hid-samsung.o
CC drivers/hid/hid-sjoy.o
CC drivers/media/rc/keymaps/rc-x96max.o
CC drivers/media/rc/keymaps/rc-zx-irdec.o
CC drivers/hid/hid-sony.o
CC drivers/hid/hid-speedlink.o
CC drivers/hid/hid-sunplus.o
CC drivers/hid/hid-gaff.o
CC drivers/hid/hid-tmff.o
CC drivers/hid/hid-tivo.o
CC drivers/hid/hid-topseed.o
CC drivers/hid/hid-uclogic-core.o
CC drivers/hid/hid-twinhan.o
CC drivers/hid/hid-uclogic-rdesc.o
CC drivers/hid/hid-uclogic-params.o
CC drivers/hid/hid-led.o
CC drivers/hid/hid-zydacron.o
CC drivers/hid/hid-zpff.o
CC drivers/hid/wacom_wac.o
CC drivers/hid/wacom_sys.o
CC drivers/hid/hid-waltop.o
CC drivers/hid/hid-wiimote-core.o
CC drivers/hid/hid-wiimote-modules.o
CC drivers/hid/hid-wiimote-debug.o
AR drivers/gpu/drm/i915/built-in.a
AR drivers/gpu/drm/built-in.a
AR drivers/gpu/built-in.a
AR drivers/media/rc/keymaps/built-in.a
AR drivers/media/rc/built-in.a
AR drivers/media/built-in.a
AR drivers/infiniband/core/built-in.a
AR drivers/infiniband/built-in.a
AR drivers/hid/built-in.a
AR fs/xfs/built-in.a
AR fs/built-in.a
AR drivers/android/built-in.a
AR drivers/built-in.a
GEN .version
CHK include/generated/compile.h
LD vmlinux.o
MODPOST vmlinux.symvers
MODINFO modules.builtin.modinfo
GEN modules.builtin
BTF: .tmp_vmlinux.btf: pahole version v1.9 is too old, need at least v1.16
Failed to generate BTF for vmlinux
Try to disable CONFIG_DEBUG_INFO_BTF
Makefile:1162: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1


Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=10e7bac5900000


Tested on:

commit: c9c9e6a4 Merge tag 'trace-v5.9-rc5-2' of git://git.kernel...
git tree: upstream
dashboard link: https://syzkaller.appspot.com/bug?extid=02e97e2ad931a981e568
compiler: gcc (GCC) 10.1.0-syz 20200507

[Dmitry Vyukov]

This commit should work-around this btf problem:
https://github.com/google/syzkaller/commits/2d5ea0cb6edb828803beea8af38dbc04dc80f028

Let's try again:

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master

> --
> You received this message because you are subscribed to the Google Groups "syzkaller-bugs" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to syzkaller-bug...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/syzkaller-bugs/000000000000090cbd05b00779fb%40google.com.

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+02e97e...@syzkaller.appspotmail.com

Tested on:

commit: a1bffa48 Merge tag 'scsi-fixes' of git://git.kernel.org/pu..
git tree: upstream
kernel config: https://syzkaller.appspot.com/x/.config?x=90d19cefb5518834

dashboard link: https://syzkaller.appspot.com/bug?extid=02e97e2ad931a981e568
compiler: gcc (GCC) 10.1.0-syz 20200507

Note: testing is done by a robot and is best-effort only.