[syzbot] [bcachefs?] kernel BUG in bch2_journal_replay (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: fbfd64d25c7a Merge tag 'vfs-6.13-rc7.fixes' of git://git.k..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=14c9a4b0580000
kernel config: https://syzkaller.appspot.com/x/.config?x=4ef22c4fce5135b4
dashboard link: https://syzkaller.appspot.com/bug?extid=a3885f6d294f83923567
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-fbfd64d2.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/ae42c226ccad/vmlinux-fbfd64d2.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1fe6ec294113/bzImage-fbfd64d2.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+a3885f...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 32768
bcachefs (/dev/loop0): error reading default superblock: Not a bcachefs superblock (got magic c68573f6-4e1a-45ca-8265-f50d00000000)
bcachefs (loop0): starting version 0.775: (unknown version) opts=metadata_checksum=none,data_checksum=none,compression=lz4,nojournal_transaction_names
bcachefs (loop0): recovering from clean shutdown, journal seq 18446744073709550602
bcachefs (loop0): accounting_read... done
bcachefs (loop0): alloc_read... done
bcachefs (loop0): stripes_read... done
bcachefs (loop0): snapshots_read... done
bcachefs (loop0): going read-write
bcachefs (loop0): journal_replay...
------------[ cut here ]------------
kernel BUG at fs/bcachefs/recovery.c:130!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI
CPU: 0 UID: 0 PID: 5313 Comm: syz.0.0 Not tainted 6.13.0-rc6-syzkaller-00036-gfbfd64d25c7a #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:replay_now_at fs/bcachefs/recovery.c:130 [inline]
RIP: 0010:bch2_journal_replay+0x2a09/0x2a40 fs/bcachefs/recovery.c:346
Code: 9d f5 7d 07 e8 d8 9f 54 fd 90 0f 0b e8 d0 9f 54 fd 90 0f 0b e8 c8 9f 54 fd 90 0f 0b e8 c0 9f 54 fd 90 0f 0b e8 b8 9f 54 fd 90 <0f> 0b e8 b0 9f 54 fd 90 0f 0b e8 a8 9f 54 fd 90 0f 0b e8 a0 9f 54
RSP: 0018:ffffc9002301f180 EFLAGS: 00010287
RAX: ffffffff844ae468 RBX: fffffffffffffc0b RCX: 0000000000100000
RDX: ffffc9000e762000 RSI: 000000000005e908 RDI: 000000000005e909
RBP: ffffc9002301f478 R08: ffffffff844ad9d9 R09: ffffffff84beb7ff
R10: 0000000000000004 R11: ffffffff844af370 R12: ffff8880375cabb8
R13: dffffc0000000000 R14: 00000000ffffffff R15: ffff8880375cabc0
FS: 00007f599b12f6c0(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055fa4fa70200 CR3: 0000000033f4c000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
bch2_run_recovery_pass+0xf0/0x1e0 fs/bcachefs/recovery_passes.c:191
bch2_run_recovery_passes+0x3a7/0x880 fs/bcachefs/recovery_passes.c:244
bch2_fs_recovery+0x25cc/0x39d0 fs/bcachefs/recovery.c:861
bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1037
bch2_fs_get_tree+0xd68/0x1710 fs/bcachefs/fs.c:2170
vfs_get_tree+0x90/0x2b0 fs/super.c:1814
do_new_mount+0x2be/0xb40 fs/namespace.c:3513
do_mount fs/namespace.c:3853 [inline]
__do_sys_mount fs/namespace.c:4063 [inline]
__se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4040
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f599a3874ca
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f599b12ee68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f599b12eef0 RCX: 00007f599a3874ca
RDX: 00000000200000c0 RSI: 0000000020000080 RDI: 00007f599b12eeb0
RBP: 00000000200000c0 R08: 00007f599b12eef0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000020000080
R13: 00007f599b12eeb0 R14: 00000000000059b2 R15: 0000000020000100
</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:replay_now_at fs/bcachefs/recovery.c:130 [inline]
RIP: 0010:bch2_journal_replay+0x2a09/0x2a40 fs/bcachefs/recovery.c:346
Code: 9d f5 7d 07 e8 d8 9f 54 fd 90 0f 0b e8 d0 9f 54 fd 90 0f 0b e8 c8 9f 54 fd 90 0f 0b e8 c0 9f 54 fd 90 0f 0b e8 b8 9f 54 fd 90 <0f> 0b e8 b0 9f 54 fd 90 0f 0b e8 a8 9f 54 fd 90 0f 0b e8 a0 9f 54
RSP: 0018:ffffc9002301f180 EFLAGS: 00010287
RAX: ffffffff844ae468 RBX: fffffffffffffc0b RCX: 0000000000100000
RDX: ffffc9000e762000 RSI: 000000000005e908 RDI: 000000000005e909
RBP: ffffc9002301f478 R08: ffffffff844ad9d9 R09: ffffffff84beb7ff
R10: 0000000000000004 R11: ffffffff844af370 R12: ffff8880375cabb8
R13: dffffc0000000000 R14: 00000000ffffffff R15: ffff8880375cabc0
FS: 00007f599b12f6c0(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055fa4fa70200 CR3: 0000000033f4c000 CR4: 0000000000352ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: ad26fc09dabf Merge tag 'mm-hotfixes-stable-2025-01-16-21-1..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=104fe1f8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=aadf89e2f6db86cc

dashboard link: https://syzkaller.appspot.com/bug?extid=a3885f6d294f83923567
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17ceba18580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=137ee9df980000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-ad26fc09.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/e8c59e9a573f/vmlinux-ad26fc09.xz
kernel image: https://storage.googleapis.com/syzbot-assets/8bfa2df81410/bzImage-ad26fc09.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/8485647a2ac3/mount_1.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+a3885f...@syzkaller.appspotmail.com

new u64s 5 type deleted 14293651161087:U64_MAX:U32_MAX len 0 ver 0
bcachefs (loop0): bch2_btree_update_start(): error EIO
bcachefs (loop0): bch2_btree_update_start(): error EIO

------------[ cut here ]------------
kernel BUG at fs/bcachefs/recovery.c:130!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI

CPU: 0 UID: 0 PID: 5306 Comm: syz-executor276 Not tainted 6.13.0-rc7-syzkaller-00160-gad26fc09dabf #0

Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:replay_now_at fs/bcachefs/recovery.c:130 [inline]
RIP: 0010:bch2_journal_replay+0x2a09/0x2a40 fs/bcachefs/recovery.c:346

Code: cd 35 7e 07 e8 68 9e 54 fd 90 0f 0b e8 60 9e 54 fd 90 0f 0b e8 58 9e 54 fd 90 0f 0b e8 50 9e 54 fd 90 0f 0b e8 48 9e 54 fd 90 <0f> 0b e8 40 9e 54 fd 90 0f 0b e8 38 9e 54 fd 90 0f 0b e8 30 9e 54
RSP: 0018:ffffc9000d297180 EFLAGS: 00010293
RAX: ffffffff844ae428 RBX: ff0000000000000b RCX: ffff88801f6b0000
RDX: 0000000000000000 RSI: 00000000ffffffff RDI: ff0000000000000b
RBP: ffffc9000d297478 R08: ffffffff844ad999 R09: ffffffff84beba5f
R10: 0000000000000004 R11: ffff88801f6b0000 R12: ffff888044a4abb8
R13: dffffc0000000000 R14: 00000000ffffffff R15: ffff888044a4abc0
FS: 000055555a053380(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 000055fd59292098 CR3: 0000000043c6e000 CR4: 0000000000352ef0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
bch2_run_recovery_pass+0xf0/0x1e0 fs/bcachefs/recovery_passes.c:191
bch2_run_recovery_passes+0x3a7/0x880 fs/bcachefs/recovery_passes.c:244
bch2_fs_recovery+0x25cc/0x39d0 fs/bcachefs/recovery.c:861
bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1037
bch2_fs_get_tree+0xd68/0x1710 fs/bcachefs/fs.c:2170
vfs_get_tree+0x90/0x2b0 fs/super.c:1814

do_new_mount+0x2be/0xb40 fs/namespace.c:3511
do_mount fs/namespace.c:3851 [inline]
__do_sys_mount fs/namespace.c:4061 [inline]
__se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4038

do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

RIP: 0033:0x7f1e71c47dfa
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 5e 04 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffde82bfb88 EFLAGS: 00000282 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ffde82bfba0 RCX: 00007f1e71c47dfa
RDX: 00000000200058c0 RSI: 0000000020000140 RDI: 00007ffde82bfba0
RBP: 0000000000004800 R08: 00007ffde82bfbe0 R09: 0000000000005a2b
R10: 0000000000004800 R11: 0000000000000282 R12: 0000000000000005
R13: 00007ffde82bfbe0 R14: 0000000000000004 R15: 0000000001000000

</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:replay_now_at fs/bcachefs/recovery.c:130 [inline]
RIP: 0010:bch2_journal_replay+0x2a09/0x2a40 fs/bcachefs/recovery.c:346

Code: cd 35 7e 07 e8 68 9e 54 fd 90 0f 0b e8 60 9e 54 fd 90 0f 0b e8 58 9e 54 fd 90 0f 0b e8 50 9e 54 fd 90 0f 0b e8 48 9e 54 fd 90 <0f> 0b e8 40 9e 54 fd 90 0f 0b e8 38 9e 54 fd 90 0f 0b e8 30 9e 54
RSP: 0018:ffffc9000d297180 EFLAGS: 00010293
RAX: ffffffff844ae428 RBX: ff0000000000000b RCX: ffff88801f6b0000
RDX: 0000000000000000 RSI: 00000000ffffffff RDI: ff0000000000000b
RBP: ffffc9000d297478 R08: ffffffff844ad999 R09: ffffffff84beba5f
R10: 0000000000000004 R11: ffff88801f6b0000 R12: ffff888044a4abb8
R13: dffffc0000000000 R14: 00000000ffffffff R15: ffff888044a4abc0
FS: 000055555a053380(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 000055fd59292098 CR3: 0000000043c6e000 CR4: 0000000000352ef0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400


---

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[I Hsin Cheng]

#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git ad26fc09dabf

diff --git a/fs/bcachefs/recovery.c b/fs/bcachefs/recovery.c
index 71c786cdb192..e4a538de0943 100644
--- a/fs/bcachefs/recovery.c
+++ b/fs/bcachefs/recovery.c
@@ -183,6 +183,7 @@ static void zero_out_btree_mem_ptr(struct journal_keys *keys)

static void replay_now_at(struct journal *j, u64 seq)
{
+ pr_err("seq = %llu, replay_journal_seq = %llu\n", seq, j->replay_journal_seq);
BUG_ON(seq < j->replay_journal_seq);

seq = min(seq, j->replay_journal_seq_end);

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
kernel BUG in bch2_journal_replay

bcachefs (loop0): bch2_btree_update_start(): error EIO

bcachefs: replay_now_at() seq = 4294967295, replay_journal_seq = 18374686479671623691
------------[ cut here ]------------
kernel BUG at fs/bcachefs/recovery.c:131!

Oops: invalid opcode: 0000 [#1] PREEMPT SMP KASAN NOPTI

CPU: 0 UID: 0 PID: 5813 Comm: syz.0.16 Not tainted 6.13.0-rc7-syzkaller-00160-gad26fc09dabf-dirty #0

Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014

RIP: 0010:replay_now_at fs/bcachefs/recovery.c:131 [inline]
RIP: 0010:bch2_journal_replay+0x2ae5/0x2b10 fs/bcachefs/recovery.c:347
Code: fd 90 0f 0b e8 8c 9d 54 fd 90 0f 0b e8 84 9d 54 fd 90 0f 0b e8 7c 9d 54 fd 90 0f 0b e8 74 9d 54 fd 90 0f 0b e8 6c 9d 54 fd 90 <0f> 0b e8 64 9d 54 fd 90 0f 0b e8 5c 9d 54 fd 90 0f 0b e8 54 9d 54
RSP: 0018:ffffc900028d7180 EFLAGS: 00010293
RAX: ffffffff844ae504 RBX: ff0000000000000b RCX: ffff888000c9a440

RDX: 0000000000000000 RSI: 00000000ffffffff RDI: ff0000000000000b

RBP: ffffc900028d7478 R08: ffffffff844adb29 R09: 1ffff9200051adcc
R10: dffffc0000000000 R11: fffff5200051adcd R12: ffff88804b4cabb8
R13: dffffc0000000000 R14: ffff88804b4cabc0 R15: 00000000ffffffff
FS: 00007ff25c6246c0(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 000055bfa0a02048 CR3: 000000003f8a4000 CR4: 0000000000352ef0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
bch2_run_recovery_pass+0xf0/0x1e0 fs/bcachefs/recovery_passes.c:191
bch2_run_recovery_passes+0x3a7/0x880 fs/bcachefs/recovery_passes.c:244

bch2_fs_recovery+0x25cc/0x39d0 fs/bcachefs/recovery.c:862

bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1037
bch2_fs_get_tree+0xd68/0x1710 fs/bcachefs/fs.c:2170
vfs_get_tree+0x90/0x2b0 fs/super.c:1814
do_new_mount+0x2be/0xb40 fs/namespace.c:3511
do_mount fs/namespace.c:3851 [inline]
__do_sys_mount fs/namespace.c:4061 [inline]
__se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4038
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

RIP: 0033:0x7ff25b7874ca
Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff25c623e68 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ff25c623ef0 RCX: 00007ff25b7874ca
RDX: 00000000200058c0 RSI: 0000000020000140 RDI: 00007ff25c623eb0
RBP: 00000000200058c0 R08: 00007ff25c623ef0 R09: 0000000000004800
R10: 0000000000004800 R11: 0000000000000246 R12: 0000000020000140
R13: 00007ff25c623eb0 R14: 0000000000005a31 R15: 0000000020000180

</TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---

RIP: 0010:replay_now_at fs/bcachefs/recovery.c:131 [inline]
RIP: 0010:bch2_journal_replay+0x2ae5/0x2b10 fs/bcachefs/recovery.c:347
Code: fd 90 0f 0b e8 8c 9d 54 fd 90 0f 0b e8 84 9d 54 fd 90 0f 0b e8 7c 9d 54 fd 90 0f 0b e8 74 9d 54 fd 90 0f 0b e8 6c 9d 54 fd 90 <0f> 0b e8 64 9d 54 fd 90 0f 0b e8 5c 9d 54 fd 90 0f 0b e8 54 9d 54
RSP: 0018:ffffc900028d7180 EFLAGS: 00010293
RAX: ffffffff844ae504 RBX: ff0000000000000b RCX: ffff888000c9a440

RDX: 0000000000000000 RSI: 00000000ffffffff RDI: ff0000000000000b

RBP: ffffc900028d7478 R08: ffffffff844adb29 R09: 1ffff9200051adcc
R10: dffffc0000000000 R11: fffff5200051adcd R12: ffff88804b4cabb8
R13: dffffc0000000000 R14: ffff88804b4cabc0 R15: 00000000ffffffff
FS: 00007ff25c6246c0(0000) GS:ffff88801fc00000(0000) knlGS:0000000000000000

CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033

CR2: 000055bfa0a02048 CR3: 000000003f8a4000 CR4: 0000000000352ef0

DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Tested on:

commit: ad26fc09 Merge tag 'mm-hotfixes-stable-2025-01-16-21-1..
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
console output: https://syzkaller.appspot.com/x/log.txt?x=14532b4c580000

kernel config: https://syzkaller.appspot.com/x/.config?x=aadf89e2f6db86cc
dashboard link: https://syzkaller.appspot.com/bug?extid=a3885f6d294f83923567
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

patch: https://syzkaller.appspot.com/x/patch.diff?x=175e423f980000

[syzbot]

Auto-closing this bug as obsolete.
No recent activity, existing reproducers are no longer triggering the issue.