[syzbot] [f2fs?] UBSAN: array-index-out-of-bounds in read_inline_xattr

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 7af08b57bcb9 Merge tag 'trace-v6.13-2' of git://git.kernel..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1519f3c0580000
kernel config: https://syzkaller.appspot.com/x/.config?x=3891b550f14aea0f
dashboard link: https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-7af08b57.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/63d6781734c3/vmlinux-7af08b57.xz
kernel image: https://storage.googleapis.com/syzbot-assets/f3bd17982594/bzImage-7af08b57.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+69f537...@syzkaller.appspotmail.com

loop0: detected capacity change from 0 to 131072
F2FS-fs (loop0): Invalid Fs Meta Ino: node(13) meta(0) root(3)
F2FS-fs (loop0): Can't find valid F2FS filesystem in 2th superblock
F2FS-fs (loop0): Found nat_bits in checkpoint
F2FS-fs (loop0): Try to recover 2th superblock, ret: 0
F2FS-fs (loop0): Mounted with checkpoint version = 1b41e955
------------[ cut here ]------------
UBSAN: array-index-out-of-bounds in fs/f2fs/f2fs.h:3292:19
index 18446744073709550491 is out of range for type '__le32[923]' (aka 'unsigned int[923]')
CPU: 0 UID: 0 PID: 5338 Comm: syz.0.0 Not tainted 6.12.0-syzkaller-10689-g7af08b57bcb9 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
ubsan_epilogue lib/ubsan.c:231 [inline]
__ubsan_handle_out_of_bounds+0x121/0x150 lib/ubsan.c:429
read_inline_xattr+0x273/0x280
lookup_all_xattrs fs/f2fs/xattr.c:341 [inline]
f2fs_getxattr+0x57b/0x13b0 fs/f2fs/xattr.c:533
vfs_getxattr_alloc+0x472/0x5c0 fs/xattr.c:393
ima_read_xattr+0x38/0x60 security/integrity/ima/ima_appraise.c:229
process_measurement+0x117a/0x1fb0 security/integrity/ima/ima_main.c:353
ima_file_check+0xd9/0x120 security/integrity/ima/ima_main.c:572
security_file_post_open+0xb9/0x280 security/security.c:3121
do_open fs/namei.c:3830 [inline]
path_openat+0x2ccd/0x3590 fs/namei.c:3987
do_file_open_root+0x3a7/0x720 fs/namei.c:4039
file_open_root+0x247/0x2a0 fs/open.c:1382
do_handle_open+0x85b/0x9d0 fs/fhandle.c:414
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f4a4bf80849
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4a4cd52058 EFLAGS: 00000246 ORIG_RAX: 0000000000000130
RAX: ffffffffffffffda RBX: 00007f4a4c145fa0 RCX: 00007f4a4bf80849
RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000000000003
RBP: 00007f4a4bff3986 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f4a4c145fa0 R15: 00007ffd9526f5d8
</TASK>
---[ end trace ]---


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: bcde95ce32b6 Merge tag 'devicetree-fixes-for-6.13-1' of gi..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=116c0adf980000
kernel config: https://syzkaller.appspot.com/x/.config?x=1234f097ee657d8b

dashboard link: https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=167f9f30580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=142d7cf8580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/be6d4de70f82/disk-bcde95ce.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/70993500a1e4/vmlinux-bcde95ce.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1018443184c5/bzImage-bcde95ce.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/7e1b134be79c/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+69f537...@syzkaller.appspotmail.com

F2FS-fs (loop0): Failed to enable quota tracking (type=1, err=-22). Please run fsck to fix.
F2FS-fs (loop0): Cannot turn on quotas: error -22
F2FS-fs (loop0): Mounted with checkpoint version = 1b41e954

------------[ cut here ]------------
UBSAN: array-index-out-of-bounds in fs/f2fs/f2fs.h:3292:19

index 18446744073709500059 is out of range for type '__le32[923]' (aka 'unsigned int[923]')
CPU: 0 UID: 0 PID: 5820 Comm: syz-executor178 Not tainted 6.13.0-rc3-syzkaller-00301-gbcde95ce32b6 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024

Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:94 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
ubsan_epilogue lib/ubsan.c:231 [inline]
__ubsan_handle_out_of_bounds+0x121/0x150 lib/ubsan.c:429
read_inline_xattr+0x273/0x280
lookup_all_xattrs fs/f2fs/xattr.c:341 [inline]
f2fs_getxattr+0x57b/0x13b0 fs/f2fs/xattr.c:533

__vfs_getxattr+0x433/0x470 fs/xattr.c:423
smk_fetch+0xb1/0x140 security/smack/smack_lsm.c:306
smack_d_instantiate+0x749/0xa50 security/smack/smack_lsm.c:3615
security_d_instantiate+0x107/0x1f0 security/security.c:4070
d_splice_alias+0x6f/0x330 fs/dcache.c:3001
f2fs_lookup+0x4ff/0x820 fs/f2fs/namei.c:523
lookup_one_qstr_excl+0x11f/0x260 fs/namei.c:1692
filename_create+0x297/0x540 fs/namei.c:4081
do_mkdirat+0xbd/0x3a0 fs/namei.c:4326
__do_sys_mkdir fs/namei.c:4354 [inline]
__se_sys_mkdir fs/namei.c:4352 [inline]
__x64_sys_mkdir+0x6c/0x80 fs/namei.c:4352

do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

RIP: 0033:0x7f5566117ad7
Code: ff ff 77 07 31 c0 c3 0f 1f 40 00 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 b8 53 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff7eab6a58 EFLAGS: 00000246 ORIG_RAX: 0000000000000053
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f5566117ad7
RDX: 0000000000000000 RSI: 00000000000001ff RDI: 0000000020000180
RBP: 0000000020000180 R08: 0000000000000000 R09: 0000000000000000

R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000

R13: 00007fff7eab6af0 R14: 0000000000000000 R15: 0000000000000000

</TASK>
---[ end trace ]---


---

If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[syzbot]

syzbot has bisected this issue to:

commit 388a2a0640e16a8887f0d47dab207f344fbdb913
Author: Chao Yu <ch...@kernel.org>
Date: Thu Jun 6 09:55:51 2024 +0000

f2fs: remove redundant sanity check in sanity_check_inode()

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14bffcf8580000
start commit: bcde95ce32b6 Merge tag 'devicetree-fixes-for-6.13-1' of gi..
git tree: upstream
final oops: https://syzkaller.appspot.com/x/report.txt?x=16bffcf8580000
console output: https://syzkaller.appspot.com/x/log.txt?x=12bffcf8580000

kernel config: https://syzkaller.appspot.com/x/.config?x=1234f097ee657d8b
dashboard link: https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=112b98c4580000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16fd7cf8580000

Reported-by: syzbot+69f537...@syzkaller.appspotmail.com
Fixes: 388a2a0640e1 ("f2fs: remove redundant sanity check in sanity_check_inode()")

For information about bisection process see: https://goo.gl/tpsmEJ#bisection

[Chao Yu]

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip

[syzbot]

Hello,

syzbot tried to test the proposed patch but the build/boot failed:

fs/f2fs/segment.c:5541:6: error: call to undeclared function 'unlike'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration]


Tested on:

commit: 7d46ca6d f2fs: fix to avoid return invalid mtime from ..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip

kernel config: https://syzkaller.appspot.com/x/.config?x=1234f097ee657d8b
dashboard link: https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.

[Chao Yu]

#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip

On 2024/12/23 3:13, syzbot wrote:

[syzbot]

Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-by: syzbot+69f537...@syzkaller.appspotmail.com
Tested-by: syzbot+69f537...@syzkaller.appspotmail.com

Tested on:

commit: 6f121821 f2fs: fix to avoid return invalid mtime from ..

git tree: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip

console output: https://syzkaller.appspot.com/x/log.txt?x=12fbe2f8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=91c852e3d1d7c1a6

dashboard link: https://syzkaller.appspot.com/bug?extid=69f5379a1717a0b982a1
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.

Note: testing is done by a robot and is best-effort only.