[syzbot] [bcachefs?] KMSAN: uninit-value in bch2_alloc_v4_validate (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit: 3022e9d00ebe Merge tag 'sched_ext-for-6.12-rc7-fixes' of g..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=175f0df7980000
kernel config: https://syzkaller.appspot.com/x/.config?x=dcca673786a14715
dashboard link: https://syzkaller.appspot.com/bug?extid=8dd95f470e7cd0ff4b66
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
userspace arch: i386

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/937339c4ba17/disk-3022e9d0.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/23acd73c301b/vmlinux-3022e9d0.xz
kernel image: https://storage.googleapis.com/syzbot-assets/66d14471611f/bzImage-3022e9d0.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8dd95f...@syzkaller.appspotmail.com

=====================================================
BUG: KMSAN: uninit-value in bch2_alloc_v4_validate+0x739/0x19a0 fs/bcachefs/alloc_background.c:249
bch2_alloc_v4_validate+0x739/0x19a0 fs/bcachefs/alloc_background.c:249
bch2_bkey_val_validate+0x2b5/0x440 fs/bcachefs/bkey_methods.c:143
bset_key_validate fs/bcachefs/btree_io.c:845 [inline]
validate_bset_keys+0x1531/0x2080 fs/bcachefs/btree_io.c:914
validate_bset_for_write+0x142/0x290 fs/bcachefs/btree_io.c:1946
__bch2_btree_node_write+0x53df/0x6830 fs/bcachefs/btree_io.c:2156
bch2_btree_node_write+0x256/0x2e0 fs/bcachefs/btree_io.c:2300
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
__bch2_journal_reclaim+0xda8/0x1670 fs/bcachefs/journal_reclaim.c:698
bch2_journal_reclaim_thread+0x18e/0x760 fs/bcachefs/journal_reclaim.c:740
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was stored to memory at:
bch2_alloc_v4_validate+0x27f/0x19a0 fs/bcachefs/alloc_background.c:247
bch2_bkey_val_validate+0x2b5/0x440 fs/bcachefs/bkey_methods.c:143
bset_key_validate fs/bcachefs/btree_io.c:845 [inline]
validate_bset_keys+0x1531/0x2080 fs/bcachefs/btree_io.c:914
validate_bset_for_write+0x142/0x290 fs/bcachefs/btree_io.c:1946
__bch2_btree_node_write+0x53df/0x6830 fs/bcachefs/btree_io.c:2156
bch2_btree_node_write+0x256/0x2e0 fs/bcachefs/btree_io.c:2300
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
__bch2_journal_reclaim+0xda8/0x1670 fs/bcachefs/journal_reclaim.c:698
bch2_journal_reclaim_thread+0x18e/0x760 fs/bcachefs/journal_reclaim.c:740
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was stored to memory at:
memcpy_u64s_small fs/bcachefs/util.h:393 [inline]
bkey_p_copy fs/bcachefs/bkey.h:47 [inline]
bch2_sort_keys_keep_unwritten_whiteouts+0x16af/0x19d0 fs/bcachefs/bkey_sort.c:187
__bch2_btree_node_write+0x3ae8/0x6830 fs/bcachefs/btree_io.c:2099
bch2_btree_node_write+0x256/0x2e0 fs/bcachefs/btree_io.c:2300
btree_node_write_if_need fs/bcachefs/btree_io.h:151 [inline]
__btree_node_flush+0x606/0x680 fs/bcachefs/btree_trans_commit.c:252
bch2_btree_node_flush1+0x38/0x60 fs/bcachefs/btree_trans_commit.c:266
journal_flush_pins+0xce6/0x1780 fs/bcachefs/journal_reclaim.c:565
__bch2_journal_reclaim+0xda8/0x1670 fs/bcachefs/journal_reclaim.c:698
bch2_journal_reclaim_thread+0x18e/0x760 fs/bcachefs/journal_reclaim.c:740
kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was created at:
___kmalloc_large_node+0x22c/0x370 mm/slub.c:4219
__kmalloc_large_node_noprof+0x3f/0x1e0 mm/slub.c:4236
__do_kmalloc_node mm/slub.c:4252 [inline]
__kmalloc_node_noprof+0x9d6/0xf50 mm/slub.c:4270
__kvmalloc_node_noprof+0xc0/0x2d0 mm/util.c:658
btree_bounce_alloc fs/bcachefs/btree_io.c:124 [inline]
btree_node_sort+0x78a/0x1d30 fs/bcachefs/btree_io.c:323
bch2_btree_post_write_cleanup+0x1b0/0xf20 fs/bcachefs/btree_io.c:2252
bch2_btree_node_prep_for_write+0x494/0x720 fs/bcachefs/btree_trans_commit.c:93
bch2_trans_lock_write+0x7ef/0xc00 fs/bcachefs/btree_trans_commit.c:129
do_bch2_trans_commit fs/bcachefs/btree_trans_commit.c:896 [inline]
__bch2_trans_commit+0x31c4/0xd190 fs/bcachefs/btree_trans_commit.c:1121
bch2_trans_commit fs/bcachefs/btree_update.h:184 [inline]
bch2_journal_replay+0x2e3d/0x4d30 fs/bcachefs/recovery.c:317
bch2_run_recovery_pass fs/bcachefs/recovery_passes.c:185 [inline]
bch2_run_recovery_passes+0xaf9/0xf80 fs/bcachefs/recovery_passes.c:238
bch2_fs_recovery+0x447b/0x5b00 fs/bcachefs/recovery.c:861
bch2_fs_start+0x7b2/0xbd0 fs/bcachefs/super.c:1036
bch2_fs_get_tree+0x13ea/0x22d0 fs/bcachefs/fs.c:2170
vfs_get_tree+0xb1/0x5a0 fs/super.c:1814
do_new_mount+0x71f/0x15e0 fs/namespace.c:3507
path_mount+0x742/0x1f10 fs/namespace.c:3834
do_mount fs/namespace.c:3847 [inline]
__do_sys_mount fs/namespace.c:4057 [inline]
__se_sys_mount+0x722/0x810 fs/namespace.c:4034
__ia32_sys_mount+0xe3/0x150 fs/namespace.c:4034
ia32_sys_call+0x2530/0x40d0 arch/x86/include/generated/asm/syscalls_32.h:22
do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
__do_fast_syscall_32+0xb0/0x110 arch/x86/entry/common.c:386
do_fast_syscall_32+0x38/0x80 arch/x86/entry/common.c:411
do_SYSENTER_32+0x1f/0x30 arch/x86/entry/common.c:449
entry_SYSENTER_compat_after_hwframe+0x84/0x8e

CPU: 0 UID: 0 PID: 12680 Comm: bch-reclaim/loo Not tainted 6.12.0-rc7-syzkaller-00012-g3022e9d00ebe #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
=====================================================


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit: 7eef7e306d3c Merge tag 'for-6.13/dm-changes' of git://git...
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=1346e1e8580000
kernel config: https://syzkaller.appspot.com/x/.config?x=c5486b9d7cc64830

dashboard link: https://syzkaller.appspot.com/bug?extid=8dd95f470e7cd0ff4b66
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40

syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1353fff7980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=151643c0580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/2331c33a914b/disk-7eef7e30.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/8e50ed828391/vmlinux-7eef7e30.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a942e199e781/bzImage-7eef7e30.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/495fbbf0d709/mount_0.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+8dd95f...@syzkaller.appspotmail.com

=====================================================
BUG: KMSAN: uninit-value in bch2_alloc_v4_validate+0x739/0x19a0 fs/bcachefs/alloc_background.c:249
bch2_alloc_v4_validate+0x739/0x19a0 fs/bcachefs/alloc_background.c:249
bch2_bkey_val_validate+0x2b5/0x440 fs/bcachefs/bkey_methods.c:143

bset_key_validate fs/bcachefs/btree_io.c:841 [inline]
validate_bset_keys+0x1531/0x2080 fs/bcachefs/btree_io.c:910
validate_bset_for_write+0x142/0x290 fs/bcachefs/btree_io.c:1942
__bch2_btree_node_write+0x53df/0x6830 fs/bcachefs/btree_io.c:2152
bch2_btree_node_write+0xa5/0x2e0 fs/bcachefs/btree_io.c:2284
bch2_btree_node_rewrite+0x1442/0x1930 fs/bcachefs/btree_update_interior.c:2179
async_btree_node_rewrite_trans fs/bcachefs/btree_update_interior.c:2236 [inline]
async_btree_node_rewrite_work+0x485/0x1710 fs/bcachefs/btree_update_interior.c:2249
process_one_work kernel/workqueue.c:3229 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3310
worker_thread+0xea7/0x14f0 kernel/workqueue.c:3391

kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was stored to memory at:
bch2_alloc_v4_validate+0x27f/0x19a0 fs/bcachefs/alloc_background.c:247
bch2_bkey_val_validate+0x2b5/0x440 fs/bcachefs/bkey_methods.c:143

bset_key_validate fs/bcachefs/btree_io.c:841 [inline]
validate_bset_keys+0x1531/0x2080 fs/bcachefs/btree_io.c:910
validate_bset_for_write+0x142/0x290 fs/bcachefs/btree_io.c:1942
__bch2_btree_node_write+0x53df/0x6830 fs/bcachefs/btree_io.c:2152
bch2_btree_node_write+0xa5/0x2e0 fs/bcachefs/btree_io.c:2284
bch2_btree_node_rewrite+0x1442/0x1930 fs/bcachefs/btree_update_interior.c:2179
async_btree_node_rewrite_trans fs/bcachefs/btree_update_interior.c:2236 [inline]
async_btree_node_rewrite_work+0x485/0x1710 fs/bcachefs/btree_update_interior.c:2249
process_one_work kernel/workqueue.c:3229 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3310
worker_thread+0xea7/0x14f0 kernel/workqueue.c:3391

kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was stored to memory at:
memcpy_u64s_small fs/bcachefs/util.h:393 [inline]
bkey_p_copy fs/bcachefs/bkey.h:47 [inline]
bch2_sort_keys_keep_unwritten_whiteouts+0x16af/0x19d0 fs/bcachefs/bkey_sort.c:187

__bch2_btree_node_write+0x3ae8/0x6830 fs/bcachefs/btree_io.c:2095
bch2_btree_node_write+0xa5/0x2e0 fs/bcachefs/btree_io.c:2284
bch2_btree_node_rewrite+0x1442/0x1930 fs/bcachefs/btree_update_interior.c:2179
async_btree_node_rewrite_trans fs/bcachefs/btree_update_interior.c:2236 [inline]
async_btree_node_rewrite_work+0x485/0x1710 fs/bcachefs/btree_update_interior.c:2249
process_one_work kernel/workqueue.c:3229 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3310
worker_thread+0xea7/0x14f0 kernel/workqueue.c:3391

kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was stored to memory at:
memcpy_u64s_small fs/bcachefs/util.h:393 [inline]
bkey_p_copy fs/bcachefs/bkey.h:47 [inline]

bch2_sort_repack+0xb74/0x1040 fs/bcachefs/bkey_sort.c:140
bch2_btree_sort_into+0x212/0x620 fs/bcachefs/btree_io.c:399
bch2_btree_node_alloc_replacement+0xa3d/0xb60 fs/bcachefs/btree_update_interior.c:469
bch2_btree_node_rewrite+0x2d4/0x1930 fs/bcachefs/btree_update_interior.c:2155
async_btree_node_rewrite_trans fs/bcachefs/btree_update_interior.c:2236 [inline]
async_btree_node_rewrite_work+0x485/0x1710 fs/bcachefs/btree_update_interior.c:2249
process_one_work kernel/workqueue.c:3229 [inline]
process_scheduled_works+0xae0/0x1c40 kernel/workqueue.c:3310
worker_thread+0xea7/0x14f0 kernel/workqueue.c:3391

kthread+0x3e2/0x540 kernel/kthread.c:389
ret_from_fork+0x6d/0x90 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

Uninit was created at:

___kmalloc_large_node+0x22c/0x370 mm/slub.c:4238
__kmalloc_large_node_noprof+0x3f/0x1e0 mm/slub.c:4255
__do_kmalloc_node mm/slub.c:4271 [inline]
__kmalloc_node_noprof+0xc96/0x1250 mm/slub.c:4289
__kvmalloc_node_noprof+0xc0/0x2d0 mm/util.c:650

btree_bounce_alloc fs/bcachefs/btree_io.c:124 [inline]
btree_node_sort+0x78a/0x1d30 fs/bcachefs/btree_io.c:323

bch2_btree_post_write_cleanup+0x1b0/0xf20 fs/bcachefs/btree_io.c:2248

bch2_btree_node_prep_for_write+0x494/0x720 fs/bcachefs/btree_trans_commit.c:93
bch2_trans_lock_write+0x7ef/0xc00 fs/bcachefs/btree_trans_commit.c:129
do_bch2_trans_commit fs/bcachefs/btree_trans_commit.c:896 [inline]
__bch2_trans_commit+0x31c4/0xd190 fs/bcachefs/btree_trans_commit.c:1121
bch2_trans_commit fs/bcachefs/btree_update.h:184 [inline]
bch2_journal_replay+0x2e3d/0x4d30 fs/bcachefs/recovery.c:317

bch2_run_recovery_pass fs/bcachefs/recovery_passes.c:191 [inline]
bch2_run_recovery_passes+0xaf9/0xf80 fs/bcachefs/recovery_passes.c:244
bch2_fs_recovery+0x447b/0x5b00 fs/bcachefs/recovery.c:861
bch2_fs_start+0x7b2/0xbd0 fs/bcachefs/super.c:1037

bch2_fs_get_tree+0x13ea/0x22d0 fs/bcachefs/fs.c:2170
vfs_get_tree+0xb1/0x5a0 fs/super.c:1814
do_new_mount+0x71f/0x15e0 fs/namespace.c:3507
path_mount+0x742/0x1f10 fs/namespace.c:3834
do_mount fs/namespace.c:3847 [inline]
__do_sys_mount fs/namespace.c:4057 [inline]
__se_sys_mount+0x722/0x810 fs/namespace.c:4034

__x64_sys_mount+0xe4/0x150 fs/namespace.c:4034
x64_sys_call+0x39bf/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:166
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

CPU: 1 UID: 0 PID: 11 Comm: kworker/u8:0 Not tainted 6.12.0-syzkaller-09567-g7eef7e306d3c #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Workqueue: btree_node_rewrite async_btree_node_rewrite_work
=====================================================


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

[syzbot]

For archival purposes, forwarding an incoming command email to
linux-...@vger.kernel.org, syzkall...@googlegroups.com.

***

Subject:
Author: kent.ov...@linux.dev

#syz fix bcachefs: Disable asm memcpys when kmsan enabled