[syzbot] WARNING in io_wq_submit_work (2)

11 views
Skip to first unread message

syzbot

unread,
Sep 8, 2021, 8:09:18ā€ÆPM9/8/21
to asml.s...@gmail.com, ax...@kernel.dk, io-u...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
Hello,

syzbot found the following issue on:

HEAD commit: 4b93c544e90e thunderbolt: test: split up test cases in tb_..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=10b7836d300000
kernel config: https://syzkaller.appspot.com/x/.config?x=ac2f9cc43f6b17e4
dashboard link: https://syzkaller.appspot.com/bug?extid=bc2d90f602545761f287
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10e8ce0b300000

The issue was bisected to:

commit 3146cba99aa284b1d4a10fbd923df953f1d18035
Author: Jens Axboe <ax...@kernel.dk>
Date: Wed Sep 1 17:20:10 2021 +0000

io-wq: make worker creation resilient against signals

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11098e0d300000
final oops: https://syzkaller.appspot.com/x/report.txt?x=13098e0d300000
console output: https://syzkaller.appspot.com/x/log.txt?x=15098e0d300000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bc2d90...@syzkaller.appspotmail.com
Fixes: 3146cba99aa2 ("io-wq: make worker creation resilient against signals")

------------[ cut here ]------------
WARNING: CPU: 1 PID: 8804 at fs/io_uring.c:1164 req_ref_get fs/io_uring.c:1164 [inline]
WARNING: CPU: 1 PID: 8804 at fs/io_uring.c:1164 io_wq_submit_work+0x272/0x300 fs/io_uring.c:6731
Modules linked in:
CPU: 1 PID: 8804 Comm: syz-executor.0 Not tainted 5.14.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:req_ref_get fs/io_uring.c:1164 [inline]
RIP: 0010:io_wq_submit_work+0x272/0x300 fs/io_uring.c:6731
Code: e8 d3 21 91 ff 83 fb 7f 76 1b e8 89 1a 91 ff be 04 00 00 00 4c 89 ef e8 bc 62 d8 ff f0 ff 45 a4 e9 41 fe ff ff e8 6e 1a 91 ff <0f> 0b eb dc e8 65 1a 91 ff 4c 89 e7 e8 ad dc fb ff 48 85 c0 49 89
RSP: 0018:ffffc900027b7ae8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 000000000000007f RCX: 0000000000000000
RDX: ffff8880209cb900 RSI: ffffffff81e506d2 RDI: 0000000000000003
RBP: ffff888071824978 R08: 000000000000007f R09: ffff88807182491f
R10: ffffffff81e506ad R11: 0000000000000000 R12: ffff8880718248c0
R13: ffff88807182491c R14: ffff888071824918 R15: 0000000000100000
FS: 0000000002b68400(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055f33208ca50 CR3: 0000000071827000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
io_run_cancel fs/io-wq.c:809 [inline]
io_acct_cancel_pending_work.isra.0+0x2a9/0x5e0 fs/io-wq.c:950
io_wqe_cancel_pending_work+0x98/0x130 fs/io-wq.c:968
io_wq_destroy fs/io-wq.c:1185 [inline]
io_wq_put_and_exit+0x7d1/0xc70 fs/io-wq.c:1198
io_uring_clean_tctx fs/io_uring.c:9607 [inline]
io_uring_cancel_generic+0x5fe/0x740 fs/io_uring.c:9687
io_uring_files_cancel include/linux/io_uring.h:16 [inline]
do_exit+0x265/0x2a30 kernel/exit.c:780
do_group_exit+0x125/0x310 kernel/exit.c:922
__do_sys_exit_group kernel/exit.c:933 [inline]
__se_sys_exit_group kernel/exit.c:931 [inline]
__x64_sys_exit_group+0x3a/0x50 kernel/exit.c:931
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x4665f9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffdd0a294a8 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 000000000000001e RCX: 00000000004665f9
RDX: 000000000041940b RSI: ffffffffffffffbc RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000001b2be20070 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 0000000000000000 R14: 0000000000000000 R15: 00007ffdd0a295a0


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzk...@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
For information about bisection process see: https://goo.gl/tpsmEJ#bisection
syzbot can test patches for this issue, for details see:
https://goo.gl/tpsmEJ#testing-patches

Pavel Begunkov

unread,
Sep 8, 2021, 8:19:32ā€ÆPM9/8/21
to syzbot, ax...@kernel.dk, io-u...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
On 9/9/21 1:09 AM, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 4b93c544e90e thunderbolt: test: split up test cases in tb_..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=10b7836d300000
> kernel config: https://syzkaller.appspot.com/x/.config?x=ac2f9cc43f6b17e4
> dashboard link: https://syzkaller.appspot.com/bug?extid=bc2d90f602545761f287
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10e8ce0b300000
>
> The issue was bisected to:
>
> commit 3146cba99aa284b1d4a10fbd923df953f1d18035
> Author: Jens Axboe <ax...@kernel.dk>
> Date: Wed Sep 1 17:20:10 2021 +0000
>
> io-wq: make worker creation resilient against signals

fixed today

#syz test: git://git.kernel.dk/linux-block io_uring-5.15
--
Pavel Begunkov

syzbot

unread,
Sep 8, 2021, 8:56:08ā€ÆPM9/8/21
to asml.s...@gmail.com, ax...@kernel.dk, io-u...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
Hello,

syzbot has tested the proposed patch and the reproducer did not trigger any issue:

Reported-and-tested-by: syzbot+bc2d90...@syzkaller.appspotmail.com

Tested on:

commit: c57a91fb io_uring: fix missing mb() before waitqueue_a..
git tree: git://git.kernel.dk/linux-block io_uring-5.15
kernel config: https://syzkaller.appspot.com/x/.config?x=f9bfda6f9dee77cd
dashboard link: https://syzkaller.appspot.com/bug?extid=bc2d90f602545761f287
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1

Note: testing is done by a robot and is best-effort only.

syzbot

unread,
Sep 11, 2021, 9:53:30ā€ÆAM9/11/21
to asml.s...@gmail.com, ax...@kernel.dk, io-u...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
syzbot has found a reproducer for the following issue on:

HEAD commit: 926de8c4326c Merge tag 'acpi-5.15-rc1-3' of git://git.kern..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17fefe8b300000
kernel config: https://syzkaller.appspot.com/x/.config?x=37df9ef5660a8387
dashboard link: https://syzkaller.appspot.com/bug?extid=bc2d90f602545761f287
compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.1
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11e4357d300000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1173a663300000

The issue was bisected to:

commit 3146cba99aa284b1d4a10fbd923df953f1d18035
Author: Jens Axboe <ax...@kernel.dk>
Date: Wed Sep 1 17:20:10 2021 +0000

io-wq: make worker creation resilient against signals

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=11098e0d300000
final oops: https://syzkaller.appspot.com/x/report.txt?x=13098e0d300000
console output: https://syzkaller.appspot.com/x/log.txt?x=15098e0d300000

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+bc2d90...@syzkaller.appspotmail.com
Fixes: 3146cba99aa2 ("io-wq: make worker creation resilient against signals")

RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 000000000043f6d9
RDX: 0000000000000000 RSI: 0000000000000304 RDI: 0000000000000003
RBP: 00007ffed8512ba0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000004
R13: 0000000000000000 R14: 00000000004ad018 R15: 0000000000400488
------------[ cut here ]------------
WARNING: CPU: 0 PID: 6524 at fs/io_uring.c:1164 req_ref_get fs/io_uring.c:1164 [inline]
WARNING: CPU: 0 PID: 6524 at fs/io_uring.c:1164 io_wq_submit_work+0x272/0x300 fs/io_uring.c:6733
Modules linked in:
CPU: 0 PID: 6524 Comm: syz-executor339 Not tainted 5.14.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:req_ref_get fs/io_uring.c:1164 [inline]
RIP: 0010:io_wq_submit_work+0x272/0x300 fs/io_uring.c:6733
Code: e8 43 33 91 ff 83 fb 7f 76 1b e8 f9 2b 91 ff be 04 00 00 00 4c 89 ef e8 3c 7a d8 ff f0 ff 45 a4 e9 41 fe ff ff e8 de 2b 91 ff <0f> 0b eb dc e8 d5 2b 91 ff 4c 89 e7 e8 ed db fb ff 48 85 c0 49 89
RSP: 0018:ffffc9000116fae8 EFLAGS: 00010293
RAX: 0000000000000000 RBX: 000000000000007f RCX: 0000000000000000
RDX: ffff88801be91c80 RSI: ffffffff81e4e162 RDI: 0000000000000003
RBP: ffff88801a793978 R08: 000000000000007f R09: ffff88801a79391f
R10: ffffffff81e4e13d R11: 0000000000000000 R12: ffff88801a7938c0
R13: ffff88801a79391c R14: ffff88801a793918 R15: 0000000000100000
FS: 0000000000a12300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000480310 CR3: 00000000778f6000 CR4: 0000000000350ef0
Call Trace:
io_run_cancel fs/io-wq.c:809 [inline]
io_acct_cancel_pending_work.isra.0+0x2a9/0x5e0 fs/io-wq.c:950
io_wqe_cancel_pending_work+0x6c/0x130 fs/io-wq.c:968
io_wq_destroy fs/io-wq.c:1185 [inline]
io_wq_put_and_exit+0x7d1/0xc70 fs/io-wq.c:1198
io_uring_clean_tctx fs/io_uring.c:9609 [inline]
io_uring_cancel_generic+0x5fe/0x740 fs/io_uring.c:9689
io_uring_files_cancel include/linux/io_uring.h:16 [inline]
do_exit+0x265/0x2a30 kernel/exit.c:780
do_group_exit+0x125/0x310 kernel/exit.c:922
__do_sys_exit_group kernel/exit.c:933 [inline]
__se_sys_exit_group kernel/exit.c:931 [inline]
__x64_sys_exit_group+0x3a/0x50 kernel/exit.c:931
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x43e3d9
Code: 90 49 c7 c0 c0 ff ff ff be e7 00 00 00 ba 3c 00 00 00 eb 12 0f 1f 44 00 00 89 d0 0f 05 48 3d 00 f0 ff ff 77 1c f4 89 f0 0f 05 <48> 3d 00 f0 ff ff 76 e7 f7 d8 64 41 89 00 eb df 0f 1f 80 00 00 00
RSP: 002b:00007ffed8512b78 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 00000000004af3b0 RCX: 000000000043e3d9
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffffffffffc0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00000000004af3b0
R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001

syzbot

unread,
Oct 11, 2021, 4:32:07ā€ÆPM10/11/21
to asml.s...@gmail.com, ax...@kernel.dk, fghee...@gmail.com, io-u...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
syzbot suspects this issue was fixed by commit:

commit c57a91fb1ccfa203ba3e31e5a389cb04de5b0561
Author: Pavel Begunkov <asml.s...@gmail.com>
Date: Wed Sep 8 19:49:17 2021 +0000

io_uring: fix missing mb() before waitqueue_active

bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=143b46bf300000
start commit: 926de8c4326c Merge tag 'acpi-5.15-rc1-3' of git://git.kern..
git tree: upstream
If the result looks correct, please mark the issue as fixed by replying with:

#syz fix: io_uring: fix missing mb() before waitqueue_active

Pavel Begunkov

unread,
Oct 12, 2021, 6:43:16ā€ÆAM10/12/21
to syzbot, ax...@kernel.dk, fghee...@gmail.com, io-u...@vger.kernel.org, linux-...@vger.kernel.org, syzkall...@googlegroups.com
#syz fix: io-wq: fix cancellation on create-worker failure


--
Pavel Begunkov
Reply all
Reply to author
Forward
0 new messages